frodovdr/raspap-webgui
1
0
Fork 0
mirror of https://github.com/billz/raspap-webgui.git synced 2023-10-10 13:37:24 +02:00
Code Issues Releases Wiki Activity
ce21f2ac57
raspap-webgui/includes/hostapd.php

556 lines
27 KiB
PHP
Raw Normal View History

Move HostAPD into separate file
2016-07-27 22:43:40 +02:00
<?php
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
include_once( 'includes/status_messages.php' );
Move HostAPD into separate file
2016-07-27 22:43:40 +02:00
/**
*
*
*/
function DisplayHostAPDConfig(){
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
$status = new StatusMessages();
Created new branch off master to help troubleshoot with #132
2017-11-02 15:43:41 +01:00
$arrHostapdConf = parse_ini_file('/etc/raspap/hostapd.ini');
Some validation on POST data
2016-08-05 22:38:02 +02:00
$arrConfig = array();
$arrChannel = array('a','b','g');
$arrSecurity = array( 1 => 'WPA', 2 => 'WPA2',3=> 'WPA+WPA2');
$arrEncType = array('TKIP' => 'TKIP', 'CCMP' => 'CCMP', 'TKIP CCMP' => 'TKIP+CCMP');
exec("ip -o link show | awk -F': ' '{print $2}'", $interfaces);
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
if( isset($_POST['SaveHostAPDSettings']) ) {
if (CSRFValidate()) {
Some validation on POST data
2016-08-05 22:38:02 +02:00
SaveHostAPDConfig($arrSecurity, $arrEncType, $arrChannel, $interfaces, $status);
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
} else {
error_log('CSRF violation');
}
} elseif( isset($_POST['StartHotspot']) ) {
if (CSRFValidate()) {
$status->addMessage('Attempting to start hotspot', 'info');
exec( 'sudo /etc/init.d/hostapd start', $return );
foreach( $return as $line ) {
$status->addMessage($line, 'info');
}
} else {
error_log('CSRF violation');
}
} elseif( isset($_POST['StopHotspot']) ) {
if (CSRFValidate()) {
$status->addMessage('Attempting to stop hotspot', 'info');
exec( 'sudo /etc/init.d/hostapd stop', $return );
foreach( $return as $line ) {
$status->addMessage($line, 'info');
}
} else {
error_log('CSRF violation');
}
}
Move HostAPD into separate file
2016-07-27 22:43:40 +02:00
exec( 'cat '. RASPI_HOSTAPD_CONFIG, $return );
exec( 'pidof hostapd | wc -l', $hostapdstatus);
if( $hostapdstatus[0] == 0 ) {
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
$status->addMessage('HostAPD is not running', 'warning');
Move HostAPD into separate file
2016-07-27 22:43:40 +02:00
} else {
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
$status->addMessage('HostAPD is running', 'success');
Move HostAPD into separate file
2016-07-27 22:43:40 +02:00
}
foreach( $return as $a ) {
if( $a[0] != "#" ) {
$arrLine = explode( "=",$a) ;
$arrConfig[$arrLine[0]]=$arrLine[1];
}
};
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
?>
Move HostAPD into separate file
2016-07-27 22:43:40 +02:00
<div class="row">
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
<div class="col-lg-12">
Some validation on POST data
2016-08-05 22:38:02 +02:00
<div class="panel panel-primary">
Replaced interface labels with gettext()
2017-10-23 21:51:34 +02:00
<div class="panel-heading"><i class="fa fa-dot-circle-o fa-fw"></i> <?php echo _("Configure hotspot"); ?></div>
Move HostAPD into separate file
2016-07-27 22:43:40 +02:00
<!-- /.panel-heading -->
<div class="panel-body">
Moved alert above tabs for consistency
2017-05-25 11:40:37 +02:00
<p><?php $status->showMessages(); ?></p>
Set form actions correctly
2016-09-11 21:48:12 +02:00
<form role="form" action="?page=hostapd_conf" method="POST">
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
<!-- Nav tabs -->
Move HostAPD into separate file
2016-07-27 22:43:40 +02:00
<ul class="nav nav-tabs">
Replaced interface labels with gettext()
2017-10-23 21:51:34 +02:00
<li class="active"><a href="#basic" data-toggle="tab"><?php echo _("Basic"); ?></a></li>
<li><a href="#security" data-toggle="tab"><?php echo _("Security"); ?></a></li>
<li><a href="#advanced" data-toggle="tab"><?php echo _("Advanced"); ?></a></li>
Replaced strings with gettext alias
2018-05-27 17:48:42 +02:00
<li><a href="#logoutput" data-toggle="tab"><?php echo _("Logfile output"); ?></a></li>
Move HostAPD into separate file
2016-07-27 22:43:40 +02:00
</ul>
<!-- Tab panes -->
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
<div class="tab-content">
Moved alert above tabs for consistency
2017-05-25 11:40:37 +02:00
<div class="tab-pane fade in active" id="basic">
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
Replaced interface labels with gettext()
2017-10-23 21:51:34 +02:00
<h4><?php echo _("Basic settings") ;?></h4>
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
<?php CSRFToken() ?>
<div class="row">
<div class="form-group col-md-4">
Replaced interface labels with gettext()
2017-10-23 21:51:34 +02:00
<label for="code"><?php echo _("Interface") ;?></label>
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
<?php
SelectorOptions('interface', $interfaces, $arrConfig['interface']);
?>
</div>
</div>
<div class="row">
<div class="form-group col-md-4">
Replaced interface labels with gettext()
2017-10-23 21:51:34 +02:00
<label for="code"><?php echo _("SSID"); ?></label>
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
<input type="text" class="form-control" name="ssid" value="<?php echo htmlspecialchars($arrConfig['ssid'], ENT_QUOTES); ?>" />
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
</div>
</div>
<div class="row">
<div class="form-group col-md-4">
Replaced interface labels with gettext()
2017-10-23 21:51:34 +02:00
<label for="code"><?php echo _("Wireless Mode") ;?></label>
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
<?php SelectorOptions('hw_mode', $arrChannel, $arrConfig['hw_mode']); ?>
</div>
</div>
<div class="row">
<div class="form-group col-md-4">
Replaced interface labels with gettext()
2017-10-23 21:51:34 +02:00
<label for="code"><?php echo _("Channel"); ?></label>
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
<?php SelectorOptions('channel', range(1, 14), intval($arrConfig['channel'])) ?>
</div>
</div>
</div>
<div class="tab-pane fade" id="security">
Replaced interface labels with gettext()
2017-10-23 21:51:34 +02:00
<h4><?php echo _("Security settings"); ?></h4>
Move HostAPD into separate file
2016-07-27 22:43:40 +02:00
<div class="row">
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
<div class="form-group col-md-4">
Replaced interface labels with gettext()
2017-10-23 21:51:34 +02:00
<label for="code"><?php echo _("Security type"); ?></label>
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
<?php SelectorOptions('wpa', $arrSecurity, $arrConfig['wpa']); ?>
</div>
</div>
<div class="row">
<div class="form-group col-md-4">
Replaced interface labels with gettext()
2017-10-23 21:51:34 +02:00
<label for="code"><?php echo _("Encryption Type"); ?></label>
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
<?php SelectorOptions('wpa_pairwise', $arrEncType, $arrConfig['wpa_pairwise']); ?>
</div>
</div>
<div class="row">
<div class="form-group col-md-4">
Replaced interface labels with gettext()
2017-10-23 21:51:34 +02:00
<label for="code"><?php echo _("PSK"); ?></label>
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
<input type="text" class="form-control" name="wpa_passphrase" value="<?php echo htmlspecialchars($arrConfig['wpa_passphrase'], ENT_QUOTES); ?>" />
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
</div>
</div>
Move HostAPD into separate file
2016-07-27 22:43:40 +02:00
</div>
Created new branch off master to help troubleshoot with #132
2017-11-02 15:43:41 +01:00
<div class="tab-pane fade" id="logoutput">
Replaced strings with gettext alias
2018-05-27 17:48:42 +02:00
<h4><?php echo _("Logfile output"); ?></h4>
Added standard div wrapper to new tab
2017-11-02 19:43:52 +01:00
<div class="row">
<div class="form-group col-md-8">
<?php
if($arrHostapdConf['LogEnable'] == 1) {
$log = file_get_contents('/tmp/hostapd.log');
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
echo '<br /><textarea class="logoutput">'.htmlspecialchars($log, ENT_QUOTES).'</textarea>';
Added standard div wrapper to new tab
2017-11-02 19:43:52 +01:00
} else {
echo "<br />Logfile output not enabled";
}
?>
</div>
</div>
Created new branch off master to help troubleshoot with #132
2017-11-02 15:43:41 +01:00
</div>
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
<div class="tab-pane fade" id="advanced">
Replaced interface labels with gettext()
2017-10-23 21:51:34 +02:00
<h4><?php echo _("Advanced settings"); ?></h4>
Created new branch off master to help troubleshoot with #132
2017-11-02 15:43:41 +01:00
<div class="row">
<div class="col-md-4">
<div class="form-check">
<label class="form-check-label">
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
<?php echo _("Enable logging");
$checked = '';
if ($arrHostapdConf['LogEnable'] == 1) {
$checked = ' checked="checked"';
}
?>
<input id="logEnable" name ="logEnable" type="checkbox" class="form-check-input" value="1"<?php echo $checked; ?> />
Created new branch off master to help troubleshoot with #132
2017-11-02 15:43:41 +01:00
</label>
</div>
</div>
</div>
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
<div class="row">
<div class="form-group col-md-4">
Replaced interface labels with gettext()
2017-10-23 21:51:34 +02:00
<label for="code"><?php echo _("Country Code"); ?></label>
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
<input type="hidden" id="selected_country" value="<?php echo htmlspecialchars($arrConfig['country_code'], ENT_QUOTES); ?>">
Removed inline style
2017-10-07 01:18:42 +02:00
<select class="form-control" id="countries" name="country_code">
Resolves #60
2017-05-19 16:00:47 +02:00
<option value="AF">Afghanistan</option>
<option value="AX">Åland Islands</option>
<option value="AL">Albania</option>
<option value="DZ">Algeria</option>
<option value="AS">American Samoa</option>
<option value="AD">Andorra</option>
<option value="AO">Angola</option>
<option value="AI">Anguilla</option>
<option value="AQ">Antarctica</option>
<option value="AG">Antigua and Barbuda</option>
<option value="AR">Argentina</option>
<option value="AM">Armenia</option>
<option value="AW">Aruba</option>
<option value="AU">Australia</option>
<option value="AT">Austria</option>
<option value="AZ">Azerbaijan</option>
<option value="BS">Bahamas</option>
<option value="BH">Bahrain</option>
<option value="BD">Bangladesh</option>
<option value="BB">Barbados</option>
<option value="BY">Belarus</option>
<option value="BE">Belgium</option>
<option value="BZ">Belize</option>
<option value="BJ">Benin</option>
<option value="BM">Bermuda</option>
<option value="BT">Bhutan</option>
<option value="BO">Bolivia, Plurinational State of</option>
<option value="BQ">Bonaire, Sint Eustatius and Saba</option>
<option value="BA">Bosnia and Herzegovina</option>
<option value="BW">Botswana</option>
<option value="BV">Bouvet Island</option>
<option value="BR">Brazil</option>
<option value="IO">British Indian Ocean Territory</option>
<option value="BN">Brunei Darussalam</option>
<option value="BG">Bulgaria</option>
<option value="BF">Burkina Faso</option>
<option value="BI">Burundi</option>
<option value="KH">Cambodia</option>
<option value="CM">Cameroon</option>
<option value="CA">Canada</option>
<option value="CV">Cape Verde</option>
<option value="KY">Cayman Islands</option>
<option value="CF">Central African Republic</option>
<option value="TD">Chad</option>
<option value="CL">Chile</option>
<option value="CN">China</option>
<option value="CX">Christmas Island</option>
<option value="CC">Cocos (Keeling) Islands</option>
<option value="CO">Colombia</option>
<option value="KM">Comoros</option>
<option value="CG">Congo</option>
<option value="CD">Congo, the Democratic Republic of the</option>
<option value="CK">Cook Islands</option>
<option value="CR">Costa Rica</option>
<option value="CI">Côte d'Ivoire</option>
<option value="HR">Croatia</option>
<option value="CU">Cuba</option>
<option value="CW">Curaçao</option>
<option value="CY">Cyprus</option>
<option value="CZ">Czech Republic</option>
<option value="DK">Denmark</option>
<option value="DJ">Djibouti</option>
<option value="DM">Dominica</option>
<option value="DO">Dominican Republic</option>
<option value="EC">Ecuador</option>
<option value="EG">Egypt</option>
<option value="SV">El Salvador</option>
<option value="GQ">Equatorial Guinea</option>
<option value="ER">Eritrea</option>
<option value="EE">Estonia</option>
<option value="ET">Ethiopia</option>
<option value="FK">Falkland Islands (Malvinas)</option>
<option value="FO">Faroe Islands</option>
<option value="FJ">Fiji</option>
<option value="FI">Finland</option>
<option value="FR">France</option>
<option value="GF">French Guiana</option>
<option value="PF">French Polynesia</option>
<option value="TF">French Southern Territories</option>
<option value="GA">Gabon</option>
<option value="GM">Gambia</option>
<option value="GE">Georgia</option>
<option value="DE">Germany</option>
<option value="GH">Ghana</option>
<option value="GI">Gibraltar</option>
<option value="GR">Greece</option>
<option value="GL">Greenland</option>
<option value="GD">Grenada</option>
<option value="GP">Guadeloupe</option>
<option value="GU">Guam</option>
<option value="GT">Guatemala</option>
<option value="GG">Guernsey</option>
<option value="GN">Guinea</option>
<option value="GW">Guinea-Bissau</option>
<option value="GY">Guyana</option>
<option value="HT">Haiti</option>
<option value="HM">Heard Island and McDonald Islands</option>
<option value="VA">Holy See (Vatican City State)</option>
<option value="HN">Honduras</option>
<option value="HK">Hong Kong</option>
<option value="HU">Hungary</option>
<option value="IS">Iceland</option>
<option value="IN">India</option>
<option value="ID">Indonesia</option>
<option value="IR">Iran, Islamic Republic of</option>
<option value="IQ">Iraq</option>
<option value="IE">Ireland</option>
<option value="IM">Isle of Man</option>
<option value="IL">Israel</option>
<option value="IT">Italy</option>
<option value="JM">Jamaica</option>
<option value="JP">Japan</option>
<option value="JE">Jersey</option>
<option value="JO">Jordan</option>
<option value="KZ">Kazakhstan</option>
<option value="KE">Kenya</option>
<option value="KI">Kiribati</option>
<option value="KP">Korea, Democratic People's Republic of</option>
<option value="KR">Korea, Republic of</option>
<option value="KW">Kuwait</option>
<option value="KG">Kyrgyzstan</option>
<option value="LA">Lao People's Democratic Republic</option>
<option value="LV">Latvia</option>
<option value="LB">Lebanon</option>
<option value="LS">Lesotho</option>
<option value="LR">Liberia</option>
<option value="LY">Libya</option>
<option value="LI">Liechtenstein</option>
<option value="LT">Lithuania</option>
<option value="LU">Luxembourg</option>
<option value="MO">Macao</option>
<option value="MK">Macedonia, the former Yugoslav Republic of</option>
<option value="MG">Madagascar</option>
<option value="MW">Malawi</option>
<option value="MY">Malaysia</option>
<option value="MV">Maldives</option>
<option value="ML">Mali</option>
<option value="MT">Malta</option>
<option value="MH">Marshall Islands</option>
<option value="MQ">Martinique</option>
<option value="MR">Mauritania</option>
<option value="MU">Mauritius</option>
<option value="YT">Mayotte</option>
<option value="MX">Mexico</option>
<option value="FM">Micronesia, Federated States of</option>
<option value="MD">Moldova, Republic of</option>
<option value="MC">Monaco</option>
<option value="MN">Mongolia</option>
<option value="ME">Montenegro</option>
<option value="MS">Montserrat</option>
<option value="MA">Morocco</option>
<option value="MZ">Mozambique</option>
<option value="MM">Myanmar</option>
<option value="NA">Namibia</option>
<option value="NR">Nauru</option>
<option value="NP">Nepal</option>
<option value="NL">Netherlands</option>
<option value="NC">New Caledonia</option>
<option value="NZ">New Zealand</option>
<option value="NI">Nicaragua</option>
<option value="NE">Niger</option>
<option value="NG">Nigeria</option>
<option value="NU">Niue</option>
<option value="NF">Norfolk Island</option>
<option value="MP">Northern Mariana Islands</option>
<option value="NO">Norway</option>
<option value="OM">Oman</option>
<option value="PK">Pakistan</option>
<option value="PW">Palau</option>
<option value="PS">Palestinian Territory, Occupied</option>
<option value="PA">Panama</option>
<option value="PG">Papua New Guinea</option>
<option value="PY">Paraguay</option>
<option value="PE">Peru</option>
<option value="PH">Philippines</option>
<option value="PN">Pitcairn</option>
<option value="PL">Poland</option>
<option value="PT">Portugal</option>
<option value="PR">Puerto Rico</option>
<option value="QA">Qatar</option>
<option value="RE">Réunion</option>
<option value="RO">Romania</option>
<option value="RU">Russian Federation</option>
<option value="RW">Rwanda</option>
<option value="BL">Saint Barthélemy</option>
<option value="SH">Saint Helena, Ascension and Tristan da Cunha</option>
<option value="KN">Saint Kitts and Nevis</option>
<option value="LC">Saint Lucia</option>
<option value="MF">Saint Martin (French part)</option>
<option value="PM">Saint Pierre and Miquelon</option>
<option value="VC">Saint Vincent and the Grenadines</option>
<option value="WS">Samoa</option>
<option value="SM">San Marino</option>
<option value="ST">Sao Tome and Principe</option>
<option value="SA">Saudi Arabia</option>
<option value="SN">Senegal</option>
<option value="RS">Serbia</option>
<option value="SC">Seychelles</option>
<option value="SL">Sierra Leone</option>
<option value="SG">Singapore</option>
<option value="SX">Sint Maarten (Dutch part)</option>
<option value="SK">Slovakia</option>
<option value="SI">Slovenia</option>
<option value="SB">Solomon Islands</option>
<option value="SO">Somalia</option>
<option value="ZA">South Africa</option>
<option value="GS">South Georgia and the South Sandwich Islands</option>
<option value="SS">South Sudan</option>
<option value="ES">Spain</option>
<option value="LK">Sri Lanka</option>
<option value="SD">Sudan</option>
<option value="SR">Suriname</option>
<option value="SJ">Svalbard and Jan Mayen</option>
<option value="SZ">Swaziland</option>
<option value="SE">Sweden</option>
<option value="CH">Switzerland</option>
<option value="SY">Syrian Arab Republic</option>
<option value="TW">Taiwan, Province of China</option>
<option value="TJ">Tajikistan</option>
<option value="TZ">Tanzania, United Republic of</option>
<option value="TH">Thailand</option>
<option value="TL">Timor-Leste</option>
<option value="TG">Togo</option>
<option value="TK">Tokelau</option>
<option value="TO">Tonga</option>
<option value="TT">Trinidad and Tobago</option>
<option value="TN">Tunisia</option>
<option value="TR">Turkey</option>
<option value="TM">Turkmenistan</option>
<option value="TC">Turks and Caicos Islands</option>
<option value="TV">Tuvalu</option>
<option value="UG">Uganda</option>
<option value="UA">Ukraine</option>
<option value="AE">United Arab Emirates</option>
<option value="GB">United Kingdom</option>
<option value="US">United States</option>
<option value="UM">United States Minor Outlying Islands</option>
<option value="UY">Uruguay</option>
<option value="UZ">Uzbekistan</option>
<option value="VU">Vanuatu</option>
<option value="VE">Venezuela, Bolivarian Republic of</option>
<option value="VN">Viet Nam</option>
<option value="VG">Virgin Islands, British</option>
<option value="VI">Virgin Islands, U.S.</option>
<option value="WF">Wallis and Futuna</option>
<option value="EH">Western Sahara</option>
<option value="YE">Yemen</option>
<option value="ZM">Zambia</option>
<option value="ZW">Zimbabwe</option>
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
</select>
<script type="text/javascript">
var country = document.getElementById("selected_country").value;
var countries = document.getElementById("countries");
var ops = countries.getElementsByTagName("option");
for (var i = 0; i < ops.length; ++i) {
if(ops[i].value == country){
ops[i].selected=true;
break;
}
}
</script>
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
</div>
Fixed misplaced /div
2017-05-19 16:56:07 +02:00
</div><!-- /.panel-body -->
</div><!-- /.panel-primary -->
Updated static labels with gettext()
2017-10-24 15:50:30 +02:00
<input type="submit" class="btn btn-outline btn-primary" name="SaveHostAPDSettings" value="<?php echo _("Save settings"); ?>" />
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
<?php
if($hostapdstatus[0] == 0) {
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
echo '<input type="submit" class="btn btn-success" name="StartHotspot" value="' . _("Start hotspot") . '"/>' , PHP_EOL;
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
} else {
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
echo '<input type="submit" class="btn btn-warning" name="StopHotspot" value="' . _("Stop hotspot") . '"/>' , PHP_EOL;
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
};
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
?>
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
</form>
Fixed misplaced /div
2017-05-19 16:56:07 +02:00
</div></div><!-- /.panel-primary -->
Replaced interface labels with gettext()
2017-10-23 21:51:34 +02:00
<div class="panel-footer"> <?php echo _("Information provided by hostapd"); ?></div>
Add CSRF to hostapd config And tidy things up a bit
2016-08-05 16:50:05 +02:00
</div><!-- /.col-lg-12 -->
Move HostAPD into separate file
2016-07-27 22:43:40 +02:00
</div><!-- /.row -->
<?php
}
Move function to save HostAPD config too
2016-07-27 22:48:27 +02:00
Some validation on POST data
2016-08-05 22:38:02 +02:00
function SaveHostAPDConfig($wpa_array, $enc_types, $modes, $interfaces, $status) {
// It should not be possible to send bad data for these fields so clearly
// someone is up to something if they fail. Fail silently.
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
if (!(array_key_exists($_POST['wpa'], $wpa_array) &&
array_key_exists($_POST['wpa_pairwise'], $enc_types) &&
in_array($_POST['hw_mode'], $modes))) {
error_log("Attempting to set hostapd config with wpa='".$_POST['wpa']."', wpa_pairwise='".$_POST['wpa_pairwise']."' and hw_mode='".$_POST['hw_mode']."'"); // FIXME: log injection
Some validation on POST data
2016-08-05 22:38:02 +02:00
return false;
}
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
if ((!filter_var($_POST['channel'], FILTER_VALIDATE_INT)) ||
intval($_POST['channel']) < 1 ||
intval($_POST['channel']) > 14) {
error_log("Attempting to set channel to '".$_POST['channel']."'"); // FIXME: log injection
Some validation on POST data
2016-08-05 22:38:02 +02:00
return false;
}
$good_input = true;
Created new branch off master to help troubleshoot with #132
2017-11-02 15:43:41 +01:00
// Check for Logging Checkbox
$logEnable = 0;
if($arrHostapdConf['LogEnable'] == 0) {
if(isset($_POST['logEnable'])) {
// Need code to enable logfile logging here
$logEnable = 1;
exec('sudo /etc/raspap/hostapd/enablelog.sh');
} else {
exec('sudo /etc/raspap/hostapd/disablelog.sh');
}
} else {
if(isset($_POST['logEnable'])) {
$logEnable = 1;
exec('sudo /etc/raspap/hostapd/enablelog.sh');
} else {
exec('sudo /etc/raspap/hostapd/disablelog.sh');
}
}
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
Created new branch off master to help troubleshoot with #132
2017-11-02 15:43:41 +01:00
write_php_ini(["LogEnable" => $logEnable],'/etc/raspap/hostapd.ini');
Some validation on POST data
2016-08-05 22:38:02 +02:00
// Verify input
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
if (empty($_POST['ssid']) || strlen($_POST['ssid']) > 32) {
Some validation on POST data
2016-08-05 22:38:02 +02:00
// Not sure of all the restrictions of SSID
$status->addMessage('SSID must be between 1 and 32 characters', 'danger');
$good_input = false;
}
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
Some validation on POST data
2016-08-05 22:38:02 +02:00
if (strlen($_POST['wpa_passphrase']) < 8 || strlen($_POST['wpa_passphrase']) > 63) {
$status->addMessage('WPA passphrase must be between 8 and 63 characters', 'danger');
$good_input = false;
}
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
Some validation on POST data
2016-08-05 22:38:02 +02:00
if (! in_array($_POST['interface'], $interfaces)) {
// The user is probably up to something here but it may also be a
// genuine error.
Fix xss in interface parameter.
2018-10-02 12:58:50 +02:00
$status->addMessage('Unknown interface '.htmlspecialchars($_POST['interface'], ENT_QUOTES), 'danger');
Some validation on POST data
2016-08-05 22:38:02 +02:00
$good_input = false;
}
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
if (strlen($_POST['country_code']) !== 0 && strlen($_POST['country_code']) != 2) {
Some validation on POST data
2016-08-05 22:38:02 +02:00
$status->addMessage('Country code must be blank or two characters', 'danger');
$good_input = false;
}
if ($good_input) {
if ($tmp_file = fopen('/tmp/hostapddata', 'w')) {
// Fixed values
fwrite($tmp_file, 'driver=nl80211'.PHP_EOL);
fwrite($tmp_file, 'ctrl_interface='.RASPI_HOSTAPD_CTRL_INTERFACE.PHP_EOL);
fwrite($tmp_file, 'ctrl_interface_group=0'.PHP_EOL);
fwrite($tmp_file, 'beacon_int=100'.PHP_EOL);
fwrite($tmp_file, 'auth_algs=1'.PHP_EOL);
fwrite($tmp_file, 'wpa_key_mgmt=WPA-PSK'.PHP_EOL);
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
// TODO: deal with ini file value escaping. E.g. ssid=E=mc2 becomes ssid=E\=mc2
Some validation on POST data
2016-08-05 22:38:02 +02:00
fwrite($tmp_file, 'ssid='.$_POST['ssid'].PHP_EOL);
fwrite($tmp_file, 'channel='.$_POST['channel'].PHP_EOL);
fwrite($tmp_file, 'hw_mode='.$_POST['hw_mode'].PHP_EOL);
fwrite($tmp_file, 'wpa_passphrase='.$_POST['wpa_passphrase'].PHP_EOL);
fwrite($tmp_file, 'interface='.$_POST['interface'].PHP_EOL);
fwrite($tmp_file, 'wpa='.$_POST['wpa'].PHP_EOL);
fwrite($tmp_file, 'wpa_pairwise='.$_POST['wpa_pairwise'].PHP_EOL);
fwrite($tmp_file, 'country_code='.$_POST['country_code'].PHP_EOL);
fclose($tmp_file);
system( "sudo cp /tmp/hostapddata " . RASPI_HOSTAPD_CONFIG, $return );
if( $return == 0 ) {
$status->addMessage('Wifi Hotspot settings saved', 'success');
} else {
$status->addMessage('Unable to save wifi hotspot settings', 'danger');
}
} else {
$status->addMessage('Unable to save wifi hotspot settings', 'danger');
return false;
Move function to save HostAPD config too
2016-07-27 22:48:27 +02:00
}
}
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
Some validation on POST data
2016-08-05 22:38:02 +02:00
return true;
Move function to save HostAPD config too
2016-07-27 22:48:27 +02:00
}
Escape client input, console output etc. before doing any echo. Signed-off-by: D9ping <D9ping@users.noreply.github.com>
2018-08-04 01:58:34 +02:00
Reference in New Issue Copy Permalink