Fix dma handling for cuvid with placebo

Silence some compiler warnings
Support for ffmpeg 7.0.x
2025-03-01 10:39:28 +00:00 · 2024-09-03 09:16:45 +02:00 · 2024-08-05 23:13:05 +02:00 · 2024-08-05 17:00:56 +02:00 · 2024-06-04 06:32:44 +02:00 · 2024-03-12 09:11:40 +01:00
6 changed files with 151 additions and 63 deletions
--- a/18
+++ b/18
@@ -24,7 +24,7 @@ DRM ?= 0

 # use libplacebo -
 # available for all decoders but for DRM you need LIBPLACEBO_GL
-LIBPLACEBO ?= 1
+LIBPLACEBO ?= 0
 LIBPLACEBO_GL ?= 0

 # use YADIF deint - only available with cuvid
@@ -35,7 +35,6 @@ YADIF = 1

 CONFIG := -DDEBUG 		# remove '#' to enable debug output

-
 #--------------------- no more config needed past this point--------------------------------

 # sanitize selections --------
@@ -159,29 +158,29 @@ endif

 ifeq ($(LIBPLACEBO_GL),1)
 CONFIG += -DPLACEBO_GL -DPLACEBO
-LIBS += -lepoxy
-LIBS += -lplacebo
+_CFLAGS += $(shell pkg-config --cflags libplacebo)
+LIBS += $(shell pkg-config --libs epoxy libplacebo)
 else
-LIBS += -lEGL
+LIBS += $(shell pkg-config --libs egl)
 endif

 ifeq ($(LIBPLACEBO),1)
 CONFIG += -DPLACEBO
-LIBS += -lEGL
-LIBS += -lplacebo
+_CFLAGS += $(shell pkg-config --cflags libplacebo)
+LIBS += $(shell pkg-config --libs egl libplacebo)
 endif

 ifeq ($(DRM),1)
 PLUGIN = softhddrm
 CONFIG += -DUSE_DRM -DVAAPI
 _CFLAGS += $(shell pkg-config --cflags libdrm)
-LIBS += -lgbm -ldrm -lEGL
+LIBS += $(shell pkg-config --libs egl gbm libdrm)
 endif

 ifeq ($(CUVID),1)
 #CONFIG += -DUSE_PIP			# PIP support
 CONFIG += -DCUVID			# enable CUVID decoder
-LIBS += -lEGL -lGL
+LIBS += $(shell pkg-config --libs egl gl)
 ifeq ($(YADIF),1)
 CONFIG += -DYADIF			# Yadif only with CUVID
 endif
@@ -274,6 +273,7 @@ LIBS += -lcuda -lnvcuvid
 endif

 LIBS += -lGLEW -lGLU  -ldl -lglut
+#LIBS += -ldl $(shell pkg-config --libs glew glu glut)

 ### Includes and Defines (add further entries here):

--- a/codec.c
+++ b/codec.c
@@ -125,7 +125,7 @@ struct _video_decoder_
 */
 static enum AVPixelFormat Codec_get_format(AVCodecContext *video_ctx, const enum AVPixelFormat *fmt) {
    VideoDecoder *decoder;
-    enum AVPixelFormat fmt1;
+

    decoder = video_ctx->opaque;
    // bug in ffmpeg 1.1.1, called with zero width or height
@@ -389,15 +389,19 @@ void CodecVideoClose(VideoDecoder *video_decoder) {
    Debug(3, "CodecVideoClose\n");
    if (video_decoder->VideoCtx) {
        pthread_mutex_lock(&CodecLockMutex);
-#if 1
+
        frame = av_frame_alloc();
        avcodec_send_packet(video_decoder->VideoCtx, NULL);
        while (avcodec_receive_frame(video_decoder->VideoCtx, frame) >= 0)
            ;
        av_frame_free(&frame);
-#endif
+
+#if LIBAVUTIL_VERSION_INT < AV_VERSION_INT(55,63,100)
 	    avcodec_close(video_decoder->VideoCtx);
 	    av_freep(&video_decoder->VideoCtx);
+#else
+	    avcodec_free_context(&video_decoder->VideoCtx);
+#endif
        pthread_mutex_unlock(&CodecLockMutex);
    }
 }
@@ -513,7 +517,7 @@ void CodecVideoDecode(VideoDecoder *decoder, const AVPacket *avpkt) {
    int ret, ret1;
    int got_frame;
    int consumed = 0;
-    static uint64_t first_time = 0;
+    //static uint64_t first_time = 0;
    const AVPacket *pkt;

 next_part:
@@ -541,7 +545,7 @@ next_part:
            frame = av_frame_alloc();
            ret = avcodec_receive_frame(video_ctx, frame); // get new frame
            if (ret >= 0) {                                // one is avail.
-            first_time = frame->pts;
+                //first_time = frame->pts;
                got_frame = 1;
            } else {
                got_frame = 0;
@@ -716,9 +720,6 @@ void CodecAudioOpen(AudioDecoder *audio_decoder, int codec_id) {
        Fatal(_("codec: can't allocate audio codec context\n"));
    }

-    if (CodecDownmix) {
-        audio_decoder->AudioCtx->request_channel_layout = AV_CH_LAYOUT_STEREO;
-    }
    pthread_mutex_lock(&CodecLockMutex);
    // open codec
    if (1) {
@@ -758,8 +759,12 @@ void CodecAudioClose(AudioDecoder *audio_decoder) {
    }
    if (audio_decoder->AudioCtx) {
        pthread_mutex_lock(&CodecLockMutex);
+#if LIBAVUTIL_VERSION_INT < AV_VERSION_INT(55,63,100)
 	    avcodec_close(audio_decoder->AudioCtx);
 	    av_freep(&audio_decoder->AudioCtx);
+#else
+	    avcodec_free_context(&audio_decoder->AudioCtx);
+#endif
        pthread_mutex_unlock(&CodecLockMutex);
    }
 }
@@ -871,19 +876,35 @@ static int CodecAudioUpdateHelper(AudioDecoder *audio_decoder, int *passthrough)
    int err;

    audio_ctx = audio_decoder->AudioCtx;
-    Debug(3, "codec/audio: Chanlayout %lx format change %s %dHz *%d channels%s%s%s%s%s\n",audio_ctx->channel_layout,
-          av_get_sample_fmt_name(audio_ctx->sample_fmt), audio_ctx->sample_rate, audio_ctx->channels,
-          CodecPassthrough & CodecPCM ? " PCM" : "", CodecPassthrough & CodecMPA ? " MPA" : "",
-          CodecPassthrough & CodecAC3 ? " AC-3" : "", CodecPassthrough & CodecEAC3 ? " E-AC-3" : "",
+    
+ 
+    Debug(3, "codec/audio: format change %s %dHz *%d channels%s%s%s%s%s%s\n",
+	av_get_sample_fmt_name(audio_ctx->sample_fmt), audio_ctx->sample_rate,
+#if LIBAVCODEC_VERSION_INT < AV_VERSION_INT(59,24,100)
+	audio_ctx->channels, CodecPassthrough & CodecPCM ? " PCM" : "",
+#else
+	audio_ctx->ch_layout.nb_channels, CodecPassthrough & CodecPCM ? " PCM" : "",
+#endif
+	CodecPassthrough & CodecMPA ? " MPA" : "",
+	CodecPassthrough & CodecAC3 ? " AC-3" : "",
+	CodecPassthrough & CodecEAC3 ? " E-AC-3" : "",
+	CodecPassthrough & CodecDTS ? " DTS" : "",
 	CodecPassthrough ? " pass-through" : "");

+
    *passthrough = 0;
    audio_decoder->SampleRate = audio_ctx->sample_rate;
    audio_decoder->HwSampleRate = audio_ctx->sample_rate;
+#if LIBAVCODEC_VERSION_INT < AV_VERSION_INT(59,24,100)
    audio_decoder->Channels = audio_ctx->channels;
    audio_decoder->HwChannels = audio_ctx->channels;
-    audio_decoder->Passthrough = CodecPassthrough;
+#else
+    audio_decoder->Channels = audio_ctx->ch_layout.nb_channels;
+    audio_decoder->HwChannels = audio_ctx->ch_layout.nb_channels;
+#endif
+    if (CodecDownmix && !CodecPassthrough) audio_decoder->HwChannels = 2;

+    audio_decoder->Passthrough = CodecPassthrough;
    // SPDIF/HDMI pass-through
    if ((CodecPassthrough & CodecAC3 && audio_ctx->codec_id == AV_CODEC_ID_AC3) ||
        (CodecPassthrough & CodecEAC3 && audio_ctx->codec_id == AV_CODEC_ID_EAC3)) {
@@ -912,10 +933,16 @@ static int CodecAudioUpdateHelper(AudioDecoder *audio_decoder, int *passthrough)
        }
    }

-    Debug(3, "codec/audio: resample %s %dHz *%d -> %s %dHz *%d\n", av_get_sample_fmt_name(audio_ctx->sample_fmt),
-          audio_ctx->sample_rate, audio_ctx->channels, av_get_sample_fmt_name(AV_SAMPLE_FMT_S16),
+    Debug(3, "codec/audio: resample %s %dHz *%d -> %s %dHz *%d\n",
+	    av_get_sample_fmt_name(audio_ctx->sample_fmt), audio_ctx->sample_rate,
+#if LIBAVCODEC_VERSION_INT < AV_VERSION_INT(59,24,100)
+	    audio_ctx->channels, av_get_sample_fmt_name(AV_SAMPLE_FMT_S16),
+#else
+	    audio_ctx->ch_layout.nb_channels, av_get_sample_fmt_name(AV_SAMPLE_FMT_S16),
+#endif
 	    audio_decoder->HwSampleRate, audio_decoder->HwChannels);

+
    return 0;
 }

@@ -1143,6 +1170,12 @@ static void CodecAudioUpdateFormat(AudioDecoder *audio_decoder) {
    int passthrough;
    const AVCodecContext *audio_ctx;

+#if LIBAVCODEC_VERSION_INT < AV_VERSION_INT(59,24,100)
+    int64_t dmlayout = AV_CH_LAYOUT_STEREO;
+#else
+    AVChannelLayout dmlayout = AV_CHANNEL_LAYOUT_STEREO;
+#endif
+
    if (CodecAudioUpdateHelper(audio_decoder, &passthrough)) {
        // FIXME: handle swresample format conversions.
        return;
@@ -1153,6 +1186,12 @@ static void CodecAudioUpdateFormat(AudioDecoder *audio_decoder) {

    audio_ctx = audio_decoder->AudioCtx;

+#if LIBAVCODEC_VERSION_INT < AV_VERSION_INT(59,24,100)
+    if (!CodecDownmix || CodecPassthrough) dmlayout = audio_ctx->channel_layout;
+#else
+    if (!CodecDownmix || CodecPassthrough) dmlayout = audio_ctx->ch_layout;
+#endif
+
 #ifdef DEBUG
    if (audio_ctx->sample_fmt == AV_SAMPLE_FMT_S16 && audio_ctx->sample_rate == audio_decoder->HwSampleRate &&
        !CodecAudioDrift) {
@@ -1161,14 +1200,25 @@ static void CodecAudioUpdateFormat(AudioDecoder *audio_decoder) {
    }
 #endif
    
-    audio_decoder->Resample = swr_alloc_set_opts(audio_decoder->Resample, audio_ctx->channel_layout, AV_SAMPLE_FMT_S16,
-                                                 audio_decoder->HwSampleRate, audio_ctx->channel_layout,
-                                                 audio_ctx->sample_fmt, audio_ctx->sample_rate, 0, NULL);
+#if LIBSWRESAMPLE_VERSION_INT < AV_VERSION_INT(4,5,100)
+    audio_decoder->Resample =
+        swr_alloc_set_opts(audio_decoder->Resample, dmlayout,
+        AV_SAMPLE_FMT_S16, audio_decoder->HwSampleRate,
+        audio_ctx->channel_layout, audio_ctx->sample_fmt,
+#else
+        swr_alloc_set_opts2(&audio_decoder->Resample, &dmlayout,
+        AV_SAMPLE_FMT_S16, audio_decoder->HwSampleRate,
+        &audio_ctx->ch_layout, audio_ctx->sample_fmt,
+#endif
+	   audio_ctx->sample_rate, 0, NULL); 
+
    if (audio_decoder->Resample) {
 	swr_init(audio_decoder->Resample);
    } else {
 	Error(_("codec/audio: can't setup resample\n"));
    }
+
+
 }

 /**
@@ -1211,7 +1261,11 @@ void CodecAudioDecode(AudioDecoder *audio_decoder, const AVPacket *avpkt) {
            // format change
            if (audio_decoder->Passthrough != CodecPassthrough ||
                audio_decoder->SampleRate != audio_ctx->sample_rate ||
+#if LIBAVCODEC_VERSION_INT < AV_VERSION_INT(59,24,100)
                audio_decoder->Channels != audio_ctx->channels) {
+#else
+                audio_decoder->Channels != audio_ctx->ch_layout.nb_channels) {
+#endif
                CodecAudioUpdateFormat(audio_decoder);
            }
            if (!audio_decoder->HwSampleRate || !audio_decoder->HwChannels) {
@@ -1220,6 +1274,7 @@ void CodecAudioDecode(AudioDecoder *audio_decoder, const AVPacket *avpkt) {
            if (CodecAudioPassthroughHelper(audio_decoder, avpkt)) {
                return;
            }
+            
            if (audio_decoder->Resample) {
                uint8_t outbuf[8192  * 2 * 8];
                uint8_t *out[1];
@@ -1227,6 +1282,7 @@ void CodecAudioDecode(AudioDecoder *audio_decoder, const AVPacket *avpkt) {
                out[0] = outbuf;
                ret = swr_convert(audio_decoder->Resample, out, sizeof(outbuf) / (2 * audio_decoder->HwChannels),
                                  (const uint8_t **)frame->extended_data, frame->nb_samples);
+                                  
                if (ret > 0) {
                    if (!(audio_decoder->Passthrough & CodecPCM)) {
                        CodecReorderAudioFrame((int16_t *)outbuf, ret * 2 * audio_decoder->HwChannels,
--- a/drm.c
+++ b/drm.c
@@ -209,9 +209,12 @@ static int FindDevice(VideoRender *render) {
    int found = 0;
    render->fd_drm = open("/dev/dri/card0", O_RDWR);
    if (render->fd_drm < 0) {
-        fprintf(stderr, "FindDevice: cannot open /dev/dri/card0: %m\n");
+        render->fd_drm = open("/dev/dri/card1", O_RDWR);
+        if (render->fd_drm < 0) {
+            fprintf(stderr, "FindDevice: cannot open /dev/dri/card0 or card1: %m\n");
            return -errno;
        }
+    }

    int ret = drmSetMaster(render->fd_drm);

@@ -545,6 +548,7 @@ static void drm_swap_buffers() {
        m_need_modeset = 0;
        has_modeset = 1;
    }
+    
    drmModeSetCrtc(render->fd_drm, render->crtc_id, fb, 0, 0, &render->connector_id, 1, &render->mode);

    if (previous_bo) {
@@ -562,15 +566,16 @@ static void drm_clean_up() {
        return;
    Debug(3, "drm clean up\n");

-    if (previous_bo) {
-        drmModeRmFB(render->fd_drm, previous_fb);
-        gbm_surface_release_buffer(gbm.surface, previous_bo);
-    }
    
    drmModeSetCrtc(render->fd_drm, render->saved_crtc->crtc_id, render->saved_crtc->buffer_id, render->saved_crtc->x,
                   render->saved_crtc->y, &render->connector_id, 1, &render->saved_crtc->mode);
    drmModeFreeCrtc(render->saved_crtc);

+    if (previous_bo) {
+        drmModeRmFB(render->fd_drm, previous_fb);
+        gbm_surface_release_buffer(gbm.surface, previous_bo);
+    }
+
    if (has_modeset) {
        drmModeAtomicReqPtr ModeReq;
        const uint32_t flags = DRM_MODE_ATOMIC_ALLOW_MODESET;
@@ -613,22 +618,29 @@ static void drm_clean_up() {
    if (render->hdr_blob_id)
        drmModeDestroyPropertyBlob(render->fd_drm, render->hdr_blob_id);
    render->hdr_blob_id = 0;
-
+#if 0
+    eglMakeCurrent(eglDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT);
    eglDestroySurface(eglDisplay, eglSurface);
    EglCheck();
-    gbm_surface_destroy(gbm.surface);
-    eglDestroyContext(eglDisplay, eglContext);
-    EglCheck();
    eglDestroyContext(eglDisplay, eglSharedContext);
    EglCheck();
+    eglDestroyContext(eglDisplay, eglContext);
+    EglCheck();
    eglSharedContext = NULL;
-
+    eglContext = NULL;
    eglTerminate(eglDisplay);
    EglCheck();
-
+    eglDisplay = NULL;
+#endif
+    eglMakeCurrent(eglDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT);
+    eglDestroySurface(eglDisplay, eglSurface);
+    EglCheck();
+    eglSurface = NULL;
+    gbm_surface_destroy(gbm.surface);
    gbm_device_destroy(gbm.dev);
    drmDropMaster(render->fd_drm);
    close(render->fd_drm);
-    eglDisplay = NULL;
    free(render);
+    render = NULL;
+    Debug(3, "nach drm clean up\n");
 }
--- a/softhdcuvid.cpp
+++ b/softhdcuvid.cpp
@@ -61,7 +61,7 @@ extern void ToggleLUT();
 /// vdr-plugin version number.
 /// Makefile extracts the version number for generating the file name
 /// for the distribution archive.
-static const char *const VERSION = "3.16"
+static const char *const VERSION = "3.24"
 #ifdef GIT_REV
                                   "-GIT" GIT_REV
 #endif
--- a/video.c
+++ b/video.c
@@ -1246,14 +1246,22 @@ static void EglExit(void) {
        glxSharedContext = NULL;
    }
 #else
-    if (eglGetCurrentContext() == eglContext) {
-        // if currently used, set to none
+#ifdef USE_DRM
+    drm_clean_up();
+
+#endif
+    
    eglMakeCurrent(eglDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT);
+
+    if (eglSurface) {
+        eglDestroySurface(eglDisplay, eglSurface);
+        EglCheck();
+        eglSurface = NULL;
    }
-#ifndef USE_DRM
    if (eglSharedContext) {
        eglDestroyContext(eglDisplay, eglSharedContext);
        EglCheck();
+        eglSharedContext = NULL;
    }

    if (eglContext) {
@@ -1261,13 +1269,8 @@ static void EglExit(void) {
        EglCheck();
        eglContext = NULL;
    }
-
    eglTerminate(eglDisplay);
-#endif
-
-#ifdef USE_DRM
-    drm_clean_up();
-#endif
+    eglDisplay = NULL;

 #endif
 }
@@ -1990,6 +1993,9 @@ make_egl() {
        Fatal(_("Could not make context current!\n"));
    }
    EglEnabled = 1;
+#ifdef USE_DRM
+    drm_swap_buffers();
+#endif
 }
 #endif

@@ -2279,7 +2285,7 @@ void createTextureDst(CuvidDecoder *decoder, int anz, unsigned int size_x, unsig
                               &decoder->pl_frames[i].planes[n].texture); // delete old texture
            }

-            if (p->has_dma_buf == 0) {
+            //if (p->has_dma_buf == 0) {
                decoder->pl_frames[i].planes[n].texture = pl_tex_create(
                    p->gpu, &(struct pl_tex_params) {
                        .w = n == 0 ? size_x : size_x / 2, .h = n == 0 ? size_y : size_y / 2, .d = 0, .format = fmt,
@@ -2291,7 +2297,7 @@ void createTextureDst(CuvidDecoder *decoder, int anz, unsigned int size_x, unsig
                        .export_handle = PL_HANDLE_FD,
 #endif
                    });
-            }
+            //}

            // make planes for image
            pl = &decoder->pl_frames[i].planes[n];
@@ -2998,10 +3004,12 @@ static enum AVPixelFormat Cuvid_get_format(CuvidDecoder *decoder, AVCodecContext
 #ifdef CUVID
        ist->active_hwaccel_id = HWACCEL_CUVID;
 #else
-        if (VideoDeinterlace[decoder->Resolution]) // need deinterlace
+        if (VideoDeinterlace[decoder->Resolution]) {// need deinterlace
            ist->filter = 1;                       // init deint vaapi
-        else
+        }
+        else {
            ist->filter = 0;
+        }

        ist->active_hwaccel_id = HWACCEL_VAAPI;
 #endif
@@ -7091,6 +7099,14 @@ void VideoInit(const char *display_name) {
    xcb_screen_iterator_t screen_iter;
    xcb_screen_t const *screen;

+#ifdef VAAPI
+    VideoDeinterlace[0] = 1; // 576i
+    VideoDeinterlace[1] = 0; // mode[1];  // 720p
+    VideoDeinterlace[2] = 1; // fake 1080
+    VideoDeinterlace[3] = 1; // 1080
+    VideoDeinterlace[4] = 0; // mode[4];  2160p
+#endif
+
 #ifdef USE_DRM
    VideoInitDrm();
 #else
--- a/video.h
+++ b/video.h
@@ -249,6 +249,10 @@ extern int VideoRaiseWindow(void);
 /// Set Shaders
 extern int VideoSetShader(char *);

+extern void VideoSetRefresh(char *);
+
+extern void VideoSetConnector(char *);
+
 #ifdef USE_OPENGLOSD
 extern void ActivateOsd(GLuint, int, int, int, int);
 #endif
Author	SHA1	Message	Date
jojo61	230bb5ca11	Fix dma handling for cuvid with placebo	2024-09-03 09:16:45 +02:00
jojo61	f026e8e86d	Silence some compiler warnings	2024-08-05 23:13:05 +02:00
jojo61	9dd936df86	Support for ffmpeg 7.0.x	2024-08-05 17:00:56 +02:00
jojo61	4e5529efcf	Make compiler happy	2024-06-04 06:32:44 +02:00
jojo61	20f1bd45e6	Update Version	2024-03-12 09:11:40 +01:00
jojo61	7a7e09ff7a	For drm try card1 if card0 fails.	2024-03-12 09:09:51 +01:00
jojo61	c4a660ede2	Update Version	2024-02-15 09:24:30 +01:00
jojo61	8e495266e2	Changes for egl exit	2024-02-15 09:23:09 +01:00
jojo61	f27e4fb35f	Set Deinterlace Table for vaapi Clean up exit on softhddrm	2024-02-05 10:50:19 +01:00
jojo61	e14ea73a00	Fix typo	2024-02-04 17:45:54 +01:00
jojo61	72cb77f771	Simplify Stereo Downmix	2024-02-04 10:32:33 +01:00
jojo61	c679d812d1	Fix flicker after mpv plugin use	2024-02-03 12:09:17 +01:00
jojo61	47b461ab46	Ffmeg does no Stereo Downmix for Codec AAV LATM Do Downmix after decoding	2024-02-02 15:27:39 +01:00
jojo61	8629946041	Reverse pkg-config for glu glew and glut	2024-02-02 00:19:43 +01:00
jojo61	a222f6a1d5	Fix Makefile	2024-01-30 17:11:16 +01:00
jojo61	b51589aaa9	Fix Makefile (remove placebo default)	2024-01-30 17:07:53 +01:00
jojo61	c3af54aae0	Merge pull request #69 from tmn505/pkg-config Use pkg-config for most configuration	2024-01-30 16:59:50 +01:00
Tomasz Maciej Nowak	4e96489e35	Query pkg-config for libplacebo library location The location of libplacebo could vary between systems, as it's fast-changing library with very dynamic API. This could force having various versions on the system for different applications. Use pkg-config to provide location of targeted libplacebo version, by providing custom PKG_CONFIG_PATH environmet variable.	2023-02-18 17:08:58 +01:00
Tomasz Maciej Nowak	65017da5ac	Provide linked libs by querying pkg-config	2023-02-18 17:08:58 +01:00