From d5fa0a49f868ff97cb5df523df9d3204ca1664df Mon Sep 17 00:00:00 2001 From: schmirl Date: Fri, 17 Jul 2009 06:21:23 +0000 Subject: [PATCH] fixed insecure format strings in LSTX handlers --- CONTRIBUTORS | 1 + HISTORY | 1 + server/connectionVTP.c | 10 +++++----- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTORS b/CONTRIBUTORS index 647fee9..2aef7be 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -101,6 +101,7 @@ Pixelpeter Anssi Hannula for the vdr-1.6.0-ignore_missing_cam.diff patch + for fixing insecure format strings in LSTX handlers wirbel for pointing out that section filtering is optional for VDR devices diff --git a/HISTORY b/HISTORY index b3b07cf..7ce45f8 100644 --- a/HISTORY +++ b/HISTORY @@ -1,6 +1,7 @@ VDR Plugin 'streamdev' Revision History --------------------------------------- +- fixed insecure format strings in LSTX handlers (thanks to Anssi Hannula) - updated Finish translation (thanks to Rolf Ahrenberg) - removed redefinitions in includes - caused problems in older compilers - fixed ts2ps.h defines diff --git a/server/connectionVTP.c b/server/connectionVTP.c index 6037ecc..c177eaf 100644 --- a/server/connectionVTP.c +++ b/server/connectionVTP.c @@ -1,5 +1,5 @@ /* - * $Id: connectionVTP.c,v 1.22 2009/07/02 06:03:51 schmirl Exp $ + * $Id: connectionVTP.c,v 1.23 2009/07/17 06:21:24 schmirl Exp $ */ #include "server/connectionVTP.h" @@ -215,7 +215,7 @@ bool cLSTEHandler::Next(bool &Last) Last = true; cString str(m_Error, true); m_Error = NULL; - return m_Client->Respond(m_Errno, *str); + return m_Client->Respond(m_Errno, "%s", *str); } Last = false; @@ -429,7 +429,7 @@ bool cLSTCHandler::Next(bool &Last) Last = true; cString str(m_Error, true); m_Error = NULL; - return m_Client->Respond(m_Errno, *str); + return m_Client->Respond(m_Errno, "%s", *str); } int number; @@ -525,7 +525,7 @@ bool cLSTTHandler::Next(bool &Last) Last = true; cString str(m_Error, true); m_Error = NULL; - return m_Client->Respond(m_Errno, *str); + return m_Client->Respond(m_Errno, "%s", *str); } bool result; @@ -626,7 +626,7 @@ bool cLSTRHandler::Next(bool &Last) Last = true; cString str(m_Error, true); m_Error = NULL; - return m_Client->Respond(m_Errno, *str); + return m_Client->Respond(m_Errno, "%s", *str); } if (m_Info) {