From 24972170960de056d5754aaa5360257f00d0a804 Mon Sep 17 00:00:00 2001 From: Klaus Schmidinger Date: Sat, 1 Mar 2008 09:42:36 +0100 Subject: [PATCH] The 'plugins' target in the Makefile now returns an error exit code if one of the plugins failed to compile --- CONTRIBUTORS | 2 ++ HISTORY | 4 +++- Makefile | 4 ++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTORS b/CONTRIBUTORS index 7b719184..af879b91 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -2101,6 +2101,8 @@ Tobias Grimm for fixing deleting the 'skinDescriptions' in cMenuSetupOSD::~cMenuSetupOSD() for reporting that GCC 4.3 issues a silly warning for expressions like 'a || b && c' for fixing a crash in cFreetypeFont::DrawText() if an unknown symbol is encountered + for suggesting that the 'plugins' target in the Makefile should return an error exit + code if one of the plugins failed to compile Helge Lenz for reporting a bug in setting the 'Delta' parameter when calling the shutdown diff --git a/HISTORY b/HISTORY index 6e806ed3..77e51474 100644 --- a/HISTORY +++ b/HISTORY @@ -5671,7 +5671,7 @@ Video Disk Recorder Revision History - Added the backslash ('\') to the list of characters that need to be escaped when executing external commands (thanks to Peter Bieringer for reporting this one). -2008-02-29: Version 1.5.17 +2008-03-01: Version 1.5.17 - Updated the Swedish OSD texts (thanks to Tomas Berglund). - Made the 'pic2mpg' script of the 'pictures' plugin work with uppercase filename @@ -5687,3 +5687,5 @@ Video Disk Recorder Revision History - Updated the Slovenian OSD texts (thanks to Matjaz Thaler). - Updated the Czech OSD texts (thanks to Vladimír Bárta and Jiri Dobry). - Updated the Turkish OSD texts (thanks to Oktay Yolgeçen). +- The 'plugins' target in the Makefile now returns an error exit code if one of the + plugins failed to compile (suggested by Tobias Grimm). diff --git a/Makefile b/Makefile index bbf67034..b07b1dfb 100644 --- a/Makefile +++ b/Makefile @@ -4,7 +4,7 @@ # See the main source file 'vdr.c' for copyright information and # how to reach the author. # -# $Id: Makefile 1.112 2008/01/13 12:53:17 kls Exp $ +# $Id: Makefile 1.113 2008/02/29 21:43:03 kls Exp $ .DELETE_ON_ERROR: @@ -153,7 +153,7 @@ plugins: include-dir $(MAKE) -C "$(PLUGINDIR)/src/$$i" all || failed="$$failed $$i";\ done;\ if [ -n "$$noapiv" ] ; then echo; echo "*** plugins without APIVERSION:$$noapiv"; echo; fi;\ - if [ -n "$$failed" ] ; then echo; echo "*** failed plugins:$$failed"; echo; fi + if [ -n "$$failed" ] ; then echo; echo "*** failed plugins:$$failed"; echo; exit 1; fi clean-plugins: @for i in `ls $(PLUGINDIR)/src | grep -v '[^a-z0-9]'`; do $(MAKE) -C "$(PLUGINDIR)/src/$$i" clean; done