From 66639dc1870fd30f1f4ef4e6b52d108eaadcbe5f Mon Sep 17 00:00:00 2001 From: Klaus Schmidinger Date: Sun, 11 Mar 2012 16:01:52 +0100 Subject: [PATCH] Made the "overloaded-virtual" warning an error to detect hidden overloaded virtual functions --- CONTRIBUTORS | 1 + HISTORY | 4 ++++ Make.config.template | 4 ++-- Makefile | 4 ++-- PLUGINS/src/dvbsddevice/Makefile | 4 ++-- PLUGINS/src/epgtableid0/Makefile | 4 ++-- PLUGINS/src/hello/Makefile | 4 ++-- PLUGINS/src/osddemo/Makefile | 4 ++-- PLUGINS/src/pictures/Makefile | 4 ++-- PLUGINS/src/rcu/Makefile | 4 ++-- PLUGINS/src/servicedemo/Makefile | 4 ++-- PLUGINS/src/skincurses/Makefile | 4 ++-- PLUGINS/src/status/Makefile | 4 ++-- PLUGINS/src/svdrpdemo/Makefile | 4 ++-- newplugin | 4 ++-- 15 files changed, 31 insertions(+), 26 deletions(-) diff --git a/CONTRIBUTORS b/CONTRIBUTORS index e6224e80..6bebb8a0 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -2386,6 +2386,7 @@ Anssi Hannula for setting the audio type of language descriptors to 0x00 in the PAT/PMT generator for adding support for automatically selecting subtitles when playing old PES recordings made with the subtitles plugin + for pointing out -Werror=... Antti Hartikainen for updating 'S13E' in 'sources.conf' diff --git a/HISTORY b/HISTORY index a290893e..a93b0863 100644 --- a/HISTORY +++ b/HISTORY @@ -7027,3 +7027,7 @@ Video Disk Recorder Revision History uses the respective code. You can reactivate these to quickly make your plugin compile again, but beware that these code parts will be removed in one of the next versions. +- Made the "overloaded-virtual" warning an error to detect hidden overloaded + virtual functions (thanks to Anssi Hannula for pointing out -Werror=...). + Plugin authors may want to change -Woverloaded-virtual to -Werror=overloaded-virtual + in their Makefiles. diff --git a/Make.config.template b/Make.config.template index 9b92621a..6c778c28 100644 --- a/Make.config.template +++ b/Make.config.template @@ -6,7 +6,7 @@ # See the main source file 'vdr.c' for copyright information and # how to reach the author. # -# $Id: Make.config.template 2.6 2012/02/27 10:56:28 kls Exp $ +# $Id: Make.config.template 2.7 2012/03/11 15:33:54 kls Exp $ ### The C compiler and options: @@ -14,7 +14,7 @@ CC ?= gcc CFLAGS ?= -g -O3 -Wall CXX ?= g++ -CXXFLAGS ?= -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses +CXXFLAGS ?= -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses ifdef PLUGIN CFLAGS += -fPIC diff --git a/Makefile b/Makefile index a5ff9c5b..019a0042 100644 --- a/Makefile +++ b/Makefile @@ -4,7 +4,7 @@ # See the main source file 'vdr.c' for copyright information and # how to reach the author. # -# $Id: Makefile 2.25 2012/02/27 10:54:38 kls Exp $ +# $Id: Makefile 2.26 2012/03/11 15:33:57 kls Exp $ .DELETE_ON_ERROR: @@ -12,7 +12,7 @@ CC ?= gcc CFLAGS ?= -g -O3 -Wall CXX ?= g++ -CXXFLAGS ?= -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses +CXXFLAGS ?= -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses LSIDIR = ./libsi DESTDIR ?= diff --git a/PLUGINS/src/dvbsddevice/Makefile b/PLUGINS/src/dvbsddevice/Makefile index bf5f7173..1e7b5dde 100644 --- a/PLUGINS/src/dvbsddevice/Makefile +++ b/PLUGINS/src/dvbsddevice/Makefile @@ -1,7 +1,7 @@ # # Makefile for a Video Disk Recorder plugin # -# $Id: Makefile 1.8 2012/01/18 12:28:43 kls Exp $ +# $Id: Makefile 1.9 2012/03/11 15:34:02 kls Exp $ # The official name of this plugin. # This name will be used in the '-P...' option of VDR to load the plugin. @@ -18,7 +18,7 @@ VERSION = $(shell grep 'static const char \*VERSION *=' $(PLUGIN).c | awk '{ pri ### The C++ compiler and options: CXX ?= g++ -CXXFLAGS ?= -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses +CXXFLAGS ?= -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses ### The directory environment: diff --git a/PLUGINS/src/epgtableid0/Makefile b/PLUGINS/src/epgtableid0/Makefile index 5653e28e..78bf3e78 100644 --- a/PLUGINS/src/epgtableid0/Makefile +++ b/PLUGINS/src/epgtableid0/Makefile @@ -1,7 +1,7 @@ # # Makefile for a Video Disk Recorder plugin # -# $Id: Makefile 1.1 2012/03/10 14:23:58 kls Exp $ +# $Id: Makefile 1.2 2012/03/11 15:34:04 kls Exp $ # The official name of this plugin. # This name will be used in the '-P...' option of VDR to load the plugin. @@ -18,7 +18,7 @@ VERSION = $(shell grep 'static const char \*VERSION *=' $(PLUGIN).c | awk '{ pri ### The C++ compiler and options: CXX ?= g++ -CXXFLAGS ?= -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses +CXXFLAGS ?= -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses ### The directory environment: diff --git a/PLUGINS/src/hello/Makefile b/PLUGINS/src/hello/Makefile index b1a5af11..cdf63401 100644 --- a/PLUGINS/src/hello/Makefile +++ b/PLUGINS/src/hello/Makefile @@ -1,7 +1,7 @@ # # Makefile for a Video Disk Recorder plugin # -# $Id: Makefile 2.8 2012/01/18 12:29:09 kls Exp $ +# $Id: Makefile 2.9 2012/03/11 15:34:06 kls Exp $ # The official name of this plugin. # This name will be used in the '-P...' option of VDR to load the plugin. @@ -18,7 +18,7 @@ VERSION = $(shell grep 'static const char \*VERSION *=' $(PLUGIN).c | awk '{ pri ### The C++ compiler and options: CXX ?= g++ -CXXFLAGS ?= -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses +CXXFLAGS ?= -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses ### The directory environment: diff --git a/PLUGINS/src/osddemo/Makefile b/PLUGINS/src/osddemo/Makefile index d192b4ae..68a236b5 100644 --- a/PLUGINS/src/osddemo/Makefile +++ b/PLUGINS/src/osddemo/Makefile @@ -1,7 +1,7 @@ # # Makefile for a Video Disk Recorder plugin # -# $Id: Makefile 2.4 2012/01/18 12:17:23 kls Exp $ +# $Id: Makefile 2.5 2012/03/11 15:34:08 kls Exp $ # The official name of this plugin. # This name will be used in the '-P...' option of VDR to load the plugin. @@ -16,7 +16,7 @@ VERSION = $(shell grep 'static const char \*VERSION *=' $(PLUGIN).c | awk '{ pri ### The C++ compiler and options: CXX ?= g++ -CXXFLAGS ?= -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses +CXXFLAGS ?= -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses ### The directory environment: diff --git a/PLUGINS/src/pictures/Makefile b/PLUGINS/src/pictures/Makefile index 112586bc..cee95efb 100644 --- a/PLUGINS/src/pictures/Makefile +++ b/PLUGINS/src/pictures/Makefile @@ -1,7 +1,7 @@ # # Makefile for a Video Disk Recorder plugin # -# $Id: Makefile 2.8 2012/01/18 12:30:05 kls Exp $ +# $Id: Makefile 2.9 2012/03/11 15:34:10 kls Exp $ # The official name of this plugin. # This name will be used in the '-P...' option of VDR to load the plugin. @@ -18,7 +18,7 @@ VERSION = $(shell grep 'static const char \*VERSION *=' $(PLUGIN).c | awk '{ pri ### The C++ compiler and options: CXX ?= g++ -CXXFLAGS ?= -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses +CXXFLAGS ?= -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses ### The directory environment: diff --git a/PLUGINS/src/rcu/Makefile b/PLUGINS/src/rcu/Makefile index 60bcf904..170490aa 100644 --- a/PLUGINS/src/rcu/Makefile +++ b/PLUGINS/src/rcu/Makefile @@ -1,7 +1,7 @@ # # Makefile for a Video Disk Recorder plugin # -# $Id: Makefile 1.1 2012/02/27 10:46:08 kls Exp $ +# $Id: Makefile 1.2 2012/03/11 15:34:12 kls Exp $ # The official name of this plugin. # This name will be used in the '-P...' option of VDR to load the plugin. @@ -18,7 +18,7 @@ VERSION = $(shell grep 'static const char \*VERSION *=' $(PLUGIN).c | awk '{ pri ### The C++ compiler and options: CXX ?= g++ -CXXFLAGS ?= -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses +CXXFLAGS ?= -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses ### The directory environment: diff --git a/PLUGINS/src/servicedemo/Makefile b/PLUGINS/src/servicedemo/Makefile index b2713ed7..941aaff6 100644 --- a/PLUGINS/src/servicedemo/Makefile +++ b/PLUGINS/src/servicedemo/Makefile @@ -1,7 +1,7 @@ # # Makefile for a Video Disk Recorder plugin # -# $Id: Makefile 2.4 2012/01/18 12:17:23 kls Exp $ +# $Id: Makefile 2.5 2012/03/11 15:34:13 kls Exp $ # The official name of this plugin. # This name will be used in the '-P...' option of VDR to load the plugin. @@ -18,7 +18,7 @@ VERSION = $(shell grep 'static const char \*VERSION *=' $(PLUGIN1).c | awk '{ pr ### The C++ compiler and options: CXX ?= g++ -CXXFLAGS ?= -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses +CXXFLAGS ?= -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses ### The directory environment: diff --git a/PLUGINS/src/skincurses/Makefile b/PLUGINS/src/skincurses/Makefile index 62f5d257..b43518b6 100644 --- a/PLUGINS/src/skincurses/Makefile +++ b/PLUGINS/src/skincurses/Makefile @@ -1,7 +1,7 @@ # # Makefile for a Video Disk Recorder plugin # -# $Id: Makefile 2.8 2012/01/18 12:30:52 kls Exp $ +# $Id: Makefile 2.9 2012/03/11 15:34:18 kls Exp $ # The official name of this plugin. # This name will be used in the '-P...' option of VDR to load the plugin. @@ -18,7 +18,7 @@ VERSION = $(shell grep 'static const char \*VERSION *=' $(PLUGIN).c | awk '{ pri ### The C++ compiler and options: CXX ?= g++ -CXXFLAGS ?= -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses +CXXFLAGS ?= -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses ### The directory environment: diff --git a/PLUGINS/src/status/Makefile b/PLUGINS/src/status/Makefile index 3e9b170d..dd46ba69 100644 --- a/PLUGINS/src/status/Makefile +++ b/PLUGINS/src/status/Makefile @@ -1,7 +1,7 @@ # # Makefile for a Video Disk Recorder plugin # -# $Id: Makefile 2.4 2012/01/18 12:17:23 kls Exp $ +# $Id: Makefile 2.5 2012/03/11 15:34:20 kls Exp $ # The official name of this plugin. # This name will be used in the '-P...' option of VDR to load the plugin. @@ -16,7 +16,7 @@ VERSION = $(shell grep 'static const char \*VERSION *=' $(PLUGIN).c | awk '{ pri ### The C++ compiler and options: CXX ?= g++ -CXXFLAGS ?= -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses +CXXFLAGS ?= -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses ### The directory environment: diff --git a/PLUGINS/src/svdrpdemo/Makefile b/PLUGINS/src/svdrpdemo/Makefile index 1f640b86..5109b297 100644 --- a/PLUGINS/src/svdrpdemo/Makefile +++ b/PLUGINS/src/svdrpdemo/Makefile @@ -1,7 +1,7 @@ # # Makefile for a Video Disk Recorder plugin # -# $Id: Makefile 2.4 2012/01/18 12:17:23 kls Exp $ +# $Id: Makefile 2.5 2012/03/11 15:34:22 kls Exp $ # The official name of this plugin. # This name will be used in the '-P...' option of VDR to load the plugin. @@ -16,7 +16,7 @@ VERSION = $(shell grep 'static const char \*VERSION *=' $(PLUGIN).c | awk '{ pri ### The C++ compiler and options: CXX ?= g++ -CXXFLAGS ?= -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses +CXXFLAGS ?= -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses ### The directory environment: diff --git a/newplugin b/newplugin index 53cbb73e..59a9435c 100755 --- a/newplugin +++ b/newplugin @@ -12,7 +12,7 @@ # See the main source file 'vdr.c' for copyright information and # how to reach the author. # -# $Id: newplugin 2.7 2012/01/18 12:32:31 kls Exp $ +# $Id: newplugin 2.8 2012/03/11 15:34:26 kls Exp $ $PLUGIN_NAME = $ARGV[0] || die "Usage: newplugin \n"; @@ -77,7 +77,7 @@ VERSION = \$(shell grep 'static const char \\*VERSION *=' \$(PLUGIN).c | awk '{ ### The C++ compiler and options: CXX ?= g++ -CXXFLAGS ?= -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses +CXXFLAGS ?= -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses ### The directory environment: