frodovdr/vdr
1
0
Fork 0
mirror of https://github.com/VDR4Arch/vdr.git synced 2023-10-10 13:36:52 +02:00
Code Issues Releases Wiki Activity

Fixed a possible heap-use-after-free in cDvbTuner::Action()

Browse Source
This commit is contained in:
Klaus Schmidinger 2022-12-05 14:04:10 +01:00
parent a299d8d348
commit c12c7378e9
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CONTRIBUTORS
View File

@ -2202,6 +2202,7 @@ Marko M
for reporting a problem with the video directory not being set correctly with --edit for reporting a problem with the video directory not being set correctly with --edit
for reporting a compiler warning about the use of strncpy() in strreplace() for reporting a compiler warning about the use of strncpy() in strreplace()
for adding support for kernel based LIRC driver for adding support for kernel based LIRC driver
for reporting a possible heap-use-after-free in cDvbTuner::Action()
Patrick Rother <krd-vdr@gulu.net> Patrick Rother <krd-vdr@gulu.net>
for reporting a bug in defining timers that only differ in the day of week for reporting a bug in defining timers that only differ in the day of week

3
HISTORY
View File

@ -9816,9 +9816,10 @@ Video Disk Recorder Revision History
- Added missing rounding when dividing frequencies in processing the NIT (thanks to - Added missing rounding when dividing frequencies in processing the NIT (thanks to
Winfried Köhler). Winfried Köhler).
2022-12-01: 2022-12-05:
- Fixed a compiler warning. - Fixed a compiler warning.
- Fixed generating the index file in the cutter (reported by Christoph Haubrich). - Fixed generating the index file in the cutter (reported by Christoph Haubrich).
- Fixed a faulty 'Timer still recording' query when canceling an editing job. - Fixed a faulty 'Timer still recording' query when canceling an editing job.
- Added code for the 'qks' audio track (thanks to Johann Friedrichs). - Added code for the 'qks' audio track (thanks to Johann Friedrichs).
- Fixed a possible heap-use-after-free in cDvbTuner::Action() (reported by Marko Mäkelä).

8
dvbdevice.c
View File

@ -4,7 +4,7 @@
* See the main source file 'vdr.c' for copyright information and * See the main source file 'vdr.c' for copyright information and
* how to reach the author. * how to reach the author.
* *
* $Id: dvbdevice.c 5.2 2022/11/14 16:31:08 kls Exp $ * $Id: dvbdevice.c 5.3 2022/12/05 14:04:10 kls Exp $
*/ */
#include "dvbdevice.h" #include "dvbdevice.h"
@ -1858,16 +1858,16 @@ cDvbDevice::cDvbDevice(int Adapter, int Frontend)
// We only check the devices that must be present - the others will be checked before accessing them://XXX // We only check the devices that must be present - the others will be checked before accessing them://XXX
dvbTuner = new cDvbTuner(this, adapter, frontend);
StartSectionHandler(); StartSectionHandler();
dvbTuner = new cDvbTuner(this, adapter, frontend);
} }
cDvbDevice::~cDvbDevice() cDvbDevice::~cDvbDevice()
{ {
StopSectionHandler();
delete dvbTuner; delete dvbTuner;
delete ciAdapter; delete ciAdapter;
StopSectionHandler();
UnBond(); UnBond();
// We're not explicitly closing any device files here, since this sometimes // We're not explicitly closing any device files here, since this sometimes
// caused segfaults. Besides, the program is about to terminate anyway... // caused segfaults. Besides, the program is about to terminate anyway...