Update usage of apt module, move away from deprecated loop approach

Manual.org

@@ -198,7 +198,7 @@ fi
 # update packages
 apt update
 apt -y install software-properties-common
-add-apt-repository -y ppa:ansible/ansible-2.6
+add-apt-repository -y ppa:ansible/ansible-2.7
 
 # install required packages
 apt-get -y install --no-install-recommends ansible python-jmespath
@@ -430,12 +430,10 @@ grub:
 
 - name: apt | install packages
   apt:
-    name: '{{ item }}'
+    name: '{{ packages }}'
     state: present
     install_recommends: no
     cache_valid_time: 60
-  with_items:
-    '{{ packages }}'
 #+END_SRC
 
 ** nvidia experimental drivers
@@ -464,12 +462,11 @@ install nvidia-396 from ppa:graphics-drivers/ppa
 
 - name: install nvidia-396 and other required packages
   apt:
-    name: '{{ item }}'
+    name:
+      -nvidia-396
+      -nvidia-settings
     state: present
     install_recommends: no
-  with_items:
-    - nvidia-396
-    - nvidia-settings
   tags:
     - packages
 #+END_SRC
@@ -669,10 +666,7 @@ yavdr-common executes the following tasks:
  #+BEGIN_SRC yaml :tangle roles/yavdr-common/tasks/configure_system.yml :mkdirp yes
 - name: apt | install basic packages
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-    install_recommends: no
-  with_items:
       - anacron
       - acl
       - at
@@ -691,6 +685,8 @@ yavdr-common executes the following tasks:
       - wpasupplicant
       - usbutils
       - xfsprogs
+    state: present
+    install_recommends: no
 
  #+END_SRC
 ***** Install additional packages (user defined)
@@ -700,11 +696,10 @@ yavdr-common executes the following tasks:
 #+BEGIN_SRC yaml :tangle roles/yavdr-common/tasks/configure_system.yml
 - name: apt | install extra packages
   apt:
-    name: '{{ item }}'
+    name: '{{ extra_packages }}'
     state: present
     install_recommends: no
-  with_items:
+      
-      '{{ extra_packages }}'
 #+END_SRC
 ***** create directories
 :PROPERTIES:
@@ -835,13 +830,12 @@ first_run: False
 
 - name: apt | install basic vdr packages
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-    install_recommends: no
-  with_items:
       - vdr
       - vdrctl
       - vdr-plugin-dbus2vdr
+    state: present
+    install_recommends: no
 #+END_SRC
 **** Add svdrp/svdrp-disc to /etc/services
 :PROPERTIES:
@@ -899,11 +893,9 @@ The additional plugins to install can be set in the variable ~{{vdr_plugins}}~ i
 #+BEGIN_SRC yaml :tangle roles/vdr/tasks/main.yml :mkdirp yes
 - name: apt | install additional vdr plugins
   apt:
-    name: '{{ item }}'
+    name: '{{ vdr_plugins | default([]) }}'
     state: present
     install_recommends: no
-  with_items:
-    '{{ vdr_plugins | default({}) }}'
   notify: [ 'Restart VDR' ]
 #+END_SRC
 **** copy vdr configuration files (if they don't exist yet)
@@ -1144,10 +1136,7 @@ install_avahi: true
 
 - name: apt | install packages for network services
   apt:
-      name: '{{ item }}'
+      name:
-      state: present
-      install_recommends: no
-  with_items:
           - avahi-daemon
           - avahi-utils
           #- biosdevname # caution: this may change device names after a minimal installation!
@@ -1155,6 +1144,8 @@ install_avahi: true
           - nfs-common
           - vdr-addon-avahi-linker
           - wakeonlan
+      state: present
+      install_recommends: no
 
 # Does this really work? We need a way to check if an interface supports WOL - Python Skript?
 # - name: check WOL capabilities of network interfaces
@@ -1219,12 +1210,11 @@ install_avahi: true
 
 - name: install nfs server packages
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-    install_recommends: no
-  with_items:
       - nfs-kernel-server
       - nfs-common
+    state: present
+    install_recommends: no
 
 - name: create /etc/exports
   template:
@@ -1292,11 +1282,10 @@ lircd0_socket: /var/run/lirc/lircd0
 
 - name: apt | install packages for remote support
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-  with_items:
       - yavdr-remote
       - lirc
+    state: present
   tags:
     - packages
 
@@ -1330,11 +1319,10 @@ lircd0_socket: /var/run/lirc/lircd0
 
 - name: apt | install eventlircd and lircd2uinput
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-  with_items:
       - eventlircd
       - lircd2uinput
+    state: present
   tags:
     - packages
 
@@ -1584,13 +1572,12 @@ ati_remote    rc-medion-x10-digitainer   /lib/udev/rc_keymaps/rc-medion-x10-digi
 
 - name: apt | install pulseaudio, pavucontrol and vdr-plugin-pulsecontrol
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-    install_recommends: no
-  with_items:
       - pulseaudio
       - pavucontrol
       - vdr-plugin-pulsecontrol
+    state: present
+    install_recommends: no
 
 - name: create /etc/asound.conf with pulseaudio as default device
   template:
@@ -2144,9 +2131,7 @@ preferred_refreshrates:
 
 - name: apt | install packages for xorg
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-  with_items:
       - xlogin
       - yavdr-xorg
       - xorg
@@ -2161,14 +2146,14 @@ preferred_refreshrates:
       - vdr-plugin-osd2web
       - feh
       #- yavdr-xorg
+    state: present
 
 - name: apt | install packages for Intel IGP
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-  with_items:
       - xserver-xorg-video-intel
       - i965-va-driver-shaders
+    state: present
   when: intel_detected
 
 - name: download yavdr logo
@@ -2195,12 +2180,11 @@ preferred_refreshrates:
 
 - name: apt | install desktop programs
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-  with_items:
       - xterm
       - firefox
       - kiosk-browser
+    state: present
 #+END_SRC
 **** detect-xorg.yml
 :PROPERTIES:
@@ -4911,14 +4895,14 @@ end
 
 - name: install samba server
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-    install_recommends: no
-  with_items:
       - samba
       - samba-common
       - samba-common-bin
       - tdb-tools
+    state: present
+    install_recommends: no
+  with_items:
 
 #+END_SRC
 ** samba-config
@@ -5135,8 +5119,7 @@ This role installs the guest additions for virtualbox guests on Ubuntu 16.04
     - name: install packages
       apt:
         state: present
-        name: '{{ item }}'
+        name:
-      with_items:
           - dkms
           - virtualbox-guest-x11-hwe
           - virtualbox-guest-dkms-hwe
@@ -5151,11 +5134,10 @@ This role installs the guest additions for virtualbox guests on Ubuntu 16.04
 - name: set xineliboutput as frontend
   block:
     - apt:
-        name: '{{ item }}'
+        name:
-        state: present
-      with_items:
           - vdr-plugin-xineliboutput
           - xineliboutput-sxfe
+        state: present
     - command: '{{ item }}'
       with_items:
         - vdrctl disable softhddevice

install-yavdr.sh

@@ -8,7 +8,7 @@ fi
 # update packages
 apt update
 apt -y install software-properties-common
-add-apt-repository -y ppa:ansible/ansible-2.6
+add-apt-repository -y ppa:ansible/ansible-2.7
 
 # install required packages
 apt-get -y install --no-install-recommends ansible python-jmespath

roles/autoinstall-virtualbox-guest/tasks/main.yml

@@ -6,8 +6,7 @@
     - name: install packages
       apt:
         state: present
-        name: '{{ item }}'
+        name:
-      with_items:
           - dkms
           - virtualbox-guest-x11-hwe
           - virtualbox-guest-dkms-hwe
@@ -22,11 +21,10 @@
 - name: set xineliboutput as frontend
   block:
     - apt:
-        name: '{{ item }}'
+        name:
-        state: present
-      with_items:
           - vdr-plugin-xineliboutput
           - xineliboutput-sxfe
+        state: present
     - command: '{{ item }}'
       with_items:
         - vdrctl disable softhddevice

roles/nfs-server/tasks/main.yml

@@ -2,12 +2,11 @@
 
 - name: install nfs server packages
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-    install_recommends: no
-  with_items:
       - nfs-kernel-server
       - nfs-common
+    state: present
+    install_recommends: no
 
 - name: create /etc/exports
   template:

roles/nvidia-experimental/tasks/main.yml

@@ -10,11 +10,10 @@
 
 - name: install nvidia-396 and other required packages
   apt:
-    name: '{{ item }}'
+    name:
+      -nvidia-396
+      -nvidia-settings
     state: present
     install_recommends: no
-  with_items:
-    - nvidia-396
-    - nvidia-settings
   tags:
     - packages

roles/pulseaudio/tasks/main.yml

@@ -2,13 +2,12 @@
 
 - name: apt | install pulseaudio, pavucontrol and vdr-plugin-pulsecontrol
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-    install_recommends: no
-  with_items:
       - pulseaudio
       - pavucontrol
       - vdr-plugin-pulsecontrol
+    state: present
+    install_recommends: no
 
 - name: create /etc/asound.conf with pulseaudio as default device
   template:

roles/samba-install/tasks/main.yml

@@ -3,11 +3,11 @@
 
 - name: install samba server
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-    install_recommends: no
-  with_items:
       - samba
       - samba-common
       - samba-common-bin
       - tdb-tools
+    state: present
+    install_recommends: no
+  with_items:

roles/vdr/tasks/main.yml

@@ -3,13 +3,12 @@
 
 - name: apt | install basic vdr packages
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-    install_recommends: no
-  with_items:
       - vdr
       - vdrctl
       - vdr-plugin-dbus2vdr
+    state: present
+    install_recommends: no
 - name: add svdrp and svdrp-disc to /etc/services
   lineinfile:
     dest: /etc/services
@@ -48,11 +47,9 @@
 # TODO: set recdir, user etc. in /etc/vdr/conf.d/
 - name: apt | install additional vdr plugins
   apt:
-    name: '{{ item }}'
+    name: '{{ vdr_plugins | default([]) }}'
     state: present
     install_recommends: no
-  with_items:
-    '{{ vdr_plugins | default({}) }}'
   notify: [ 'Restart VDR' ]
 - name: ensure vdr is stopped
   systemd:

roles/yavdr-common/tasks/configure_system.yml

@@ -31,10 +31,7 @@
       skip: true
 - name: apt | install basic packages
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-    install_recommends: no
-  with_items:
       - anacron
       - acl
       - at
@@ -53,10 +50,10 @@
       - wpasupplicant
       - usbutils
       - xfsprogs
-- name: apt | install extra packages
-  apt:
-    name: '{{ item }}'
     state: present
     install_recommends: no
-  with_items:
+- name: apt | install extra packages
-      '{{ extra_packages }}'
+  apt:
+    name: '{{ extra_packages }}'
+    state: present
+    install_recommends: no

roles/yavdr-network/tasks/main.yml

@@ -3,10 +3,7 @@
 
 - name: apt | install packages for network services
   apt:
-      name: '{{ item }}'
+      name:
-      state: present
-      install_recommends: no
-  with_items:
           - avahi-daemon
           - avahi-utils
           #- biosdevname # caution: this may change device names after a minimal installation!
@@ -14,6 +11,8 @@
           - nfs-common
           - vdr-addon-avahi-linker
           - wakeonlan
+      state: present
+      install_recommends: no
 
 # Does this really work? We need a way to check if an interface supports WOL - Python Skript?
 # - name: check WOL capabilities of network interfaces

roles/yavdr-remote/tasks/main.yml

@@ -3,11 +3,10 @@
 
 - name: apt | install packages for remote support
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-  with_items:
       - yavdr-remote
       - lirc
+    state: present
   tags:
     - packages
 
@@ -41,11 +40,10 @@
 
 - name: apt | install eventlircd and lircd2uinput
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-  with_items:
       - eventlircd
       - lircd2uinput
+    state: present
   tags:
     - packages
 

roles/yavdr-xorg/tasks/setup-xorg.yml

@@ -55,9 +55,7 @@
 
 - name: apt | install packages for xorg
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-  with_items:
       - xlogin
       - yavdr-xorg
       - xorg
@@ -72,14 +70,14 @@
       - vdr-plugin-osd2web
       - feh
       #- yavdr-xorg
+    state: present
 
 - name: apt | install packages for Intel IGP
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-  with_items:
       - xserver-xorg-video-intel
       - i965-va-driver-shaders
+    state: present
   when: intel_detected
 
 - name: download yavdr logo
@@ -106,9 +104,8 @@
 
 - name: apt | install desktop programs
   apt:
-    name: '{{ item }}'
+    name:
-    state: present
-  with_items:
       - xterm
       - firefox
       - kiosk-browser
+    state: present