Merge pull request #73 from lobocobra/patch-1

Fix error in start script


Former-commit-id: 6a02b865c86befa29e970a7465b256cde5335e95

src/hyperion-v4l2/CMakeLists.txt

@@ -21,6 +21,7 @@ set(Hyperion_V4L2_QT_HEADERS
 
 set(Hyperion_V4L2_HEADERS
 	VideoStandardParameter.h
+	PixelFormatParameter.h
 	ProtoConnection.h
 )
 

src/hyperion-v4l2/PixelFormatParameter.h

@@ -0,0 +1,43 @@
+// getoptPlusPLus includes
+#include <getoptPlusPlus/getoptpp.h>
+
+// grabber includes
+#include <grabber/PixelFormat.h>
+
+using namespace vlofgren;
+
+/// Data parameter for the pixel format
+typedef vlofgren::PODParameter<PixelFormat> PixelFormatParameter;
+
+namespace vlofgren {
+	/// Translates a string (as passed on the commandline) to a pixel format
+	///
+	/// @param[in] s The string (as passed on the commandline)
+	/// @return The pixel format
+	/// @throws Parameter::ParameterRejected If the string did not result in a pixel format
+	template<>
+	PixelFormat PixelFormatParameter::validate(const std::string& s) throw (Parameter::ParameterRejected)
+	{
+		QString input = QString::fromStdString(s).toLower();
+
+		if (input == "yuyv")
+		{
+			return PIXELFORMAT_YUYV;
+		}
+		else if (input == "uyvy")
+		{
+			return PIXELFORMAT_UYVY;
+		}
+		else if (input == "rgb32")
+		{
+			return PIXELFORMAT_RGB32;
+		}
+		else if (input == "no-change")
+		{
+			return PIXELFORMAT_NO_CHANGE;
+		}
+
+		throw Parameter::ParameterRejected("Invalid value for pixel format. Valid values are: YUYV, UYVY, RGB32, and NO-CHANGE");
+		return PIXELFORMAT_NO_CHANGE;
+	}
+}

src/hyperion-v4l2/hyperion-v4l2.cpp

@@ -18,6 +18,7 @@
 // hyperion-v4l2 includes
 #include "ProtoConnection.h"
 #include "VideoStandardParameter.h"
+#include "PixelFormatParameter.h"
 #include "ImageHandler.h"
 #include "ScreenshotHandler.h"
 
@@ -50,6 +51,7 @@ int main(int argc, char** argv)
 
 		StringParameter        & argDevice          = parameters.add<StringParameter>       ('d', "device",           "The device to use [default=/dev/video0]");
 		VideoStandardParameter & argVideoStandard   = parameters.add<VideoStandardParameter>('v', "video-standard",   "The used video standard. Valid values are PAL or NTSC (optional)");
+		PixelFormatParameter   & argPixelFormat     = parameters.add<PixelFormatParameter>  (0x0, "pixel-format",     "The use pixel format. Valid values are YUYV, UYVY, and RGB32 (optional)");
 		IntParameter           & argInput           = parameters.add<IntParameter>          (0x0, "input",            "Input channel (optional)");
 		IntParameter           & argWidth           = parameters.add<IntParameter>          (0x0, "width",            "Try to set the width of the video input (optional)");
 		IntParameter           & argHeight          = parameters.add<IntParameter>          (0x0, "height",           "Try to set the height of the video input (optional)");
@@ -76,6 +78,7 @@ int main(int argc, char** argv)
 		// set defaults
 		argDevice.setDefault("/dev/video0");
 		argVideoStandard.setDefault(VIDEOSTANDARD_NO_CHANGE);
+		argPixelFormat.setDefault(PIXELFORMAT_NO_CHANGE);
 		argInput.setDefault(-1);
 		argWidth.setDefault(-1);
 		argHeight.setDefault(-1);
@@ -107,6 +110,7 @@ int main(int argc, char** argv)
 					argDevice.getValue(),
 					argInput.getValue(),
 					argVideoStandard.getValue(),
+					argPixelFormat.getValue(),
 					argWidth.getValue(),
 					argHeight.getValue(),
 					std::max(1, argFrameDecimation.getValue()),

src/hyperiond/hyperiond.cpp

@@ -180,6 +180,7 @@ int main(int argc, char** argv)
 					grabberConfig.get("device", "/dev/video0").asString(),
 					grabberConfig.get("input", 0).asInt(),
 					parseVideoStandard(grabberConfig.get("standard", "no-change").asString()),
+					parsePixelFormat(grabberConfig.get("pixelFormat", "no-change").asString()),
 					grabberConfig.get("width", -1).asInt(),
 					grabberConfig.get("height", -1).asInt(),
 					grabberConfig.get("frameDecimation", 2).asInt(),