frodovdr/kopano-ol-extension
1
0
Fork 0
mirror of https://github.com/Kopano-dev/kopano-ol-extension.git synced 2023-10-10 13:37:40 +02:00
Code Issues Releases Wiki Activity

More small cleanups

Browse Source
This commit is contained in:
Patrick Simpson 2017-02-15 11:40:34 +01:00
parent 0657c490c8
commit 66601246b1
3 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/AcaciaZPushPlugin/AcaciaZPushPlugin/UI/Outlook/OutlookImageList.cs
View File

@ -43,7 +43,6 @@ namespace Acacia.UI.Outlook
Images.ColorDepth = ColorDepth.Depth32Bit; Images.ColorDepth = ColorDepth.Depth32Bit;
Images.ImageSize = new Size(16, 16); Images.ImageSize = new Size(16, 16);
// TODO: memory management
using (IExplorer explorer = ThisAddIn.Instance.GetActiveExplorer()) using (IExplorer explorer = ThisAddIn.Instance.GetActiveExplorer())
using (ICommandBars cmdBars = explorer.GetCommandBars()) using (ICommandBars cmdBars = explorer.GetCommandBars())
{ {

7
src/AcaciaZPushPlugin/AcaciaZPushPlugin/Utils/MailEvents.cs
View File

@ -48,8 +48,6 @@ namespace Acacia.Utils
public event MailResponseEventHandler Reply; public event MailResponseEventHandler Reply;
private void OnReply(IMailItem mail, IMailItem response) private void OnReply(IMailItem mail, IMailItem response)
{ {
// TODO: check release of first item
// TODO: release if not sending event
try try
{ {
if ((Reply != null || Respond != null) && mail != null && response != null) if ((Reply != null || Respond != null) && mail != null && response != null)
@ -69,8 +67,6 @@ namespace Acacia.Utils
public event MailResponseEventHandler ReplyAll; public event MailResponseEventHandler ReplyAll;
private void OnReplyAll(IMailItem mail, IMailItem response) private void OnReplyAll(IMailItem mail, IMailItem response)
{ {
// TODO: check release of first item
// TODO: release if not sending event
try try
{ {
if ((ReplyAll != null || Respond != null) && mail != null && response != null) if ((ReplyAll != null || Respond != null) && mail != null && response != null)
@ -90,8 +86,6 @@ namespace Acacia.Utils
public event MailResponseEventHandler Forward; public event MailResponseEventHandler Forward;
private void OnForward(IMailItem mail, IMailItem response) private void OnForward(IMailItem mail, IMailItem response)
{ {
// TODO: check release of first item
// TODO: release if not sending event
try try
{ {
if ((Forward != null || Respond != null) && mail != null && response != null) if ((Forward != null || Respond != null) && mail != null && response != null)
@ -162,7 +156,6 @@ namespace Acacia.Utils
{ {
try try
{ {
// TODO: release item if event not sent
if (ItemSend != null && item != null) if (ItemSend != null && item != null)
{ {
using (IMailItem wrapped = Mapping.WrapOrDefault<IMailItem>(item, false)) using (IMailItem wrapped = Mapping.WrapOrDefault<IMailItem>(item, false))

3
src/AcaciaZPushPlugin/AcaciaZPushPlugin/ZPush/ZPushWatcher.cs
View File

@ -130,7 +130,6 @@ namespace Acacia.ZPush
} }
else else
{ {
// TODO
ThisAddIn.Instance.InvokeUI(() => ThisAddIn.Instance.InvokeUI(() =>
{ {
Logger.Instance.Warning(this, "Password not available for account: {0}", account); Logger.Instance.Warning(this, "Password not available for account: {0}", account);
@ -182,7 +181,7 @@ namespace Acacia.ZPush
catch (System.Exception e) { Logger.Instance.Error(this, "Exception in Explorer_SelectionChange.ActiveFolderChange: {0}", e); } catch (System.Exception e) { Logger.Instance.Error(this, "Exception in Explorer_SelectionChange.ActiveFolderChange: {0}", e); }
} }
} }
// TODO: cache value // TODO: cache value?
if (ZPushAccountChange != null) if (ZPushAccountChange != null)
{ {
try try