frodovdr
/
node-red-nodes
mirror of https://github.com/node-red/node-red-nodes.git
1
0
Fork 0
Code Issues Releases Wiki Activity

STOMP: Improved error stated and logging (#1021) 

* Improved error states and logging

* Fix misplaced reconnect error message

* No double logging of reconnecting event
This commit is contained in:
Olivier Verhaegen 2023-08-11 16:31:00 +02:00 committed by GitHub
parent 79b93f30ec
commit 878694fa1c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
io/stomp/18-stomp.js
View File

@ -54,15 +54,15 @@ module.exports = function(RED) {
}
}
function setStatusError(node, allNodes) {
function setStatusError(node, allNodes, message = undefined) {
if(allNodes) {
for (var id in node.users) {
if (hasProperty(node.users, id)) {
node.users[id].status({ fill: "red", shape: "dot", text: "error" });
node.users[id].status({ fill: "red", shape: "dot", text: message ?? "error" });
}
}
} else {
node.status({ fill: "red", shape: "dot", text: "error" });
node.status({ fill: "red", shape: "dot", text: message ?? "error" });
}
}
@ -219,22 +219,24 @@ module.exports = function(RED) {
});
node.client.on("reconnecting", function() {
node.warn("reconnecting");
node.connecting = true;
node.connected = false;
node.log("Reconnecting to STOMP server...", {url: `${node.options.address}:${node.options.port}`, protocolVersion: node.options.protocolVersion});
node.warn(`Reconnecting to STOMP server, url: ${node.options.address}:${node.options.port}, protocolVersion: ${node.options.protocolVersion}`);
setStatusConnecting(node, true);
});
node.client.on("error", function(err) {
node.error(err);
setStatusError(node, true);
if (err.reconnectionFailed) {
setStatusError(node, true, "Reconnection failed: exceeded number of reconnection attempts");
}
});
node.client.connect();
} catch (err) {
node.error(err);
setStatusError(node, true);
}
} else {
node.log("Not connecting to STOMP server, already connected");