1
0
mirror of https://github.com/node-red/node-red-nodes.git synced 2023-10-10 13:36:58 +02:00
Commit Graph

1327 Commits

Author SHA1 Message Date
guzba
ff9d21827d
Attempt to mitigate stream server connect feedback loop
Pushbullet dev here. Around 36 hours ago we started receiving around 750 additional requests per second to connect to our stream server. I blocked around 50 - 100 IP addresses to mitigate the spam. This spam traffic has continued unchanged since then.

I don't know for sure what caused this, but one user came forward reporting issues with their Node-Red setup after I banned the IPs (status code is my banned IP status code which is pretty compelling evidence). I can't be sure what is causing the issue since no User-Agent is included in the requests, but it for sure is at least partly Node-Red API users. I'd like to work on mitigating this since mitigating the spam traffic costs money.

My first theory here is in this PR. I am not aware of any guarantees that you'll never get multiple 'error' events, so it makes sense to clear the timeout before setting a new one to reconnect. Even if it is just defensive, it may not have much cost? If you do get multiple error events without this change, it is possible to trigger many connect() requests which can error out and then trigger many more connect() requests with lots of timeouts, which is not good.

Another thing to consider is that this library's dependency for PB (https://github.com/alexwhitman/node-pushbullet-api) already has code to reconnect if a websocket connection is lost without having been properly closed. I think an even better solution is verifying this works and then deleting the reconnect logic from here.

I'm not an expert on Node-Red though so I am only trying to offer suggestions to ensure everyone is a good citizen when using our API :) Thanks!
2020-10-13 16:27:30 -05:00
Dave Conway-Jones
f599797144
bump for latest PRs 2020-10-05 09:45:38 +01:00
Ross Cruickshank
9cc61cb0f1
mongdb - move projection into find pipeline (#697)
new node.js client API moved projection into options object - switched to pipeline stage instead #695
2020-10-05 09:28:58 +01:00
Ross Cruickshank
4ae0818a4b
mongodb - dereference aggregateCursor (#696)
new node.js client library moved  aggregate response  - using toArray to  return result-set in msg.payload #693
2020-10-05 09:28:39 +01:00
Dave Conway-Jones
aa45796a98
bump pushbullet package for PR 2020-09-27 12:59:02 +01:00
Frakke0
e980c8c04d
Fix not shown error (#692)
Fixed response to shown as string and not object
2020-09-27 12:57:09 +01:00
Dave Conway-Jones
d3a3bc158c
email - show valid folders in error if fetch fails 2020-09-23 23:54:09 +01:00
Dave Conway-Jones
973fd8c6ec
bump email package version 2020-09-23 10:20:58 +01:00
Vincent Hou
606f9c71e7
Update 61-email.js (#689)
Fixed disposition issue caused by `this`.
2020-09-23 08:35:08 +01:00
Dave Conway-Jones
fbad6e4c2d
clarify linting confusion 2020-09-17 10:02:54 +01:00
Dave Conway-Jones
c21fb22918
Linting and bump package for new clustered PR. 2020-09-17 09:21:50 +01:00
Ross Cruickshank
cde422f34a
mongodb: update to add support replicaset clusters (ICD4Mongo) (#688) 2020-09-17 09:17:43 +01:00
Dave Conway-Jones
d26cb057f9
add host property to outgoing msg
to close #687
2020-09-15 16:12:03 +01:00
Ross Cruickshank
4becf68848
use mongodb 3.6.1 client, add clustering support (#685) 2020-09-14 17:21:41 +01:00
Dave Conway-Jones
7e8571af42
update lib versions for grunt 2020-09-11 22:21:52 +01:00
Dave Conway-Jones
f95f0639f4
bump sqlite lib 2020-09-11 12:44:05 +01:00
Dave Conway-Jones
2625022fbc
bump pigpio package for env variable pin setting pr 2020-08-31 10:48:48 +01:00
Pablo Acosta-Serafini
0b4c1ff977
Enable the use of environment variables to define GPIO pin number (#676)
* Enable the use of environment variables to define GPIO pin number

* Pin field moved below table. Field width made the same as table. Restored
fa-icon and "Pin" label. Closed validation escapes.
2020-08-31 10:45:41 +01:00
Dave Conway-Jones
46f3dfc382
email don't retry connection while still busy. 2020-08-28 09:36:06 +01:00
Dave Conway-Jones
53ad00f165
bump serialport dependency, add ja translation for baudrate message, fix linting, bump package 2020-08-27 13:00:10 +01:00
Orfait
53f32ec521
[serialport] Allow baudrate change at run time (#675)
* Added baudrate change in serialport

* Added baudrate change to "serial request" (not only "serial out")

* Added doc
2020-08-27 09:20:09 +01:00
Dave Conway-Jones
ea729546d4
add sms_changed to pushbullet handler 2020-08-24 12:12:32 +01:00
Ben Hardill
34262e2fb0
Adding extra error checking for response from devices (#672) 2020-08-17 21:43:12 +01:00
Dave Conway-Jones
4ed0cb84d9
add some words to snmp info/readme
to close #667
2020-08-06 18:10:09 +01:00
Dave Conway-Jones
81039eacbc
bump markdown node package version 2020-07-16 10:16:03 +01:00
Dave Conway-Jones
4cabe5ea30
bump xmpp node package version 2020-07-16 10:15:49 +01:00
Andreas Martens
e334040dd7
replace xmpp-simple with @xmpp/client (#664)
* replace xmpp-simple with @xmpp/client

* indent at 4

* remove trailing commas
2020-07-16 10:00:27 +01:00
Dave Conway-Jones
2d0c8f0fb0
fix esversion for lint 2020-07-16 09:15:01 +01:00
Andreas Martens
bf94d320a9
correctly join a chat room (#663) 2020-07-10 12:30:44 +01:00
Dave Conway-Jones
8919edf0e6
turn off allow node14 failures 2020-07-04 17:06:41 +01:00
Dave Conway-Jones
8e45b96ec1
do the x-red thing to smooth node 2020-07-01 11:17:00 +01:00
Dave Conway-Jones
5ba989f09d
tidy up ping node listeners 2020-07-01 11:16:20 +01:00
Dave Conway-Jones
41d9f18608
Daemon node - catch tiny possible escape with "\n " in command as label 2020-06-22 22:45:34 +01:00
Nick O'Leary
98d5df965c
[sensehatsim] Add support for scrolling text 2020-06-18 00:44:53 +01:00
Dave Conway-Jones
696a99eaa3
bump random node to pickup translations 2020-06-17 18:15:10 +01:00
Kazuhito Yokoi
7cec44d353
Add Japanese translations for random node (#658) 2020-06-17 09:02:47 +01:00
Dave Conway-Jones
34fc79ddb6
Bump piLcd package after tidy up 2020-06-15 23:20:46 +01:00
Dave Conway-Jones
6161df3380
Merge branch 'master' of https://github.com/node-red/node-red-nodes 2020-06-15 23:16:59 +01:00
Kazuhito Yokoi
84c5c6cb30
Add Japanese translations for pilcd node (#657) 2020-06-15 23:11:53 +01:00
Dave Conway-Jones
a84658661d
fix comment 2020-06-15 15:31:44 +01:00
Dave Conway-Jones
24bd20ab21
Fix not triggering on waitfor character 2020-06-13 20:35:14 +01:00
Dave Conway-Jones
cd85fe8df2
Fix RBE greater than change not emitting on first message
And fix missing close tags
2020-05-31 21:52:37 +01:00
Dave Conway-Jones
01d675b372
Merge branch 'master' of https://github.com/node-red/node-red-nodes 2020-05-24 16:42:42 +01:00
Dave Conway-Jones
e2c9a6521e
pushover node - hide user id and well as api key 2020-05-24 16:42:28 +01:00
juggledad
3afc2622f3
Updated README to expand the way msg.from works (#654) 2020-05-23 07:57:31 +01:00
Dave Conway-Jones
18afc438da
bup version for npm to pick up error handling PR. 2020-05-20 14:07:26 +01:00
JsBergbau
d4d2404578
On error sending pushover message throw a catchable exception (#653)
* On error throw a catchable 

Throws an catchable exception if there is any error in sending the message. So you can react to it with a catch node

* Updated errorhandling

Updated the error handling process to be in compliance with the Node-RED Api
2020-05-20 14:04:42 +01:00
Dave Conway-Jones
05a9312905
fix gpio initial read timing and order 2020-05-09 16:51:22 +01:00
Dave Conway-Jones
c79bcfbd0e
bump serialport lib 2020-05-08 15:45:29 +01:00
Dave Conway-Jones
3caf92ffc3
fic link in pibrella readme
to close #652
2020-05-08 13:52:01 +01:00