Merge pull request #3728 from node-red/fix-credential-clear

Do not remove unknown credentials of Subflow Modules
This commit is contained in:
Nick O'Leary 2022-07-04 20:47:04 +01:00 committed by GitHub
commit 18acd67b4f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 6 deletions

View File

@ -390,7 +390,6 @@ class Subflow extends Flow {
}
name = newName;
}
var parent = this.parent;
if (parent) {

View File

@ -373,11 +373,13 @@ var api = module.exports = {
}
}
for (cred in savedCredentials) {
if (savedCredentials.hasOwnProperty(cred)) {
if (!newCreds.hasOwnProperty(cred)) {
delete savedCredentials[cred];
dirty = true;
if (/^subflow(:|$)/.test(nodeType)) {
for (cred in savedCredentials) {
if (savedCredentials.hasOwnProperty(cred)) {
if (!newCreds.hasOwnProperty(cred)) {
delete savedCredentials[cred];
dirty = true;
}
}
}
}