frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-03-01 10:36:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3869 from Steve-Mcl/fix-mqtt-birth-bad-topic-crash

Browse Source 
Prevent invalid mqtt birth topic crashing node-red
This commit is contained in:
Nick O'Leary
2022-09-12 19:17:43 +01:00
committed by GitHub
parent e6097e4968 fbde0091de
commit 5b7e84c1b0
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
packages/node_modules/@node-red/nodes/core/network/10-mqtt.js vendored
View File

@@ -997,14 +997,21 @@ module.exports = function(RED) {
}
if (topicOK) {
node.client.publish(msg.topic, msg.payload, options, function(err) {
done && done(err);
return
});
node.client.publish(msg.topic, msg.payload, options, function (err) {
if (done) {
done(err)
} else {
node.error(err, msg)
}
})
} else {
const error = new Error(RED._("mqtt.errors.invalid-topic"));
error.warn = true;
done(error);
const error = new Error(RED._("mqtt.errors.invalid-topic"))
error.warn = true
if (done) {
done(error)
} else {
node.warn(error, msg)
}
}
}
};