frodovdr
/
node-red
mirror of https://github.com/node-red/node-red.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #387 from hindessm/fix-scope-of-data 

Avoid wasting time preparing the payload if operation is a delete.
This commit is contained in:
Nick O'Leary 2014-09-08 20:19:54 +01:00
parent cba4791b65 22b32b1684
commit afa201790d
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
nodes/core/storage/50-file.js
View File

@ -29,14 +29,6 @@ module.exports = function(RED) {
if (filename === "") {
node.warn('No filename specified');
} else if (typeof msg.payload != "undefined") {
var data = msg.payload;
if (typeof data == "object") {
if (!Buffer.isBuffer(data)) {
data = JSON.stringify(data);
}
}
if (typeof data == "boolean") { data = data.toString(); }
if ((this.appendNewline)&&(!Buffer.isBuffer(data))) { data += "\n"; }
if (msg.hasOwnProperty('delete')) {
fs.unlink(filename, function (err) {
if (err) { node.warn('Failed to delete file : '+err); }
@ -44,6 +36,14 @@ module.exports = function(RED) {
});
}
else {
var data = msg.payload;
if (typeof data == "object") {
if (!Buffer.isBuffer(data)) {
data = JSON.stringify(data);
}
}
if (typeof data == "boolean") { data = data.toString(); }
if ((this.appendNewline)&&(!Buffer.isBuffer(data))) { data += "\n"; }
if (this.overwriteFile) {
fs.writeFile(filename, data, function (err) {
if (err) { node.warn('Failed to write to file : '+err); }