frodovdr
/
node-red
mirror of https://github.com/node-red/node-red.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge branch 'pr_2965' into dev

This commit is contained in:
Nick O'Leary 2021-04-29 11:04:50 +01:00
parent 1d4dd4be96 00caa13a12
commit caa98b08da
No known key found for this signature in database
GPG Key ID: 4F2157149161A6C9
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/node_modules/@node-red/registry/lib/externalModules.js vendored
View File

@ -194,7 +194,7 @@ async function installModule(moduleDetails) {
"module": moduleDetails.module,
"version": moduleDetails.version,
"dir": installDir,
"args": ["--production"]
"args": ["--production","--engine-strict"]
}
return hooks.trigger("preInstall", triggerPayload).then((result) => {
// preInstall passed

2
packages/node_modules/@node-red/registry/lib/installer.js vendored
View File

@ -175,7 +175,7 @@ async function installModule(module,version,url) {
"dir": installDir,
"isExisting": isExisting,
"isUpgrade": isUpgrade,
"args": ['--no-audit','--no-update-notifier','--no-fund','--save','--save-prefix=~','--production']
"args": ['--no-audit','--no-update-notifier','--no-fund','--save','--save-prefix=~','--production','--engine-strict']
}
return hooks.trigger("preInstall", triggerPayload).then((result) => {

7
test/unit/@node-red/registry/lib/externalModules_spec.js
View File

@ -48,13 +48,14 @@ describe("externalModules api", function() {
beforeEach(function() {
sinon.stub(exec,"run").callsFake(async function(cmd, args, options) {
let error;
if (args[2] === "moduleNotFound") {
let moduleName = args[args.length-1];
if (moduleName === "moduleNotFound") {
error = new Error();
error.stderr = "E404";
} else if (args[2] === "moduleVersionNotFound") {
} else if (moduleName === "moduleVersionNotFound") {
error = new Error();
error.stderr = "ETARGET";
} else if (args[2] === "moduleFail") {
} else if (moduleName === "moduleFail") {
error = new Error();
error.stderr = "Some unexpected install error";
}