1
0
mirror of https://github.com/node-red/node-red.git synced 2023-10-10 13:36:53 +02:00
Commit Graph

6280 Commits

Author SHA1 Message Date
Nick O'Leary
79aeeea640 Handle duplicate PUBREL
Fixes #138

If the connection to a broker is lost mid qos 2 flow, there is a window where we have processed the PUBREL, released the message and deleted it from our store, but not sent the PUBCOMP. When the connection is re-established, and the PUBREL is resent by the broker, we assume the message still exists - and hit the error reported.

The fix is to check the message is valid before trying to process it. We send the PUBCOMP to complete the flow regardless.
2014-01-13 11:32:16 +00:00
Nick O'Leary
6b3010f95b Guard against null client in MQTT nodes
Fixes #130

There was a timing window where a client could connect to a broker just as new flows were deployed that would cause the on-connect callback to be called after client has been set to null. This caused an NPE.

The fix is to check client isn't null in the event handler.
2014-01-13 11:27:09 +00:00
Dave C-J
10b7f402c3 Update MQTT node Icon color to be different from Twitter one
Fixes #132
2014-01-08 16:44:47 +00:00
Dave C-J
cbad188be8 Update to fs.watch node to use new fs.notify API
requires npm update fs.notify
2014-01-08 16:44:05 +00:00
Dave C-J
b652d26b6b Add invite event to irc node 2014-01-03 10:57:49 +00:00
Dave C-J
e5536b848a Changes to IRC node
addresses fix for #106
moved channel to node properties (won't break but will flag as undeployed changes)
changed defaults to be irc.freenode.net
allow input of a msg.raw as an array of a raw irc command (undocumented)
2014-01-02 11:15:03 +00:00
Nick O'Leary
5219d08cb8 Support drag/drop of flow json onto the canvas
Closes #43
2013-12-31 21:32:50 +00:00
Chris Swan
9839e87580 pintable + tablepin maps for all 17 WiringPi pins 2013-12-31 08:54:06 +00:00
Chris Swan
982ad91581 Drop down options for all 17 pins in WiringPi 2013-12-31 08:50:24 +00:00
Nick O'Leary
1c010c568d Fix keepalive handling in MQTT client
Fixes #124
2013-12-29 20:16:27 +00:00
Nick O'Leary
0046164689 Prevent nodes being dragged off canvas - top-left only
Fixes #120

Doesn't prevent dragging off the right/bottom sides, but that should be less likely to occur
2013-12-28 20:03:43 +00:00
Nick O'Leary
4e3594d617 Disable keyboard handler whilst workspace dialogs are open
Fixes #128
2013-12-28 17:59:45 +00:00
Nick O'Leary
24c373ecc2 Tidying up the Change node after a lot of churn 2013-12-24 23:16:36 +00:00
Nick O'Leary
74f43f4059 Merge pull request #127 from fvdpol/master
Add validation to the Change node 'from' field
2013-12-24 14:53:48 -08:00
Frank van de Pol
44e920fde2 Disable the notification for the Change node editor
Disable the notification on the Change node.
Once the infrastructure for validation error messages is implemented
this can be re-enabled and retrofitted to the
new structure.
2013-12-24 23:29:40 +01:00
Frank van de Pol
1ebc5979aa Add validation to Change node editor for invalid regex
This change adds input validation to the gui of Change Nodes to prevent
the user from unintentionally entering an invalid regular expression
(in case the ‘use regular expressions’  option is enabled).

The user will be notified (using the RED notification mechanism) on the
specific error code to help resolve the issue.
2013-12-24 20:28:08 +01:00
Frank van de Pol
b411d59d43 Make log message in invalid regular expressions more verbose
Make logging of erratic regular expressions more verbose to help
identification and resolving of the configuration issue:

eg.:
old: 24 Dec 18:40:09 - [error] [change:Strip kW] Invalid regex: *kW
new: 24 Dec 18:40:09 - [error] [change:Strip kW] Invalid regular
expression: /*kW/: Nothing to repeat

old: 24 Dec 20:15:57 - [error] [change:Strip kW] Invalid regex: *kW
new: 24 Dec 20:15:57 - [error] [change:Strip kW] Invalid regular
expression: /[kW/: Unterminated character class
2013-12-24 20:17:42 +01:00
Frank van de Pol
231f8b6a4d undo my changes to the Change node; revert to original
undo the local changes to the Change node to get back aligned with the
master tree
2013-12-24 20:02:30 +01:00
Frank van de Pol
b81f251023 merge from upstream 2013-12-24 18:53:38 +01:00
Dave C-J
00202a3930 wrong syntax for checking check box... in change node 2013-12-24 17:07:07 +00:00
Dave C-J
e0921f84c4 still flattening wrinkles in change node...
(I blame the Xmas "spirit" ;-)
2013-12-24 17:01:53 +00:00
Dave C-J
dafb2f1d38 Removed excess debugging from change node (sorry) 2013-12-24 16:54:19 +00:00
Dave C-J
6b2e666600 Make sure old flows with change node - work as-is/was.
Signed-off-by: Dave C-J <dave@conway-jones.co.uk>
2013-12-24 16:24:31 +00:00
Dave C-J
b7531bae4d Added proper choice for regex support to change node
(and better error catching)
Addresses Issue #121
2013-12-24 16:18:18 +00:00
Dave C-J
2ba5e0fe3e Add socketTimeout to settings.js for TCP server sockets
Fixes #125
adds an optional socketTimeout param to settings.js file to add a TCP server
socket timeout. Default is no timeout.
2013-12-24 13:12:17 +00:00
Nick O'Leary
a9668a1999 Better error message if twitter auth flow fails
Closes #123
2013-12-23 14:44:35 +00:00
Nick O'Leary
c6264e8040 Add newline when wrapping function to allow comments
Fixes #122
2013-12-22 22:22:47 +00:00
Frank van de Pol
a03b4e4dd4 Added validation logic to Change editor for validity of regular expressions
This change adds input validation to the gui of Change Nodes to prevent
the user from unintentionally entering an invalid regular expression.
The user will be notified on the specific error code to help resolve
the issue.
2013-12-22 17:46:25 +01:00
Frank van de Pol
655e777a3e Add exception handing to Change node
Adding exception handling to the change node to prevent node-RED from
crashing on invalid regular expressions eg. “*kW” (missing escape
before the asterix)
2013-12-22 14:00:25 +01:00
Nick O'Leary
5d43334b1c Bump version 0.5.0 2013-12-21 19:31:50 +00:00
Dave C-J
15669b7f1f Only declare node variables inside node declaration.
Fix for Issue #119
(also reformatted with spaces hence what looks like massive changes...)
2013-12-21 17:31:05 +00:00
Nick O'Leary
95b8600da7 Automatically follow 301-redirects in HTTP request node
Fixes #30
2013-12-20 11:11:50 +00:00
Nick O'Leary
48d37df199 Track node.changed state over undo
Part of #33
2013-12-19 21:34:25 +00:00
Nick O'Leary
73f3ea52a5 Add session awareness to TCP nodes
Closes #63,#65
2013-12-19 21:16:25 +00:00
Nick O'Leary
02df584af6 Allow storage module to be set explicitly
Rather than just by name
2013-12-19 11:05:03 +00:00
Nick O'Leary
751ac7b9ee Handle Buffer objects properly in Serial out node
Fixes #115
The serial out node does a JSON.stringify if the payload is an object. This was incorrectly being applied to Buffer objects, causing the output seen in issue #115.

The Buffer is now passed through as-is (with the newline appended if so configured).
2013-12-13 10:27:52 +00:00
Nick O'Leary
344660dfee Refinements to Unknown-node handling
Refinement to #113
2013-12-12 15:51:15 +00:00
Dave C-J
4fff3ce448 Make missing node type error popup non-permanent
Fixes Issue #113
2013-12-11 22:22:33 +00:00
Dave C-J
ac884bfdf3 Add "Unknown node" type to core.
Relates to Issue #5
not the best/complete solution - but a start.
2013-12-08 21:55:34 +00:00
Nicholas O'Leary
3984b6b702 Add websocket node docs
Part of #105
2013-12-08 20:41:57 +00:00
Nicholas O'Leary
cce5f33a97 Allow JSON sending/receiving in websocket node
Fixes #105
2013-12-08 20:31:56 +00:00
Nicholas O'Leary
f22cd381ee Add JSONP support to http response node
Fixes #102
2013-12-08 19:40:27 +00:00
Dave C-J
fae34f8244 Let serialport retry reconnects etc
Partial fix to Issue #111

This doesn't fix the screaming loop issue if you try to write to an unplugged
serial port - but does attempt to fix the not retrying to reconnect part of 
the issue.

Both were introduced by changes to the underlying serialport npm.
2013-12-08 16:59:36 +00:00
Dave C-J
67e16adfd0 Added output "New Line" char to Serial
Addresses Issue #104
adds the option to re-use the character used the split input into lineson input as an append to every line sent out to the serial port.
2013-12-06 21:04:35 +00:00
Nicholas O'Leary
d2ce6af486 Switch node: infer intent to compare numbers
Fixes #108
2013-12-06 20:26:55 +00:00
Nicholas O'Leary
4475e74187 Overlapping mqtt subs get duplicate messages 2013-12-06 14:19:21 +00:00
Nicholas O'Leary
ce7bf78349 Non-Cloning of req/res properties caused them to be lost
The previous fix to not clone the req/res objects introduced a bug where the req/res objects were lost from all but the first clone made out of a particular node.
2013-12-05 14:39:26 +00:00
Nicholas O'Leary
5767478871 Switch node null/not null tests don't always work
a === null / a !=== null

is different to

    typeof a == "undefined" / typeof a != "undefined"
2013-12-03 01:12:29 +00:00
Nick O'Leary
7eae669a34 Merge pull request #101 from hardillb/master
Fix typo in the delay node
2013-11-30 10:14:20 -08:00
Ben Hardill
f44272877e Merge remote-tracking branch 'upstream/master' 2013-11-30 18:10:03 +00:00