correct declaration of env object/dic/lookup

ensure object before attempting to call function
Merge pull request #4156 from node-red/4133-mqtt-v5-disconnects-when-subscribing-to-aws-core-broker
2025-03-01 10:36:34 +00:00 · 2023-06-09 11:30:21 +01:00 · 2023-06-09 11:29:54 +01:00 · 2023-05-22 16:42:25 +01:00
2 changed files with 2 additions and 2 deletions
--- a/packages/node_modules/@node-red/runtime/lib/flows/Flow.js
+++ b/packages/node_modules/@node-red/runtime/lib/flows/Flow.js
@@ -808,7 +808,7 @@ function handlePreRoute(flow, sendEvent, reportError) {
            return;
        } else if (err !== false) {
            sendEvent.destination.node = flow.getNode(sendEvent.destination.id);
-            if (sendEvent.destination.node) {
+            if (sendEvent.destination.node && typeof sendEvent.destination.node === 'object') {
                if (sendEvent.cloneMessage) {
                    sendEvent.msg = redUtil.cloneMessage(sendEvent.msg);
                }
--- a/packages/node_modules/@node-red/runtime/lib/flows/Subflow.js
+++ b/packages/node_modules/@node-red/runtime/lib/flows/Subflow.js
@@ -119,7 +119,7 @@ class Subflow extends Flow {
        this.templateCredentials = credentials.get(subflowDef.id) || {};
        this.instanceCredentials = credentials.get(id) || {};

-        var env = [];
+        var env = {}; 
        if (this.subflowDef.env) {
            this.subflowDef.env.forEach(e => {
                env[e.name] = e;
Author	SHA1	Message	Date
Steve-Mcl	1cbd910e5d	correct declaration of env object/dic/lookup	2023-06-09 11:30:21 +01:00
Steve-Mcl	b102ef512e	ensure object before attempting to call function	2023-06-09 11:29:54 +01:00
Nick O'Leary	5d698d66d0	Merge pull request #4156 from node-red/4133-mqtt-v5-disconnects-when-subscribing-to-aws-core-broker Dont use `subscriptionIdentifier` if broker doesnt support it	2023-05-22 16:42:25 +01:00