Ensure subflow instance node has g property set

Update index.mst

packages/node_modules/@node-red/editor-client/locales/en-US/editor.json

@@ -1222,6 +1222,7 @@
             "invalid-expr": "Invalid JSONata expression: __error__",
             "invalid-prop": "Invalid property expression",
             "invalid-num": "Invalid number",
+            "invalid-num-prop": "__prop__: invalid number",
             "invalid-regexp": "Invalid input pattern",
             "invalid-regex-prop": "__prop__: invalid input pattern",
             "missing-required-prop": "__prop__: property value missing",

packages/node_modules/@node-red/editor-client/locales/fr/editor.json

@@ -1217,6 +1217,7 @@
       "invalid-expr": "Expression JSONata invalide : __error__",
       "invalid-prop": "Expression de propriété invalide",
       "invalid-num": "Numéro invalide",
+      "invalid-num-prop": "__prop__: numéro invalide",
       "invalid-regexp": "Modèle d'entrée non valide",
       "invalid-regex-prop": "__prop__: modèle d'entrée non valide",
       "missing-required-prop": "__prop__: valeur de la propriété manquante",

packages/node_modules/@node-red/editor-client/locales/ja/editor.json

@@ -129,6 +129,11 @@
             "editPalette": "パレットの管理",
             "other": "その他",
             "showTips": "ヒントを表示",
+            "showNodeHelp": "ノードのヘルプを表示",
+            "enableSelectedNodes": "選択したノードを有効化",
+            "disableSelectedNodes": "選択したノードを無効化",
+            "showSelectedNodeLabels": "選択したノードのラベル表示",
+            "hideSelectedNodeLabels": "選択したノードのラベル非表示",
             "showWelcomeTours": "新バージョンのガイドツアーを表示",
             "help": "Node-REDウェブサイト",
             "projects": "プロジェクト",
@@ -510,7 +515,7 @@
         "selectAllConnected": "接続されたノードを選択",
         "addRemoveNode": "ノードの選択、選択解除",
         "editSelected": "選択したノードを編集",
-        "deleteSelected": "選択したノードや接続を削除",
+        "deleteSelected": "選択部分を削除",
         "deleteReconnect": "削除と再接続",
         "importNode": "フローの読み込み",
         "exportNode": "フローの書き出し",
@@ -1214,8 +1219,10 @@
     "validator": {
         "errors": {
             "invalid-json": "JSONデータが不正: __error__",
+            "invalid-expr": "不正なJSONata式: __error__",
             "invalid-prop": "プロパティ式が不正",
             "invalid-num": "数値が不正",
+            "invalid-num-prop": "__prop__: 数値が不正",
             "invalid-regexp": "入力パターンが不正",
             "invalid-regex-prop": "__prop__: 入力パターンが不正",
             "missing-required-prop": "__prop__: プロパティが未設定",
@@ -1225,6 +1232,7 @@
         }
     },
     "contextMenu": {
+        "showActionList": "動作一覧を表示",
         "insert": "挿入",
         "node": "ノード",
         "junction": "分岐点",

packages/node_modules/@node-red/editor-client/locales/pt-BR/editor.json

@@ -1187,6 +1187,7 @@
             "invalid-json": "Dados JSON inválidos: __error__",
             "invalid-prop": "Expressão de propriedade inválida",
             "invalid-num": "Número inválido",
+            "invalid-num-prop": "__prop__: número inválido",
             "invalid-regexp": "Padrão de entrada inválido",
             "invalid-regex-prop": "__prop__: Padrão de entrada inválido",
             "missing-required-prop": "__prop__: valor de propriedade ausente",

packages/node_modules/@node-red/editor-client/locales/zh-CN/editor.json

@@ -1220,6 +1220,7 @@
       "invalid-expr": "无效的 JSONata 表达式: __error__",
       "invalid-prop": "无效的属性表达式",
       "invalid-num": "无效的数字",
+      "invalid-num-prop": "__prop__: 无效的数字",
       "invalid-regexp": "输入格式无效",
       "invalid-regex-prop": "__prop__: 输入格式无效",
       "missing-required-prop": "__prop__: 缺少属性值",

packages/node_modules/@node-red/editor-client/src/js/ui/contextMenu.js

@@ -30,8 +30,26 @@ RED.contextMenu = (function () {
             const isGroup = hasSelection && selection.nodes.length === 1 && selection.nodes[0].type === 'group'
             const canEdit = !RED.workspaces.isLocked()
             const canRemoveFromGroup = hasSelection && !!selection.nodes[0].g
-            const isAllGroups = hasSelection && selection.nodes.filter(n => n.type !== 'group').length === 0
-            const hasGroup = hasSelection && selection.nodes.filter(n => n.type === 'group' ).length > 0
+            let hasGroup, isAllGroups = true, hasDisabledNode, hasEnabledNode, hasLabeledNode, hasUnlabeledNode;
+            if (hasSelection) {
+                selection.nodes.forEach(n => {
+                    if (n.type === 'group') {
+                        hasGroup = true;
+                    } else {
+                        isAllGroups = false;
+                    }
+                    if (n.d) {
+                        hasDisabledNode = true;
+                    } else {
+                        hasEnabledNode = true;
+                    }
+                    if (n.l === undefined || n.l) {
+                        hasLabeledNode = true;
+                    } else {
+                        hasUnlabeledNode = true;
+                    }
+                });
+            }
             const offset = $("#red-ui-workspace-chart").offset()
 
             let addX = options.x - offset.left + $("#red-ui-workspace-chart").scrollLeft()
@@ -55,7 +73,7 @@ RED.contextMenu = (function () {
                     onselect: function () {
                         RED.view.showQuickAddDialog({
                             position: [addX, addY],
-                            touchTrigger: true,
+                            touchTrigger: 'ontouchstart' in window,
                             splice: isSingleLink ? selection.links[0] : undefined,
                             // spliceMultiple: isMultipleLinks
                         })
@@ -113,11 +131,11 @@ RED.contextMenu = (function () {
                     )
                 }
                 nodeOptions.push(
-                    { onselect: 'core:enable-selected-nodes', label: RED._('menu.label.enableSelectedNodes') },
-                    { onselect: 'core:disable-selected-nodes', label: RED._('menu.label.disableSelectedNodes') },
+                    { onselect: 'core:enable-selected-nodes', label: RED._('menu.label.enableSelectedNodes'), disabled: !hasDisabledNode },
+                    { onselect: 'core:disable-selected-nodes', label: RED._('menu.label.disableSelectedNodes'), disabled: !hasEnabledNode },
                     null,
-                    { onselect: 'core:show-selected-node-labels', label: RED._('menu.label.showSelectedNodeLabels') },
-                    { onselect: 'core:hide-selected-node-labels', label: RED._('menu.label.hideSelectedNodeLabels') }
+                    { onselect: 'core:show-selected-node-labels', label: RED._('menu.label.showSelectedNodeLabels'), disabled: !hasUnlabeledNode },
+                    { onselect: 'core:hide-selected-node-labels', label: RED._('menu.label.hideSelectedNodeLabels'), disabled: !hasLabeledNode }
                 )
                 menuItems.push({
                     label: RED._('sidebar.info.node'),

packages/node_modules/@node-red/editor-client/src/js/ui/editor.js

@@ -1231,7 +1231,11 @@ RED.editor = (function() {
                 })
 
                 if (node_def.hasUsers !== false) {
-                    $('<span><i class="fa fa-info-circle"></i> <span id="red-ui-editor-config-user-count"></span></span>').css("margin-left", "10px").appendTo(trayFooterLeft);
+                    // $('<span><i class="fa fa-info-circle"></i> <span id="red-ui-editor-config-user-count"></span></span>').css("margin-left", "10px").appendTo(trayFooterLeft);
+                    $('<button type="button" class="red-ui-button"><i class="fa fa-user"></i><span id="red-ui-editor-config-user-count"></span></button>').on('click', function() {
+                        RED.sidebar.info.outliner.search('uses:'+editing_config_node.id)
+                        RED.sidebar.info.show()
+                    }).appendTo(trayFooterLeft);
                 }
                 trayFooter.append('<span class="red-ui-tray-footer-right"><span id="red-ui-editor-config-scope-warning" data-i18n="[title]editor.errors.scopeChange"><i class="fa fa-warning"></i></span><select id="red-ui-editor-config-scope"></select></span>');
 
@@ -1289,7 +1293,8 @@ RED.editor = (function() {
                         });
                     }
                     if (node_def.hasUsers !== false) {
-                        $("#red-ui-editor-config-user-count").text(RED._("editor.nodesUse", {count:editing_config_node.users.length})).parent().show();
+                        $("#red-ui-editor-config-user-count").text(editing_config_node.users.length).parent().show();
+                        RED.popover.tooltip($("#red-ui-editor-config-user-count").parent(), function() { return RED._('editor.nodesUse',{count:editing_config_node.users.length})});
                     }
                     trayBody.i18n();
                     trayFooter.i18n();

packages/node_modules/@node-red/editor-client/src/js/ui/env-var.js

@@ -71,7 +71,7 @@ RED.envVar = (function() {
                 };
                 if (item.name.trim() !== "") {
                     new_env.push(item);
-                    if ((item.type === "cred") && (item.value !== "__PWRD__")) {
+                    if (item.type === "cred") {
                         credentials.map[item.name] = item.value;
                         credentials.map["has_"+item.name] = (item.value !== "");
                         item.value = "__PWRD__";

packages/node_modules/@node-red/editor-client/src/js/ui/tab-config.js

@@ -158,6 +158,7 @@ RED.sidebar.config = (function() {
                 entry.data('node',node.id);
                 nodeDiv.data('node',node.id);
                 var label = $('<div class="red-ui-palette-label"></div>').text(labelText).appendTo(nodeDiv);
+
                 if (node.d) {
                     nodeDiv.addClass("red-ui-palette-node-config-disabled");
                     $('<i class="fa fa-ban"></i>').prependTo(label);
@@ -179,6 +180,20 @@ RED.sidebar.config = (function() {
                         nodeDiv.addClass("red-ui-palette-node-config-unused");
                     }
                 }
+
+                if (!node.valid) {
+                    nodeDiv.addClass("red-ui-palette-node-config-invalid")
+                    const nodeDivAnnotations = $('<svg class="red-ui-palette-node-annotations red-ui-flow-node-error" width="10" height="10"></svg>').appendTo(nodeDiv)
+                    const errorBadge = document.createElementNS("http://www.w3.org/2000/svg","path");
+                    errorBadge.setAttribute("d","M 0,9 l 10,0 -5,-8 z");
+                    nodeDivAnnotations.append($(errorBadge))
+                    RED.popover.tooltip(nodeDivAnnotations, function () {
+                        if (node.validationErrors && node.validationErrors.length > 0) {
+                            return RED._("editor.errors.invalidProperties")+"<br>  - "+node.validationErrors.join("<br>  - ")
+                        }
+                    })
+                }
+
                 nodeDiv.on('click',function(e) {
                     e.stopPropagation();
                     RED.view.select(false);

packages/node_modules/@node-red/editor-client/src/js/ui/tab-context.js

@@ -232,7 +232,7 @@ RED.sidebar.context = (function() {
                                     typeHint: data.format,
                                     sourceId: id+"."+k,
                                     tools: tools,
-                                    path: ""
+                                    path: k
                                 }).appendTo(propRow.children()[1]);
                             }
                         })
@@ -278,7 +278,7 @@ RED.sidebar.context = (function() {
                                                     typeHint: data.format,
                                                     sourceId: id+"."+k,
                                                     tools: tools,
-                                                    path: ""
+                                                    path: k
                                                 }).appendTo(propRow.children()[1]);
                                             }
                                         });
@@ -299,7 +299,7 @@ RED.sidebar.context = (function() {
                         typeHint: v.format,
                         sourceId: id+"."+k,
                         tools: tools,
-                        path: ""
+                        path: k
                     }).appendTo(propRow.children()[1]);
                     if (contextStores.length > 1) {
                         $("<span>",{class:"red-ui-sidebar-context-property-storename"}).text(v.store).appendTo($(propRow.children()[0]))

packages/node_modules/@node-red/editor-client/src/js/ui/typeSearch.js

@@ -186,8 +186,15 @@ RED.typeSearch = (function() {
                 var iconContainer = $('<div/>',{class:"red-ui-palette-icon-container"}).appendTo(nodeDiv);
                 RED.utils.createIconElement(icon_url, iconContainer, false);
 
-
-                if (!/^_action_:/.test(object.type) && object.type !== "junction") {
+                if (/^subflow:/.test(object.type)) {
+                    var sf = RED.nodes.subflow(object.type.substring(8));
+                    if (sf.in.length > 0) {
+                        $('<div/>',{class:"red-ui-search-result-node-port"}).appendTo(nodeDiv);
+                    }
+                    if (sf.out.length > 0) {
+                        $('<div/>',{class:"red-ui-search-result-node-port red-ui-search-result-node-output"}).appendTo(nodeDiv);
+                    }
+                } else if (!/^_action_:/.test(object.type) && object.type !== "junction") {
                     if (def.inputs > 0) {
                         $('<div/>',{class:"red-ui-search-result-node-port"}).appendTo(nodeDiv);
                     }

packages/node_modules/@node-red/editor-client/src/js/ui/view.js

@@ -4155,10 +4155,15 @@ RED.view = (function() {
                         scaleFactor = 30/largestEdge;
                     }
                     var width = img.width * scaleFactor;
+                    if (width > 20) {
+                        scalefactor *= 20/width;
+                        width = 20;
+                    }
                     var height = img.height * scaleFactor;
                     icon.attr("width",width);
                     icon.attr("height",height);
                     icon.attr("x",15-width/2);
+                    icon.attr("y",(30-height)/2);
                 }
                 icon.attr("xlink:href",iconUrl);
                 icon.style("display",null);

packages/node_modules/@node-red/editor-client/src/sass/tab-config.scss

@@ -36,7 +36,7 @@ ul.red-ui-sidebar-node-config-list {
         text-align: center;
     }
     .red-ui-palette-node {
-        overflow: hidden;
+        // overflow: hidden;
         cursor: default;
         &.selected {
             border-color: transparent;
@@ -113,6 +113,15 @@ ul.red-ui-sidebar-node-config-list li.red-ui-palette-node-config-type {
         margin-right: 5px;
     }
 }
+.red-ui-palette-node-config-invalid {
+    border-color: var(--red-ui-form-input-border-error-color)
+}
+.red-ui-palette-node-annotations {
+    position: absolute;
+    left: calc(100% - 15px);
+    top: -8px;
+    display: block;
+}
 .red-ui-sidebar-node-config-filter-info {
     position: absolute;
     top: 0;

packages/node_modules/@node-red/editor-client/templates/index.mst

@@ -22,8 +22,8 @@
   limitations under the License.
 -->
 <title>{{ page.title }}</title>
-<link rel="icon" type="image/png" href="{{ page.favicon }}">
-<link rel="mask-icon" href="{{ page.tabicon.icon }}" color="{{ page.tabicon.colour }}">
+<link rel="icon" type="image/png" href="{{{ page.favicon }}}">
+<link rel="mask-icon" href="{{{ page.tabicon.icon }}}" color="{{ page.tabicon.colour }}">
 <link rel="stylesheet" href="vendor/jquery/css/base/jquery-ui.min.css?v={{ cacheBuster }}">
 <link rel="stylesheet" href="vendor/font-awesome/css/font-awesome.min.css?v={{ cacheBuster }}">
 <link rel="stylesheet" href="red/style.min.css?v={{ cacheBuster }}">
@@ -38,10 +38,10 @@
 <div id="red-ui-editor"></div>
 <script src="vendor/vendor.js?v={{ cacheBuster }}"></script>
 {{#asset.vendorMonaco}}
-<script src="{{ asset.vendorMonaco }}?v={{ cacheBuster }}"></script>
+<script src="{{{ asset.vendorMonaco }}}?v={{ cacheBuster }}"></script>
 {{/asset.vendorMonaco}}
-<script src="{{ asset.red }}?v={{ cacheBuster }}"></script>
-<script src="{{ asset.main }}?v={{ cacheBuster }}"></script>
+<script src="{{{ asset.red }}}?v={{ cacheBuster }}"></script>
+<script src="{{{ asset.main }}}?v={{ cacheBuster }}"></script>
 {{# page.scripts }}
 <script src="{{.}}"></script>
 {{/ page.scripts }}

packages/node_modules/@node-red/nodes/core/network/21-httprequest.js

@@ -141,15 +141,7 @@ in your Node-RED user directory (${RED.settings.userDir}).
                 });
             }
         }
-        /**
-         * @param {Object} headersObject
-         * @param {string} name
-         * @return {any} value
-        */
-        const getHeaderValue = (headersObject, name) => {
-            const asLowercase = name.toLowercase();
-            return headersObject[Object.keys(headersObject).find(k => k.toLowerCase() === asLowercase)];
-        }
+
         this.on("input",function(msg,nodeSend,nodeDone) {
             checkNodeAgentPatch();
             //reset redirectList on each request
@@ -300,7 +292,7 @@ in your Node-RED user directory (${RED.settings.userDir}).
             }
 
             opts.headers = {};
-            //add msg.headers 
+            //add msg.headers
             //NOTE: ui headers will take precidence over msg.headers
             if (msg.headers) {
                 if (msg.headers.hasOwnProperty('x-node-red-request-node')) {
@@ -633,7 +625,7 @@ in your Node-RED user directory (${RED.settings.userDir}).
                     msg.payload = msg.payload.toString('utf8'); // txt
 
                     if (node.ret === "obj") {
-                        if (msg.statusCode == 204){msg.payload= "{}"}; 
+                        if (msg.statusCode == 204){msg.payload= "{}"};
                         try { msg.payload = JSON.parse(msg.payload); } // obj
                         catch(e) { node.warn(RED._("httpin.errors.json-error")); }
                     }
@@ -740,7 +732,7 @@ in your Node-RED user directory (${RED.settings.userDir}).
         *
         * If the algorithm directive's value ends with "-sess", then HA1 is
         *   HA1=digestCompute(digestCompute(username:realm:password):nonce:cnonce)
-        * 
+        *
         * If the algorithm directive's value does not end with "-sess", then HA1 is
         *   HA1=digestCompute(username:realm:password)
         */

packages/node_modules/@node-red/runtime/lib/flows/Flow.js

@@ -485,7 +485,7 @@ class Flow {
         }
         if (!key.startsWith("$parent.")) {
             if (this._env.hasOwnProperty(key)) {
-                return this._env[key]
+                return (Object.hasOwn(this._env[key], 'value') && this._env[key].__clone__) ? clone(this._env[key].value) : this._env[key]
             }
         } else {
                 key = key.substring(8);

packages/node_modules/@node-red/runtime/lib/flows/Group.js

@@ -41,7 +41,7 @@ class Group {
         }
         if (!key.startsWith("$parent.")) {
             if (this._env.hasOwnProperty(key)) {
-                return this._env[key]
+                return (Object.hasOwn(this._env[key], 'value') && this._env[key].__clone__) ? clone(this._env[key].value) : this._env[key]
             }
         } else {
             key = key.substring(8);

packages/node_modules/@node-red/runtime/lib/flows/Subflow.js

@@ -212,6 +212,7 @@ class Subflow extends Flow {
         var subflowInstanceConfig = {
             id: this.subflowInstance.id,
             type: this.subflowInstance.type,
+            g: this.subflowInstance.g,
             z: this.subflowInstance.z,
             name: this.subflowInstance.name,
             wires: [],
@@ -375,7 +376,7 @@ class Subflow extends Flow {
         }
         if (!key.startsWith("$parent.")) {
             if (this._env.hasOwnProperty(key)) {
-                return this._env[key]
+                return (Object.hasOwn(this._env[key], 'value') && this._env[key].__clone__) ? clone(this._env[key].value) : this._env[key]
             }
         } else {
             key = key.substring(8);

packages/node_modules/@node-red/runtime/lib/flows/util.js

@@ -102,6 +102,9 @@ async function evaluateEnvProperties(flow, env, credentials) {
             pendingEvaluations.push(new Promise((resolve, _) => {
                 redUtil.evaluateNodeProperty(value, 'jsonata', {_flow: flow}, null, (err, result) => {
                     if (!err) {
+                        if (typeof result  === 'object') {
+                            result = { value: result, __clone__: true}
+                        }
                         evaluatedEnv[name] = result
                     }
                     resolve()
@@ -109,6 +112,9 @@ async function evaluateEnvProperties(flow, env, credentials) {
             }))
         } else {
             value = redUtil.evaluateNodeProperty(value, type, {_flow: flow}, null, null);
+            if (typeof value  === 'object') {
+                value = { value: value, __clone__: true}
+            }
         }
         evaluatedEnv[name] = value
     }
@@ -138,8 +144,13 @@ async function evaluateEnvProperties(flow, env, credentials) {
                 }
             }}, null, null);
         }
+        if (typeof value  === 'object' && !value.__clone__) {
+            value = { value: value, __clone__: true}
+        }
         evaluatedEnv[name] = value
+
     }
+    // console.log(evaluatedEnv)
 
     return evaluatedEnv
 }

packages/node_modules/@node-red/runtime/lib/nodes/credentials.js

@@ -384,10 +384,27 @@ var api = module.exports = {
                     }
                 }
             } else if (nodeType === "global-config") {
-                if (JSON.stringify(savedCredentials.map) !== JSON.stringify(newCreds.map)) {
-                    savedCredentials.map = newCreds.map;
-                    dirty = true;
-                }
+                const existingCredentialKeys = Object.keys(savedCredentials?.map || [])
+                const newCredentialKeys = Object.keys(newCreds?.map || [])
+                existingCredentialKeys.forEach(key => {
+                    if (!newCreds.map?.[key]) {
+                        // This key doesn't exist in the new credentials list - remove
+                        delete savedCredentials.map[key]
+                        delete savedCredentials.map[`has_${key}`]
+                        dirty = true
+                    }
+                })
+                newCredentialKeys.forEach(key => {
+                    if (!/^has_/.test(key)) {
+                        if (!savedCredentials.map?.[key] || newCreds.map[key] !== '__PWRD__') {
+                            // This key either doesn't exist in current saved, or the
+                            // value has been changed
+                            savedCredentials.map[key] = newCreds.map[key]
+                            savedCredentials.map[`has_${key}`] = newCreds.map[`has_${key}`]
+                            dirty = true
+                        }
+                    }
+                })
             } else {
                 var dashedType = nodeType.replace(/\s+/g, '-');
                 var definition = credentialsDef[dashedType];