Modify node users info in config editor footer

Fixes #4497

packages/node_modules/@node-red/editor-client/src/js/ui/editor.js

@@ -1231,7 +1231,11 @@ RED.editor = (function() {
                 })
 
                 if (node_def.hasUsers !== false) {
-                    $('<span><i class="fa fa-info-circle"></i> <span id="red-ui-editor-config-user-count"></span></span>').css("margin-left", "10px").appendTo(trayFooterLeft);
+                    // $('<span><i class="fa fa-info-circle"></i> <span id="red-ui-editor-config-user-count"></span></span>').css("margin-left", "10px").appendTo(trayFooterLeft);
+                    $('<button type="button" class="red-ui-button"><i class="fa fa-user"></i><span id="red-ui-editor-config-user-count"></span></button>').on('click', function() {
+                        RED.sidebar.info.outliner.search('uses:'+editing_config_node.id)
+                        RED.sidebar.info.show()
+                    }).appendTo(trayFooterLeft);
                 }
                 trayFooter.append('<span class="red-ui-tray-footer-right"><span id="red-ui-editor-config-scope-warning" data-i18n="[title]editor.errors.scopeChange"><i class="fa fa-warning"></i></span><select id="red-ui-editor-config-scope"></select></span>');
 
@@ -1289,7 +1293,8 @@ RED.editor = (function() {
                         });
                     }
                     if (node_def.hasUsers !== false) {
-                        $("#red-ui-editor-config-user-count").text(RED._("editor.nodesUse", {count:editing_config_node.users.length})).parent().show();
+                        $("#red-ui-editor-config-user-count").text(editing_config_node.users.length).parent().show();
+                        RED.popover.tooltip($("#red-ui-editor-config-user-count").parent(), function() { return RED._('editor.nodesUse',{count:editing_config_node.users.length})});
                     }
                     trayBody.i18n();
                     trayFooter.i18n();

packages/node_modules/@node-red/editor-client/src/js/ui/env-var.js

@@ -71,7 +71,7 @@ RED.envVar = (function() {
                 };
                 if (item.name.trim() !== "") {
                     new_env.push(item);
-                    if (item.type === "cred") {
+                    if ((item.type === "cred") && (item.value !== "__PWRD__")) {
                         credentials.map[item.name] = item.value;
                         credentials.map["has_"+item.name] = (item.value !== "");
                         item.value = "__PWRD__";

packages/node_modules/@node-red/runtime/lib/nodes/credentials.js

@@ -384,27 +384,10 @@ var api = module.exports = {
                     }
                 }
             } else if (nodeType === "global-config") {
-                const existingCredentialKeys = Object.keys(savedCredentials?.map || [])
-                const newCredentialKeys = Object.keys(newCreds?.map || [])
-                existingCredentialKeys.forEach(key => {
-                    if (!newCreds.map?.[key]) {
-                        // This key doesn't exist in the new credentials list - remove
-                        delete savedCredentials.map[key]
-                        delete savedCredentials.map[`has_${key}`]
-                        dirty = true
-                    }
-                })
-                newCredentialKeys.forEach(key => {
-                    if (!/^has_/.test(key)) {
-                        if (!savedCredentials.map?.[key] || newCreds.map[key] !== '__PWRD__') {
-                            // This key either doesn't exist in current saved, or the
-                            // value has been changed
-                            savedCredentials.map[key] = newCreds.map[key]
-                            savedCredentials.map[`has_${key}`] = newCreds.map[`has_${key}`]
-                            dirty = true
-                        }
-                    }
-                })
+                if (JSON.stringify(savedCredentials.map) !== JSON.stringify(newCreds.map)) {
+                    savedCredentials.map = newCreds.map;
+                    dirty = true;
+                }
             } else {
                 var dashedType = nodeType.replace(/\s+/g, '-');
                 var definition = credentialsDef[dashedType];