Remove sentiment from core

(moved to node-red-nodes)

CHANGELOG.md

@@ -1,84 +1,3 @@
-#### 0.19.2: Maintenance Release
-
- - Ensure node default colour is used if palette.theme has no match
- - fix lost messages / properties in TCPRequest Node; closes #1863 (#1864)
- - Fix typo in template.html
- - Improve error reporting from context plugin loading
- - Prevent no-op edit of node marking as changed due to icon
- - Change node must handle empty rule set
-
-#### 0.19.1: Maintenance Release
-
- - Pull in latest twitter node
- - Handle windows paths for context storage
- - Handle persisting objects with circular refs in context
- - Ensure js editor can expand to fill available space
- - Add example localfilesystem contextStorage to settings
- - Fix template node handling of nested context tags
-
-#### 0.19: Milestone Release
-
-Editor
-
- - Add editorTheme.palette.theme to allow overriding colours
- - Index all node properties when searching Fixes #1446
- - Handle NaN and Infinity properly in debug sidebar Fixes #1778 #1779
- - Prevent horizontal scroll when palette name cannot wrap
- - Ignore middle-click on node/ports to enable panning
- - Better wire layout when looping back
- - fix appearence of retry button of remote branch management dialog
- - Handle releasing ctrl when using quick-add node dialog
- - Add $env function to JSONata expressions
- - Widen support for env var to use ${} or $() syntax
- - Add env-var support to TypedInput
- - Show unknown node properties in info tab
- - Add node icon picker widget
- - Only edit nodes on dbl click on primary button with no modifiers
- - Allow subflows to be put in any palette category
- - Add flow navigator widget
- - Cache flow library result to improve response time Fixes #1753
- - Add middle-button-drag to pan the workspace
- - allow multi-line category name in editor
- - Redesign sidebar tabs
- - Do not disable the export-clipboard menu option with empty selection
-
-Nodes
-
- - Change: Ensure runtime errors in Change node can be caught Fixes #1769
- - File: Add output to File Out node
- - Function: add expandable JavaScript editor pane
- - Function: allow id and name reference in function node code (#1731)
- - HTTP Request: Move to request module
- - HTTP: Ensure apiMaxLength applies to HTTP Nodes Fixes #1278
- - Join: accumulate top level properties
- - Join: allow environment variable as reduce init value
- - JSON: add JSON schema validation via msg.schema
- - Pi: Let nrgpio code work with python 3
- - Pi: let Pi nodes be visible/editable on all platforms
- - Switch: add isEmpty rule
- - TCP: queue messages while connecting; closes #1414
- - TLS: Add servername option to TLS config node for SNI Fixes #1805
- - UDP: Don't accidentally re-use udp port when set to not do so
-
-Persistent Context
-
- - Add Context data sidebar
- - Add persistable context option
- - Add default memory store
- - Add file-based context store
- - Add async mode to evaluateJSONataExpression
- - Update RED.util.evaluateNodeProperty to support context stores
-
-Runtime
-
- - Support flow.disabled and .info in /flow API
- - Node errors should be Strings not Errors Fixes #1781
- - Add detection of connection timeout in git communication Fixes #1770
- - Handle loading empty nodesDir
- - Add 'private' property to userDir generated package.json
- - Add RED.require to allow nodes to access other modules
- - Ensure add/remove modules are run sequentially
-
 #### 0.18.7: Maintenance Release
 
 Editor Fixes

Gruntfile.js

@@ -24,10 +24,6 @@ module.exports = function(grunt) {
         nodemonArgs.push(flowFile);
     }
 
-    var nonHeadless = grunt.option('non-headless');
-    if (nonHeadless) {
-        process.env.NODE_RED_NON_HEADLESS = 'true';
-    }
     grunt.initConfig({
         pkg: grunt.file.readJSON('package.json'),
         paths: {
@@ -153,10 +149,8 @@ module.exports = function(grunt) {
                     "editor/js/ui/palette.js",
                     "editor/js/ui/tab-info.js",
                     "editor/js/ui/tab-config.js",
-                    "editor/js/ui/tab-context.js",
                     "editor/js/ui/palette-editor.js",
                     "editor/js/ui/editor.js",
-                    "editor/js/ui/editors/*.js",
                     "editor/js/ui/tray.js",
                     "editor/js/ui/clipboard.js",
                     "editor/js/ui/library.js",

editor/js/keymap.json

@@ -10,7 +10,6 @@
         "ctrl-g i": "core:show-info-tab",
         "ctrl-g d": "core:show-debug-tab",
         "ctrl-g c": "core:show-config-tab",
-        "ctrl-g x": "core:show-context-tab",
         "ctrl-e": "core:show-export-dialog",
         "ctrl-i": "core:show-import-dialog",
         "ctrl-space": "core:toggle-sidebar",

editor/js/ui/clipboard.js

@@ -276,20 +276,9 @@ RED.clipboard = (function() {
         if (typeof value !== "string" ) {
             value = JSON.stringify(value, function(key,value) {
                 if (value !== null && typeof value === 'object') {
-                    if (value.__enc__) {
-                        if (value.hasOwnProperty('data') && value.hasOwnProperty('length')) {
-                            truncated = value.data.length !== value.length;
-                            return value.data;
-                        }
-                        if (value.type === 'function' || value.type === 'internal') {
-                            return undefined
-                        }
-                        if (value.type === 'number') {
-                            // Handle NaN and Infinity - they are not permitted
-                            // in JSON. We can either substitute with a String
-                            // representation or null
-                            return null;
-                        }
+                    if (value.__encoded__ && value.hasOwnProperty('data') && value.hasOwnProperty('length')) {
+                        truncated = value.data.length !== value.length;
+                        return value.data;
                     }
                 }
                 return value;

editor/js/ui/common/popover.js

@@ -48,31 +48,23 @@ RED.popover = (function() {
 
         var openPopup = function(instant) {
             if (active) {
-                div = $('<div class="red-ui-popover red-ui-popover-'+direction+'"></div>');
+                div = $('<div class="red-ui-popover red-ui-popover-'+direction+'"></div>').appendTo("body");
                 if (size !== "default") {
                     div.addClass("red-ui-popover-size-"+size);
                 }
                 if (typeof content === 'function') {
-                    var result = content.call(res);
-                    if (result === null) {
-                        return;
-                    }
-                    if (typeof result === 'string') {
-                        div.text(result);
-                    } else {
-                        div.append(result);
-                    }
+                    content.call(res).appendTo(div);
                 } else {
                     div.html(content);
                 }
                 if (width !== "auto") {
                     div.width(width);
                 }
-                div.appendTo("body");
+
 
                 var targetPos = target.offset();
-                var targetWidth = target.outerWidth();
-                var targetHeight = target.outerHeight();
+                var targetWidth = target.width();
+                var targetHeight = target.height();
                 var divHeight = div.height();
                 var divWidth = div.width();
                 if (direction === 'right') {
@@ -155,17 +147,7 @@ RED.popover = (function() {
     }
 
     return {
-        create: createPopover,
-        tooltip: function(target,content) {
-            RED.popover.create({
-                target:target,
-                trigger: "hover",
-                size: "small",
-                direction: "bottom",
-                content: content,
-                delay: { show: 550, hide: 10 }
-            });
-        }
+        create: createPopover
     }
 
 })();

editor/js/ui/common/tabs.js

@@ -17,9 +17,6 @@
 
 
 RED.tabs = (function() {
-
-    var defaultTabIcon = "fa fa-lemon-o";
-
     function createTabs(options) {
         var tabs = {};
         var pinnedTabsCount = 0;
@@ -74,7 +71,6 @@ RED.tabs = (function() {
                         var id = $(el).data('tabId');
                         var opt = {
                             id:"red-ui-tabs-menu-option-"+id,
-                            icon: tabs[id].iconClass || defaultTabIcon,
                             label: tabs[id].name,
                             onselect: function() {
                                 activateTab(id);
@@ -94,12 +90,12 @@ RED.tabs = (function() {
                     collapsibleMenu.on('mouseleave', function(){ $(this).hide() });
                     collapsibleMenu.on('mouseup', function() { $(this).hide() });
                     collapsibleMenu.appendTo("body");
+                    var elementPos = selectButton.offset();
+                    collapsibleMenu.css({
+                        top: (elementPos.top+selectButton.height()-20)+"px",
+                        left: (elementPos.left - collapsibleMenu.width() + selectButton.width())+"px"
+                    })
                 }
-                var elementPos = selectButton.offset();
-                collapsibleMenu.css({
-                    top: (elementPos.top+selectButton.height()-20)+"px",
-                    left: (elementPos.left - collapsibleMenu.width() + selectButton.width())+"px"
-                })
                 collapsibleMenu.toggle();
             })
 
@@ -174,8 +170,8 @@ RED.tabs = (function() {
                 ul.children().css({"transition": "width 100ms"});
                 link.parent().addClass("active");
                 var parentId = link.parent().attr('id');
-                wrapper.find(".red-ui-tab-link-button").removeClass("active selected");
-                $("#"+parentId+"-link-button").addClass("active selected");
+                wrapper.find(".red-ui-tab-link-button").removeClass("active");
+                $("#"+parentId+"-link-button").addClass("active");
                 if (options.scrollable) {
                     var pos = link.parent().position().left;
                     if (pos-21 < 0) {
@@ -343,7 +339,7 @@ RED.tabs = (function() {
                     if (tab.iconClass) {
                         $('<i>',{class:tab.iconClass}).appendTo(pinnedLink);
                     } else {
-                        $('<i>',{class:defaultTabIcon}).appendTo(pinnedLink);
+                        $('<i>',{class:"fa fa-lemon-o"}).appendTo(pinnedLink);
                     }
                     pinnedLink.click(function(evt) {
                         evt.preventDefault();
@@ -353,7 +349,14 @@ RED.tabs = (function() {
                         pinnedLink.addClass("red-ui-tab-link-button-pinned");
                         pinnedTabsCount++;
                     }
-                    RED.popover.tooltip($(pinnedLink), tab.name);
+                    RED.popover.create({
+                        target:$(pinnedLink),
+                        trigger: "hover",
+                        size: "small",
+                        direction: "bottom",
+                        content: tab.name,
+                        delay: { show: 550, hide: 10 }
+                    });
 
                 }
                 link.on("click",onTabClick);
@@ -367,6 +370,7 @@ RED.tabs = (function() {
                         removeTab(tab.id);
                     });
                 }
+                updateTabWidths();
                 if (options.onadd) {
                     options.onadd(tab);
                 }
@@ -451,9 +455,6 @@ RED.tabs = (function() {
                         }
                     })
                 }
-                setTimeout(function() {
-                    updateTabWidths();
-                },10);
                 collapsibleMenu = null;
             },
             removeTab: removeTab,

editor/js/ui/common/typedInput.js

@@ -14,38 +14,10 @@
  * limitations under the License.
  **/
 (function($) {
-    var contextParse = function(v) {
-        var parts = RED.utils.parseContextKey(v);
-        return {
-            option: parts.store,
-            value: parts.key
-        }
-    }
-    var contextExport = function(v,opt) {
-        if (!opt) {
-            return v;
-        }
-        var store = ((typeof opt === "string")?opt:opt.value)
-        if (store !== RED.settings.context.default) {
-            return "#:("+store+")::"+v;
-        } else {
-            return v;
-        }
-    }
     var allOptions = {
         msg: {value:"msg",label:"msg.",validate:RED.utils.validatePropertyExpression},
-        flow: {value:"flow",label:"flow.",hasValue:true,
-            options:[],
-            validate:RED.utils.validatePropertyExpression,
-            parse: contextParse,
-            export: contextExport
-        },
-        global: {value:"global",label:"global.",hasValue:true,
-            options:[],
-            validate:RED.utils.validatePropertyExpression,
-            parse: contextParse,
-            export: contextExport
-        },
+        flow: {value:"flow",label:"flow.",validate:RED.utils.validatePropertyExpression},
+        global: {value:"global",label:"global.",validate:RED.utils.validatePropertyExpression},
         str: {value:"str",label:"string",icon:"red/images/typedInput/az.png"},
         num: {value:"num",label:"number",icon:"red/images/typedInput/09.png",validate:/^[+-]?[0-9]*\.?[0-9]*([eE][-+]?[0-9]+)?$/},
         bool: {value:"bool",label:"boolean",icon:"red/images/typedInput/bool.png",options:["true","false"]},
@@ -115,40 +87,25 @@
 
     $.widget( "nodered.typedInput", {
         _create: function() {
-            try {
             if (!nlsd && RED && RED._) {
                 for (var i in allOptions) {
                     if (allOptions.hasOwnProperty(i)) {
                         allOptions[i].label = RED._("typedInput.type."+i,{defaultValue:allOptions[i].label});
                     }
                 }
-                var contextStores = RED.settings.context.stores;
-                var contextOptions = contextStores.map(function(store) {
-                    return {value:store,label: store, icon:'<i class="red-ui-typedInput-icon fa fa-database" style="color: #'+(store==='memory'?'ddd':'777')+'"></i>'}
-                })
-                if (contextOptions.length < 2) {
-                    allOptions.flow.options = [];
-                    allOptions.global.options = [];
-                } else {
-                    allOptions.flow.options = contextOptions;
-                    allOptions.global.options = contextOptions;
-                }
             }
             nlsd = true;
             var that = this;
 
             this.disarmClick = false;
-            this.input = $('<input type="text"></input>');
-            this.input.insertAfter(this.element);
-            this.input.val(this.element.val());
             this.element.addClass('red-ui-typedInput');
             this.uiWidth = this.element.outerWidth();
-            this.elementDiv = this.input.wrap("<div>").parent().addClass('red-ui-typedInput-input');
+            this.elementDiv = this.element.wrap("<div>").parent().addClass('red-ui-typedInput-input');
             this.uiSelect = this.elementDiv.wrap( "<div>" ).parent();
             var attrStyle = this.element.attr('style');
             var m;
             if ((m = /width\s*:\s*(calc\s*\(.*\)|\d+(%|px))/i.exec(attrStyle)) !== null) {
-                this.input.css('width','100%');
+                this.element.css('width','100%');
                 this.uiSelect.width(m[1]);
                 this.uiWidth = null;
             } else {
@@ -157,19 +114,17 @@
             ["Right","Left"].forEach(function(d) {
                 var m = that.element.css("margin"+d);
                 that.uiSelect.css("margin"+d,m);
-                that.input.css("margin"+d,0);
+                that.element.css("margin"+d,0);
             });
-
             this.uiSelect.addClass("red-ui-typedInput-container");
 
-            this.element.attr('type','hidden');
-
             this.options.types = this.options.types||Object.keys(allOptions);
 
             this.selectTrigger = $('<button tabindex="0"></button>').prependTo(this.uiSelect);
-            $('<i class="red-ui-typedInput-icon fa fa-sort-desc"></i>').toggle(this.options.types.length > 1).appendTo(this.selectTrigger);
-
-            this.selectLabel = $('<span class="red-ui-typedInput-type-label"></span>').appendTo(this.selectTrigger);
+            if (this.options.types.length > 1) {
+                $('<i class="fa fa-sort-desc"></i>').appendTo(this.selectTrigger);
+            }
+            this.selectLabel = $('<span></span>').appendTo(this.selectTrigger);
 
             this.types(this.options.types);
 
@@ -183,16 +138,14 @@
                 this.typeField = $("<input>",{type:'hidden'}).appendTo(this.uiSelect);
             }
 
-            this.input.on('focus', function() {
+            this.element.on('focus', function() {
                 that.uiSelect.addClass('red-ui-typedInput-focus');
             });
-            this.input.on('blur', function() {
+            this.element.on('blur', function() {
                 that.uiSelect.removeClass('red-ui-typedInput-focus');
             });
-            this.input.on('change', function() {
+            this.element.on('change', function() {
                 that.validate();
-                that.element.val(that.value());
-                that.element.trigger('change',that.propertyType,that.value());
             })
             this.selectTrigger.click(function(event) {
                 event.preventDefault();
@@ -208,11 +161,8 @@
             })
 
             // explicitly set optionSelectTrigger display to inline-block otherwise jQ sets it to 'inline'
-            this.optionSelectTrigger = $('<button tabindex="0" class="red-ui-typedInput-option-trigger" style="display:inline-block"><span class="red-ui-typedInput-option-caret"><i class="red-ui-typedInput-icon fa fa-sort-desc"></i></span></button>').appendTo(this.uiSelect);
+            this.optionSelectTrigger = $('<button tabindex="0" class="red-ui-typedInput-option-trigger" style="display:inline-block"><span class="red-ui-typedInput-option-caret"><i class="fa fa-sort-desc"></i></span></button>').appendTo(this.uiSelect);
             this.optionSelectLabel = $('<span class="red-ui-typedInput-option-label"></span>').prependTo(this.optionSelectTrigger);
-            RED.popover.tooltip(this.optionSelectLabel,function() {
-                return that.optionValue;
-            });
             this.optionSelectTrigger.click(function(event) {
                 event.preventDefault();
                 that._showOptionSelectMenu();
@@ -227,18 +177,17 @@
                 that.uiSelect.addClass('red-ui-typedInput-focus');
             });
 
-            this.optionExpandButton = $('<button tabindex="0" class="red-ui-typedInput-option-expand" style="display:inline-block"><i class="red-ui-typedInput-icon fa fa-ellipsis-h"></i></button>').appendTo(this.uiSelect);
+            this.optionExpandButton = $('<button tabindex="0" class="red-ui-typedInput-option-expand" style="display:inline-block"><i class="fa fa-ellipsis-h"></i></button>').appendTo(this.uiSelect);
+
+
             this.type(this.options.default||this.typeList[0].value);
-        }catch(err) {
-            console.log(err.stack);
-        }
         },
         _showTypeMenu: function() {
             if (this.typeList.length > 1) {
                 this._showMenu(this.menu,this.selectTrigger);
                 this.menu.find("[value='"+this.propertyType+"']").focus();
             } else {
-                this.input.focus();
+                this.element.focus();
             }
         },
         _showOptionSelectMenu: function() {
@@ -247,8 +196,8 @@
                     minWidth:this.optionSelectLabel.width()
                 });
 
-                this._showMenu(this.optionMenu,this.optionSelectTrigger);
-                var selectedOption = this.optionMenu.find("[value='"+this.optionValue+"']");
+                this._showMenu(this.optionMenu,this.optionSelectLabel);
+                var selectedOption = this.optionMenu.find("[value='"+this.value()+"']");
                 if (selectedOption.length === 0) {
                     selectedOption = this.optionMenu.children(":first");
                 }
@@ -260,7 +209,7 @@
             $(document).off("mousedown.close-property-select");
             menu.hide();
             if (this.elementDiv.is(":visible")) {
-                this.input.focus();
+                this.element.focus();
             } else if (this.optionSelectTrigger.is(":visible")){
                 this.optionSelectTrigger.focus();
             } else {
@@ -279,19 +228,10 @@
                     op.text(opt.label);
                 }
                 if (opt.icon) {
-                    if (opt.icon.indexOf("<") === 0) {
-                        $(opt.icon).prependTo(op);
-                    } else if (opt.icon.indexOf("/") !== -1) {
-                        $('<img>',{src:opt.icon,style:"margin-right: 4px; height: 18px;"}).prependTo(op);
-                    } else {
-                        $('<i>',{class:"red-ui-typedInput-icon "+opt.icon}).prependTo(op);
-                    }
+                    $('<img>',{src:opt.icon,style:"margin-right: 4px; height: 18px;"}).prependTo(op);
                 } else {
                     op.css({paddingLeft: "18px"});
                 }
-                if (!opt.icon && !opt.label) {
-                    op.text(opt.value);
-                }
 
                 op.click(function(event) {
                     event.preventDefault();
@@ -370,8 +310,7 @@
             if (this.uiWidth !== null) {
                 this.uiSelect.width(this.uiWidth);
             }
-            var type = this.typeMap[this.propertyType];
-            if (type && type.hasValue === false) {
+            if (this.typeMap[this.propertyType] && this.typeMap[this.propertyType].hasValue === false) {
                 this.selectTrigger.addClass("red-ui-typedInput-full-width");
             } else {
                 this.selectTrigger.removeClass("red-ui-typedInput-full-width");
@@ -381,68 +320,13 @@
                     this.elementDiv.css('right',"22px");
                 } else {
                     this.elementDiv.css('right','0');
-                    this.input.css({
-                        'border-top-right-radius': '4px',
-                        'border-bottom-right-radius': '4px'
-                    });
                 }
-
-                // if (this.optionSelectTrigger) {
-                //     this.optionSelectTrigger.css({'left':(labelWidth)+"px",'width':'calc( 100% - '+labelWidth+'px )'});
-                // }
-
                 if (this.optionSelectTrigger) {
-                    if (type && type.options && type.hasValue === true) {
-                        this.optionSelectLabel.css({'left':'auto'})
-                        var lw = this._getLabelWidth(this.optionSelectLabel);
-                        this.optionSelectTrigger.css({'width':(23+lw)+"px"});
-                        this.elementDiv.css('right',(23+lw)+"px");
-                        this.input.css({
-                            'border-top-right-radius': 0,
-                            'border-bottom-right-radius': 0
-                        });
-                    } else {
-                        this.optionSelectLabel.css({'left':'0'})
-                        this.optionSelectTrigger.css({'width':'calc( 100% - '+labelWidth+'px )'});
-                        if (!this.optionExpandButton.is(":visible")) {
-                            this.elementDiv.css({'right':0});
-                            this.input.css({
-                                'border-top-right-radius': '4px',
-                                'border-bottom-right-radius': '4px'
-                            });
-                        }
-                    }
+                    this.optionSelectTrigger.css({'left':(labelWidth)+"px",'width':'calc( 100% - '+labelWidth+'px )'});
                 }
             }
         },
-        _updateOptionSelectLabel: function(o) {
-            var opt = this.typeMap[this.propertyType];
-            this.optionSelectLabel.empty();
-            if (o.icon) {
-                if (o.icon.indexOf("<") === 0) {
-                    $(o.icon).prependTo(this.optionSelectLabel);
-                } else if (o.icon.indexOf("/") !== -1) {
-                    // url
-                    $('<img>',{src:o.icon,style:"height: 18px;"}).prependTo(this.optionSelectLabel);
-                } else {
-                    // icon class
-                    $('<i>',{class:"red-ui-typedInput-icon "+o.icon}).prependTo(this.optionSelectLabel);
-                }
-            } else if (o.label) {
-                this.optionSelectLabel.text(o.label);
-            } else {
-                this.optionSelectLabel.text(o.value);
-            }
-            if (opt.hasValue) {
-                this.optionValue = o.value;
-                this._resize();
-                this.input.trigger('change',this.propertyType,this.value());
-            }
-        },
         _destroy: function() {
-            if (this.optionMenu) {
-                this.optionMenu.remove();
-            }
             this.menu.remove();
         },
         types: function(types) {
@@ -460,18 +344,13 @@
                 return result;
             });
             this.selectTrigger.toggleClass("disabled", this.typeList.length === 1);
-            this.selectTrigger.find(".fa-sort-desc").toggle(this.typeList.length > 1)
             if (this.menu) {
                 this.menu.remove();
             }
             this.menu = this._createMenu(this.typeList, function(v) { that.type(v) });
             if (currentType && !this.typeMap.hasOwnProperty(currentType)) {
                 this.type(this.typeList[0].value);
-            } else {
-                this.propertyType = null;
-                this.type(currentType);
             }
-            setTimeout(function() {that._resize();},0);
         },
         width: function(desiredWidth) {
             this.uiWidth = desiredWidth;
@@ -479,33 +358,33 @@
         },
         value: function(value) {
             if (!arguments.length) {
-                var v = this.input.val();
-                if (this.typeMap[this.propertyType].export) {
-                    v = this.typeMap[this.propertyType].export(v,this.optionValue)
-                }
-                return v;
+                return this.element.val();
             } else {
-                var selectedOption;
                 if (this.typeMap[this.propertyType].options) {
+                    var validValue = false;
+                    var label;
                     for (var i=0;i<this.typeMap[this.propertyType].options.length;i++) {
                         var op = this.typeMap[this.propertyType].options[i];
                         if (typeof op === "string") {
                             if (op === value) {
-                                selectedOption = this.activeOptions[op];
+                                label = value;
+                                validValue = true;
                                 break;
                             }
                         } else if (op.value === value) {
-                            selectedOption = op;
+                            label = op.label||op.value;
+                            validValue = true;
                             break;
                         }
                     }
-                    if (!selectedOption) {
-                        selectedOption = {value:""}
+                    if (!validValue) {
+                        value = "";
+                        label = "";
                     }
-                    this._updateOptionSelectLabel(selectedOption)
+                    this.optionSelectLabel.text(label);
                 }
-                this.input.val(value);
-                this.input.trigger('change',this.type(),value);
+                this.element.val(value);
+                this.element.trigger('change',this.type(),value);
             }
         },
         type: function(type) {
@@ -516,9 +395,7 @@
                 var opt = this.typeMap[type];
                 if (opt && this.propertyType !== type) {
                     this.propertyType = type;
-                    if (this.typeField) {
-                        this.typeField.val(type);
-                    }
+                    this.typeField.val(type);
                     this.selectLabel.empty();
                     var image;
                     if (opt.icon) {
@@ -535,88 +412,37 @@
                         }
                         if (this.optionSelectTrigger) {
                             this.optionSelectTrigger.show();
-                            if (!opt.hasValue) {
-                                this.elementDiv.hide();
-                            } else {
-                                this.elementDiv.show();
-                            }
-                            this.activeOptions = {};
-                            opt.options.forEach(function(o) {
-                                if (typeof o === 'string') {
-                                    that.activeOptions[o] = {label:o,value:o};
-                                } else {
-                                    that.activeOptions[o.value] = o;
-                                }
-                            });
-
-                            if (!that.activeOptions.hasOwnProperty(that.optionValue)) {
-                                that.optionValue = null;
-                            }
+                            this.elementDiv.hide();
                             this.optionMenu = this._createMenu(opt.options,function(v){
-                                that._updateOptionSelectLabel(that.activeOptions[v]);
-                                if (!opt.hasValue) {
-                                    that.value(that.activeOptions[v].value)
-                                }
+                                that.optionSelectLabel.text(v);
+                                that.value(v);
                             });
+                            var currentVal = this.element.val();
+                            var validValue = false;
                             var op;
-                            if (!opt.hasValue) {
-                                var currentVal = this.input.val();
-                                var validValue = false;
-                                for (var i=0;i<opt.options.length;i++) {
-                                    op = opt.options[i];
-                                    if (typeof op === "string" && op === currentVal) {
-                                        that._updateOptionSelectLabel({value:currentVal});
-                                        validValue = true;
-                                        break;
-                                    } else if (op.value === currentVal) {
-                                        that._updateOptionSelectLabel(op);
+                            for (var i=0;i<opt.options.length;i++) {
+                                op = opt.options[i];
+                                if (typeof op === "string") {
+                                    if (op === currentVal) {
+                                        this.optionSelectLabel.text(currentVal);
                                         validValue = true;
                                         break;
                                     }
-                                }
-                                if (!validValue) {
-                                    op = opt.options[0];
-                                    if (typeof op === "string") {
-                                        this.value(op);
-                                        that._updateOptionSelectLabel({value:op});
-                                    } else {
-                                        this.value(op.value);
-                                        that._updateOptionSelectLabel(op);
-                                    }
-                                }
-                            } else {
-                                var selectedOption = this.optionValue||opt.options[0];
-                                if (opt.parse) {
-                                    var parts = opt.parse(this.input.val());
-                                    if (parts.option) {
-                                        selectedOption = parts.option;
-                                        if (!this.activeOptions.hasOwnProperty(selectedOption)) {
-                                            parts.option = Object.keys(this.activeOptions)[0];
-                                            selectedOption = parts.option
-                                        }
-                                    }
-                                    this.input.val(parts.value);
-                                    if (opt.export) {
-                                        this.element.val(opt.export(parts.value,parts.option||selectedOption));
-                                    }
-                                }
-                                if (typeof selectedOption === "string") {
-                                    this.optionValue = selectedOption;
-                                    if (!this.activeOptions.hasOwnProperty(selectedOption)) {
-                                        selectedOption = Object.keys(this.activeOptions)[0];
-                                    }
-                                    if (!selectedOption) {
-                                        this.optionSelectTrigger.hide();
-                                    } else {
-                                        this._updateOptionSelectLabel(this.activeOptions[selectedOption]);
-                                    }
-                                } else if (selectedOption) {
-                                    this.optionValue = selectedOption.value;
-                                    this._updateOptionSelectLabel(selectedOption);
-                                } else {
-                                    this.optionSelectTrigger.hide();
+                                } else if (op.value === currentVal) {
+                                    this.optionSelectLabel.text(op.label||op.value);
+                                    validValue = true;
+                                    break;
                                 }
                             }
+                            if (!validValue) {
+                                op = opt.options[0];
+                                if (typeof op === "string") {
+                                    this.value(op);
+                                } else {
+                                    this.value(op.value);
+                                }
+                            }
+                            console.log(validValue);
                         }
                     } else {
                         if (this.optionMenu) {
@@ -627,29 +453,27 @@
                             this.optionSelectTrigger.hide();
                         }
                         if (opt.hasValue === false) {
-                            this.oldValue = this.input.val();
-                            this.input.val("");
+                            this.oldValue = this.element.val();
+                            this.element.val("");
                             this.elementDiv.hide();
                         } else {
                             if (this.oldValue !== undefined) {
-                                this.input.val(this.oldValue);
+                                this.element.val(this.oldValue);
                                 delete this.oldValue;
                             }
                             this.elementDiv.show();
                         }
-                        if (this.optionExpandButton) {
-                            if (opt.expand && typeof opt.expand === 'function') {
-                                this.optionExpandButton.show();
-                                this.optionExpandButton.off('click');
-                                this.optionExpandButton.on('click',function(evt) {
-                                    evt.preventDefault();
-                                    opt.expand.call(that);
-                                })
-                            } else {
-                                this.optionExpandButton.hide();
-                            }
+                        if (opt.expand && typeof opt.expand === 'function') {
+                            this.optionExpandButton.show();
+                            this.optionExpandButton.off('click');
+                            this.optionExpandButton.on('click',function(evt) {
+                                evt.preventDefault();
+                                opt.expand.call(that);
+                            })
+                        } else {
+                            this.optionExpandButton.hide();
                         }
-                        this.input.trigger('change',this.propertyType,this.value());
+                        this.element.trigger('change',this.propertyType,this.value());
                     }
                     if (image) {
                         image.onload = function() { that._resize(); }

editor/js/ui/diff.js

@@ -490,7 +490,7 @@ RED.diff = (function() {
     }
     function createNodeIcon(node,def) {
         var nodeDiv = $("<div>",{class:"node-diff-node-entry-node"});
-        var colour = RED.utils.getNodeColor(node.type,def);
+        var colour = def.color;
         var icon_url = RED.utils.getNodeIcon(def,node);
         if (node.type === 'tab') {
             colour = "#C0DEED";
@@ -881,6 +881,7 @@ RED.diff = (function() {
                 }
             }
         }
+
         var properties = Object.keys(node).filter(function(p) { return p!='inputLabels'&&p!='outputLabels'&&p!='z'&&p!='wires'&&p!=='x'&&p!=='y'&&p!=='id'&&p!=='type'&&(!def.defaults||!def.defaults.hasOwnProperty(p))});
         if (def.defaults) {
             properties = properties.concat(Object.keys(def.defaults));
@@ -888,13 +889,6 @@ RED.diff = (function() {
         if (node.type !== 'tab') {
             properties = properties.concat(['inputLabels','outputLabels']);
         }
-        if ( ((localNode && localNode.hasOwnProperty('icon')) || (remoteNode && remoteNode.hasOwnProperty('icon'))) &&
-            properties.indexOf('icon') === -1
-        ) {
-            properties.unshift('icon');
-        }
-
-
         properties.forEach(function(d) {
             localChanged = false;
             remoteChanged = false;

editor/js/ui/editor.js

@@ -496,8 +496,6 @@ RED.editor = (function() {
             label = node.type;
             if (node.type === '_expression') {
                 label = RED._("expressionEditor.title");
-            } else if (node.type === '_js') {
-                label = RED._("jsEditor.title");
             } else if (node.type === '_json') {
                 label = RED._("jsonEditor.title");
             } else if (node.type === '_markdown') {
@@ -706,7 +704,7 @@ RED.editor = (function() {
         pickerBackground.on("mousedown", hide);
 
         var searchDiv = $("<div>",{class:"red-ui-search-container"}).appendTo(picker);
-        searchInput = $('<input type="text">').attr("placeholder",RED._("editor.searchIcons")).appendTo(searchDiv).searchBox({
+        searchInput = $('<input type="text">').attr("placeholder","Search icons").appendTo(searchDiv).searchBox({
             delay: 50,
             change: function() {
                 var searchTerm = $(this).val().trim();
@@ -730,7 +728,7 @@ RED.editor = (function() {
         var iconList = $('<div class="red-ui-icon-list">').appendTo(picker);
         var metaRow = $('<div class="red-ui-icon-meta"></div>').appendTo(picker);
         var summary = $('<span>').appendTo(metaRow);
-        var resetButton = $('<button class="editor-button editor-button-small">'+RED._("editor.useDefault")+'</button>').appendTo(metaRow).click(function(e) {
+        var resetButton = $('<button class="editor-button editor-button-small">use default</button>').appendTo(metaRow).click(function(e) {
             e.preventDefault();
             hide();
             done(null);
@@ -745,7 +743,7 @@ RED.editor = (function() {
                 icons.forEach(function(icon) {
                     var iconDiv = $('<div>',{class:"red-ui-icon-list-icon"}).appendTo(iconList);
                     var nodeDiv = $('<div>',{class:"red-ui-search-result-node"}).appendTo(iconDiv);
-                    var colour = RED.utils.getNodeColor(node.type, node._def);
+                    var colour = node._def.color;
                     var icon_url = "icons/"+moduleName+"/"+icon;
                     iconDiv.data('icon',icon_url)
                     nodeDiv.css('backgroundColor',colour);
@@ -816,7 +814,7 @@ RED.editor = (function() {
             var iconButton = $('<button class="editor-button">').appendTo(iconRow);
 
             var nodeDiv = $('<div>',{class:"red-ui-search-result-node"}).appendTo(iconButton);
-            var colour = RED.utils.getNodeColor(node.type, node._def);
+            var colour = node._def.color;
             var icon_url = RED.utils.getNodeIcon(node._def,node);
             nodeDiv.css('backgroundColor',colour);
             var iconContainer = $('<div/>',{class:"palette_icon_container"}).appendTo(nodeDiv);
@@ -1110,7 +1108,7 @@ RED.editor = (function() {
                                     changed = true;
                                 }
                             } else {
-                                if (icon !== "" && icon !== defaultIcon) {
+                                if (icon !== defaultIcon) {
                                     changes.icon = editing_node.icon;
                                     editing_node.icon = icon;
                                     changed = true;
@@ -1869,23 +1867,659 @@ RED.editor = (function() {
         RED.tray.show(trayOptions);
     }
 
-    function showTypeEditor(type, options) {
-        if (RED.editor.types.hasOwnProperty(type)) {
-            if (editStack.length > 0) {
-                options.parent = editStack[editStack.length-1].id;
-            }
-            editStack.push({type:type});
-            options.title = options.title || getEditStackTitle();
-            options.onclose = function() {
-                editStack.pop();
-            }
-            RED.editor.types[type].show(options);
-        } else {
-            console.log("Unknown type editor:",type);
+
+    var expressionTestCache = {};
+
+    function editExpression(options) {
+        var expressionTestCacheId = "_";
+        if (editStack.length > 0) {
+            expressionTestCacheId = editStack[editStack.length-1].id;
         }
+
+        var value = options.value;
+        var onComplete = options.complete;
+        var type = "_expression"
+        editStack.push({type:type});
+        RED.view.state(RED.state.EDITING);
+        var expressionEditor;
+        var testDataEditor;
+        var testResultEditor
+        var panels;
+
+        var trayOptions = {
+            title: getEditStackTitle(),
+            width: "inherit",
+            buttons: [
+                {
+                    id: "node-dialog-cancel",
+                    text: RED._("common.label.cancel"),
+                    click: function() {
+                        RED.tray.close();
+                    }
+                },
+                {
+                    id: "node-dialog-ok",
+                    text: RED._("common.label.done"),
+                    class: "primary",
+                    click: function() {
+                        $("#node-input-expression-help").text("");
+                        onComplete(expressionEditor.getValue());
+                        RED.tray.close();
+                    }
+                }
+            ],
+            resize: function(dimensions) {
+                if (dimensions) {
+                    editTrayWidthCache[type] = dimensions.width;
+                }
+                var height = $("#dialog-form").height();
+                if (panels) {
+                    panels.resize(height);
+                }
+
+            },
+            open: function(tray) {
+                var trayBody = tray.find('.editor-tray-body');
+                trayBody.addClass("node-input-expression-editor")
+                var dialogForm = buildEditForm(tray.find('.editor-tray-body'),'dialog-form','_expression','editor');
+                var funcSelect = $("#node-input-expression-func");
+                Object.keys(jsonata.functions).forEach(function(f) {
+                    funcSelect.append($("<option></option>").val(f).text(f));
+                })
+                funcSelect.change(function(e) {
+                    var f = $(this).val();
+                    var args = RED._('jsonata:'+f+".args",{defaultValue:''});
+                    var title = "<h5>"+f+"("+args+")</h5>";
+                    var body = marked(RED._('jsonata:'+f+'.desc',{defaultValue:''}));
+                    $("#node-input-expression-help").html(title+"<p>"+body+"</p>");
+
+                })
+                expressionEditor = RED.editor.createEditor({
+                    id: 'node-input-expression',
+                    value: "",
+                    mode:"ace/mode/jsonata",
+                    options: {
+                        enableBasicAutocompletion:true,
+                        enableSnippets:true,
+                        enableLiveAutocompletion: true
+                    }
+                });
+                var currentToken = null;
+                var currentTokenPos = -1;
+                var currentFunctionMarker = null;
+
+                expressionEditor.getSession().setValue(value||"",-1);
+                expressionEditor.on("changeSelection", function() {
+                    var c = expressionEditor.getCursorPosition();
+                    var token = expressionEditor.getSession().getTokenAt(c.row,c.column);
+                    if (token !== currentToken || (token && /paren/.test(token.type) && c.column !== currentTokenPos)) {
+                        currentToken = token;
+                        var r,p;
+                        var scopedFunction = null;
+                        if (token && token.type === 'keyword') {
+                            r = c.row;
+                            scopedFunction = token;
+                        } else {
+                            var depth = 0;
+                            var next = false;
+                            if (token) {
+                                if (token.type === 'paren.rparen') {
+                                    // If this is a block of parens ')))', set
+                                    // depth to offset against the cursor position
+                                    // within the block
+                                    currentTokenPos = c.column;
+                                    depth = c.column - (token.start + token.value.length);
+                                }
+                                r = c.row;
+                                p = token.index;
+                            } else {
+                                r = c.row-1;
+                                p = -1;
+                            }
+                            while ( scopedFunction === null && r > -1) {
+                                var rowTokens = expressionEditor.getSession().getTokens(r);
+                                if (p === -1) {
+                                    p = rowTokens.length-1;
+                                }
+                                while (p > -1) {
+                                    var type = rowTokens[p].type;
+                                    if (next) {
+                                        if (type === 'keyword') {
+                                            scopedFunction = rowTokens[p];
+                                            // console.log("HIT",scopedFunction);
+                                            break;
+                                        }
+                                        next = false;
+                                    }
+                                    if (type === 'paren.lparen') {
+                                        depth-=rowTokens[p].value.length;
+                                    } else if (type === 'paren.rparen') {
+                                        depth+=rowTokens[p].value.length;
+                                    }
+                                    if (depth < 0) {
+                                        next = true;
+                                        depth = 0;
+                                    }
+                                    // console.log(r,p,depth,next,rowTokens[p]);
+                                    p--;
+                                }
+                                if (!scopedFunction) {
+                                    r--;
+                                }
+                            }
+                        }
+                        expressionEditor.session.removeMarker(currentFunctionMarker);
+                        if (scopedFunction) {
+                        //console.log(token,.map(function(t) { return t.type}));
+                            funcSelect.val(scopedFunction.value).change();
+                        }
+                    }
+                });
+
+                dialogForm.i18n();
+                $("#node-input-expression-func-insert").click(function(e) {
+                    e.preventDefault();
+                    var pos = expressionEditor.getCursorPosition();
+                    var f = funcSelect.val();
+                    var snippet = jsonata.getFunctionSnippet(f);
+                    expressionEditor.insertSnippet(snippet);
+                    expressionEditor.focus();
+                });
+                $("#node-input-expression-reformat").click(function(evt) {
+                    evt.preventDefault();
+                    var v = expressionEditor.getValue()||"";
+                    try {
+                        v = jsonata.format(v);
+                    } catch(err) {
+                        // TODO: do an optimistic auto-format
+                    }
+                    expressionEditor.getSession().setValue(v||"",-1);
+                });
+
+                var tabs = RED.tabs.create({
+                    element: $("#node-input-expression-tabs"),
+                    onchange:function(tab) {
+                        $(".node-input-expression-tab-content").hide();
+                        tab.content.show();
+                        trayOptions.resize();
+                    }
+                })
+
+                tabs.addTab({
+                    id: 'expression-help',
+                    label: RED._('expressionEditor.functionReference'),
+                    content: $("#node-input-expression-tab-help")
+                });
+                tabs.addTab({
+                    id: 'expression-tests',
+                    label: RED._('expressionEditor.test'),
+                    content: $("#node-input-expression-tab-test")
+                });
+                testDataEditor = RED.editor.createEditor({
+                    id: 'node-input-expression-test-data',
+                    value: expressionTestCache[expressionTestCacheId] || '{\n    "payload": "hello world"\n}',
+                    mode:"ace/mode/json",
+                    lineNumbers: false
+                });
+                var changeTimer;
+                $(".node-input-expression-legacy").click(function(e) {
+                    e.preventDefault();
+                    RED.sidebar.info.set(RED._("expressionEditor.compatModeDesc"));
+                    RED.sidebar.info.show();
+                })
+                var testExpression = function() {
+                    var value = testDataEditor.getValue();
+                    var parsedData;
+                    var currentExpression = expressionEditor.getValue();
+                    var expr;
+                    var usesContext = false;
+                    var legacyMode = /(^|[^a-zA-Z0-9_'"])msg([^a-zA-Z0-9_'"]|$)/.test(currentExpression);
+                    $(".node-input-expression-legacy").toggle(legacyMode);
+                    try {
+                        expr = jsonata(currentExpression);
+                        expr.assign('flowContext',function(val) {
+                            usesContext = true;
+                            return null;
+                        });
+                        expr.assign('globalContext',function(val) {
+                            usesContext = true;
+                            return null;
+                        });
+                    } catch(err) {
+                        testResultEditor.setValue(RED._("expressionEditor.errors.invalid-expr",{message:err.message}),-1);
+                        return;
+                    }
+                    try {
+                        parsedData = JSON.parse(value);
+                    } catch(err) {
+                        testResultEditor.setValue(RED._("expressionEditor.errors.invalid-msg",{message:err.toString()}))
+                        return;
+                    }
+
+                    try {
+                        var result = expr.evaluate(legacyMode?{msg:parsedData}:parsedData);
+                        if (usesContext) {
+                            testResultEditor.setValue(RED._("expressionEditor.errors.context-unsupported"),-1);
+                            return;
+                        }
+
+                        var formattedResult;
+                        if (result !== undefined) {
+                            formattedResult = JSON.stringify(result,null,4);
+                        } else {
+                            formattedResult = RED._("expressionEditor.noMatch");
+                        }
+                        testResultEditor.setValue(formattedResult,-1);
+                    } catch(err) {
+                        testResultEditor.setValue(RED._("expressionEditor.errors.eval",{message:err.message}),-1);
+                    }
+                }
+
+                testDataEditor.getSession().on('change', function() {
+                    clearTimeout(changeTimer);
+                    changeTimer = setTimeout(testExpression,200);
+                    expressionTestCache[expressionTestCacheId] = testDataEditor.getValue();
+                });
+                expressionEditor.getSession().on('change', function() {
+                    clearTimeout(changeTimer);
+                    changeTimer = setTimeout(testExpression,200);
+                });
+
+                testResultEditor = RED.editor.createEditor({
+                    id: 'node-input-expression-test-result',
+                    value: "",
+                    mode:"ace/mode/json",
+                    lineNumbers: false,
+                    readOnly: true
+                });
+                panels = RED.panels.create({
+                    id:"node-input-expression-panels",
+                    resize: function(p1Height,p2Height) {
+                        var p1 = $("#node-input-expression-panel-expr");
+                        p1Height -= $(p1.children()[0]).outerHeight(true);
+                        var editorRow = $(p1.children()[1]);
+                        p1Height -= (parseInt(editorRow.css("marginTop"))+parseInt(editorRow.css("marginBottom")));
+                        $("#node-input-expression").css("height",(p1Height-5)+"px");
+                        expressionEditor.resize();
+
+                        var p2 = $("#node-input-expression-panel-info > .form-row > div:first-child");
+                        p2Height -= p2.outerHeight(true) + 20;
+                        $(".node-input-expression-tab-content").height(p2Height);
+                        $("#node-input-expression-test-data").css("height",(p2Height-5)+"px");
+                        testDataEditor.resize();
+                        $("#node-input-expression-test-result").css("height",(p2Height-5)+"px");
+                        testResultEditor.resize();
+                    }
+                });
+
+                $("#node-input-example-reformat").click(function(evt) {
+                    evt.preventDefault();
+                    var v = testDataEditor.getValue()||"";
+                    try {
+                        v = JSON.stringify(JSON.parse(v),null,4);
+                    } catch(err) {
+                        // TODO: do an optimistic auto-format
+                    }
+                    testDataEditor.getSession().setValue(v||"",-1);
+                });
+
+                testExpression();
+            },
+            close: function() {
+                editStack.pop();
+                expressionEditor.destroy();
+                testDataEditor.destroy();
+            },
+            show: function() {}
+        }
+        RED.tray.show(trayOptions);
     }
 
 
+    function editJSON(options) {
+        var value = options.value;
+        var onComplete = options.complete;
+        var type = "_json"
+        editStack.push({type:type});
+        RED.view.state(RED.state.EDITING);
+        var expressionEditor;
+        var changeTimer;
+
+        var checkValid = function() {
+            var v = expressionEditor.getValue();
+            try {
+                JSON.parse(v);
+                $("#node-dialog-ok").removeClass('disabled');
+                return true;
+            } catch(err) {
+                $("#node-dialog-ok").addClass('disabled');
+                return false;
+            }
+        }
+        var trayOptions = {
+            title: options.title || getEditStackTitle(),
+            width: "inherit",
+            buttons: [
+                {
+                    id: "node-dialog-cancel",
+                    text: RED._("common.label.cancel"),
+                    click: function() {
+                        RED.tray.close();
+                    }
+                },
+                {
+                    id: "node-dialog-ok",
+                    text: RED._("common.label.done"),
+                    class: "primary",
+                    click: function() {
+                        if (options.requireValid && !checkValid()) {
+                            return;
+                        }
+                        onComplete(expressionEditor.getValue());
+                        RED.tray.close();
+                    }
+                }
+            ],
+            resize: function(dimensions) {
+                editTrayWidthCache[type] = dimensions.width;
+
+                var rows = $("#dialog-form>div:not(.node-text-editor-row)");
+                var editorRow = $("#dialog-form>div.node-text-editor-row");
+                var height = $("#dialog-form").height();
+                for (var i=0;i<rows.size();i++) {
+                    height -= $(rows[i]).outerHeight(true);
+                }
+                height -= (parseInt($("#dialog-form").css("marginTop"))+parseInt($("#dialog-form").css("marginBottom")));
+                $(".node-text-editor").css("height",height+"px");
+                expressionEditor.resize();
+            },
+            open: function(tray) {
+                var trayBody = tray.find('.editor-tray-body');
+                var dialogForm = buildEditForm(tray.find('.editor-tray-body'),'dialog-form',type,'editor');
+                expressionEditor = RED.editor.createEditor({
+                    id: 'node-input-json',
+                    value: "",
+                    mode:"ace/mode/json"
+                });
+                expressionEditor.getSession().setValue(value||"",-1);
+                if (options.requireValid) {
+                    expressionEditor.getSession().on('change', function() {
+                        clearTimeout(changeTimer);
+                        changeTimer = setTimeout(checkValid,200);
+                    });
+                    checkValid();
+                }
+                $("#node-input-json-reformat").click(function(evt) {
+                    evt.preventDefault();
+                    var v = expressionEditor.getValue()||"";
+                    try {
+                        v = JSON.stringify(JSON.parse(v),null,4);
+                    } catch(err) {
+                        // TODO: do an optimistic auto-format
+                    }
+                    expressionEditor.getSession().setValue(v||"",-1);
+                });
+                dialogForm.i18n();
+            },
+            close: function() {
+                editStack.pop();
+                expressionEditor.destroy();
+            },
+            show: function() {}
+        }
+        RED.tray.show(trayOptions);
+    }
+
+    function editMarkdown(options) {
+        var value = options.value;
+        var onComplete = options.complete;
+        var type = "_markdown"
+        editStack.push({type:type});
+        RED.view.state(RED.state.EDITING);
+        var expressionEditor;
+
+        var trayOptions = {
+            title: options.title || getEditStackTitle(),
+            width: "inherit",
+            buttons: [
+                {
+                    id: "node-dialog-cancel",
+                    text: RED._("common.label.cancel"),
+                    click: function() {
+                        RED.tray.close();
+                    }
+                },
+                {
+                    id: "node-dialog-ok",
+                    text: RED._("common.label.done"),
+                    class: "primary",
+                    click: function() {
+                        onComplete(expressionEditor.getValue());
+                        RED.tray.close();
+                    }
+                }
+            ],
+            resize: function(dimensions) {
+                editTrayWidthCache[type] = dimensions.width;
+
+                var rows = $("#dialog-form>div:not(.node-text-editor-row)");
+                var editorRow = $("#dialog-form>div.node-text-editor-row");
+                var height = $("#dialog-form").height();
+                for (var i=0;i<rows.size();i++) {
+                    height -= $(rows[i]).outerHeight(true);
+                }
+                height -= (parseInt($("#dialog-form").css("marginTop"))+parseInt($("#dialog-form").css("marginBottom")));
+                $(".node-text-editor").css("height",height+"px");
+                expressionEditor.resize();
+            },
+            open: function(tray) {
+                var trayBody = tray.find('.editor-tray-body');
+                var dialogForm = buildEditForm(tray.find('.editor-tray-body'),'dialog-form',type,'editor');
+                expressionEditor = RED.editor.createEditor({
+                    id: 'node-input-markdown',
+                    value: value,
+                    mode:"ace/mode/markdown"
+                });
+                if (options.header) {
+                    options.header.appendTo(tray.find('#node-input-markdown-title'));
+                }
+
+                dialogForm.i18n();
+            },
+            close: function() {
+                editStack.pop();
+                expressionEditor.destroy();
+            },
+            show: function() {}
+        }
+        RED.tray.show(trayOptions);
+    }
+
+    function stringToUTF8Array(str) {
+        var data = [];
+        var i=0, l = str.length;
+        for (i=0; i<l; i++) {
+            var char = str.charCodeAt(i);
+            if (char < 0x80) {
+                data.push(char);
+            } else if (char < 0x800) {
+                data.push(0xc0 | (char >> 6));
+                data.push(0x80 | (char & 0x3f));
+            } else if (char < 0xd800 || char >= 0xe000) {
+                data.push(0xe0 | (char >> 12));
+                data.push(0x80 | ((char>>6) & 0x3f));
+                data.push(0x80 | (char & 0x3f));
+            } else {
+                i++;
+                char = 0x10000 + (((char & 0x3ff)<<10) | (str.charAt(i) & 0x3ff));
+                data.push(0xf0 | (char >>18));
+                data.push(0x80 | ((char>>12) & 0x3f));
+                data.push(0x80 | ((char>>6) & 0x3f));
+                data.push(0x80 | (char & 0x3f));
+            }
+        }
+        return data;
+    }
+
+    function editBuffer(options) {
+        var value = options.value;
+        var onComplete = options.complete;
+        var type = "_buffer"
+        editStack.push({type:type});
+        RED.view.state(RED.state.EDITING);
+        var bufferStringEditor = [];
+        var bufferBinValue;
+
+        var panels;
+
+        var trayOptions = {
+            title: getEditStackTitle(),
+            width: "inherit",
+            buttons: [
+                {
+                    id: "node-dialog-cancel",
+                    text: RED._("common.label.cancel"),
+                    click: function() {
+                        RED.tray.close();
+                    }
+                },
+                {
+                    id: "node-dialog-ok",
+                    text: RED._("common.label.done"),
+                    class: "primary",
+                    click: function() {
+                        onComplete(JSON.stringify(bufferBinValue));
+                        RED.tray.close();
+                    }
+                }
+            ],
+            resize: function(dimensions) {
+                if (dimensions) {
+                    editTrayWidthCache[type] = dimensions.width;
+                }
+                var height = $("#dialog-form").height();
+                if (panels) {
+                    panels.resize(height);
+                }
+            },
+            open: function(tray) {
+                var trayBody = tray.find('.editor-tray-body');
+                var dialogForm = buildEditForm(tray.find('.editor-tray-body'),'dialog-form',type,'editor');
+
+                bufferStringEditor = RED.editor.createEditor({
+                    id: 'node-input-buffer-str',
+                    value: "",
+                    mode:"ace/mode/text"
+                });
+                bufferStringEditor.getSession().setValue(value||"",-1);
+
+                bufferBinEditor = RED.editor.createEditor({
+                    id: 'node-input-buffer-bin',
+                    value: "",
+                    mode:"ace/mode/text",
+                    readOnly: true
+                });
+
+                var changeTimer;
+                var buildBuffer = function(data) {
+                    var valid = true;
+                    var isString = typeof data === 'string';
+                    var binBuffer = [];
+                    if (isString) {
+                        bufferBinValue = stringToUTF8Array(data);
+                    } else {
+                        bufferBinValue = data;
+                    }
+                    var i=0,l=bufferBinValue.length;
+                    var c = 0;
+                    for(i=0;i<l;i++) {
+                        var d = parseInt(bufferBinValue[i]);
+                        if (!isString && (isNaN(d) || d < 0 || d > 255)) {
+                            valid = false;
+                            break;
+                        }
+                        if (i>0) {
+                            if (i%8 === 0) {
+                                if (i%16 === 0) {
+                                    binBuffer.push("\n");
+                                } else {
+                                    binBuffer.push("  ");
+                                }
+                            } else {
+                                binBuffer.push(" ");
+                            }
+                        }
+                        binBuffer.push((d<16?"0":"")+d.toString(16).toUpperCase());
+                    }
+                    if (valid) {
+                        $("#node-input-buffer-type-string").toggle(isString);
+                        $("#node-input-buffer-type-array").toggle(!isString);
+                        bufferBinEditor.setValue(binBuffer.join(""),1);
+                    }
+                    return valid;
+                }
+                var bufferStringUpdate = function() {
+                    var value = bufferStringEditor.getValue();
+                    var isValidArray = false;
+                    if (/^[\s]*\[[\s\S]*\][\s]*$/.test(value)) {
+                        isValidArray = true;
+                        try {
+                            var data = JSON.parse(value);
+                            isValidArray = buildBuffer(data);
+                        } catch(err) {
+                            isValidArray = false;
+                        }
+                    }
+                    if (!isValidArray) {
+                        buildBuffer(value);
+                    }
+
+                }
+                bufferStringEditor.getSession().on('change', function() {
+                    clearTimeout(changeTimer);
+                    changeTimer = setTimeout(bufferStringUpdate,200);
+                });
+
+                bufferStringUpdate();
+
+                dialogForm.i18n();
+
+                panels = RED.panels.create({
+                    id:"node-input-buffer-panels",
+                    resize: function(p1Height,p2Height) {
+                        var p1 = $("#node-input-buffer-panel-str");
+                        p1Height -= $(p1.children()[0]).outerHeight(true);
+                        var editorRow = $(p1.children()[1]);
+                        p1Height -= (parseInt(editorRow.css("marginTop"))+parseInt(editorRow.css("marginBottom")));
+                        $("#node-input-buffer-str").css("height",(p1Height-5)+"px");
+                        bufferStringEditor.resize();
+
+                        var p2 = $("#node-input-buffer-panel-bin");
+                        editorRow = $(p2.children()[0]);
+                        p2Height -= (parseInt(editorRow.css("marginTop"))+parseInt(editorRow.css("marginBottom")));
+                        $("#node-input-buffer-bin").css("height",(p2Height-5)+"px");
+                        bufferBinEditor.resize();
+                    }
+                });
+
+                $(".node-input-buffer-type").click(function(e) {
+                    e.preventDefault();
+                    RED.sidebar.info.set(RED._("bufferEditor.modeDesc"));
+                    RED.sidebar.info.show();
+                })
+
+
+            },
+            close: function() {
+                editStack.pop();
+                bufferStringEditor.destroy();
+                bufferBinEditor.destroy();
+            },
+            show: function() {}
+        }
+        RED.tray.show(trayOptions);
+    }
+
     return {
         init: function() {
             RED.tray.init();
@@ -1897,23 +2531,14 @@ RED.editor = (function() {
                 $("#node-dialog-cancel").click();
                 $("#node-config-dialog-cancel").click();
             });
-
-            for (var type in RED.editor.types) {
-                if (RED.editor.types.hasOwnProperty(type)) {
-                    RED.editor.types[type].init();
-                }
-            }
         },
-        types: {},
         edit: showEditDialog,
         editConfig: showEditConfigNodeDialog,
         editSubflow: showEditSubflowDialog,
-        editJavaScript: function(options) { showTypeEditor("_js",options) },
-        editExpression: function(options) { showTypeEditor("_expression", options) },
-        editJSON: function(options) { showTypeEditor("_json", options) },
-        editMarkdown: function(options) { showTypeEditor("_markdown", options) },
-        editBuffer: function(options) { showTypeEditor("_buffer", options) },
-        buildEditForm: buildEditForm,
+        editExpression: editExpression,
+        editJSON: editJSON,
+        editMarkdown: editMarkdown,
+        editBuffer: editBuffer,
         validateNode: validateNode,
         updateNodeProperties: updateNodeProperties, // TODO: only exposed for edit-undo
 

editor/js/ui/editors/buffer.js

@@ -1,209 +0,0 @@
-/**
- * Copyright JS Foundation and other contributors, http://js.foundation
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
-RED.editor.types._buffer = (function() {
-
-
-    var template = '<script type="text/x-red" data-template-name="_buffer"><div id="node-input-buffer-panels"><div id="node-input-buffer-panel-str" class="red-ui-panel"><div class="form-row" style="margin-bottom: 3px; text-align: right;"><span class="node-input-buffer-type"><i class="fa fa-exclamation-circle"></i> <span id="node-input-buffer-type-string" data-i18n="bufferEditor.modeString"></span><span id="node-input-buffer-type-array" data-i18n="bufferEditor.modeArray"></span></span></div><div class="form-row node-text-editor-row"><div class="node-text-editor" id="node-input-buffer-str"></div></div></div><div id="node-input-buffer-panel-bin" class="red-ui-panel"><div class="form-row node-text-editor-row" style="margin-top: 10px"><div class="node-text-editor" id="node-input-buffer-bin"></div></div></div></div></script>';
-
-    function stringToUTF8Array(str) {
-        var data = [];
-        var i=0, l = str.length;
-        for (i=0; i<l; i++) {
-            var char = str.charCodeAt(i);
-            if (char < 0x80) {
-                data.push(char);
-            } else if (char < 0x800) {
-                data.push(0xc0 | (char >> 6));
-                data.push(0x80 | (char & 0x3f));
-            } else if (char < 0xd800 || char >= 0xe000) {
-                data.push(0xe0 | (char >> 12));
-                data.push(0x80 | ((char>>6) & 0x3f));
-                data.push(0x80 | (char & 0x3f));
-            } else {
-                i++;
-                char = 0x10000 + (((char & 0x3ff)<<10) | (str.charAt(i) & 0x3ff));
-                data.push(0xf0 | (char >>18));
-                data.push(0x80 | ((char>>12) & 0x3f));
-                data.push(0x80 | ((char>>6) & 0x3f));
-                data.push(0x80 | (char & 0x3f));
-            }
-        }
-        return data;
-    }
-
-
-    return {
-        init: function() {
-            $(template).appendTo(document.body);
-        },
-        show: function(options) {
-            var value = options.value;
-            var onComplete = options.complete;
-            var type = "_buffer"
-            RED.view.state(RED.state.EDITING);
-            var bufferStringEditor = [];
-            var bufferBinValue;
-
-            var panels;
-
-            var trayOptions = {
-                title: options.title,
-                width: "inherit",
-                buttons: [
-                    {
-                        id: "node-dialog-cancel",
-                        text: RED._("common.label.cancel"),
-                        click: function() {
-                            RED.tray.close();
-                        }
-                    },
-                    {
-                        id: "node-dialog-ok",
-                        text: RED._("common.label.done"),
-                        class: "primary",
-                        click: function() {
-                            onComplete(JSON.stringify(bufferBinValue));
-                            RED.tray.close();
-                        }
-                    }
-                ],
-                resize: function(dimensions) {
-                    var height = $("#dialog-form").height();
-                    if (panels) {
-                        panels.resize(height);
-                    }
-                },
-                open: function(tray) {
-                    var trayBody = tray.find('.editor-tray-body');
-                    var dialogForm = RED.editor.buildEditForm(tray.find('.editor-tray-body'),'dialog-form',type,'editor');
-
-                    bufferStringEditor = RED.editor.createEditor({
-                        id: 'node-input-buffer-str',
-                        value: "",
-                        mode:"ace/mode/text"
-                    });
-                    bufferStringEditor.getSession().setValue(value||"",-1);
-
-                    bufferBinEditor = RED.editor.createEditor({
-                        id: 'node-input-buffer-bin',
-                        value: "",
-                        mode:"ace/mode/text",
-                        readOnly: true
-                    });
-
-                    var changeTimer;
-                    var buildBuffer = function(data) {
-                        var valid = true;
-                        var isString = typeof data === 'string';
-                        var binBuffer = [];
-                        if (isString) {
-                            bufferBinValue = stringToUTF8Array(data);
-                        } else {
-                            bufferBinValue = data;
-                        }
-                        var i=0,l=bufferBinValue.length;
-                        var c = 0;
-                        for(i=0;i<l;i++) {
-                            var d = parseInt(bufferBinValue[i]);
-                            if (!isString && (isNaN(d) || d < 0 || d > 255)) {
-                                valid = false;
-                                break;
-                            }
-                            if (i>0) {
-                                if (i%8 === 0) {
-                                    if (i%16 === 0) {
-                                        binBuffer.push("\n");
-                                    } else {
-                                        binBuffer.push("  ");
-                                    }
-                                } else {
-                                    binBuffer.push(" ");
-                                }
-                            }
-                            binBuffer.push((d<16?"0":"")+d.toString(16).toUpperCase());
-                        }
-                        if (valid) {
-                            $("#node-input-buffer-type-string").toggle(isString);
-                            $("#node-input-buffer-type-array").toggle(!isString);
-                            bufferBinEditor.setValue(binBuffer.join(""),1);
-                        }
-                        return valid;
-                    }
-                    var bufferStringUpdate = function() {
-                        var value = bufferStringEditor.getValue();
-                        var isValidArray = false;
-                        if (/^[\s]*\[[\s\S]*\][\s]*$/.test(value)) {
-                            isValidArray = true;
-                            try {
-                                var data = JSON.parse(value);
-                                isValidArray = buildBuffer(data);
-                            } catch(err) {
-                                isValidArray = false;
-                            }
-                        }
-                        if (!isValidArray) {
-                            buildBuffer(value);
-                        }
-
-                    }
-                    bufferStringEditor.getSession().on('change', function() {
-                        clearTimeout(changeTimer);
-                        changeTimer = setTimeout(bufferStringUpdate,200);
-                    });
-
-                    bufferStringUpdate();
-
-                    dialogForm.i18n();
-
-                    panels = RED.panels.create({
-                        id:"node-input-buffer-panels",
-                        resize: function(p1Height,p2Height) {
-                            var p1 = $("#node-input-buffer-panel-str");
-                            p1Height -= $(p1.children()[0]).outerHeight(true);
-                            var editorRow = $(p1.children()[1]);
-                            p1Height -= (parseInt(editorRow.css("marginTop"))+parseInt(editorRow.css("marginBottom")));
-                            $("#node-input-buffer-str").css("height",(p1Height-5)+"px");
-                            bufferStringEditor.resize();
-
-                            var p2 = $("#node-input-buffer-panel-bin");
-                            editorRow = $(p2.children()[0]);
-                            p2Height -= (parseInt(editorRow.css("marginTop"))+parseInt(editorRow.css("marginBottom")));
-                            $("#node-input-buffer-bin").css("height",(p2Height-5)+"px");
-                            bufferBinEditor.resize();
-                        }
-                    });
-
-                    $(".node-input-buffer-type").click(function(e) {
-                        e.preventDefault();
-                        RED.sidebar.info.set(RED._("bufferEditor.modeDesc"));
-                        RED.sidebar.info.show();
-                    })
-
-
-                },
-                close: function() {
-                    if (options.onclose) {
-                        options.onclose();
-                    }
-                    bufferStringEditor.destroy();
-                    bufferBinEditor.destroy();
-                },
-                show: function() {}
-            }
-            RED.tray.show(trayOptions);
-        }
-    }
-})();

editor/js/ui/editors/expression.js

@@ -1,325 +0,0 @@
-/**
- * Copyright JS Foundation and other contributors, http://js.foundation
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
-RED.editor.types._expression = (function() {
-
-
-    var template = '<script type="text/x-red" data-template-name="_expression"><div id="node-input-expression-panels"><div id="node-input-expression-panel-expr" class="red-ui-panel"><div class="form-row" style="margin-bottom: 3px; text-align: right;"><span class="node-input-expression-legacy"><i class="fa fa-exclamation-circle"></i> <span data-i18n="expressionEditor.compatMode"></span></span><button id="node-input-expression-reformat" class="editor-button editor-button-small"><span data-i18n="expressionEditor.format"></span></button></div><div class="form-row node-text-editor-row"><div class="node-text-editor" id="node-input-expression"></div></div></div><div id="node-input-expression-panel-info" class="red-ui-panel"><div class="form-row"><ul id="node-input-expression-tabs"></ul><div id="node-input-expression-tab-help" class="node-input-expression-tab-content hide"><div><select id="node-input-expression-func"></select><button id="node-input-expression-func-insert" class="editor-button" data-i18n="expressionEditor.insert"></button></div><div id="node-input-expression-help"></div></div><div id="node-input-expression-tab-test" class="node-input-expression-tab-content hide"><div><span style="display: inline-block; width: calc(50% - 5px);"><span data-i18n="expressionEditor.data"></span><button style="float: right; margin-right: 5px;" id="node-input-example-reformat" class="editor-button editor-button-small"><span data-i18n="jsonEditor.format"></span></button></span><span style="display: inline-block; width: calc(50% - 5px);" data-i18n="expressionEditor.result"></span></div><div style="display: inline-block; width: calc(50% - 5px);" class="node-text-editor" id="node-input-expression-test-data"></div><div style="display: inline-block; width: calc(50% - 5px);" class="node-text-editor" id="node-input-expression-test-result"></div></div></div></div></div></script>';
-    var expressionTestCache = {};
-
-    return {
-        init: function() {
-            $(template).appendTo(document.body);
-        },
-        show: function(options) {
-            var expressionTestCacheId = options.parent||"_";
-            var value = options.value;
-            var onComplete = options.complete;
-            var type = "_expression"
-            RED.view.state(RED.state.EDITING);
-            var expressionEditor;
-            var testDataEditor;
-            var testResultEditor
-            var panels;
-
-            var trayOptions = {
-                title: options.title,
-                width: "inherit",
-                buttons: [
-                    {
-                        id: "node-dialog-cancel",
-                        text: RED._("common.label.cancel"),
-                        click: function() {
-                            RED.tray.close();
-                        }
-                    },
-                    {
-                        id: "node-dialog-ok",
-                        text: RED._("common.label.done"),
-                        class: "primary",
-                        click: function() {
-                            $("#node-input-expression-help").text("");
-                            onComplete(expressionEditor.getValue());
-                            RED.tray.close();
-                        }
-                    }
-                ],
-                resize: function(dimensions) {
-                    var height = $("#dialog-form").height();
-                    if (panels) {
-                        panels.resize(height);
-                    }
-
-                },
-                open: function(tray) {
-                    var trayBody = tray.find('.editor-tray-body');
-                    trayBody.addClass("node-input-expression-editor")
-                    var dialogForm = RED.editor.buildEditForm(tray.find('.editor-tray-body'),'dialog-form','_expression','editor');
-                    var funcSelect = $("#node-input-expression-func");
-                    Object.keys(jsonata.functions).forEach(function(f) {
-                        funcSelect.append($("<option></option>").val(f).text(f));
-                    })
-                    funcSelect.change(function(e) {
-                        var f = $(this).val();
-                        var args = RED._('jsonata:'+f+".args",{defaultValue:''});
-                        var title = "<h5>"+f+"("+args+")</h5>";
-                        var body = marked(RED._('jsonata:'+f+'.desc',{defaultValue:''}));
-                        $("#node-input-expression-help").html(title+"<p>"+body+"</p>");
-
-                    })
-                    expressionEditor = RED.editor.createEditor({
-                        id: 'node-input-expression',
-                        value: "",
-                        mode:"ace/mode/jsonata",
-                        options: {
-                            enableBasicAutocompletion:true,
-                            enableSnippets:true,
-                            enableLiveAutocompletion: true
-                        }
-                    });
-                    var currentToken = null;
-                    var currentTokenPos = -1;
-                    var currentFunctionMarker = null;
-
-                    expressionEditor.getSession().setValue(value||"",-1);
-                    expressionEditor.on("changeSelection", function() {
-                        var c = expressionEditor.getCursorPosition();
-                        var token = expressionEditor.getSession().getTokenAt(c.row,c.column);
-                        if (token !== currentToken || (token && /paren/.test(token.type) && c.column !== currentTokenPos)) {
-                            currentToken = token;
-                            var r,p;
-                            var scopedFunction = null;
-                            if (token && token.type === 'keyword') {
-                                r = c.row;
-                                scopedFunction = token;
-                            } else {
-                                var depth = 0;
-                                var next = false;
-                                if (token) {
-                                    if (token.type === 'paren.rparen') {
-                                        // If this is a block of parens ')))', set
-                                        // depth to offset against the cursor position
-                                        // within the block
-                                        currentTokenPos = c.column;
-                                        depth = c.column - (token.start + token.value.length);
-                                    }
-                                    r = c.row;
-                                    p = token.index;
-                                } else {
-                                    r = c.row-1;
-                                    p = -1;
-                                }
-                                while ( scopedFunction === null && r > -1) {
-                                    var rowTokens = expressionEditor.getSession().getTokens(r);
-                                    if (p === -1) {
-                                        p = rowTokens.length-1;
-                                    }
-                                    while (p > -1) {
-                                        var type = rowTokens[p].type;
-                                        if (next) {
-                                            if (type === 'keyword') {
-                                                scopedFunction = rowTokens[p];
-                                                // console.log("HIT",scopedFunction);
-                                                break;
-                                            }
-                                            next = false;
-                                        }
-                                        if (type === 'paren.lparen') {
-                                            depth-=rowTokens[p].value.length;
-                                        } else if (type === 'paren.rparen') {
-                                            depth+=rowTokens[p].value.length;
-                                        }
-                                        if (depth < 0) {
-                                            next = true;
-                                            depth = 0;
-                                        }
-                                        // console.log(r,p,depth,next,rowTokens[p]);
-                                        p--;
-                                    }
-                                    if (!scopedFunction) {
-                                        r--;
-                                    }
-                                }
-                            }
-                            expressionEditor.session.removeMarker(currentFunctionMarker);
-                            if (scopedFunction) {
-                            //console.log(token,.map(function(t) { return t.type}));
-                                funcSelect.val(scopedFunction.value).change();
-                            }
-                        }
-                    });
-
-                    dialogForm.i18n();
-                    $("#node-input-expression-func-insert").click(function(e) {
-                        e.preventDefault();
-                        var pos = expressionEditor.getCursorPosition();
-                        var f = funcSelect.val();
-                        var snippet = jsonata.getFunctionSnippet(f);
-                        expressionEditor.insertSnippet(snippet);
-                        expressionEditor.focus();
-                    });
-                    $("#node-input-expression-reformat").click(function(evt) {
-                        evt.preventDefault();
-                        var v = expressionEditor.getValue()||"";
-                        try {
-                            v = jsonata.format(v);
-                        } catch(err) {
-                            // TODO: do an optimistic auto-format
-                        }
-                        expressionEditor.getSession().setValue(v||"",-1);
-                    });
-
-                    var tabs = RED.tabs.create({
-                        element: $("#node-input-expression-tabs"),
-                        onchange:function(tab) {
-                            $(".node-input-expression-tab-content").hide();
-                            tab.content.show();
-                            trayOptions.resize();
-                        }
-                    })
-
-                    tabs.addTab({
-                        id: 'expression-help',
-                        label: RED._('expressionEditor.functionReference'),
-                        content: $("#node-input-expression-tab-help")
-                    });
-                    tabs.addTab({
-                        id: 'expression-tests',
-                        label: RED._('expressionEditor.test'),
-                        content: $("#node-input-expression-tab-test")
-                    });
-                    testDataEditor = RED.editor.createEditor({
-                        id: 'node-input-expression-test-data',
-                        value: expressionTestCache[expressionTestCacheId] || '{\n    "payload": "hello world"\n}',
-                        mode:"ace/mode/json",
-                        lineNumbers: false
-                    });
-                    var changeTimer;
-                    $(".node-input-expression-legacy").click(function(e) {
-                        e.preventDefault();
-                        RED.sidebar.info.set(RED._("expressionEditor.compatModeDesc"));
-                        RED.sidebar.info.show();
-                    })
-                    var testExpression = function() {
-                        var value = testDataEditor.getValue();
-                        var parsedData;
-                        var currentExpression = expressionEditor.getValue();
-                        var expr;
-                        var usesContext = false;
-                        var legacyMode = /(^|[^a-zA-Z0-9_'"])msg([^a-zA-Z0-9_'"]|$)/.test(currentExpression);
-                        $(".node-input-expression-legacy").toggle(legacyMode);
-                        try {
-                            expr = jsonata(currentExpression);
-                            expr.assign('flowContext',function(val) {
-                                usesContext = true;
-                                return null;
-                            });
-                            expr.assign('globalContext',function(val) {
-                                usesContext = true;
-                                return null;
-                            });
-                        } catch(err) {
-                            testResultEditor.setValue(RED._("expressionEditor.errors.invalid-expr",{message:err.message}),-1);
-                            return;
-                        }
-                        try {
-                            parsedData = JSON.parse(value);
-                        } catch(err) {
-                            testResultEditor.setValue(RED._("expressionEditor.errors.invalid-msg",{message:err.toString()}))
-                            return;
-                        }
-
-                        try {
-                            var result = expr.evaluate(legacyMode?{msg:parsedData}:parsedData);
-                            if (usesContext) {
-                                testResultEditor.setValue(RED._("expressionEditor.errors.context-unsupported"),-1);
-                                return;
-                            }
-
-                            var formattedResult;
-                            if (result !== undefined) {
-                                formattedResult = JSON.stringify(result,null,4);
-                            } else {
-                                formattedResult = RED._("expressionEditor.noMatch");
-                            }
-                            testResultEditor.setValue(formattedResult,-1);
-                        } catch(err) {
-                            testResultEditor.setValue(RED._("expressionEditor.errors.eval",{message:err.message}),-1);
-                        }
-                    }
-
-                    testDataEditor.getSession().on('change', function() {
-                        clearTimeout(changeTimer);
-                        changeTimer = setTimeout(testExpression,200);
-                        expressionTestCache[expressionTestCacheId] = testDataEditor.getValue();
-                    });
-                    expressionEditor.getSession().on('change', function() {
-                        clearTimeout(changeTimer);
-                        changeTimer = setTimeout(testExpression,200);
-                    });
-
-                    testResultEditor = RED.editor.createEditor({
-                        id: 'node-input-expression-test-result',
-                        value: "",
-                        mode:"ace/mode/json",
-                        lineNumbers: false,
-                        readOnly: true
-                    });
-                    panels = RED.panels.create({
-                        id:"node-input-expression-panels",
-                        resize: function(p1Height,p2Height) {
-                            var p1 = $("#node-input-expression-panel-expr");
-                            p1Height -= $(p1.children()[0]).outerHeight(true);
-                            var editorRow = $(p1.children()[1]);
-                            p1Height -= (parseInt(editorRow.css("marginTop"))+parseInt(editorRow.css("marginBottom")));
-                            $("#node-input-expression").css("height",(p1Height-5)+"px");
-                            expressionEditor.resize();
-
-                            var p2 = $("#node-input-expression-panel-info > .form-row > div:first-child");
-                            p2Height -= p2.outerHeight(true) + 20;
-                            $(".node-input-expression-tab-content").height(p2Height);
-                            $("#node-input-expression-test-data").css("height",(p2Height-5)+"px");
-                            testDataEditor.resize();
-                            $("#node-input-expression-test-result").css("height",(p2Height-5)+"px");
-                            testResultEditor.resize();
-                        }
-                    });
-
-                    $("#node-input-example-reformat").click(function(evt) {
-                        evt.preventDefault();
-                        var v = testDataEditor.getValue()||"";
-                        try {
-                            v = JSON.stringify(JSON.parse(v),null,4);
-                        } catch(err) {
-                            // TODO: do an optimistic auto-format
-                        }
-                        testDataEditor.getSession().setValue(v||"",-1);
-                    });
-
-                    testExpression();
-                },
-                close: function() {
-                    if (options.onclose) {
-                        options.onclose();
-                    }
-                    expressionEditor.destroy();
-                    testDataEditor.destroy();
-                },
-                show: function() {}
-            }
-            RED.tray.show(trayOptions);
-        }
-    }
-})();

editor/js/ui/editors/js.js

@@ -1,102 +0,0 @@
-/**
- * Copyright JS Foundation and other contributors, http://js.foundation
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
-RED.editor.types._js = (function() {
-
-
-    var template = '<script type="text/x-red" data-template-name="_js"><div class="form-row node-text-editor-row"><div style="height: 200px;min-height: 150px;" class="node-text-editor" id="node-input-js"></div></div></script>';
-
-    return {
-        init: function() {
-            $(template).appendTo(document.body);
-        },
-        show: function(options) {
-            var value = options.value;
-            var onComplete = options.complete;
-            var type = "_js"
-            RED.view.state(RED.state.EDITING);
-            var expressionEditor;
-            var changeTimer;
-
-            var trayOptions = {
-                title: options.title,
-                width: "inherit",
-                buttons: [
-                    {
-                        id: "node-dialog-cancel",
-                        text: RED._("common.label.cancel"),
-                        click: function() {
-                            RED.tray.close();
-                        }
-                    },
-                    {
-                        id: "node-dialog-ok",
-                        text: RED._("common.label.done"),
-                        class: "primary",
-                        click: function() {
-                            onComplete(expressionEditor.getValue(),expressionEditor.getCursorPosition());
-                            RED.tray.close();
-                        }
-                    }
-                ],
-                resize: function(dimensions) {
-                    var rows = $("#dialog-form>div:not(.node-text-editor-row)");
-                    var editorRow = $("#dialog-form>div.node-text-editor-row");
-                    var height = $("#dialog-form").height();
-                    for (var i=0;i<rows.size();i++) {
-                        height -= $(rows[i]).outerHeight(true);
-                    }
-                    $(".node-text-editor").css("height",height+"px");
-                    expressionEditor.resize();
-                },
-                open: function(tray) {
-                    var trayBody = tray.find('.editor-tray-body');
-                    var dialogForm = RED.editor.buildEditForm(tray.find('.editor-tray-body'),'dialog-form',type,'editor');
-                    expressionEditor = RED.editor.createEditor({
-                        id: 'node-input-js',
-                        mode: 'ace/mode/javascript',
-                        value: value,
-                        globals: {
-                            msg:true,
-                            context:true,
-                            RED: true,
-                            util: true,
-                            flow: true,
-                            global: true,
-                            console: true,
-                            Buffer: true,
-                            setTimeout: true,
-                            clearTimeout: true,
-                            setInterval: true,
-                            clearInterval: true
-                        }
-                    });
-                    if (options.cursor) {
-                        expressionEditor.gotoLine(options.cursor.row+1,options.cursor.column,false);
-                    }
-                    dialogForm.i18n();
-                },
-                close: function() {
-                    expressionEditor.destroy();
-                    if (options.onclose) {
-                        options.onclose();
-                    }
-                },
-                show: function() {}
-            }
-            RED.tray.show(trayOptions);
-        }
-    }
-})();

editor/js/ui/editors/json.js

@@ -1,118 +0,0 @@
-/**
- * Copyright JS Foundation and other contributors, http://js.foundation
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
-RED.editor.types._json = (function() {
-
-
-    var template = '<script type="text/x-red" data-template-name="_json"><div class="form-row" style="margin-bottom: 3px; text-align: right;"><button id="node-input-json-reformat" class="editor-button editor-button-small"><span data-i18n="jsonEditor.format"></span></button></div><div class="form-row node-text-editor-row"><div style="height: 200px;min-height: 150px;" class="node-text-editor" id="node-input-json"></div></div></script>';
-
-    return {
-        init: function() {
-            $(template).appendTo(document.body);
-        },
-        show: function(options) {
-            var value = options.value;
-            var onComplete = options.complete;
-            var type = "_json"
-            RED.view.state(RED.state.EDITING);
-            var expressionEditor;
-            var changeTimer;
-
-            var checkValid = function() {
-                var v = expressionEditor.getValue();
-                try {
-                    JSON.parse(v);
-                    $("#node-dialog-ok").removeClass('disabled');
-                    return true;
-                } catch(err) {
-                    $("#node-dialog-ok").addClass('disabled');
-                    return false;
-                }
-            }
-            var trayOptions = {
-                title: options.title,
-                width: "inherit",
-                buttons: [
-                    {
-                        id: "node-dialog-cancel",
-                        text: RED._("common.label.cancel"),
-                        click: function() {
-                            RED.tray.close();
-                        }
-                    },
-                    {
-                        id: "node-dialog-ok",
-                        text: RED._("common.label.done"),
-                        class: "primary",
-                        click: function() {
-                            if (options.requireValid && !checkValid()) {
-                                return;
-                            }
-                            onComplete(expressionEditor.getValue());
-                            RED.tray.close();
-                        }
-                    }
-                ],
-                resize: function(dimensions) {
-                    var rows = $("#dialog-form>div:not(.node-text-editor-row)");
-                    var editorRow = $("#dialog-form>div.node-text-editor-row");
-                    var height = $("#dialog-form").height();
-                    for (var i=0;i<rows.size();i++) {
-                        height -= $(rows[i]).outerHeight(true);
-                    }
-                    height -= (parseInt($("#dialog-form").css("marginTop"))+parseInt($("#dialog-form").css("marginBottom")));
-                    $(".node-text-editor").css("height",height+"px");
-                    expressionEditor.resize();
-                },
-                open: function(tray) {
-                    var trayBody = tray.find('.editor-tray-body');
-                    var dialogForm = RED.editor.buildEditForm(tray.find('.editor-tray-body'),'dialog-form',type,'editor');
-                    expressionEditor = RED.editor.createEditor({
-                        id: 'node-input-json',
-                        value: "",
-                        mode:"ace/mode/json"
-                    });
-                    expressionEditor.getSession().setValue(value||"",-1);
-                    if (options.requireValid) {
-                        expressionEditor.getSession().on('change', function() {
-                            clearTimeout(changeTimer);
-                            changeTimer = setTimeout(checkValid,200);
-                        });
-                        checkValid();
-                    }
-                    $("#node-input-json-reformat").click(function(evt) {
-                        evt.preventDefault();
-                        var v = expressionEditor.getValue()||"";
-                        try {
-                            v = JSON.stringify(JSON.parse(v),null,4);
-                        } catch(err) {
-                            // TODO: do an optimistic auto-format
-                        }
-                        expressionEditor.getSession().setValue(v||"",-1);
-                    });
-                    dialogForm.i18n();
-                },
-                close: function() {
-                    expressionEditor.destroy();
-                    if (options.onclose) {
-                        options.onclose();
-                    }
-                },
-                show: function() {}
-            }
-            RED.tray.show(trayOptions);
-        }
-    }
-})();

editor/js/ui/editors/markdown.js

@@ -1,90 +0,0 @@
-/**
- * Copyright JS Foundation and other contributors, http://js.foundation
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
-RED.editor.types._markdown = (function() {
-
-
-    var template = '<script type="text/x-red" data-template-name="_markdown"><div class="form-row" id="node-input-markdown-title" style="margin-bottom: 3px; text-align: right;"></div><div class="form-row node-text-editor-row"><div style="height: 200px;min-height: 150px;" class="node-text-editor" id="node-input-markdown"></div></div></script>';
-
-    return {
-        init: function() {
-            $(template).appendTo(document.body);
-        },
-        show: function(options) {
-            var value = options.value;
-            var onComplete = options.complete;
-            var type = "_markdown"
-            RED.view.state(RED.state.EDITING);
-            var expressionEditor;
-
-            var trayOptions = {
-                title: options.title,
-                width: "inherit",
-                buttons: [
-                    {
-                        id: "node-dialog-cancel",
-                        text: RED._("common.label.cancel"),
-                        click: function() {
-                            RED.tray.close();
-                        }
-                    },
-                    {
-                        id: "node-dialog-ok",
-                        text: RED._("common.label.done"),
-                        class: "primary",
-                        click: function() {
-                            onComplete(expressionEditor.getValue());
-                            RED.tray.close();
-                        }
-                    }
-                ],
-                resize: function(dimensions) {
-                    var rows = $("#dialog-form>div:not(.node-text-editor-row)");
-                    var editorRow = $("#dialog-form>div.node-text-editor-row");
-                    var height = $("#dialog-form").height();
-                    for (var i=0;i<rows.size();i++) {
-                        height -= $(rows[i]).outerHeight(true);
-                    }
-                    height -= (parseInt($("#dialog-form").css("marginTop"))+parseInt($("#dialog-form").css("marginBottom")));
-                    $(".node-text-editor").css("height",height+"px");
-                    expressionEditor.resize();
-                },
-                open: function(tray) {
-                    var trayBody = tray.find('.editor-tray-body');
-                    var dialogForm = RED.editor.buildEditForm(tray.find('.editor-tray-body'),'dialog-form',type,'editor');
-                    expressionEditor = RED.editor.createEditor({
-                        id: 'node-input-markdown',
-                        value: value,
-                        mode:"ace/mode/markdown"
-                    });
-                    if (options.header) {
-                        options.header.appendTo(tray.find('#node-input-markdown-title'));
-                    }
-
-                    dialogForm.i18n();
-                },
-                close: function() {
-                    expressionEditor.destroy();
-                    if (options.onclose) {
-                        options.onclose();
-                    }
-                },
-                show: function() {}
-            }
-            RED.tray.show(trayOptions);
-
-        }
-    }
-})();

editor/js/ui/notifications.js

@@ -96,7 +96,7 @@ RED.notifications = (function() {
         if (options.buttons) {
             var buttonSet = $('<div style="margin-top: 20px;" class="ui-dialog-buttonset"></div>').appendTo(n)
             options.buttons.forEach(function(buttonDef) {
-                var b = $('<button>').html(buttonDef.text).click(buttonDef.click).appendTo(buttonSet);
+                var b = $('<button>').text(buttonDef.text).click(buttonDef.click).appendTo(buttonSet);
                 if (buttonDef.id) {
                     b.attr('id',buttonDef.id);
                 }

editor/js/ui/palette-editor.js

@@ -233,7 +233,7 @@ RED.palette.editor = (function() {
                             if (set.enabled) {
                                 var def = RED.nodes.getType(t);
                                 if (def && def.color) {
-                                    swatch.css({background:RED.utils.getNodeColor(t,def)});
+                                    swatch.css({background:def.color});
                                     swatch.css({border: "1px solid "+getContrastingBorder(swatch.css('backgroundColor'))})
 
                                 } else {

editor/js/ui/palette.js

@@ -172,7 +172,7 @@ RED.palette = (function() {
                 $('<div/>',{class:"palette_icon",style:"background-image: url("+icon_url+")"}).appendTo(iconContainer);
             }
 
-            d.style.backgroundColor = RED.utils.getNodeColor(nt,def);
+            d.style.backgroundColor = def.color;
 
             if (def.outputs > 0) {
                 var portOut = document.createElement("div");

editor/js/ui/projects/projects.js

@@ -622,7 +622,7 @@ RED.projects = (function() {
                                             },
                                             400: {
                                                 'project_exists': function(error) {
-                                                    console.log(RED._("projects.clone-project.already-exists2"));
+                                                    console.log(RED._("projects.clone-project.already-exists"));
                                                 },
                                                 'git_error': function(error) {
                                                     console.log(RED._("projects.clone-project.git-error"),error);
@@ -1983,7 +1983,7 @@ RED.projects = (function() {
                                     notification.close();
                                 }
                             },{
-                                text: '<span><i class="fa fa-refresh"></i> ' +RED._("projects.send-req.retry") +'</span>',
+                                text: $('<span><i class="fa fa-refresh"></i> Retry</span>'),
                                 click: function() {
                                     body = body || {};
                                     var authBody = {};

editor/js/ui/search.js

@@ -26,24 +26,6 @@ RED.search = (function() {
     var keys = [];
     var results = [];
 
-
-    function indexProperty(node,label,property) {
-        if (typeof property === 'string' || typeof property === 'number') {
-            property = (""+property).toLowerCase();
-            index[property] = index[property] || {};
-            index[property][node.id] = {node:node,label:label};
-        } else if (Array.isArray(property)) {
-            property.forEach(function(prop) {
-                indexProperty(node,label,prop);
-            })
-        } else if (typeof property === 'object') {
-            for (var prop in property) {
-                if (property.hasOwnProperty(prop)) {
-                    indexProperty(node,label,property[prop])
-                }
-            }
-        }
-    }
     function indexNode(n) {
         var l = RED.utils.getNodeLabel(n);
         if (l) {
@@ -60,11 +42,17 @@ RED.search = (function() {
         }
         for (var i=0;i<properties.length;i++) {
             if (n.hasOwnProperty(properties[i])) {
-                indexProperty(n, l, n[properties[i]]);
+                var v = n[properties[i]];
+                if (typeof v === 'string' || typeof v === 'number') {
+                    v = (""+v).toLowerCase();
+                    index[v] = index[v] || {};
+                    index[v][n.id] = {node:n,label:l};
+                }
             }
         }
-    }
 
+
+    }
     function indexWorkspace() {
         index = {};
         RED.nodes.eachWorkspace(indexNode);
@@ -193,7 +181,7 @@ RED.search = (function() {
                     var div = $('<a>',{href:'#',class:"red-ui-search-result"}).appendTo(container);
 
                     var nodeDiv = $('<div>',{class:"red-ui-search-result-node"}).appendTo(div);
-                    var colour = RED.utils.getNodeColor(node.type,def);
+                    var colour = def.color;
                     var icon_url = RED.utils.getNodeIcon(def,node);
                     if (node.type === 'tab') {
                         colour = "#C0DEED";

editor/js/ui/sidebar.js

@@ -61,7 +61,7 @@ RED.sidebar = (function() {
         }
 
         delete options.closeable;
-
+        
         options.wrapper = $('<div>',{style:"height:100%"}).appendTo("#sidebar-content")
         options.wrapper.append(options.content);
         options.wrapper.hide();
@@ -218,7 +218,6 @@ RED.sidebar = (function() {
         showSidebar();
         RED.sidebar.info.init();
         RED.sidebar.config.init();
-        RED.sidebar.context.init();
         // hide info bar at start if screen rather narrow...
         if ($(window).width() < 600) { RED.menu.setSelected("menu-item-sidebar",false); }
     }

editor/js/ui/tab-context.js

@@ -1,292 +0,0 @@
-/**
- * Copyright JS Foundation and other contributors, http://js.foundation
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
-RED.sidebar.context = (function() {
-
-    var content;
-    var sections;
-
-    var localCache = {};
-
-
-    var nodeSection;
-    // var subflowSection;
-    var flowSection;
-    var globalSection;
-
-    var currentNode;
-    var currentFlow;
-
-    function init() {
-
-        content = $("<div>").css({"position":"relative","height":"100%"});
-        content.className = "sidebar-context"
-        // var toolbar = $('<div class="sidebar-header">'+
-        //     '</div>').appendTo(content);
-
-        var footerToolbar = $('<div>'+
-            // '<span class="button-group"><a class="sidebar-footer-button" href="#" data-i18n="[title]node-red:debug.sidebar.openWindow"><i class="fa fa-desktop"></i></a></span> ' +
-            '</div>');
-
-
-
-        var stackContainer = $("<div>",{class:"sidebar-context-stack"}).appendTo(content);
-        sections = RED.stack.create({
-            container: stackContainer
-        });
-
-        nodeSection = sections.add({
-            title: RED._("sidebar.context.node"),
-            collapsible: true,
-            // onexpand: function() {
-            //     updateNode(currentNode,true);
-            // }
-        });
-        nodeSection.expand();
-        nodeSection.content.css({height:"100%"});
-        nodeSection.timestamp = $('<div class="sidebar-context-updated">&nbsp;</div>').appendTo(nodeSection.content);
-        var table = $('<table class="node-info"></table>').appendTo(nodeSection.content);
-        nodeSection.table = $('<tbody>').appendTo(table);
-        var bg = $('<div style="float: right"></div>').appendTo(nodeSection.header);
-        $('<button class="editor-button editor-button-small"><i class="fa fa-refresh"></i></button>')
-            .appendTo(bg)
-            .click(function(evt) {
-                evt.stopPropagation();
-                evt.preventDefault();
-                updateNode(currentNode, true);
-            })
-
-        // subflowSection  = sections.add({
-        //     title: "Subflow",
-        //     collapsible: true
-        // });
-        // subflowSection.expand();
-        // subflowSection.content.css({height:"100%"});
-        // bg = $('<div style="float: right"></div>').appendTo(subflowSection.header);
-        // $('<button class="editor-button editor-button-small"><i class="fa fa-refresh"></i></button>')
-        //     .appendTo(bg)
-        //     .click(function(evt) {
-        //         evt.stopPropagation();
-        //         evt.preventDefault();
-        //     })
-        //
-        // subflowSection.container.hide();
-
-        flowSection = sections.add({
-            title: RED._("sidebar.context.flow"),
-            collapsible: true
-        });
-        flowSection.expand();
-        flowSection.content.css({height:"100%"});
-        flowSection.timestamp = $('<div class="sidebar-context-updated">&nbsp;</div>').appendTo(flowSection.content);
-        var table = $('<table class="node-info"></table>').appendTo(flowSection.content);
-        flowSection.table = $('<tbody>').appendTo(table);
-        bg = $('<div style="float: right"></div>').appendTo(flowSection.header);
-        $('<button class="editor-button editor-button-small"><i class="fa fa-refresh"></i></button>')
-            .appendTo(bg)
-            .click(function(evt) {
-                evt.stopPropagation();
-                evt.preventDefault();
-                updateFlow(currentFlow);
-            })
-
-        globalSection = sections.add({
-            title: RED._("sidebar.context.global"),
-            collapsible: true
-        });
-        globalSection.expand();
-        globalSection.content.css({height:"100%"});
-        globalSection.timestamp = $('<div class="sidebar-context-updated">&nbsp;</div>').appendTo(globalSection.content);
-        var table = $('<table class="node-info"></table>').appendTo(globalSection.content);
-        globalSection.table = $('<tbody>').appendTo(table);
-
-        bg = $('<div style="float: right"></div>').appendTo(globalSection.header);
-        $('<button class="editor-button editor-button-small"><i class="fa fa-refresh"></i></button>')
-            .appendTo(bg)
-            .click(function(evt) {
-                evt.stopPropagation();
-                evt.preventDefault();
-                updateEntry(globalSection,"context/global","global");
-            })
-
-
-        RED.actions.add("core:show-context-tab",show);
-
-        RED.sidebar.addTab({
-            id: "context",
-            label: RED._("sidebar.context.label"),
-            name: RED._("sidebar.context.name"),
-            iconClass: "fa fa-database",
-            content: content,
-            toolbar: footerToolbar,
-            // pinned: true,
-            enableOnEdit: false
-        });
-
-        // var toggleLiveButton = $("#sidebar-context-toggle-live");
-        // toggleLiveButton.click(function(evt) {
-        //     evt.preventDefault();
-        //     if ($(this).hasClass("selected")) {
-        //         $(this).removeClass("selected");
-        //         $(this).find("i").removeClass("fa-pause");
-        //         $(this).find("i").addClass("fa-play");
-        //     } else {
-        //         $(this).addClass("selected");
-        //         $(this).find("i").removeClass("fa-play");
-        //         $(this).find("i").addClass("fa-pause");
-        //     }
-        // });
-        // RED.popover.tooltip(toggleLiveButton, function() {
-        //     if (toggleLiveButton.hasClass("selected")) {
-        //         return "Pause live updates"
-        //     } else {
-        //         return "Start live updates"
-        //     }
-        // });
-
-
-        RED.events.on("view:selection-changed", function(event) {
-            var selectedNode = event.nodes && event.nodes.length === 1 && event.nodes[0];
-            updateNode(selectedNode);
-        })
-
-        RED.events.on("workspace:change", function(event) {
-            updateFlow(RED.nodes.workspace(event.workspace));
-        })
-
-        updateEntry(globalSection,"context/global","global");
-
-    }
-
-    function updateNode(node,force) {
-        currentNode = node;
-        if (force) {
-            if (node) {
-                updateEntry(nodeSection,"context/node/"+node.id,node.id);
-                // if (/^subflow:/.test(node.type)) {
-                //     subflowSection.container.show();
-                //     updateEntry(subflowSection,"context/flow/"+node.id,node.id);
-                // } else {
-                //     subflowSection.container.hide();
-                // }
-            } else {
-                // subflowSection.container.hide();
-                updateEntry(nodeSection)
-            }
-        } else {
-            $(nodeSection.table).empty();
-            if (node) {
-                $('<tr class="node-info-node-row red-ui-search-empty blank" colspan="2"><td data-i18n="sidebar.context.refresh"></td></tr>').appendTo(nodeSection.table).i18n();
-            } else {
-                $('<tr class="node-info-node-row red-ui-search-empty blank" colspan="2"><td data-i18n="sidebar.context.none"></td></tr>').appendTo(nodeSection.table).i18n();
-            }
-            nodeSection.timestamp.html("&nbsp;");
-
-        }
-    }
-    function updateFlow(flow) {
-        currentFlow = flow;
-        if (flow) {
-            updateEntry(flowSection,"context/flow/"+flow.id,flow.id);
-        } else {
-            updateEntry(flowSection)
-        }
-    }
-
-    function refreshEntry(section,baseUrl,id) {
-
-        var contextStores = RED.settings.context.stores;
-        var container = section.table;
-
-        $.getJSON(baseUrl, function(data) {
-            $(container).empty();
-            var sortedData = {};
-            for (var store in data) {
-                if (data.hasOwnProperty(store)) {
-                    for (var key in data[store]) {
-                        if (data[store].hasOwnProperty(key)) {
-                            if (!sortedData.hasOwnProperty(key)) {
-                                sortedData[key] = [];
-                            }
-                            data[store][key].store = store;
-                            sortedData[key].push(data[store][key])
-                        }
-                    }
-                }
-            }
-            var keys = Object.keys(sortedData);
-            keys.sort();
-            var l = keys.length;
-            for (var i = 0; i < l; i++) {
-                sortedData[keys[i]].forEach(function(v) {
-                    var k = keys[i];
-                    var l2 = sortedData[k].length;
-                    var propRow = $('<tr class="node-info-node-row"><td class="sidebar-context-property"></td><td></td></tr>').appendTo(container);
-                    var obj = $(propRow.children()[0]);
-                    obj.text(k);
-                    var tools = $('<span class="debug-message-tools button-group"></span>').appendTo(obj);
-                    var refreshItem = $('<button class="editor-button editor-button-small"><i class="fa fa-refresh"></i></button>').appendTo(tools).click(function(e) {
-                        e.preventDefault();
-                        e.stopPropagation();
-                        $.getJSON(baseUrl+"/"+k+"?store="+v.store, function(data) {
-                            $(propRow.children()[1]).empty();
-                            var payload = data.msg;
-                            var format = data.format;
-                            payload = RED.utils.decodeObject(payload,format);
-                            RED.utils.createObjectElement(payload, {
-                                typeHint: data.format,
-                                sourceId: id+"."+k
-                            }).appendTo(propRow.children()[1]);
-                        })
-                    });
-
-
-                    var payload = v.msg;
-                    var format = v.format;
-                    payload = RED.utils.decodeObject(payload,format);
-                    RED.utils.createObjectElement(payload, {
-                        typeHint: v.format,
-                        sourceId: id+"."+k
-                    }).appendTo(propRow.children()[1]);
-                    if (contextStores.length > 1) {
-                        $("<span>",{class:"sidebar-context-property-storename"}).text(v.store).appendTo($(propRow.children()[0]))
-                    }
-                });
-            }
-            if (l === 0) {
-                $('<tr class="node-info-node-row red-ui-search-empty blank" colspan="2"><td data-i18n="sidebar.context.empty"></td></tr>').appendTo(container).i18n();
-            }
-            $(section.timestamp).text(new Date().toLocaleString());
-        });
-    }
-    function updateEntry(section,baseUrl,id) {
-        var container = section.table;
-        if (id) {
-            refreshEntry(section,baseUrl,id);
-        } else {
-            $(container).empty();
-            $('<tr class="node-info-node-row red-ui-search-empty blank" colspan="2"><td data-i18n="sidebar.context.none"></td></tr>').appendTo(container).i18n();
-        }
-    }
-
-
-
-    function show() {
-        RED.sidebar.show("context");
-    }
-    return {
-        init: init
-    }
-})();

editor/js/ui/tab-info.js

@@ -221,7 +221,7 @@ RED.sidebar.info = (function() {
 
                                         var div = $('<span>',{class:""}).appendTo(container);
                                         var nodeDiv = $('<div>',{class:"palette_node palette_node_small"}).appendTo(div);
-                                        var colour = RED.utils.getNodeColor(configNode.type,configNode._def);
+                                        var colour = configNode._def.color;
                                         var icon_url = RED.utils.getNodeIcon(configNode._def);
                                         nodeDiv.css({'backgroundColor':colour, "cursor":"pointer"});
                                         var iconContainer = $('<div/>',{class:"palette_icon_container"}).appendTo(nodeDiv);
@@ -280,7 +280,8 @@ RED.sidebar.info = (function() {
             if (infoText) {
                 setInfoText(infoText);
             }
-            $(".sidebar-node-info-stack").scrollTop(0);
+
+
             $(".node-info-property-header").click(function(e) {
                 e.preventDefault();
                 expandedSections["property"] = !expandedSections["property"];
@@ -394,9 +395,10 @@ RED.sidebar.info = (function() {
     function set(html,title) {
         // tips.stop();
         // sections.show();
+        // nodeSection.container.hide();
+        infoSection.title.text(title||"");
         refresh(null);
-        nodeSection.container.hide();
-        infoSection.title.text(title||RED._("sidebar.info.info"));
+        $(infoSection.content).empty();
         setInfoText(html);
         $(".sidebar-node-info-stack").scrollTop(0);
     }

editor/js/ui/typeSearch.js

@@ -128,7 +128,7 @@ RED.typeSearch = (function() {
                 var div = $('<a>',{href:'#',class:"red-ui-search-result"}).appendTo(container);
 
                 var nodeDiv = $('<div>',{class:"red-ui-search-result-node"}).appendTo(div);
-                var colour = RED.utils.getNodeColor(object.type,def);
+                var colour = def.color;
                 var icon_url = RED.utils.getNodeIcon(def);
                 nodeDiv.css('backgroundColor',colour);
 

editor/js/ui/utils.js

@@ -34,10 +34,6 @@ RED.utils = (function() {
                 result = $('<span class="debug-message-object-value debug-message-type-meta"></span>').text('buffer['+value.length+']');
             } else if (value.hasOwnProperty('type') && value.type === 'array' && value.hasOwnProperty('data')) {
                 result = $('<span class="debug-message-object-value debug-message-type-meta"></span>').text('array['+value.length+']');
-            } else if (value.hasOwnProperty('type') && value.type === 'function') {
-                result = $('<span class="debug-message-object-value debug-message-type-meta"></span>').text('function');
-            } else if (value.hasOwnProperty('type') && value.type === 'number') {
-                result = $('<span class="debug-message-object-value debug-message-type-number"></span>').text(value.data);
             } else {
                 result = $('<span class="debug-message-object-value debug-message-type-meta">object</span>');
             }
@@ -49,8 +45,6 @@ RED.utils = (function() {
                 subvalue = sanitize(value);
             }
             result = $('<span class="debug-message-object-value debug-message-type-string"></span>').html('"'+formatString(subvalue)+'"');
-        } else if (typeof value === 'number') {
-            result = $('<span class="debug-message-object-value debug-message-type-number"></span>').text(""+value);
         } else {
             result = $('<span class="debug-message-object-value debug-message-type-other"></span>').text(""+value);
         }
@@ -131,7 +125,7 @@ RED.utils = (function() {
             e.stopPropagation();
             RED.clipboard.copyText(msg,copyPayload,"clipboard.copyMessageValue");
         })
-        if (strippedKey !== undefined && strippedKey !== '') {
+        if (strippedKey !== '') {
             var isPinned = pinnedPaths[sourceId].hasOwnProperty(strippedKey);
 
             var pinPath = $('<button class="editor-button editor-button-small debug-message-tools-pin"><i class="fa fa-map-pin"></i></button>').appendTo(tools).click(function(e) {
@@ -298,18 +292,13 @@ RED.utils = (function() {
 
         var isArray = Array.isArray(obj);
         var isArrayObject = false;
-        if (obj && typeof obj === 'object' && obj.hasOwnProperty('type') && obj.hasOwnProperty('data') && ((obj.__enc__ && obj.type === 'array') || obj.type === 'Buffer')) {
+        if (obj && typeof obj === 'object' && obj.hasOwnProperty('type') && obj.hasOwnProperty('data') && ((obj.__encoded__ && obj.type === 'array') || obj.type === 'Buffer')) {
             isArray = true;
             isArrayObject = true;
         }
+
         if (obj === null || obj === undefined) {
             $('<span class="debug-message-type-null">'+obj+'</span>').appendTo(entryObj);
-        } else if (obj.__enc__ && obj.type === 'number') {
-            e = $('<span class="debug-message-type-number debug-message-object-header"></span>').text(obj.data).appendTo(entryObj);
-        } else if (typeHint === "function" || (obj.__enc__ && obj.type === 'function')) {
-            e = $('<span class="debug-message-type-meta debug-message-object-header"></span>').text("function").appendTo(entryObj);
-        } else if (typeHint === "internal" || (obj.__enc__ && obj.type === 'internal')) {
-            e = $('<span class="debug-message-type-meta debug-message-object-header"></span>').text("[internal]").appendTo(entryObj);
         } else if (typeof obj === 'string') {
             if (/[\t\n\r]/.test(obj)) {
                 element.addClass('collapsed');
@@ -354,7 +343,7 @@ RED.utils = (function() {
                 if (originalLength === undefined) {
                     originalLength = data.length;
                 }
-                if (data.__enc__) {
+                if (data.__encoded__) {
                     data = data.data;
                 }
                 type = obj.type.toLowerCase();
@@ -794,41 +783,6 @@ RED.utils = (function() {
         return RED.text.bidi.enforceTextDirectionWithUCC(l);
     }
 
-    var nodeColorCache = {};
-    function getNodeColor(type, def) {
-        var result = def.color;
-        var paletteTheme = RED.settings.theme('palette.theme') || [];
-        if (paletteTheme.length > 0) {
-            if (!nodeColorCache.hasOwnProperty(type)) {
-                nodeColorCache[type] = def.color;
-                var l = paletteTheme.length;
-                for (var i = 0; i < l; i++ ){
-                    var themeRule = paletteTheme[i];
-                    if (themeRule.hasOwnProperty('category')) {
-                        if (!themeRule.hasOwnProperty('_category')) {
-                            themeRule._category = new RegExp(themeRule.category);
-                        }
-                        if (!themeRule._category.test(def.category)) {
-                            continue;
-                        }
-                    }
-                    if (themeRule.hasOwnProperty('type')) {
-                        if (!themeRule.hasOwnProperty('_type')) {
-                            themeRule._type = new RegExp(themeRule.type);
-                        }
-                        if (!themeRule._type.test(type)) {
-                            continue;
-                        }
-                    }
-                    nodeColorCache[type] = themeRule.color || def.color;
-                    break;
-                }
-            }
-            result = nodeColorCache[type];
-        }
-        return result;
-    }
-
     function addSpinnerOverlay(container,contain) {
         var spinner = $('<div class="projects-dialog-spinner "><img src="red/images/spin.svg"/></div>').appendTo(container);
         if (contain) {
@@ -837,47 +791,6 @@ RED.utils = (function() {
         return spinner;
     }
 
-    function decodeObject(payload,format) {
-        if ((format === 'number') && (payload === "NaN")) {
-            payload = Number.NaN;
-        } else if ((format === 'number') && (payload === "Infinity")) {
-            payload = Infinity;
-        } else if ((format === 'number') && (payload === "-Infinity")) {
-            payload = -Infinity;
-        } else if (format === 'Object' || /^array/.test(format) || format === 'boolean' || format === 'number' ) {
-            payload = JSON.parse(payload);
-        } else if (/error/i.test(format)) {
-            payload = JSON.parse(payload);
-            payload = (payload.name?payload.name+": ":"")+payload.message;
-        } else if (format === 'null') {
-            payload = null;
-        } else if (format === 'undefined') {
-            payload = undefined;
-        } else if (/^buffer/.test(format)) {
-            var buffer = payload;
-            payload = [];
-            for (var c = 0; c < buffer.length; c += 2) {
-                payload.push(parseInt(buffer.substr(c, 2), 16));
-            }
-        }
-        return payload;
-    }
-
-    function parseContextKey(key) {
-        var parts = {};
-        var m = /^#:\((\S+?)\)::(.*)$/.exec(key);
-        if (m) {
-            parts.store = m[1];
-            parts.key = m[2];
-        } else {
-            parts.key = key;
-            if (RED.settings.context) {
-                parts.store = RED.settings.context.default;
-            }
-        }
-        return parts;
-    }
-
     return {
         createObjectElement: buildMessageElement,
         getMessageProperty: getMessageProperty,
@@ -887,9 +800,6 @@ RED.utils = (function() {
         getDefaultNodeIcon: getDefaultNodeIcon,
         getNodeIcon: getNodeIcon,
         getNodeLabel: getNodeLabel,
-        getNodeColor: getNodeColor,
-        addSpinnerOverlay: addSpinnerOverlay,
-        decodeObject: decodeObject,
-        parseContextKey: parseContextKey
+        addSpinnerOverlay: addSpinnerOverlay
     }
 })();

editor/js/ui/view-navigator.js

@@ -46,7 +46,7 @@
              .attr("y",function(d) { return (d.y-d.h/2)/nav_scale })
              .attr("width",function(d) { return Math.max(9,d.w/nav_scale) })
              .attr("height",function(d) { return Math.max(3,d.h/nav_scale) })
-             .attr("fill",function(d) { return RED.utils.getNodeColor(d.type,d._def);})
+             .attr("fill",function(d) { return d._def.color;})
          });
      }
      function onScroll() {
@@ -65,28 +65,13 @@
                       .attr('height',chartSize[1]/nav_scale/scaleFactor)
          }
      }
-     function toggle() {
-         if (!isShowing) {
-             isShowing = true;
-             $("#btn-navigate").addClass("selected");
-             resizeNavBorder();
-             refreshNodes();
-             $("#chart").on("scroll",onScroll);
-             navContainer.fadeIn(200);
-         } else {
-             isShowing = false;
-             navContainer.fadeOut(100);
-             $("#chart").off("scroll",onScroll);
-             $("#btn-navigate").removeClass("selected");
-         }
-     }
 
      return {
          init: function() {
 
              $(window).resize(resizeNavBorder);
              RED.events.on("sidebar:resize",resizeNavBorder);
-             RED.actions.add("core:toggle-navigator",toggle);
+
              var hideTimeout;
 
              navContainer = $('<div>').css({
@@ -156,12 +141,23 @@
 
             $("#btn-navigate").click(function(evt) {
                 evt.preventDefault();
-                toggle();
+                if (!isShowing) {
+                    isShowing = true;
+                    $("#btn-navigate").addClass("selected");
+                    resizeNavBorder();
+                    refreshNodes();
+                    $("#chart").on("scroll",onScroll);
+                    navContainer.fadeIn(200);
+                } else {
+                    isShowing = false;
+                    navContainer.fadeOut(100);
+                    $("#chart").off("scroll",onScroll);
+                    $("#btn-navigate").removeClass("selected");
+                }
             })
         },
         refresh: refreshNodes,
-        resize: resizeNavBorder,
-        toggle: toggle
+        resize: resizeNavBorder
     }
 
 

editor/js/ui/view.js

@@ -59,9 +59,7 @@ RED.view = (function() {
         dblClickPrimed = null,
         clickTime = 0,
         clickElapsed = 0,
-        scroll_position = [],
-        quickAddActive = false,
-        quickAddLink = null;
+        scroll_position;
 
     var clipboard = "";
 
@@ -464,82 +462,6 @@ RED.view = (function() {
         RED.actions.add("core:step-selection-left", function() { moveSelection(-20,0);});
     }
 
-    function generateLinkPath(origX,origY, destX, destY, sc) {
-        var dy = destY-origY;
-        var dx = destX-origX;
-        var delta = Math.sqrt(dy*dy+dx*dx);
-        var scale = lineCurveScale;
-        var scaleY = 0;
-        if (dx*sc > 0) {
-            if (delta < node_width) {
-                scale = 0.75-0.75*((node_width-delta)/node_width);
-                // scale += 2*(Math.min(5*node_width,Math.abs(dx))/(5*node_width));
-                // if (Math.abs(dy) < 3*node_height) {
-                //     scaleY = ((dy>0)?0.5:-0.5)*(((3*node_height)-Math.abs(dy))/(3*node_height))*(Math.min(node_width,Math.abs(dx))/(node_width)) ;
-                // }
-            }
-        } else {
-            scale = 0.4-0.2*(Math.max(0,(node_width-Math.min(Math.abs(dx),Math.abs(dy)))/node_width));
-        }
-        if (dx*sc > 0) {
-            return "M "+origX+" "+origY+
-                " C "+(origX+sc*(node_width*scale))+" "+(origY+scaleY*node_height)+" "+
-                (destX-sc*(scale)*node_width)+" "+(destY-scaleY*node_height)+" "+
-                destX+" "+destY
-        } else {
-
-            var midX = Math.floor(destX-dx/2);
-            var midY = Math.floor(destY-dy/2);
-            //
-            if (dy === 0) {
-                midY = destY + node_height;
-            }
-            var cp_height = node_height/2;
-            var y1 = (destY + midY)/2
-            var topX =origX + sc*node_width*scale;
-            var topY = dy>0?Math.min(y1 - dy/2 , origY+cp_height):Math.max(y1 - dy/2 , origY-cp_height);
-            var bottomX = destX - sc*node_width*scale;
-            var bottomY = dy>0?Math.max(y1, destY-cp_height):Math.min(y1, destY+cp_height);
-            var x1 = (origX+topX)/2;
-            var scy = dy>0?1:-1;
-            var cp = [
-                // Orig -> Top
-                [x1,origY],
-                [topX,dy>0?Math.max(origY, topY-cp_height):Math.min(origY, topY+cp_height)],
-                // Top -> Mid
-                // [Mirror previous cp]
-                [x1,dy>0?Math.min(midY, topY+cp_height):Math.max(midY, topY-cp_height)],
-                // Mid -> Bottom
-                // [Mirror previous cp]
-                [bottomX,dy>0?Math.max(midY, bottomY-cp_height):Math.min(midY, bottomY+cp_height)],
-                // Bottom -> Dest
-                // [Mirror previous cp]
-                [(destX+bottomX)/2,destY]
-            ];
-            if (cp[2][1] === topY+scy*cp_height) {
-                if (Math.abs(dy) < cp_height*10) {
-                    cp[1][1] = topY-scy*cp_height/2;
-                    cp[3][1] = bottomY-scy*cp_height/2;
-                }
-                cp[2][0] = topX;
-            }
-            return "M "+origX+" "+origY+
-                " C "+
-                   cp[0][0]+" "+cp[0][1]+" "+
-                   cp[1][0]+" "+cp[1][1]+" "+
-                   topX+" "+topY+
-                " S "+
-                   cp[2][0]+" "+cp[2][1]+" "+
-                   midX+" "+midY+
-               " S "+
-                  cp[3][0]+" "+cp[3][1]+" "+
-                  bottomX+" "+bottomY+
-                " S "+
-                    cp[4][0]+" "+cp[4][1]+" "+
-                    destX+" "+destY
-        }
-    }
-
 
     function addNode(type,x,y) {
         var m = /^subflow:(.+)$/.exec(type);
@@ -647,16 +569,14 @@ RED.view = (function() {
                     mouse_mode = RED.state.QUICK_JOINING;
                     $(window).on('keyup',disableQuickJoinEventHandler);
                 }
-                quickAddActive = true;
+
                 RED.typeSearch.show({
                     x:d3.event.clientX-mainPos.left-node_width/2,
                     y:d3.event.clientY-mainPos.top-node_height/2,
                     cancel: function() {
-                        quickAddActive = false;
                         resetMouseVars();
                     },
                     add: function(type) {
-                        quickAddActive = false;
                         var result = addNode(type);
                         if (!result) {
                             return;
@@ -665,10 +585,11 @@ RED.view = (function() {
                         var historyEvent = result.historyEvent;
                         nn.x = point[0];
                         nn.y = point[1];
-                        if (mouse_mode === RED.state.QUICK_JOINING || quickAddLink) {
-                            if (quickAddLink || drag_lines.length > 0) {
-                                var drag_line = quickAddLink||drag_lines[0];
+                        if (mouse_mode === RED.state.QUICK_JOINING) {
+                            if (drag_lines.length > 0) {
+                                var drag_line = drag_lines[0];
                                 var src = null,dst,src_port;
+
                                 if (drag_line.portType === PORT_TYPE_OUTPUT && nn.inputs > 0) {
                                     src = drag_line.node;
                                     src_port = drag_line.port;
@@ -683,9 +604,9 @@ RED.view = (function() {
                                     RED.nodes.addLink(link);
                                     historyEvent.links = [link];
                                     hideDragLines();
-                                    if (!quickAddLink && drag_line.portType === PORT_TYPE_OUTPUT && nn.outputs > 0) {
+                                    if (drag_line.portType === PORT_TYPE_OUTPUT && nn.outputs > 0) {
                                         showDragLines([{node:nn,port:0,portType:PORT_TYPE_OUTPUT}]);
-                                    } else if (!quickAddLink && drag_line.portType === PORT_TYPE_INPUT && nn.inputs > 0) {
+                                    } else if (drag_line.portType === PORT_TYPE_INPUT && nn.inputs > 0) {
                                         showDragLines([{node:nn,port:0,portType:PORT_TYPE_INPUT}]);
                                     } else {
                                         resetMouseVars();
@@ -703,9 +624,9 @@ RED.view = (function() {
                                     resetMouseVars();
                                 }
                             }
-                            quickAddLink = null;
                         }
 
+
                         RED.history.push(historyEvent);
                         RED.nodes.add(nn);
                         RED.editor.validateNode(nn);
@@ -870,7 +791,28 @@ RED.view = (function() {
 
                 var sc = (drag_line.portType === PORT_TYPE_OUTPUT)?1:-1;
 
-                drag_line.el.attr("d",generateLinkPath(drag_line.node.x+sc*drag_line.node.w/2,drag_line.node.y+portY,mousePos[0],mousePos[1],sc));
+                var dy = mousePos[1]-(drag_line.node.y+portY);
+                var dx = mousePos[0]-(drag_line.node.x+sc*drag_line.node.w/2);
+                var delta = Math.sqrt(dy*dy+dx*dx);
+                var scale = lineCurveScale;
+                var scaleY = 0;
+
+                if (delta < node_width) {
+                    scale = 0.75-0.75*((node_width-delta)/node_width);
+                }
+                if (dx*sc < 0) {
+                    scale += 2*(Math.min(5*node_width,Math.abs(dx))/(5*node_width));
+                    if (Math.abs(dy) < 3*node_height) {
+                        scaleY = ((dy>0)?0.5:-0.5)*(((3*node_height)-Math.abs(dy))/(3*node_height))*(Math.min(node_width,Math.abs(dx))/(node_width)) ;
+                    }
+                }
+
+                drag_line.el.attr("d",
+                    "M "+(drag_line.node.x+sc*drag_line.node.w/2)+" "+(drag_line.node.y+portY)+
+                    " C "+(drag_line.node.x+sc*(drag_line.node.w/2+node_width*scale))+" "+(drag_line.node.y+portY+scaleY*node_height)+" "+
+                    (mousePos[0]-sc*(scale)*node_width)+" "+(mousePos[1]-scaleY*node_height)+" "+
+                    mousePos[0]+" "+mousePos[1]
+                    );
             }
             d3.event.preventDefault();
         } else if (mouse_mode == RED.state.MOVING) {
@@ -1470,9 +1412,6 @@ RED.view = (function() {
     function disableQuickJoinEventHandler(evt) {
         // Check for ctrl (all browsers), "Meta" (Chrome/FF), keyCode 91 (Safari)
         if (evt.keyCode === 17 || evt.key === "Meta" || evt.keyCode === 91) {
-            if (quickAddActive && drag_lines.length > 0) {
-                quickAddLink = drag_lines[0];
-            }
             resetMouseVars();
             hideDragLines();
             redraw();
@@ -1484,10 +1423,6 @@ RED.view = (function() {
         //console.log(d,portType,portIndex);
         // disable zoom
         //vis.call(d3.behavior.zoom().on("zoom"), null);
-        if (d3.event.button === 1) {
-            return;
-        }
-
         mousedown_node = d;
         mousedown_port_type = portType;
         mousedown_port_index = portIndex || 0;
@@ -1719,9 +1654,6 @@ RED.view = (function() {
 
     function nodeMouseDown(d) {
         focusView();
-        if (d3.event.button === 1) {
-            return;
-        }
         //var touch0 = d3.event;
         //var pos = [touch0.pageX,touch0.pageY];
         //RED.touch.radialMenu.show(d3.select(this),pos);
@@ -2038,7 +1970,7 @@ RED.view = (function() {
                             .attr("ry",4)
                             .attr("width",16)
                             .attr("height",node_height-12)
-                            .attr("fill",function(d) { return RED.utils.getNodeColor(d.type,d._def); /*d._def.color;*/})
+                            .attr("fill",function(d) { return d._def.color;})
                             .attr("cursor","pointer")
                             .on("mousedown",function(d) {if (!lasso && isButtonEnabled(d)) {focusView();d3.select(this).attr("fill-opacity",0.2);d3.event.preventDefault(); d3.event.stopPropagation();}})
                             .on("mouseup",function(d) {if (!lasso && isButtonEnabled(d)) { d3.select(this).attr("fill-opacity",0.4);d3.event.preventDefault();d3.event.stopPropagation();}})
@@ -2059,7 +1991,7 @@ RED.view = (function() {
                         .classed("node_unknown",function(d) { return d.type == "unknown"; })
                         .attr("rx", 5)
                         .attr("ry", 5)
-                        .attr("fill",function(d) { return RED.utils.getNodeColor(d.type,d._def); /*d._def.color;*/})
+                        .attr("fill",function(d) { return d._def.color;})
                         .on("mouseup",nodeMouseUp)
                         .on("mousedown",nodeMouseDown)
                         .on("touchstart",function(d) {
@@ -2456,17 +2388,32 @@ RED.view = (function() {
                         var numOutputs = d.source.outputs || 1;
                         var sourcePort = d.sourcePort || 0;
                         var y = -((numOutputs-1)/2)*13 +13*sourcePort;
+
+                        var dy = d.target.y-(d.source.y+y);
+                        var dx = (d.target.x-d.target.w/2)-(d.source.x+d.source.w/2);
+                        var delta = Math.sqrt(dy*dy+dx*dx);
+                        var scale = lineCurveScale;
+                        var scaleY = 0;
+                        if (delta < node_width) {
+                            scale = 0.75-0.75*((node_width-delta)/node_width);
+                        }
+
+                        if (dx < 0) {
+                            scale += 2*(Math.min(5*node_width,Math.abs(dx))/(5*node_width));
+                            if (Math.abs(dy) < 3*node_height) {
+                                scaleY = ((dy>0)?0.5:-0.5)*(((3*node_height)-Math.abs(dy))/(3*node_height))*(Math.min(node_width,Math.abs(dx))/(node_width)) ;
+                            }
+                        }
+
                         d.x1 = d.source.x+d.source.w/2;
                         d.y1 = d.source.y+y;
                         d.x2 = d.target.x-d.target.w/2;
                         d.y2 = d.target.y;
 
-                        // return "M "+d.x1+" "+d.y1+
-                        //     " C "+(d.x1+scale*node_width)+" "+(d.y1+scaleY*node_height)+" "+
-                        //     (d.x2-scale*node_width)+" "+(d.y2-scaleY*node_height)+" "+
-                        //     d.x2+" "+d.y2;
-
-                        return generateLinkPath(d.x1,d.y1,d.x2,d.y2,1);
+                        return "M "+d.x1+" "+d.y1+
+                            " C "+(d.x1+scale*node_width)+" "+(d.y1+scaleY*node_height)+" "+
+                            (d.x2-scale*node_width)+" "+(d.y2-scaleY*node_height)+" "+
+                            d.x2+" "+d.y2;
                     });
                 }
             })

editor/sass/bootstrap.scss

@@ -19,7 +19,3 @@
 div.btn-group, a.btn {
    @include disable-selection;
 }
-
-.dropdown-menu>li>a {
-    color: #444;
-}

editor/sass/debug.scss

@@ -64,22 +64,22 @@
             display: inline-block;
         }
     }
-}
-.debug-message-row {
-    .debug-message-tools-pin {
-        display: none;
-    }
-    &.debug-message-row-pinned .debug-message-tools-pin {
-        display: inline-block;
-    }
-    &:hover {
-        background: #f3f3f3;
-        &>.debug-message-tools {
-            .debug-message-tools-copy {
-                display: inline-block;
-            }
-            .debug-message-tools-pin {
-                display: inline-block;
+    .debug-message-row {
+        .debug-message-tools-pin {
+            display: none;
+        }
+        &.debug-message-row-pinned .debug-message-tools-pin {
+            display: inline-block;
+        }
+        &:hover {
+            background: #f3f3f3;
+            &>.debug-message-tools {
+                .debug-message-tools-copy {
+                    display: inline-block;
+                }
+                .debug-message-tools-pin {
+                    display: inline-block;
+                }
             }
         }
     }

editor/sass/flow.scss

@@ -248,7 +248,7 @@
 
 .link_outline {
     stroke: #fff;
-    stroke-width: 5;
+    stroke-width: 4;
     cursor: crosshair;
     fill: none;
     pointer-events: none;

editor/sass/mixins.scss

@@ -134,18 +134,15 @@
     color: $workspace-button-toggle-color !important;
     background:$workspace-button-background-active;
     margin-bottom: 1px;
-
-    &.selected:not(.disabled):not(:disabled) {
+    &.selected:not(.disabled) {
         color: $workspace-button-toggle-color-selected !important;
         background: $workspace-button-background;
         border-bottom-width: 2px;
         border-bottom-color: $form-input-border-selected-color;
         margin-bottom: 0;
-        &:not(.single) {
-            cursor: default;
-        }
+        cursor: default;
     }
-    &.disabled,&:disabled {
+    &.disabled {
         color: $workspace-button-toggle-color-disabled !important;
     }
 }

editor/sass/palette.scss

@@ -90,14 +90,13 @@
     text-align: left;
     padding: 9px;
     font-weight: bold;
-    padding-left: 30px;
     overflow: hidden;
-    user-select: none;
+    white-space: nowrap;
+    text-overflow: ellipsis;
+
 }
 .palette-header > i {
-    position: absolute;
-    left: 11px;
-    top: 12px;
+    margin: 3px 10px 3px 3px;
     -webkit-transition: all 0.2s ease-in-out;
     -moz-transition: all 0.2s ease-in-out;
     -o-transition: all 0.2s ease-in-out;

editor/sass/style.scss

@@ -40,7 +40,6 @@
 @import "panels";
 @import "tabs";
 @import "tab-config";
-@import "tab-context";
 @import "tab-info";
 @import "popover";
 @import "flow";

editor/sass/tab-context.scss

@@ -1,54 +0,0 @@
-/**
- * Copyright JS Foundation and other contributors, http://js.foundation
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
-
-.sidebar-context-stack {
-    position: absolute;
-    top: 0;
-    bottom: 0;
-    left: 0;
-    right: 0;
-    overflow-y: scroll;
-
-    .palette-category {
-        &:not(.palette-category-expanded) button {
-            display: none;
-        }
-    }
-}
-
-.sidebar-context-property {
-    position: relative;
-    .debug-message-tools {
-        right: 0px;
-        margin-right: 5px;
-        display: none;
-    }
-    &:hover .debug-message-tools {
-        display: inline-block;
-    }
-}
-.sidebar-context-updated {
-    text-align: right;
-    font-size: 11px;
-    color: #bbb;
-    padding: 1px 3px;
-}
-.sidebar-context-property-storename {
-    display: block;
-    font-size: 0.8em;
-    font-style: italic;
-    color: #aaa;
-}

editor/sass/tabs.scss

@@ -214,11 +214,12 @@
     border-bottom: 1px solid $primary-border-color;
     z-index: 2;
     a {
-        @include workspace-button-toggle;
+        @include workspace-button;
         line-height: 26px;
         height: 28px;
         width: 28px;
         margin: 4px 3px 3px;
+        border: 1px solid $primary-border-color;
         z-index: 2;
         &.red-ui-tab-link-button {
             &:not(.active) {

editor/sass/ui/common/typedInput.scss

@@ -23,7 +23,7 @@
     margin: 0;
     vertical-align: middle;
     box-sizing: border-box;
-    overflow:visible;
+    overflow:hidden;
     position: relative;
     .red-ui-typedInput-input {
         position: absolute;
@@ -43,7 +43,6 @@
         border-bottom-left-radius: 0;
         box-shadow: none;
         vertical-align: middle;
-        // backgroun/d: #f0fff0;
     }
 
     &.red-ui-typedInput-focus:not(.input-error) {
@@ -64,7 +63,7 @@
         line-height: 32px;
         vertical-align: middle;
         color: #555;
-        i.red-ui-typedInput-icon {
+        i {
             position: relative;
             top: -3px;
             margin-left: 1px;
@@ -77,11 +76,11 @@
         }
         &.disabled {
             cursor: default;
-            i.red-ui-typedInput-icon {
+            i {
                 color: #bbb;
             }
         }
-        .red-ui-typedInput-type-label,.red-ui-typedInput-option-label {
+        span {
             display: inline-block;
             height: 100%;
             padding: 0 1px 0 5px;
@@ -122,25 +121,26 @@
         border-bottom-right-radius: 4px;
         padding: 0 0 0 0;
         position:absolute;
-        right: 0;
+        width: calc( 100% );
+
+        i {
+            position:absolute;
+            right: 4px;
+            top: 7px;
+        }
         .red-ui-typedInput-option-label {
-            background:$typedInput-button-background;
+            background:#fff;
             position:absolute;
             left:0;
             right:23px;
             top: 0;
-            padding: 0 5px 0 8px;
-            i.red-ui-typedInput-icon {
-                margin-right: 4px;
-                margin-top: 4px;
-            }
+            padding: 0 5px 0 5px;
         }
         .red-ui-typedInput-option-caret {
             top: 0;
             position: absolute;
             right: 0;
             width: 17px;
-            padding-left: 6px;
         }
         &:focus {
             box-shadow: none;
@@ -175,7 +175,4 @@
             background: $typedInput-button-background-active;
         }
     }
-    .red-ui-typedInput-icon {
-        margin-right: 4px;
-    }
 }

editor/sass/userSettings.scss

@@ -61,13 +61,7 @@
 }
 
 #user-settings-tab-view {
-    position: absolute;
-    top:0;
-    right: 0;
-    left: 0;
-    bottom: 0;
     padding: 8px 20px 20px;
-    overflow-y: scroll;
 }
 .user-settings-row {
     padding: 5px 10px 2px;

editor/templates/index.mst

@@ -51,7 +51,7 @@
             <a class="workspace-footer-button" id="btn-zoom-out" href="#"><i class="fa fa-minus"></i></a>
             <a class="workspace-footer-button" id="btn-zoom-zero" href="#"><i class="fa fa-circle-o"></i></a>
             <a class="workspace-footer-button" id="btn-zoom-in" href="#"><i class="fa fa-plus"></i></a>
-            <a class="workspace-footer-button-toggle single" id="btn-navigate" href="#"><i class="fa fa-map-o"></i></a>
+            <a class="workspace-footer-button-toggle" id="btn-navigate" href="#"><i class="fa fa-map-o"></i></a>
         </div>
         <div id="editor-shade" class="hide"></div>
     </div>
@@ -145,6 +145,76 @@
     </div>
     <div class="form-row form-tips" id="subflow-dialog-user-count"></div>
 </script>
+
+<script type="text/x-red" data-template-name="_expression">
+    <div id="node-input-expression-panels">
+        <div id="node-input-expression-panel-expr" class="red-ui-panel">
+            <div class="form-row" style="margin-bottom: 3px; text-align: right;">
+                <span class="node-input-expression-legacy"><i class="fa fa-exclamation-circle"></i> <span data-i18n="expressionEditor.compatMode"></span></span>
+                <button id="node-input-expression-reformat" class="editor-button editor-button-small"><span data-i18n="expressionEditor.format"></span></button>
+            </div>
+            <div class="form-row node-text-editor-row">
+                <div class="node-text-editor" id="node-input-expression"></div>
+            </div>
+        </div>
+        <div id="node-input-expression-panel-info" class="red-ui-panel">
+            <div class="form-row">
+                <ul id="node-input-expression-tabs"></ul>
+                <div id="node-input-expression-tab-help" class="node-input-expression-tab-content hide">
+                    <div>
+                        <select id="node-input-expression-func"></select>
+                        <button id="node-input-expression-func-insert" class="editor-button" data-i18n="expressionEditor.insert"></button>
+                    </div>
+                    <div id="node-input-expression-help"></div>
+                </div>
+                <div id="node-input-expression-tab-test" class="node-input-expression-tab-content hide">
+                    <div>
+                        <span style="display: inline-block; width: calc(50% - 5px);">
+                            <span data-i18n="expressionEditor.data"></span>
+                            <button style="float: right; margin-right: 5px;" id="node-input-example-reformat" class="editor-button editor-button-small"><span data-i18n="jsonEditor.format"></span></button>
+                        </span>
+                        <span style="display: inline-block; width: calc(50% - 5px);" data-i18n="expressionEditor.result"></span>
+                    </div>
+                    <div style="display: inline-block; width: calc(50% - 5px);" class="node-text-editor" id="node-input-expression-test-data"></div>
+                    <div style="display: inline-block; width: calc(50% - 5px);" class="node-text-editor" id="node-input-expression-test-result"></div>
+                </div>
+            </div>
+        </div>
+    </div>
+</script>
+<script type="text/x-red" data-template-name="_json">
+    <div class="form-row" style="margin-bottom: 3px; text-align: right;">
+        <button id="node-input-json-reformat" class="editor-button editor-button-small"><span data-i18n="jsonEditor.format"></span></button>
+    </div>
+    <div class="form-row node-text-editor-row">
+        <div style="height: 200px;min-height: 150px;" class="node-text-editor" id="node-input-json"></div>
+    </div>
+</script>
+<script type="text/x-red" data-template-name="_markdown">
+    <div class="form-row" id="node-input-markdown-title" style="margin-bottom: 3px; text-align: right;">
+
+    </div>
+    <div class="form-row node-text-editor-row">
+        <div style="height: 200px;min-height: 150px;" class="node-text-editor" id="node-input-markdown"></div>
+    </div>
+</script>
+<script type="text/x-red" data-template-name="_buffer">
+    <div id="node-input-buffer-panels">
+        <div id="node-input-buffer-panel-str" class="red-ui-panel">
+            <div class="form-row" style="margin-bottom: 3px; text-align: right;">
+                <span class="node-input-buffer-type"><i class="fa fa-exclamation-circle"></i> <span id="node-input-buffer-type-string" data-i18n="bufferEditor.modeString"></span><span id="node-input-buffer-type-array" data-i18n="bufferEditor.modeArray"></span></span>
+            </div>
+            <div class="form-row node-text-editor-row">
+                <div class="node-text-editor" id="node-input-buffer-str"></div>
+            </div>
+        </div>
+        <div id="node-input-buffer-panel-bin" class="red-ui-panel">
+            <div class="form-row node-text-editor-row" style="margin-top: 10px">
+                <div class="node-text-editor" id="node-input-buffer-bin"></div>
+            </div>
+        </div>
+    </div>
+</script>
 <script src="vendor/vendor.js"></script>
 <script src="vendor/jsonata/jsonata.min.js"></script>
 <script src="vendor/ace/ace.js"></script>

nodes/core/analysis/72-sentiment.html

@@ -1,57 +0,0 @@
-
-<script type="text/x-red" data-template-name="sentiment">
-    <div class="form-row">
-        <label for="node-input-property"><i class="fa fa-ellipsis-h"></i> <span data-i18n="node-red:common.label.property"></span></label>
-        <input type="text" id="node-input-property" style="width:70%;"/>
-    </div>
-    <div class="form-row">
-        <label for="node-input-name"><i class="fa fa-tag"></i> <span data-i18n="common.label.name"></span></label>
-        <input type="text" id="node-input-name" data-i18n="[placeholder]common.label.name">
-    </div>
-</script>
-
-<script type="text/x-red" data-help-name="sentiment">
-    <p>Analyses the chosen property, default <code>payload</code>, and adds a <code>sentiment</code> object.</p>
-    <h3>Outputs</h3>
-    <dl class="message-properties">
-        <dt>sentiment <span class="property-type">object</span></dt>
-        <dd>contains the resulting AFINN-111 sentiment.</dd>
-        <dt>sentiment.score <span class="property-type">number</span></dt>
-        <dd>the sentiment score.</dd>
-    </dl>
-    <h3>Inputs</h3>
-    <dl class="message-properties">
-        <dt>overrides <span class="property-type">object</span></dt>
-        <dd>an object of word score overrides can be supplied - <code>{ word:score,... }</code>.</dd>
-    </dl>
-    <h3>Details</h3>
-    <p>A score greater than zero is positive and less than zero is negative.</p>
-    <p>The score typically ranges from -5 to +5, but can go higher and lower.</p>
-    <p>See <a href="https://github.com/thisandagain/sentiment/blob/master/README.md" target="_blank">the Sentiment docs here</a>.</p>
-</script>
-
-<script type="text/javascript">
-    RED.nodes.registerType('sentiment',{
-        category: 'analysis-function',
-        color:"#E6E0F8",
-        defaults: {
-            name: {value:""},
-            property: {value:"payload",required:true}
-        },
-        inputs:1,
-        outputs:1,
-        icon: "arrow-in.png",
-        label: function() {
-            return this.name||"sentiment";
-        },
-        labelStyle: function() {
-            return this.name?"node_label_italic":"";
-        },
-        oneditprepare: function() {
-            if (this.property === undefined) {
-                $("#node-input-property").val("payload");
-            }
-            $("#node-input-property").typedInput({default:'msg',types:['msg']});
-        }
-    });
-</script>

nodes/core/analysis/72-sentiment.js

@@ -1,23 +0,0 @@
-
-module.exports = function(RED) {
-    "use strict";
-    var sentiment = require('sentiment');
-
-    function SentimentNode(n) {
-        RED.nodes.createNode(this,n);
-        this.property = n.property||"payload";
-        var node = this;
-
-        this.on("input", function(msg) {
-            var value = RED.util.getMessageProperty(msg,node.property);
-            if (value !== undefined) {
-                sentiment(value, msg.overrides || null, function (err, result) {
-                    msg.sentiment = result;
-                    node.send(msg);
-                });
-            }
-            else { node.send(msg); } // If no matching property - just pass it on.
-        });
-    }
-    RED.nodes.registerType("sentiment",SentimentNode);
-}

nodes/core/core/20-inject.html

@@ -237,9 +237,10 @@ If you want every 20 minutes from now - use the <i>"interval"</i> option.</p>
                 } else {
                     return this._("inject.timestamp")+suffix;
                 }
-            } else if (this.payloadType === 'flow' || this.payloadType === 'global') {
-                var key = RED.utils.parseContextKey(this.payload);
-                return this.payloadType+"."+key.key+suffix;
+            } else if (this.payloadType === 'flow' && this.payload.length < 19) {
+                return 'flow.'+this.payload+suffix;
+            } else if (this.payloadType === 'global' && this.payload.length < 17) {
+                return 'global.'+this.payload+suffix;
             } else {
                 return this._("inject.inject")+suffix;
             }
@@ -501,13 +502,7 @@ If you want every 20 minutes from now - use the <i>"interval"</i> option.</p>
                 if (this.changed) {
                     return RED.notify(RED._("notification.warning", {message:RED._("notification.warnings.undeployedChanges")}),"warning");
                 }
-                var payload = this.payload;
-                if ((this.payloadType === 'flow') ||
-                    (this.payloadType === 'global')) {
-                    var key = RED.utils.parseContextKey(payload);
-                    payload = this.payloadType+"."+key.key;
-                }
-                var label = (this.name||payload);
+                var label = (this.name||this.payload);
                 if (label.length > 30) {
                     label = label.substring(0,50)+"...";
                 }

nodes/core/core/20-inject.js

@@ -63,33 +63,21 @@ module.exports = function(RED) {
         }
 
         this.on("input",function(msg) {
-            msg.topic = this.topic;
-            if (this.payloadType !== 'flow' && this.payloadType !== 'global') {
-                try {
-                    if ( (this.payloadType == null && this.payload === "") || this.payloadType === "date") {
-                        msg.payload = Date.now();
-                    } else if (this.payloadType == null) {
-                        msg.payload = this.payload;
-                    } else if (this.payloadType === 'none') {
-                        msg.payload = "";
-                    } else {
-                        msg.payload = RED.util.evaluateNodeProperty(this.payload,this.payloadType,this,msg);
-                    }
-                    this.send(msg);
-                    msg = null;
-                } catch(err) {
-                    this.error(err,msg);
+            try {
+                msg.topic = this.topic;
+                if ( (this.payloadType == null && this.payload === "") || this.payloadType === "date") {
+                    msg.payload = Date.now();
+                } else if (this.payloadType == null) {
+                    msg.payload = this.payload;
+                } else if (this.payloadType === 'none') {
+                    msg.payload = "";
+                } else {
+                    msg.payload = RED.util.evaluateNodeProperty(this.payload,this.payloadType,this,msg);
                 }
-            } else {
-                RED.util.evaluateNodeProperty(this.payload,this.payloadType,this,msg, function(err,res) {
-                    if (err) {
-                        node.error(err,msg);
-                    } else {
-                        msg.payload = res;
-                        node.send(msg);
-                    }
-
-                });
+                this.send(msg);
+                msg = null;
+            } catch(err) {
+                this.error(err,msg);
             }
         });
     }

nodes/core/core/58-debug.html

@@ -156,7 +156,7 @@
                 toolbar: uiComponents.footer,
                 enableOnEdit: true,
                 pinned: true,
-                iconClass: "fa fa-bug"
+                iconClass: "fa fa-list-alt"
             });
             RED.actions.add("core:show-debug-tab",function() { RED.sidebar.show('debug'); });
 

nodes/core/core/58-debug.js

@@ -4,6 +4,7 @@ module.exports = function(RED) {
     var util = require("util");
     var events = require("events");
     var path = require("path");
+    var safeJSONStringify = require("json-stringify-safe");
     var debuglength = RED.settings.debugMaxLength || 1000;
     var useColors = RED.settings.debugUseColors || false;
     util.inspect.styles.boolean = "red";
@@ -103,7 +104,111 @@ module.exports = function(RED) {
     function sendDebug(msg) {
         // don't put blank errors in sidebar (but do add to logs)
         //if ((msg.msg === "") && (msg.hasOwnProperty("level")) && (msg.level === 20)) { return; }
-        msg = RED.util.encodeObject(msg,{maxLength:debuglength});
+        if (msg.msg instanceof Error) {
+            msg.format = "error";
+            var errorMsg = {};
+            if (msg.msg.name) {
+                errorMsg.name = msg.msg.name;
+            }
+            if (msg.msg.hasOwnProperty('message')) {
+                errorMsg.message = msg.msg.message;
+            } else {
+                errorMsg.message = msg.msg.toString();
+            }
+            msg.msg = JSON.stringify(errorMsg);
+        } else if (msg.msg instanceof Buffer) {
+            msg.format = "buffer["+msg.msg.length+"]";
+            msg.msg = msg.msg.toString('hex');
+            if (msg.msg.length > debuglength) {
+                msg.msg = msg.msg.substring(0,debuglength);
+            }
+        } else if (msg.msg && typeof msg.msg === 'object') {
+            try {
+                msg.format = msg.msg.constructor.name || "Object";
+                // Handle special case of msg.req/res objects from HTTP In node
+                if (msg.format === "IncomingMessage" || msg.format === "ServerResponse") {
+                    msg.format = "Object";
+                }
+            } catch(err) {
+                msg.format = "Object";
+            }
+            if (/error/i.test(msg.format)) {
+                msg.msg = JSON.stringify({
+                    name: msg.msg.name,
+                    message: msg.msg.message
+                });
+            } else {
+                var isArray = util.isArray(msg.msg);
+                if (isArray) {
+                    msg.format = "array["+msg.msg.length+"]";
+                    if (msg.msg.length > debuglength) {
+                        // msg.msg = msg.msg.slice(0,debuglength);
+                        msg.msg = {
+                            __encoded__: true,
+                            type: "array",
+                            data: msg.msg.slice(0,debuglength),
+                            length: msg.msg.length
+                        }
+                    }
+                }
+                if (isArray || (msg.format === "Object")) {
+                    msg.msg = safeJSONStringify(msg.msg, function(key, value) {
+                        if (key === '_req' || key === '_res') {
+                            value = "[internal]"
+                        } else if (value instanceof Error) {
+                            value = value.toString()
+                        } else if (util.isArray(value) && value.length > debuglength) {
+                            value = {
+                                __encoded__: true,
+                                type: "array",
+                                data: value.slice(0,debuglength),
+                                length: value.length
+                            }
+                        } else if (typeof value === 'string') {
+                            if (value.length > debuglength) {
+                                value = value.substring(0,debuglength)+"...";
+                            }
+                        } else if (value && value.constructor) {
+                            if (value.type === "Buffer") {
+                                value.__encoded__ = true;
+                                value.length = value.data.length;
+                                if (value.length > debuglength) {
+                                    value.data = value.data.slice(0,debuglength);
+                                }
+                            } else if (value.constructor.name === "ServerResponse") {
+                                value = "[internal]"
+                            } else if (value.constructor.name === "Socket") {
+                                value = "[internal]"
+                            }
+                        }
+                        return value;
+                    }," ");
+                } else {
+                    try { msg.msg = msg.msg.toString(); }
+                    catch(e) { msg.msg = "[Type not printable]"; }
+                }
+            }
+        } else if (typeof msg.msg === "boolean") {
+            msg.format = "boolean";
+            msg.msg = msg.msg.toString();
+        } else if (typeof msg.msg === "number") {
+            msg.format = "number";
+            msg.msg = msg.msg.toString();
+        } else if (msg.msg === 0) {
+            msg.format = "number";
+            msg.msg = "0";
+        } else if (msg.msg === null || typeof msg.msg === "undefined") {
+            msg.format = (msg.msg === null)?"null":"undefined";
+            msg.msg = "(undefined)";
+        } else {
+            msg.format = "string["+msg.msg.length+"]";
+            if (msg.msg.length > debuglength) {
+                msg.msg = msg.msg.substring(0,debuglength)+"...";
+            }
+        }
+        // if (msg.msg.length > debuglength) {
+        //     msg.msg = msg.msg.substr(0,debuglength) +" ....";
+        // }
         RED.comms.publish("debug",msg);
     }
 

nodes/core/core/80-function.html

@@ -9,8 +9,7 @@
         <input type="hidden" id="node-input-func" autofocus="autofocus">
         <input type="hidden" id="node-input-noerr">
     </div>
-    <div class="form-row node-text-editor-row" style="position:relative">
-        <div style="position: absolute; right:0; bottom:calc(100% + 3px);"><button id="node-function-expand-js" class="editor-button editor-button-small"><i class="fa fa-expand"></i></button></div>
+    <div class="form-row node-text-editor-row">
         <div style="height: 250px; min-height:150px;" class="node-text-editor" id="node-input-func-editor" ></div>
     </div>
     <div class="form-row">
@@ -120,22 +119,6 @@
                 fields:['name','outputs']
             });
             this.editor.focus();
-
-            $("#node-function-expand-js").click(function(e) {
-                e.preventDefault();
-                var value = that.editor.getValue();
-                RED.editor.editJavaScript({
-                    value: value,
-                    cursor: that.editor.getCursorPosition(),
-                    complete: function(v,cursor) {
-                        that.editor.setValue(v, -1);
-                        that.editor.gotoLine(cursor.row+1,cursor.column,false);
-                        setTimeout(function() {
-                            that.editor.focus();
-                        },300);
-                    }
-                })
-            })
         },
         oneditsave: function() {
             var annot = this.editor.getSession().getAnnotations();

nodes/core/core/80-template.html

@@ -77,9 +77,7 @@
 }</pre>
     <p>The resulting property will be:
     <pre>Hello Fred. Today is Monday</pre>
-    <p>It is possible to use a property from the flow context or global context. Just use <code>{{flow.name}}</code> or
-    <code>{{global.name}}</code>, or for persistable store <code>store</code> use <code>{{flow[store].name}}</code> or
-    <code>{{global[store].name}}</code>.
+    <p>It is possible to use a property from the flow context or global context. Just use <code>{{flow.name}}</code> or <code>{{global.name}}</code>.
     <p><b>Note: </b>By default, <i>mustache</i> will escape any HTML entities in the values it substitutes.
        To prevent this, use <code>{{{triple}}}</code> braces.
 </script>

nodes/core/core/80-template.js

@@ -19,41 +19,15 @@ module.exports = function(RED) {
     var mustache = require("mustache");
     var yaml = require("js-yaml");
 
-    function extractTokens(tokens,set) {
-        set = set || new Set();
-        tokens.forEach(function(token) {
-            if (token[0] !== 'text') {
-                set.add(token[1]);
-                if (token.length > 4) {
-                    extractTokens(token[4],set);
-                }
-            }
-        });
-        return set;
-    }
-
-    function parseContext(key) {
-        var match = /^(flow|global)(\[(\w+)\])?\.(.+)/.exec(key);
-        if (match) {
-            var parts = {};
-            parts.type = match[1];
-            parts.store = (match[3] === '') ? "default" : match[3];
-            parts.field = match[4];
-            return parts;
-        }
-        return undefined;
-    }
 
     /**
-     * Custom Mustache Context capable to collect message property and node
+     * Custom Mustache Context capable to resolve message property and node
      * flow and global context
      */
-
-    function NodeContext(msg, nodeContext, parent, escapeStrings, cachedContextTokens) {
+    function NodeContext(msg, nodeContext, parent, escapeStrings) {
         this.msgContext = new mustache.Context(msg,parent);
         this.nodeContext = nodeContext;
         this.escapeStrings = escapeStrings;
-        this.cachedContextTokens = cachedContextTokens;
     }
 
     NodeContext.prototype = new mustache.Context();
@@ -74,18 +48,20 @@ module.exports = function(RED) {
                 return value;
             }
 
-            // try flow/global context:
-            var context = parseContext(name);
-            if (context) {
-                var type = context.type;
-                var store = context.store;
-                var field = context.field;
-                var target = this.nodeContext[type];
-                if (target) {
-                    return this.cachedContextTokens[name];
+            // try node context:
+            var dot = name.indexOf(".");
+            /* istanbul ignore else  */
+            if (dot > 0) {
+                var contextName = name.substr(0, dot);
+                var variableName = name.substr(dot + 1);
+
+                if (contextName === "flow" && this.nodeContext.flow) {
+                    return this.nodeContext.flow.get(variableName);
+                }
+                else if (contextName === "global" && this.nodeContext.global) {
+                    return this.nodeContext.global.get(variableName);
                 }
             }
-            return '';
         }
         catch(err) {
             throw err;
@@ -93,7 +69,7 @@ module.exports = function(RED) {
     }
 
     NodeContext.prototype.push = function push (view) {
-        return new NodeContext(view, this.nodeContext, this.msgContext, undefined, this.cachedContextTokens);
+        return new NodeContext(view, this.nodeContext,this.msgContext);
     };
 
     function TemplateNode(n) {
@@ -106,37 +82,9 @@ module.exports = function(RED) {
         this.outputFormat = n.output || "str";
 
         var node = this;
-
-        function output(msg,value) {
-            /* istanbul ignore else  */
-            if (node.outputFormat === "json") {
-                value = JSON.parse(value);
-            }
-            /* istanbul ignore else  */
-            if (node.outputFormat === "yaml") {
-                value = yaml.load(value);
-            }
-
-            if (node.fieldType === 'msg') {
-                RED.util.setMessageProperty(msg, node.field, value);
-                node.send(msg);
-            } else if ((node.fieldType === 'flow') ||
-                       (node.fieldType === 'global')) {
-                var context = RED.util.parseContextStore(node.field);
-                var target = node.context()[node.fieldType];
-                target.set(context.key, value, context.store, function (err) {
-                    if (err) {
-                        node.error(err, msg);
-                    } else {
-                        node.send(msg);
-                    }
-                });
-            }
-        }
-
         node.on("input", function(msg) {
-
             try {
+                var value;
                 /***
                 * Allow template contents to be defined externally
                 * through inbound msg.template IFF node.template empty
@@ -149,46 +97,34 @@ module.exports = function(RED) {
                 }
 
                 if (node.syntax === "mustache") {
-                    var is_json = (node.outputFormat === "json");
-                    var promises = [];
-                    var tokens = extractTokens(mustache.parse(template));
-                    var resolvedTokens = {};
-                    tokens.forEach(function(name) {
-                        var context = parseContext(name);
-                        if (context) {
-                            var type = context.type;
-                            var store = context.store;
-                            var field = context.field;
-                            var target = node.context()[type];
-                            if (target) {
-                                var promise = new Promise((resolve, reject) => {
-                                    target.get(field, store, (err, val) => {
-                                        if (err) {
-                                            reject(err);
-                                        } else {
-                                            resolvedTokens[name] = val;
-                                            resolve();
-                                        }
-                                    });
-                                });
-                                promises.push(promise);
-                                return;
-                            }
-                        }
-                    });
-
-                    Promise.all(promises).then(function() {
-                        var value = mustache.render(template, new NodeContext(msg, node.context(), null, is_json, resolvedTokens));
-                        output(msg, value);
-                    }).catch(function (err) {
-                        node.error(err.message,msg);
-                    });
+                    if (node.outputFormat === "json") {
+                        value = mustache.render(template,new NodeContext(msg, node.context(), null, true));
+                    } else {
+                        value = mustache.render(template,new NodeContext(msg, node.context(), null, false));
+                    }
                 } else {
-                    output(msg, template);
+                    value = template;
                 }
+                /* istanbul ignore else  */
+                if (node.outputFormat === "json") {
+                    value = JSON.parse(value);
+                }
+                /* istanbul ignore else  */
+                if (node.outputFormat === "yaml") {
+                    value = yaml.load(value);
+                }
+
+                if (node.fieldType === 'msg') {
+                    RED.util.setMessageProperty(msg,node.field,value);
+                } else if (node.fieldType === 'flow') {
+                    node.context().flow.set(node.field,value);
+                } else if (node.fieldType === 'global') {
+                    node.context().global.set(node.field,value);
+                }
+                node.send(msg);
             }
             catch(err) {
-                node.error(err.message, msg);
+                node.error(err.message);
             }
         });
     }

nodes/core/core/89-trigger.html

@@ -162,7 +162,7 @@
             $("#node-input-op1").typedInput({
                 default: 'str',
                 typeField: $("#node-input-op1type"),
-                types:['flow','global','str','num','bool','json','bin','date','env',
+                types:['flow','global','str','num','bool','json',
                     optionPayload,
                     optionNothing
                 ]
@@ -170,7 +170,7 @@
             $("#node-input-op2").typedInput({
                 default: 'str',
                 typeField: $("#node-input-op2type"),
-                types:['flow','global','str','num','bool','json','bin','date','env',
+                types:['flow','global','str','num','bool','json',
                     optionOriginalPayload,
                     optionLatestPayload,
                     optionNothing

nodes/core/core/89-trigger.js

@@ -76,43 +76,8 @@ module.exports = function(RED) {
         var node = this;
         node.topics = {};
 
-        var pendingMessages = [];
-        var activeMessagePromise = null;
-        var processMessageQueue = function(msg) {
-            if (msg) {
-                // A new message has arrived - add it to the message queue
-                pendingMessages.push(msg);
-                if (activeMessagePromise !== null) {
-                    // The node is currently processing a message, so do nothing
-                    // more with this message
-                    return;
-                }
-            }
-            if (pendingMessages.length === 0) {
-                // There are no more messages to process, clear the active flag
-                // and return
-                activeMessagePromise = null;
-                return;
-            }
-
-            // There are more messages to process. Get the next message and
-            // start processing it. Recurse back in to check for any more
-            var nextMsg = pendingMessages.shift();
-            activeMessagePromise = processMessage(nextMsg)
-                .then(processMessageQueue)
-                .catch((err) => {
-                    node.error(err,nextMsg);
-                    return processMessageQueue();
-                });
-        }
-
-        this.on('input', function(msg) {
-            processMessageQueue(msg);
-        });
-
-        var processMessage = function(msg) {
+        this.on("input", function(msg) {
             var topic = msg.topic || "_none";
-            var promise;
             if (node.bytopic === "all") { topic = "_none"; }
             node.topics[topic] = node.topics[topic] || {};
             if (msg.hasOwnProperty("reset") || ((node.reset !== '') && msg.hasOwnProperty("payload") && (msg.payload !== null) && msg.payload.toString && (msg.payload.toString() == node.reset)) ) {
@@ -123,88 +88,48 @@ module.exports = function(RED) {
             }
             else {
                 if (((!node.topics[topic].tout) && (node.topics[topic].tout !== 0)) || (node.loop === true)) {
-                    promise = Promise.resolve();
                     if (node.op2type === "pay" || node.op2type === "payl") { node.topics[topic].m2 = RED.util.cloneMessage(msg.payload); }
                     else if (node.op2Templated) { node.topics[topic].m2 = mustache.render(node.op2,msg); }
                     else if (node.op2type !== "nul") {
-                        promise = new Promise((resolve,reject) => {
-                            RED.util.evaluateNodeProperty(node.op2,node.op2type,node,msg,(err,value) => {
-                                if (err) {
-                                    reject(err);
-                                } else {
-                                    node.topics[topic].m2 = value;
-                                    resolve();
-                                }
-                            });
-                        });
+                        node.topics[topic].m2 = RED.util.evaluateNodeProperty(node.op2,node.op2type,node,msg);
                     }
 
-                    return promise.then(() => {
-                        promise = Promise.resolve();
-                        if (node.op1type === "pay") { }
-                        else if (node.op1Templated) { msg.payload = mustache.render(node.op1,msg); }
-                        else if (node.op1type !== "nul") {
-                            promise = new Promise((resolve,reject) => {
-                                RED.util.evaluateNodeProperty(node.op1,node.op1type,node,msg,(err,value) => {
-                                    if (err) {
-                                        reject(err);
-                                    } else {
-                                        msg.payload = value;
-                                        resolve();
-                                    }
-                                });
-                            });
-                        }
-                        return promise.then(() => {
-                            if (node.duration === 0) { node.topics[topic].tout = 0; }
-                            else if (node.loop === true) {
-                                /* istanbul ignore else  */
-                                if (node.topics[topic].tout) { clearInterval(node.topics[topic].tout); }
-                                /* istanbul ignore else  */
-                                if (node.op1type !== "nul") {
-                                    var msg2 = RED.util.cloneMessage(msg);
-                                    node.topics[topic].tout = setInterval(function() { node.send(RED.util.cloneMessage(msg2)); }, node.duration);
-                                }
-                            }
-                            else {
-                                if (!node.topics[topic].tout) {
-                                    node.topics[topic].tout = setTimeout(function() {
-                                        var msg2 = null;
-                                        if (node.op2type !== "nul") {
-                                            var promise = Promise.resolve();
-                                            msg2 = RED.util.cloneMessage(msg);
-                                            if (node.op2type === "flow" || node.op2type === "global") {
-                                                promise = new Promise((resolve,reject) => {
-                                                    RED.util.evaluateNodeProperty(node.op2,node.op2type,node,msg,(err,value) => {
-                                                        if (err) {
-                                                            reject(err);
-                                                        } else {
-                                                            node.topics[topic].m2 = value;
-                                                            resolve();
-                                                        }
-                                                    });
-                                                });
-                                            }
-                                            promise.then(() => {
-                                                msg2.payload = node.topics[topic].m2;
-                                                delete node.topics[topic];
-                                                node.send(msg2);
-                                                node.status({});
-                                            }).catch(err => {
-                                                node.error(err);
-                                            });
-                                        } else {
-                                            delete node.topics[topic];
-                                            node.status({});
-                                        }
+                    if (node.op1type === "pay") { }
+                    else if (node.op1Templated) { msg.payload = mustache.render(node.op1,msg); }
+                    else if (node.op1type !== "nul") {
+                        msg.payload = RED.util.evaluateNodeProperty(node.op1,node.op1type,node,msg);
+                    }
 
-                                    }, node.duration);
+                    if (node.duration === 0) { node.topics[topic].tout = 0; }
+                    else if (node.loop === true) {
+                        /* istanbul ignore else  */
+                        if (node.topics[topic].tout) { clearInterval(node.topics[topic].tout); }
+                        /* istanbul ignore else  */
+                        if (node.op1type !== "nul") {
+                            var msg2 = RED.util.cloneMessage(msg);
+                            node.topics[topic].tout = setInterval(function() { node.send(RED.util.cloneMessage(msg2)); }, node.duration);
+                        }
+                    }
+                    else {
+                        if (!node.topics[topic].tout) {
+                            node.topics[topic].tout = setTimeout(function() {
+                                var msg2 = null;
+                                if (node.op2type !== "nul") {
+                                    msg2 = RED.util.cloneMessage(msg);
+                                    if (node.op2type === "flow" || node.op2type === "global") {
+                                        node.topics[topic].m2 = RED.util.evaluateNodeProperty(node.op2,node.op2type,node,msg);
+                                    }
+                                    msg2.payload = node.topics[topic].m2;
+                                    delete node.topics[topic];
+                                    node.send(msg2);
                                 }
-                            }
-                            node.status({fill:"blue",shape:"dot",text:" "});
-                            if (node.op1type !== "nul") { node.send(RED.util.cloneMessage(msg)); }
-                        });
-                    });
+                                else { delete node.topics[topic]; }
+                                node.status({});
+                            }, node.duration);
+                        }
+                    }
+                    node.status({fill:"blue",shape:"dot",text:" "});
+                    if (node.op1type !== "nul") { node.send(RED.util.cloneMessage(msg)); }
                 }
                 else if ((node.extend === "true" || node.extend === true) && (node.duration > 0)) {
                     /* istanbul ignore else  */
@@ -213,43 +138,25 @@ module.exports = function(RED) {
                     if (node.topics[topic].tout) { clearTimeout(node.topics[topic].tout); }
                     node.topics[topic].tout = setTimeout(function() {
                         var msg2 = null;
-                        var promise = Promise.resolve();
-
                         if (node.op2type !== "nul") {
                             if (node.op2type === "flow" || node.op2type === "global") {
-                                promise = new Promise((resolve,reject) => {
-                                    RED.util.evaluateNodeProperty(node.op2,node.op2type,node,msg,(err,value) => {
-                                        if (err) {
-                                            reject(err);
-                                        } else {
-                                            node.topics[topic].m2 = value;
-                                            resolve();
-                                        }
-                                    });
-                                });
+                                node.topics[topic].m2 = RED.util.evaluateNodeProperty(node.op2,node.op2type,node,msg);
+                            }
+                            if (node.topics[topic] !== undefined) {
+                                msg2 = RED.util.cloneMessage(msg);
+                                msg2.payload = node.topics[topic].m2;
                             }
                         }
-                        promise.then(() => {
-                            if (node.op2type !== "nul") {
-                                if (node.topics[topic] !== undefined) {
-                                    msg2 = RED.util.cloneMessage(msg);
-                                    msg2.payload = node.topics[topic].m2;
-                                }
-                            }
-                            delete node.topics[topic];
-                            node.status({});
-                            node.send(msg2);
-                        }).catch(err => {
-                            node.error(err);
-                        });
+                        delete node.topics[topic];
+                        node.status({});
+                        node.send(msg2);
                     }, node.duration);
                 }
                 else {
                     if (node.op2type === "payl") { node.topics[topic].m2 = RED.util.cloneMessage(msg.payload); }
                 }
             }
-            return Promise.resolve();
-        }
+        });
         this.on("close", function() {
             for (var t in node.topics) {
                 /* istanbul ignore else  */

nodes/core/core/lib/debug/debug-utils.js

@@ -455,8 +455,24 @@ RED.debug = (function() {
             $('<span class="debug-message-name">'+name+'</span>').appendTo(metaRow);
         }
 
-        payload = RED.utils.decodeObject(payload,format);
-
+        if ((format === 'number') && (payload === "NaN")) {
+            payload = Number.NaN;
+        } else if (format === 'Object' || /^array/.test(format) || format === 'boolean' || format === 'number' ) {
+            payload = JSON.parse(payload);
+        } else if (/error/i.test(format)) {
+            payload = JSON.parse(payload);
+            payload = (payload.name?payload.name+": ":"")+payload.message;
+        } else if (format === 'null') {
+            payload = null;
+        } else if (format === 'undefined') {
+            payload = undefined;
+        } else if (/^buffer/.test(format)) {
+            var buffer = payload;
+            payload = [];
+            for (var c = 0; c < buffer.length; c += 2) {
+                payload.push(parseInt(buffer.substr(c, 2), 16));
+            }
+        }
         var el = $('<span class="debug-message-payload"></span>').appendTo(msg);
         var path = o.property||'';
         var debugMessage = RED.utils.createObjectElement(payload, {

nodes/core/hardware/nrgpio.py

@@ -23,6 +23,10 @@ from time import sleep
 
 bounce = 25;
 
+if sys.version_info >= (3,0):
+    print("Sorry - currently only configured to work with python 2.x")
+    sys.exit(1)
+
 if len(sys.argv) > 2:
     cmd = sys.argv[1].lower()
     pin = int(sys.argv[2])
@@ -30,7 +34,7 @@ if len(sys.argv) > 2:
     GPIO.setwarnings(False)
 
     if cmd == "pwm":
-        #print("Initialised pin "+str(pin)+" to PWM")
+        #print "Initialised pin "+str(pin)+" to PWM"
         try:
             freq = int(sys.argv[3])
         except:
@@ -50,10 +54,10 @@ if len(sys.argv) > 2:
                 GPIO.cleanup(pin)
                 sys.exit(0)
             except Exception as ex:
-                print("bad data: "+data)
+                print "bad data: "+data
 
     elif cmd == "buzz":
-        #print("Initialised pin "+str(pin)+" to Buzz")
+        #print "Initialised pin "+str(pin)+" to Buzz"
         GPIO.setup(pin,GPIO.OUT)
         p = GPIO.PWM(pin, 100)
         p.stop()
@@ -72,10 +76,10 @@ if len(sys.argv) > 2:
                 GPIO.cleanup(pin)
                 sys.exit(0)
             except Exception as ex:
-                print("bad data: "+data)
+                print "bad data: "+data
 
     elif cmd == "out":
-        #print("Initialised pin "+str(pin)+" to OUT")
+        #print "Initialised pin "+str(pin)+" to OUT"
         GPIO.setup(pin,GPIO.OUT)
         if len(sys.argv) == 4:
             GPIO.output(pin,int(sys.argv[3]))
@@ -99,11 +103,11 @@ if len(sys.argv) > 2:
             GPIO.output(pin,data)
 
     elif cmd == "in":
-        #print("Initialised pin "+str(pin)+" to IN")
+        #print "Initialised pin "+str(pin)+" to IN"
         bounce = float(sys.argv[4])
         def handle_callback(chan):
             sleep(bounce/1000.0)
-            print(GPIO.input(chan))
+            print GPIO.input(chan)
 
         if sys.argv[3].lower() == "up":
             GPIO.setup(pin,GPIO.IN,GPIO.PUD_UP)
@@ -112,7 +116,7 @@ if len(sys.argv) > 2:
         else:
             GPIO.setup(pin,GPIO.IN)
 
-        print(GPIO.input(pin))
+        print GPIO.input(pin)
         GPIO.add_event_detect(pin, GPIO.BOTH, callback=handle_callback, bouncetime=int(bounce))
 
         while True:
@@ -125,7 +129,7 @@ if len(sys.argv) > 2:
                 sys.exit(0)
 
     elif cmd == "byte":
-        #print("Initialised BYTE mode - "+str(pin)+)
+        #print "Initialised BYTE mode - "+str(pin)+
         list = [7,11,13,12,15,16,18,22]
         GPIO.setup(list,GPIO.OUT)
 
@@ -148,7 +152,7 @@ if len(sys.argv) > 2:
                 GPIO.output(list[bit], data & mask)
 
     elif cmd == "borg":
-        #print("Initialised BORG mode - "+str(pin)+)
+        #print "Initialised BORG mode - "+str(pin)+
         GPIO.setup(11,GPIO.OUT)
         GPIO.setup(13,GPIO.OUT)
         GPIO.setup(15,GPIO.OUT)
@@ -186,7 +190,7 @@ if len(sys.argv) > 2:
           button = ord( buf[0] ) & pin # mask out just the required button(s)
           if button != oldbutt:  # only send if changed
               oldbutt = button
-              print(button)
+              print button
 
         while True:
             try:
@@ -211,7 +215,7 @@ if len(sys.argv) > 2:
                     # type,code,value
                     print("%u,%u" % (code, value))
                 event = file.read(EVENT_SIZE)
-            print("0,0")
+            print "0,0"
             file.close()
             sys.exit(0)
         except:
@@ -221,14 +225,14 @@ if len(sys.argv) > 2:
 elif len(sys.argv) > 1:
     cmd = sys.argv[1].lower()
     if cmd == "rev":
-        print(GPIO.RPI_REVISION)
+        print GPIO.RPI_REVISION
     elif cmd == "ver":
-        print(GPIO.VERSION)
+        print GPIO.VERSION
     elif cmd == "info":
-        print(GPIO.RPI_INFO)
+        print GPIO.RPI_INFO
     else:
-        print("Bad parameters - in|out|pwm|buzz|byte|borg|mouse|kbd|ver|info {pin} {value|up|down}")
-        print("  only ver (gpio version) and info (board information) accept no pin parameter.")
+        print "Bad parameters - in|out|pwm|buzz|byte|borg|mouse|kbd|ver|info {pin} {value|up|down}"
+        print "  only ver (gpio version) and info (board information) accept no pin parameter."
 
 else:
-    print("Bad parameters - in|out|pwm|buzz|byte|borg|mouse|kbd|ver|info {pin} {value|up|down}")
+    print "Bad parameters - in|out|pwm|buzz|byte|borg|mouse|kbd|ver|info {pin} {value|up|down}"

nodes/core/io/05-tls.html

@@ -63,11 +63,6 @@
         <input type="checkbox" id="node-config-input-verifyservercert" style="display: inline-block; width: auto; vertical-align: top;">
         <label for="node-config-input-verifyservercert" style="width: calc(100% - 170px);" data-i18n="tls.label.verify-server-cert"></label>
     </div>
-    <div class="form-row">
-        <label style="width: 120px;" for="node-config-input-servername"><i class="fa fa-server"></i> <span data-i18n="tls.label.servername"></span></label>
-        <input style="width: calc(100% - 170px);" type="text" id="node-config-input-servername" data-i18n="[placeholder]tls.placeholder.servername">
-    </div>
-    <hr>
     <div class="form-row">
         <label style="width: 120px;" for="node-config-input-name"><i class="fa fa-tag"></i> <span data-i18n="common.label.name"></span></label>
         <input style="width: calc(100% - 170px);" type="text" id="node-config-input-name" data-i18n="[placeholder]common.label.name">
@@ -101,7 +96,6 @@
             certname: {value:""},
             keyname: {value:""},
             caname: {value:""},
-            servername: {value:""},
             verifyservercert: {value: true}
         },
         credentials: {

nodes/core/io/05-tls.js

@@ -25,7 +25,6 @@ module.exports = function(RED) {
         var certPath = n.cert.trim();
         var keyPath = n.key.trim();
         var caPath = n.ca.trim();
-        this.servername = (n.servername||"").trim();
 
         if ((certPath.length > 0) || (keyPath.length > 0)) {
 
@@ -103,9 +102,6 @@ module.exports = function(RED) {
             if (this.credentials && this.credentials.passphrase) {
                 opts.passphrase = this.credentials.passphrase;
             }
-            if (this.servername) {
-                opts.servername = this.servername;
-            }
             opts.rejectUnauthorized = this.verifyservercert;
         }
         return opts;

nodes/core/io/22-websocket.js

@@ -212,11 +212,11 @@ module.exports = function(RED) {
         if (this.serverConfig) {
             this.serverConfig.registerInputNode(this);
             // TODO: nls
-            this.serverConfig.on('opened', function(n) { node.status({fill:"green",shape:"dot",text:RED._("websocket.status.connected",{count:n})}); });
-            this.serverConfig.on('erro', function() { node.status({fill:"red",shape:"ring",text:"common.status.error"}); });
+            this.serverConfig.on('opened', function(n) { node.status({fill:"green",shape:"dot",text:"connected "+n}); });
+            this.serverConfig.on('erro', function() { node.status({fill:"red",shape:"ring",text:"error"}); });
             this.serverConfig.on('closed', function(n) {
-                if (n > 0) { node.status({fill:"green",shape:"dot",text:RED._("websocket.status.connected",{count:n})}); }
-                else { node.status({fill:"red",shape:"ring",text:"common.status.disconnected"}); }
+                if (n > 0) { node.status({fill:"green",shape:"dot",text:"connected "+n}); }
+                else { node.status({fill:"red",shape:"ring",text:"disconnected"}); }
             });
         } else {
             this.error(RED._("websocket.errors.missing-conf"));
@@ -240,11 +240,11 @@ module.exports = function(RED) {
         }
         else {
             // TODO: nls
-            this.serverConfig.on('opened', function(n) { node.status({fill:"green",shape:"dot",text:RED._("websocket.status.connected",{count:n})}); });
-            this.serverConfig.on('erro', function() { node.status({fill:"red",shape:"ring",text:"common.status.error"}); });
+            this.serverConfig.on('opened', function(n) { node.status({fill:"green",shape:"dot",text:"connected "+n}); });
+            this.serverConfig.on('erro', function() { node.status({fill:"red",shape:"ring",text:"error"}); });
             this.serverConfig.on('closed', function(n) {
-                if (n > 0) { node.status({fill:"green",shape:"dot",text:RED._("websocket.status.connected",{count:n})}); }
-                else { node.status({fill:"red",shape:"ring",text:"common.status.disconnected"}); }
+                if (n > 0) { node.status({fill:"green",shape:"dot",text:"connected "+n}); }
+                else { node.status({fill:"red",shape:"ring",text:"disconnected"}); }
             });
         }
         this.on("input", function(msg) {

nodes/core/io/31-tcpin.js

@@ -18,36 +18,10 @@ module.exports = function(RED) {
     "use strict";
     var reconnectTime = RED.settings.socketReconnectTime||10000;
     var socketTimeout = RED.settings.socketTimeout||null;
-    const msgQueueSize = RED.settings.tcpMsgQueueSize || 1000;
-    const Denque = require('denque');
     var net = require('net');
 
     var connectionPool = {};
 
-    /**
-     * Enqueue `item` in `queue`
-     * @param {Denque} queue - Queue
-     * @param {*} item - Item to enqueue
-     * @private
-     * @returns {Denque} `queue`
-     */
-    const enqueue = (queue, item) => {
-        // drop msgs from front of queue if size is going to be exceeded
-        if (queue.size() === msgQueueSize) {
-            queue.shift();
-        }
-        queue.push(item);
-        return queue;
-    };
-
-    /**
-     * Shifts item off front of queue
-     * @param {Deque} queue - Queue
-     * @private
-     * @returns {*} Item previously at front of queue
-     */
-    const dequeue = queue => queue.shift();
-
     function TcpIn(n) {
         RED.nodes.createNode(this,n);
         this.host = n.host;
@@ -461,15 +435,11 @@ module.exports = function(RED) {
             // the clients object will have:
             // clients[id].client, clients[id].msg, clients[id].timeout
             var connection_id = host + ":" + port;
-            clients[connection_id] = clients[connection_id] || {
-                msgQueue: new Denque(),
-                connected: false,
-                connecting: false
-            };
-            enqueue(clients[connection_id].msgQueue, msg);
-            clients[connection_id].lastMsg = msg;
+            clients[connection_id] = clients[connection_id] || {};
+            clients[connection_id].msg = msg;
+            clients[connection_id].connected = clients[connection_id].connected || false;
 
-            if (!clients[connection_id].connecting && !clients[connection_id].connected) {
+            if (!clients[connection_id].connected) {
                 var buf;
                 if (this.out == "count") {
                     if (this.splitc === 0) { buf = Buffer.alloc(1); }
@@ -481,19 +451,14 @@ module.exports = function(RED) {
                 if (socketTimeout !== null) { clients[connection_id].client.setTimeout(socketTimeout);}
 
                 if (host && port) {
-                    clients[connection_id].connecting = true;
                     clients[connection_id].client.connect(port, host, function() {
                         //node.log(RED._("tcpin.errors.client-connected"));
                         node.status({fill:"green",shape:"dot",text:"common.status.connected"});
                         if (clients[connection_id] && clients[connection_id].client) {
                             clients[connection_id].connected = true;
-                            clients[connection_id].connecting = false;
-                            let msg;
-                            while (msg = dequeue(clients[connection_id].msgQueue)) {
-                                clients[connection_id].client.write(msg.payload);
-                            }
+                            clients[connection_id].client.write(clients[connection_id].msg.payload);
                             if (node.out === "time" && node.splitc < 0) {
-                                clients[connection_id].connected = clients[connection_id].connecting = false;
+                                clients[connection_id].connected = false;
                                 clients[connection_id].client.end();
                                 delete clients[connection_id];
                                 node.status({});
@@ -508,9 +473,9 @@ module.exports = function(RED) {
                 clients[connection_id].client.on('data', function(data) {
                     if (node.out === "sit") { // if we are staying connected just send the buffer
                         if (clients[connection_id]) {
-                            const msg = clients[connection_id].lastMsg || {};
-                            msg.payload = data;
-                            node.send(RED.util.cloneMessage(msg));
+                            if (!clients[connection_id].hasOwnProperty("msg")) { clients[connection_id].msg = {}; }
+                            clients[connection_id].msg.payload = data;
+                            node.send(RED.util.cloneMessage(clients[connection_id].msg));
                         }
                     }
                     // else if (node.splitc === 0) {
@@ -530,10 +495,9 @@ module.exports = function(RED) {
                                         clients[connection_id].timeout = setTimeout(function () {
                                             if (clients[connection_id]) {
                                                 clients[connection_id].timeout = null;
-                                                const msg = clients[connection_id].lastMsg || {};
-                                                msg.payload = Buffer.alloc(i+1);
-                                                buf.copy(msg.payload,0,0,i+1);
-                                                node.send(msg);
+                                                clients[connection_id].msg.payload = Buffer.alloc(i+1);
+                                                buf.copy(clients[connection_id].msg.payload,0,0,i+1);
+                                                node.send(clients[connection_id].msg);
                                                 if (clients[connection_id].client) {
                                                     node.status({});
                                                     clients[connection_id].client.destroy();
@@ -552,10 +516,9 @@ module.exports = function(RED) {
                                 i += 1;
                                 if ( i >= node.splitc) {
                                     if (clients[connection_id]) {
-                                        const msg = clients[connection_id].lastMsg || {};
-                                        msg.payload = Buffer.alloc(i);
-                                        buf.copy(msg.payload,0,0,i);
-                                        node.send(msg);
+                                        clients[connection_id].msg.payload = Buffer.alloc(i);
+                                        buf.copy(clients[connection_id].msg.payload,0,0,i);
+                                        node.send(clients[connection_id].msg);
                                         if (clients[connection_id].client) {
                                             node.status({});
                                             clients[connection_id].client.destroy();
@@ -571,10 +534,9 @@ module.exports = function(RED) {
                                 i += 1;
                                 if (data[j] == node.splitc) {
                                     if (clients[connection_id]) {
-                                        const msg = clients[connection_id].lastMsg || {};
-                                        msg.payload = Buffer.alloc(i);
-                                        buf.copy(msg.payload,0,0,i);
-                                        node.send(msg);
+                                        clients[connection_id].msg.payload = Buffer.alloc(i);
+                                        buf.copy(clients[connection_id].msg.payload,0,0,i);
+                                        node.send(clients[connection_id].msg);
                                         if (clients[connection_id].client) {
                                             node.status({});
                                             clients[connection_id].client.destroy();
@@ -592,7 +554,7 @@ module.exports = function(RED) {
                     //console.log("END");
                     node.status({fill:"grey",shape:"ring",text:"common.status.disconnected"});
                     if (clients[connection_id] && clients[connection_id].client) {
-                        clients[connection_id].connected = clients[connection_id].connecting = false;
+                        clients[connection_id].connected = false;
                         clients[connection_id].client = null;
                     }
                 });
@@ -600,7 +562,7 @@ module.exports = function(RED) {
                 clients[connection_id].client.on('close', function() {
                     //console.log("CLOSE");
                     if (clients[connection_id]) {
-                        clients[connection_id].connected = clients[connection_id].connecting = false;
+                        clients[connection_id].connected = false;
                     }
 
                     var anyConnected = false;
@@ -630,23 +592,21 @@ module.exports = function(RED) {
                 clients[connection_id].client.on('timeout',function() {
                     //console.log("TIMEOUT");
                     if (clients[connection_id]) {
-                        clients[connection_id].connected = clients[connection_id].connecting = false;
+                        clients[connection_id].connected = false;
                         node.status({fill:"grey",shape:"dot",text:"tcpin.errors.connect-timeout"});
                         //node.warn(RED._("tcpin.errors.connect-timeout"));
                         if (clients[connection_id].client) {
-                            clients[connection_id].connecting = true;
                             clients[connection_id].client.connect(port, host, function() {
                                 clients[connection_id].connected = true;
-                                clients[connection_id].connecting = false;
                                 node.status({fill:"green",shape:"dot",text:"common.status.connected"});
                             });
                         }
                     }
                 });
             }
-            else if (!clients[connection_id].connecting && clients[connection_id].connected) {
+            else {
                 if (clients[connection_id] && clients[connection_id].client) {
-                    clients[connection_id].client.write(dequeue(clients[connection_id].msgQueue));
+                    clients[connection_id].client.write(clients[connection_id].msg.payload);
                 }
             }
         });

nodes/core/io/32-udp.js

@@ -63,7 +63,7 @@ module.exports = function(RED) {
             udpInputPortsInUse[this.port] = server;
         }
         else {
-            node.log(RED._("udp.errors.alreadyused",{port:node.port}));
+            node.warn(RED._("udp.errors.alreadyused",{port:node.port}));
             server = udpInputPortsInUse[this.port];  // re-use existing
         }
 
@@ -172,7 +172,8 @@ module.exports = function(RED) {
         if (process.version.indexOf("v0.10") === 0) { opts = node.ipv; }
 
         var sock;
-        var p = this.outport || this.port || "0";
+        var p = this.port;
+        if (node.multicast != "false") { p = this.outport||"0"; }
         if (udpInputPortsInUse[p]) {
             sock = udpInputPortsInUse[p];
             node.log(RED._("udp.status.re-use",{outport:node.outport,host:node.addr,port:node.port}));

nodes/core/locales/en-US/messages.json

@@ -6,7 +6,8 @@
             "name": "Name",
             "username": "Username",
             "password": "Password",
-            "property": "Property"
+            "property": "Property",
+            "language": "Language"
         },
         "status": {
             "connected": "connected",
@@ -153,15 +154,13 @@
             "key": "Private Key",
             "passphrase": "Passphrase",
             "ca": "CA Certificate",
-            "verify-server-cert":"Verify server certificate",
-            "servername": "Server Name"
+            "verify-server-cert":"Verify server certificate"
         },
         "placeholder": {
             "cert":"path to certificate (PEM format)",
             "key":"path to private key (PEM format)",
             "ca":"path to CA certificate (PEM format)",
-            "passphrase":"private key passphrase (optional)",
-            "servername":"for use with SNI"
+            "passphrase":"private key passphrase (optional)"
         },
         "error": {
             "missing-file": "No certificate/key file provided"
@@ -422,10 +421,6 @@
             "url1": "URL should use ws:// or wss:// scheme and point to an existing websocket listener.",
             "url2": "By default, <code>payload</code> will contain the data to be sent over, or received from a websocket. The client can be configured to send or receive the entire message object as a JSON formatted string."
         },
-        "status": {
-            "connected": "connected __count__",
-            "connected_plural": "connected __count__"
-        },
         "errors": {
             "connect-error": "An error occured on the ws connection: ",
             "send-error": "An error occurred while sending: ",
@@ -581,8 +576,6 @@
             "null":"is null",
             "nnull":"is not null",
             "istype":"is of type",
-            "empty":"is empty",
-            "nempty":"is not empty",
             "head":"head",
             "tail":"tail",
             "index":"index between",
@@ -705,9 +698,7 @@
         "errors": {
             "dropped-object": "Ignored non-object payload",
             "dropped": "Ignored unsupported payload type",
-            "dropped-error": "Failed to convert payload",
-            "schema-error": "JSON Schema error",
-            "schema-error-compile": "JSON Schema error: failed to compile schema"
+            "dropped-error": "Failed to convert payload"
         },
         "label": {
             "o2j": "Object to JSON options",
@@ -934,8 +925,8 @@
         "ascending" : "ascending",
         "descending" : "descending",
         "as-number" : "as number",
-        "invalid-exp" : "Invalid JSONata expression in sort node: __message__",
-        "too-many" : "Too many pending messages in sort node",
+        "invalid-exp" : "invalid JSONata expression in sort node",
+        "too-many" : "too many pending messages in sort node",
         "clear" : "clear pending message in sort node"
     },
     "batch" : {

nodes/core/locales/ja/core/75-exec.html

@@ -26,7 +26,7 @@
         <dt class="optional">kill <span class="property-type">文字列</span></dt>
         <dd>execノードのプロセスに対して送るシグナルの種別を指定します</dd>
         <dt class="optional">pid <span class="property-type">数値|文字列</span></dt>
-        <dd>シグナル送信対象のexecノードのプロセスIDを指定します</dd>
+        <dd>シグナル送信対象のexecノードのプロセスID</dd>
     </dl>
 
     <h3>出力</h3>
@@ -60,12 +60,13 @@
     </ol>
     <h3>詳細</h3>
     <p>デフォルトでは、<code>exec</code>システムコールを用いてコマンドを呼び出してその完了を待ち、出力を返します。例えば、コマンドの実行が成功した場合には、<code>{ code: 0 }</code>と言う返却値を返します。</p>
-    <p><code>spawn</code>を使ってコマンドを実行し、標準出力および標準エラー出力へ出力を返すようにすることもできます。この場合、通常1行毎に値を返します。コマンドの実行が完了すると、3番目の端子にオブジェクトを出力します。例えば、コマンドの実行が成功した場合には、<code>{ code: 0 }</code>という返却値を返します。</p>
+    <p><code>spawn</code>を使ってコマンドを実行し、
+標準出力および標準エラー出力へ出力を返すようにすることもできます。この場合、通常1行毎に値を返します。コマンドの実行が完了すると、3番目の端子にオブジェクトを出力します。例えば、コマンドの実行が成功した場合には、<code>{ code: 0 }</code>と言う返却値を返します。</p>
     <p>エラー発生時には、3番目の端子の<code>msg.payload</code>に<code>message</code>、<code>signal</code>など付加情報を返します。</p>
     <p>実行対象のコマンドはノード設定で定義します。<code>msg.payload</code>や追加引数をコマンドに追加することもできます。</p>
-    <p>コマンドもしくはパラメータが空白を含む場合には、引用符で囲みます。- <code>"これは一つのパラメータです"</code></p>
+    <p>コマンドもしくはパラメータが空白を含む場合には、引用符で囲みます。- <code>"This is a single parameter"</code></p>
     <p>返却する<code>payload</code>は通常<i>文字列</i>ですが、UTF8文字以外が存在すると<i>バッファ</i>となります。</p>
-    <p>ノードが実行中の場合、ステータスアイコンとPIDを表示します。この状態変化は<code>Status</code>ノードで検知できます。</p>
+    <p>ノードが実行中の場合、ステータスアイコンとPIDを表示します。この状態変化は<code>status</code>ノードで検知できます。</p>
     <h4>プロセスの停止</h4>
     <p><code>msg.kill</code>を受信すると、実行中のプロセスを停止することができます。<code>msg.kill</code>には送出するシグナルの種別を指定します。例えば、<code>SIGINT</code>、<code>SIGQUIT</code>、<code>SIGHUP</code>などです。空の文字列を指定した場合には、<code>SIGTERM</code>を指定したものとみなします。</p>
     <p>ノードが1つ以上のプロセスを実行している場合、<code>msg.pid</code>に停止対象のPIDを指定しなければなりません。</p>

nodes/core/locales/ja/core/80-function.html

@@ -18,7 +18,7 @@
     <p>受信メッセージに対して処理を行うJavaScriptコード(関数の本体)を定義します。</p>
     <p>入力メッセージは<code>msg</code>という名称のJavaScriptオブジェクトで受け渡されます。</p>
     <p><code>msg</code>オブジェクトは<code>msg.payload</code>プロパティにメッセージ本体を保持するのが慣例です。</p>
-    <p>通常、コードはメッセージオブジェクト(もしくは複数のメッセージオブジェクト)を返却します。後続フローの実行を停止したい場合は、オブジェクトを返却しなくてもかまいません。</p>
+    <p>通常、コードはメッセージオブジェクト(もしくは複数のメッセージオブジェクト)を返却します。何も返却しない場合には、フロー実行を停止します。</p>
     <h3>詳細</h3>
     <p>コードの書き方の詳細については、<a target="_blank" href="http://nodered.org/docs/writing-functions.html">オンラインドキュメント</a>を参照してください。</p>
     <h4>メッセージの送信</h4>
@@ -40,10 +40,4 @@
     </p>
     <p>catchノードを用いてエラー処理が可能です。catchノードで処理させるためには、<code>msg</code>を<code>node.error</code>の第二引数として渡します:</p>
     <pre>node.error("エラー",msg);</pre>
-    <h4>ノード情報の参照</h4>
-    <p>コード中ではノードのIDおよび名前を以下のプロパティで参照できます:</p>
-    <ul>
-        <li><code>node.id</code> - ノードのID</li>
-        <li><code>node.name</code> - ノードの名称</li>
-    </ul>
 </script>

nodes/core/locales/ja/io/10-mqtt.html

@@ -63,8 +63,6 @@
     <p>ノードにクライアントIDを設定しておらずセッションの初期化を設定している場合、ランダムなクライアントIDを生成します。クライアントIDを設定する場合、接続先のブローカで一意となるようにしてください。</p>
     <h4>Birthメッセージ</h4>
     <p>接続を確立した際に、設定したトピックに対して発行するメッセージ</p>
-    <h4>Closeメッセージ</h4>
-    <p>接続が正常に終了する前に、ノードの再デプロイまたはシャットダウンした場合に、設定したトピックに対して発行するメッセージ</p>
     <h4>Willメッセージ</h4>
     <p>予期せず接続が切断された場合にブローカが発行するメッセージ</p>
     <h4>WebSocket</h4>

nodes/core/locales/ja/io/21-httprequest.html

@@ -30,9 +30,7 @@
         <dt class="optional">payload</dt>
         <dd>リクエストボディとして送るデータ</dd>
         <dt class="optional">rejectUnauthorized</dt>
-        <dd><code>false</code>をセットすると、自己署名証明書を使用するhttpsサイトへのリクエストを許可します。</dd>
-        <dt class="optional">followRedirects</dt>
-        <dd><code>false</code>をセットすると、リダイレクトを行いません。デフォルトは<code>true</code>です。</dd>
+        <dd><code>true</code>をセットすると、自己署名証明書を使用するhttpsサイトへのリクエストを許可します。</dd>
     </dl>
     <h3>出力</h3>
     <dl class="message-properties">

nodes/core/locales/ja/logic/10-switch.html

@@ -29,11 +29,7 @@
         <li><b>その他</b> - これより前のルールにマッチするものがなかった場合に適用</li>
     </ol>
 
-    <h3>注釈</h3>
-    <p><code>is true/false</code>と<code>is null</code>のルールは、型に対して厳密な比較を行います。型変換した上での比較はしません。</p>
-    <p><code>is empty</code>のルールは、長さ０の文字列・配列・バッファ、またはプロパティを持たないオブジェクトを出力します。<code>null</code>や<code>undefined</code>は出力しません。</p>
-
     <h3>メッセージ列の扱い</h3>
     <p>switchノードは入力メッセージの列に関する情報を保持する<code>msg.parts</code>をデフォルトでは変更しません。</p>
-    <p>「<b>メッセージ列の補正</b>」オプションを指定すると、マッチした各ルールに対して新しいメッセージ列を生成します。このモードでは、switchノードは新たなメッセージ列を送信する前に、入力メッセージ列全体を内部に蓄積します。<b>settings.js</b>の<code>nodeMessageBufferMaxLength</code>を設定すると、蓄積するメッセージ数を制限できます。</p>
+    <p>「<b>メッセージ列の補正</b>」オプションを指定すると、マッチした各ルールに対して新しいメッセージ列を生成します。このモードでは、switchノードは新たなメッセージ列を送信する前に、入力メッセージ列全体を内部に蓄積します。<code>nodeMessageBufferMaxLength</code>を設定すると、蓄積するメッセージ数を制限できます。</p>
 </script>

nodes/core/locales/ja/logic/19-batch.html

@@ -30,5 +30,5 @@
         </dd>
     </dl>
     <h4>メッセージの蓄積</h4>
-    <p>このノードの処理ではメッセージ列の処理のためメッセージを内部に蓄積します。<b>settings.js</b>の<code>nodeMessageBufferMaxLength</code>を指定することで蓄積するメッセージの最大値を制限することができます。</p>
+    <p>このノードの処理ではメッセージ列の処理のためメッセージを内部に蓄積します。<code>nodeMessageBufferMaxLength</code>を指定することで蓄積するメッセージの最大値を制限することができます。</p>
 </script>

nodes/core/locales/ja/messages.json

@@ -153,23 +153,19 @@
             "key": "秘密鍵",
             "passphrase": "パスフレーズ",
             "ca": "CA証明書",
-            "verify-server-cert": "サーバ証明書を確認",
-            "servername": "サーバ名"
+            "verify-server-cert": "サーバ証明書を確認"
         },
         "placeholder": {
             "cert": "証明書(PEM形式)のパス",
             "key": "秘密鍵(PEM形式)のパス",
             "ca": "CA証明書(PEM形式)のパス",
-            "passphrase": "秘密鍵のパスフレーズ (任意)",
-            "servername": "SNIで使用"
+            "passphrase":"秘密鍵のパスフレーズ (任意)"
         },
         "error": {
             "missing-file": "証明書と秘密鍵のファイルが設定されていません"
         }
     },
     "exec": {
-        "exec": "exec",
-        "spawn": "spawn",
         "label": {
             "command": "コマンド",
             "append": "引数",
@@ -188,7 +184,6 @@
         "oldrc": "旧型式の出力を使用(互換モード)"
     },
     "function": {
-        "function": "",
         "label": {
             "function": "コード",
             "outputs": "出力数"
@@ -200,7 +195,6 @@
         "tip": "コードの記述方法はノードの「情報」を参照してください。"
     },
     "template": {
-        "template": "template",
         "label": {
             "template": "テンプレート",
             "property": "設定先",
@@ -307,7 +301,6 @@
         }
     },
     "comment": {
-        "comment": "comment",
         "label": {
             "title": "タイトル",
             "body": "本文"
@@ -325,7 +318,6 @@
             "broker": "サーバ",
             "example": "例) localhost",
             "qos": "QoS",
-            "retain": "保持",
             "clientid": "クライアント",
             "port": "ポート",
             "keepalive": "キープアライブ時間",
@@ -335,10 +327,10 @@
             "verify-server-cert": "サーバの証明書を確認",
             "compatmode": "旧MQTT 3.1のサポート"
         },
-        "sections-label": {
+        "sections-label":{
             "birth-message": "接続時の送信メッセージ(Birthメッセージ)",
-            "will-message": "予期しない切断時の送信メッセージ(Willメッセージ)",
-            "close-message": "切断前の送信メッセージ(Closeメッセージ)"
+            "will-message":"予期しない切断時の送信メッセージ(Willメッセージ)",
+            "close-message":"切断前の送信メッセージ(Closeメッセージ)"
         },
         "tabs-label": {
             "connection": "接続",
@@ -422,10 +414,6 @@
             "url1": "URLには ws:// または wss:// スキーマを使用して、存在するwebsocketリスナを設定してください。",
             "url2": "標準では <code>payload</code> がwebsocketから送信、受信されるデータを持ちます。クライアントはJSON形式の文字列としてメッセージ全体を送信、受信するよう設定できます。"
         },
-        "status": {
-            "connected": "接続数 __count__",
-            "connected_plural": "接続数 __count__"
-        },
         "errors": {
             "connect-error": "ws接続でエラーが発生しました: ",
             "send-error": "送信中にエラーが発生しました: ",
@@ -433,7 +421,6 @@
         }
     },
     "watch": {
-        "watch": "watch",
         "label": {
             "files": "ファイル",
             "recursive": "サブディレクトリを再帰的に監視"
@@ -556,15 +543,15 @@
             "port-notset": "udp: ポートが設定されていません",
             "port-invalid": "udp: ポート番号が不正です",
             "alreadyused": "udp: 既に__port__番ポートが使用されています",
-            "ifnotfound": "udp: インターフェイス __iface__ がありません"
+            "ifnotfound": "udp: インターフェイス __iface__ がありません",
+            "alreadyused": "udp: 既にポートが使用されています"
         }
     },
     "switch": {
-        "switch": "switch",
         "label": {
             "property": "プロパティ",
             "rule": "条件",
-            "repair": "メッセージ列の補正"
+            "repair" :  "メッセージ列の補正"
         },
         "and": "～",
         "checkall": "全ての条件を適用",
@@ -578,18 +565,15 @@
             "false": "is false",
             "null": "is null",
             "nnull": "is not null",
-            "istype": "is of type",
-            "empty": "is empty",
-            "nempty": "is not empty",
-            "head": "head",
-            "tail": "tail",
-            "index": "index between",
-            "exp": "JSONata式",
+            "head":"head",
+            "tail":"tail",
+            "index":"index between",
+            "exp":"JSONata式",
             "else": "その他"
         },
         "errors": {
             "invalid-expr": "不正な表現: __error__",
-            "too-many": "switchノード内で保持しているメッセージが多すぎます"
+            "too-many" : "switchノード内で保持しているメッセージが多すぎます"
         }
     },
     "change": {
@@ -619,7 +603,6 @@
         }
     },
     "range": {
-        "range": "range",
         "label": {
             "action": "動作",
             "inputrange": "入力値の範囲",
@@ -687,7 +670,7 @@
         "label": {
             "select": "抽出する要素",
             "output": "出力",
-            "in": "対象:"
+	    "in": "対象:"
         },
         "output": {
             "html": "要素内のHTML",
@@ -703,9 +686,7 @@
         "errors": {
             "dropped-object": "オブジェクト形式でないペイロードを無視しました",
             "dropped": "対応していない形式のペイロードを無視しました",
-            "dropped-error": "ペイロードの変換処理が失敗しました",
-            "schema-error": "JSONスキーマエラー",
-            "schema-error-compile": "JSONスキーマエラー: スキーマのコンパイルが失敗しました"
+            "dropped-error": "ペイロードの変換処理が失敗しました"
         },
         "label": {
             "o2j": "オブジェクトからJSONへ変換",
@@ -714,8 +695,8 @@
             "property": "プロパティ",
             "actions": {
                 "toggle": "JSON文字列とオブジェクト間の相互変換",
-                "str": "常にJSON文字列に変換",
-                "obj": "常にJavaScriptオブジェクトに変換"
+                "str":"常にJSON文字列に変換",
+                "obj":"常にJavaScriptオブジェクトに変換"
             }
         }
     },
@@ -810,7 +791,6 @@
         }
     },
     "tail": {
-        "tail": "tail",
         "label": {
             "filename": "ファイル名",
             "type": "ファイル形式",
@@ -864,7 +844,6 @@
         "tip": "注釈: 「ファイル名」はフルパスを設定する必要があります。"
     },
     "split": {
-        "split": "split",
         "intro": "型に基づいて <code>msg.payload</code> を分割:",
         "object": "<b>オブジェクト</b>",
         "objectSend": "各key/valueペアのメッセージを送信",
@@ -876,12 +855,11 @@
         "addname": " keyのコピー先"
     },
     "join": {
-        "join": "join",
         "mode": {
             "mode": "動作",
             "auto": "自動",
-            "merge": "列のマージ",
-            "reduce": "列の集約",
+            "merge":"列のマージ",
+            "reduce":"列の集約",
             "custom": "手動"
         },
         "combine": "結合",
@@ -904,12 +882,12 @@
         "seconds": "秒",
         "complete": "<code>msg.complete</code> プロパティが設定されたメッセージ受信後",
         "tip": "このモードでは、本ノードが <i>split</i> ノードと組となるか、 <code>msg.parts</code> プロパティが設定されたメッセージを受け取ることが前提となります。",
-        "too-many": "joinノード内部で保持しているメッセージが多すぎます",
+        "too-many" : "joinノード内部で保持しているメッセージが多すぎます",
         "merge": {
-            "topics-label": "対象トピック",
-            "topics": "トピック",
-            "topic": "トピック",
-            "on-change": "新規トピックを受け取るとメッセージを送信する"
+            "topics-label":"対象トピック",
+            "topics":"トピック",
+            "topic" : "トピック",
+            "on-change":"新規トピックを受け取るとメッセージを送信する"
         },
         "reduce": {
             "exp": "集約式",
@@ -922,45 +900,43 @@
             "invalid-expr": "JSONata式が不正: __error__"
         }
     },
-    "sort": {
-        "sort": "sort",
-        "target": "対象",
-        "seq": "メッセージ列",
-        "key": "キー",
-        "elem": "要素の値",
-        "order": "順序",
-        "ascending": "昇順",
-        "descending": "降順",
-        "as-number": "数値として比較",
-        "invalid-exp": "sortノードで不正なJSONata式が指定されました",
-        "too-many": "sortノードの未処理メッセージの数が許容数を超えました",
-        "clear": "sortノードの未処理メッセージを破棄しました"
+    "sort" : {
+        "target" : "対象",
+        "seq" : "メッセージ列",
+        "key" : "キー",
+        "elem" : "要素の値",
+        "order" : "順序",
+        "ascending" : "昇順",
+        "descending" : "降順",
+        "as-number" : "数値として比較",
+        "invalid-exp" : "sortノードで不正なJSONata式が指定されました",
+        "too-many" : "sortノードの未処理メッセージの数が許容数を超えました",
+        "clear" : "sortノードの未処理メッセージを破棄しました"
     },
-    "batch": {
-        "batch": "batch",
+    "batch" : {
         "mode": {
-            "label": "モード",
-            "num-msgs": "メッセージ数でグループ化",
-            "interval": "時間間隔でグループ化",
-            "concat": "列の結合"
+            "label" : "モード",
+            "num-msgs" : "メッセージ数でグループ化",
+            "interval" : "時間間隔でグループ化",
+            "concat" : "列の結合"
         },
         "count": {
-            "label": "メッセージ数",
-            "overlap": "オーバラップ",
-            "count": "数",
-            "invalid": "メッセージ数とオーバラップ数が不正"
+            "label" : "メッセージ数",
+            "overlap" : "オーバラップ",
+            "count" : "数",
+            "invalid" : "メッセージ数とオーバラップ数が不正"
         },
         "interval": {
-            "label": "時間間隔",
-            "seconds": "秒",
-            "empty": "メッセージを受信しない場合、空のメッセージを送信"
+            "label" : "時間間隔",
+            "seconds" : "秒",
+            "empty" : "メッセージを受信しない場合、空のメッセージを送信"
         },
         "concat": {
             "topics-label": "トピック",
-            "topic": "トピック"
+            "topic" : "トピック"
         },
-        "too-many": "batchノード内で保持しているメッセージが多すぎます",
-        "unexpected": "想定外のモード",
-        "no-parts": "メッセージにpartsプロパティがありません"
+        "too-many" : "batchノード内で保持しているメッセージが多すぎます",
+        "unexpected" : "想定外のモード",
+        "no-parts" : "メッセージにpartsプロパティがありません"
     }
 }

nodes/core/locales/ja/parsers/70-JSON.html

@@ -20,8 +20,6 @@
     <dl class="message-properties">
         <dt>payload<span class="property-type">オブジェクト | 文字列</span></dt>
         <dd>JavaScriptオブジェクトもしくはJSON文字列</dd>
-        <dt>schema<span class="property-type">オブジェクト</span></dt>
-        <dd>JSONの検証に利用するJSONスキーマ。設定されていない場合は検証を行いません。</dd>
     </dl>
     <h3>出力</h3>
     <dl class="message-properties">
@@ -32,12 +30,9 @@
                 <li>入力がJavaScriptオブジェクトの場合、JSON文字列に変換します。JSON文字列は整形することも可能です。</li>
             </ul>
         </dd>
-        <dt>schemaError<span class="property-type">配列</span></dt>
-        <dd>JSONの検証でエラーが発生した場合、Catchノードを利用し、エラーを配列として<code>schemaError</code>プロパティから取得することができます。</dd>
     </dl>
     <h3>詳細</h3>
     <p>デフォルトの変換対象は<code>msg.payload</code>ですが、他のメッセージプロパティを変換対象とすることも可能です。</p>
     <p>双方向の変換を自動選択するのではなく、特定の変換のみ行うように設定できます。この機能は、例えば、<code>HTTP In</code>ノードに対するリクエストがcontent-typeを正しく設定していない場合であっても、JSONノードによる変換結果がJavaScriptオブジェクトであることを保証するために利用します。</p>
     <p>JSON文字列への変換が指定されている場合、受信した文字列に対してさらなるチェックは行いません。すなわち、文字列がJSONとして正しいかどうかの検査や、整形オプションを指定していたとしても整形処理を実施しません。</p>
-    <p>JSONスキーマの詳細については、<a href="http://json-schema.org/latest/json-schema-validation.html">こちら</a>を参照してください。</p>
 </script>

nodes/core/locales/ja/storage/50-file.html

@@ -21,8 +21,6 @@
         <dt class="optional">filename <span class="property-type">文字列</span></dt>
         <dd>対象ファイル名をノードに設定していない場合、このプロパティでファイルを指定できます</dd>
     </dl>
-    <h3>出力</h3>
-    <p>書き込みの完了時、入力メッセージを出力端子に送出します。</p>
     <h3>詳細</h3>
     <p>入力メッセージのペイロードをファイルの最後に追記します。改行(\n)を各データの最後に追加することもできます。</p>
     <p><code>msg.filename</code>を使う場合、書き込みを行う毎にファイルをクローズします。より良い性能を得るためにはファイル名をノードに設定してください。</p>

nodes/core/logic/10-switch.html

@@ -60,12 +60,6 @@
         <li>An <b>Otherwise</b> rule can be used to match if none of the preceeding
             rules have matched.</li>
     </ol>
-    <h4>Notes</h4>
-    <p>The <code>is true/false</code> and <code>is null</code> rules perform strict
-       comparisons against those types. They do not convert between types.</p>
-    <p>The <code>is empty</code> rule passes for Strings, Arrays and Buffers that have
-       a length of 0, or Objects that have no properties. It does not pass for <code>null</code>
-       or <code>undefined</code> values.</p>
     <h4>Handling message sequences</h4>
     <p>By default, the node does not modify the <code>msg.parts</code> property of messages
        that are part of a sequence.</p>
@@ -92,8 +86,6 @@
         {v:"null",t:"switch.rules.null",kind:'V'},
         {v:"nnull",t:"switch.rules.nnull",kind:'V'},
         {v:"istype",t:"switch.rules.istype",kind:'V'},
-        {v:"empty",t:"switch.rules.empty",kind:'V'},
-        {v:"nempty",t:"switch.rules.nempty",kind:'V'},
         {v:"head",t:"switch.rules.head",kind:'S'},
         {v:"index",t:"switch.rules.index",kind:'S'},
         {v:"tail",t:"switch.rules.tail",kind:'S'},
@@ -107,17 +99,11 @@
         }
         return v;
     }
-    function prop2name(key) {
-        var result = RED.utils.parseContextKey(key);
-        return result.key;
-    }
     function getValueLabel(t,v) {
         if (t === 'str') {
             return '"'+clipValueLength(v)+'"';
-        } else if (t === 'msg') {
+        } else if (t === 'msg' || t==='flow' || t==='global') {
             return t+"."+clipValueLength(v);
-        } else if (t === 'flow' || t === 'global') {
-            return t+"."+clipValueLength(prop2name(v));
         }
         return clipValueLength(v);
     }
@@ -147,7 +133,7 @@
                 }
                 if ((rule.t === 'btwn') || (rule.t === 'index')) {
                     label += " "+getValueLabel(rule.vt,rule.v)+" & "+getValueLabel(rule.v2t,rule.v2);
-                } else if (rule.t !== 'true' && rule.t !== 'false' && rule.t !== 'null' && rule.t !== 'nnull' && rule.t !== 'empty' && rule.t !== 'nempty' && rule.t !== 'else' ) {
+                } else if (rule.t !== 'true' && rule.t !== 'false' && rule.t !== 'null' && rule.t !== 'nnull' && rule.t !== 'else' ) {
                     label += " "+getValueLabel(rule.vt,rule.v);
                 }
                 return label;
@@ -199,7 +185,7 @@
                 } else if (type === "istype") {
                     typeField.typedInput("width",(newWidth-selectWidth-70));
                 } else {
-                    if (type === "true" || type === "false" || type === "null" || type === "nnull" || type === "empty" || type === "nempty" || type === "else") {
+                    if (type === "true" || type === "false" || type === "null" || type === "nnull" || type === "else") {
                         // valueField.hide();
                     } else {
                         valueField.typedInput("width",(newWidth-selectWidth-70));
@@ -295,7 +281,7 @@
                             numValueField.typedInput('hide');
                             typeValueField.typedInput('hide');
                             valueField.typedInput('hide');
-                            if (type === "true" || type === "false" || type === "null" || type === "nnull" || type === "empty" || type === "nempty" || type === "else") {
+                            if (type === "true" || type === "false" || type === "null" || type === "nnull" || type === "else") {
                                 valueField.typedInput('hide');
                                 typeValueField.typedInput('hide');
                             }
@@ -396,7 +382,7 @@
                 var rule = $(this);
                 var type = rule.find("select").val();
                 var r = {t:type};
-                if (!(type === "true" || type === "false" || type === "null" || type === "nnull" || type === "empty" || type === "nempty" || type === "else")) {
+                if (!(type === "true" || type === "false" || type === "null" || type === "nnull" || type === "else")) {
                     if ((type === "btwn") || (type === "index")) {
                         r.v = rule.find(".node-input-rule-btwn-value").typedInput('value');
                         r.vt = rule.find(".node-input-rule-btwn-value").typedInput('type');

nodes/core/logic/10-switch.js

@@ -31,23 +31,6 @@ module.exports = function(RED) {
         'false': function(a) { return a === false; },
         'null': function(a) { return (typeof a == "undefined" || a === null); },
         'nnull': function(a) { return (typeof a != "undefined" && a !== null); },
-        'empty': function(a) {
-            if (typeof a === 'string' || Array.isArray(a) || Buffer.isBuffer(a)) {
-                return a.length === 0;
-            } else if (typeof a === 'object' && a !== null) {
-                return Object.keys(a).length === 0;
-            }
-            return false;
-        },
-        'nempty': function(a) {
-            if (typeof a === 'string' || Array.isArray(a) || Buffer.isBuffer(a)) {
-                return a.length !== 0;
-            } else if (typeof a === 'object' && a !== null) {
-                return Object.keys(a).length !== 0;
-            }
-            return false;
-        },
-
         'istype': function(a, b) {
             if (b === "array") { return Array.isArray(a); }
             else if (b === "buffer") { return Buffer.isBuffer(a); }
@@ -76,157 +59,21 @@ module.exports = function(RED) {
         'else': function(a) { return a === true; }
     };
 
-    var _maxKeptCount;
+    var _max_kept_msgs_count = undefined;
 
-    function getMaxKeptCount() {
-        if (_maxKeptCount === undefined) {
+    function max_kept_msgs_count(node) {
+        if (_max_kept_msgs_count === undefined) {
             var name = "nodeMessageBufferMaxLength";
             if (RED.settings.hasOwnProperty(name)) {
-                _maxKeptCount = RED.settings[name];
+                _max_kept_msgs_count = RED.settings[name];
             }
             else {
-                _maxKeptCount = 0;
+                _max_kept_msgs_count = 0;
             }
         }
-        return _maxKeptCount;
+        return _max_kept_msgs_count;
     }
 
-    function getProperty(node,msg) {
-        return new Promise((resolve,reject) => {
-            if (node.propertyType === 'jsonata') {
-                RED.util.evaluateJSONataExpression(node.property,msg,(err,value) => {
-                    if (err) {
-                        reject(RED._("switch.errors.invalid-expr",{error:err.message}));
-                    } else {
-                        resolve(value);
-                    }
-                });
-            } else {
-                RED.util.evaluateNodeProperty(node.property,node.propertyType,node,msg,(err,value) => {
-                    if (err) {
-                        resolve(undefined);
-                    } else {
-                        resolve(value);
-                    }
-                });
-            }
-        });
-    }
-
-    function getV1(node,msg,rule,hasParts) {
-        return new Promise( (resolve,reject) => {
-            if (rule.vt === 'prev') {
-                resolve(node.previousValue);
-            } else if (rule.vt === 'jsonata') {
-                var exp = rule.v;
-                if (rule.t === 'jsonata_exp') {
-                    if (hasParts) {
-                        exp.assign("I", msg.parts.index);
-                        exp.assign("N", msg.parts.count);
-                    }
-                }
-                RED.util.evaluateJSONataExpression(exp,msg,(err,value) => {
-                    if (err) {
-                        reject(RED._("switch.errors.invalid-expr",{error:err.message}));
-                    } else {
-                        resolve(value);
-                    }
-                });
-            } else if (rule.vt === 'json') {
-                resolve("json");
-            } else if (rule.vt === 'null') {
-                resolve("null");
-            } else {
-                RED.util.evaluateNodeProperty(rule.v,rule.vt,node,msg, function(err,value) {
-                    if (err) {
-                        resolve(undefined);
-                    } else {
-                        resolve(value);
-                    }
-                });
-            }
-        });
-    }
-
-    function getV2(node,msg,rule) {
-        return new Promise((resolve,reject) => {
-            var v2 = rule.v2;
-            if (rule.v2t === 'prev') {
-                resolve(node.previousValue);
-            } else if (rule.v2t === 'jsonata') {
-                RED.util.evaluateJSONataExpression(rule.v2,msg,(err,value) => {
-                    if (err) {
-                        reject(RED._("switch.errors.invalid-expr",{error:err.message}));
-                    } else {
-                        resolve(value);
-                    }
-                });
-            } else if (typeof v2 !== 'undefined') {
-                RED.util.evaluateNodeProperty(rule.v2,rule.v2t,node,msg, function(err,value) {
-                    if (err) {
-                        resolve(undefined);
-                    } else {
-                        resolve(value);
-                    }
-                });
-            } else {
-                resolve(v2);
-            }
-        })
-    }
-
-    function applyRule(node, msg, property, state) {
-        return new Promise((resolve,reject) => {
-
-            var rule = node.rules[state.currentRule];
-            var v1,v2;
-
-            getV1(node,msg,rule,state.hasParts).then(value => {
-                v1 = value;
-            }).then(()=>getV2(node,msg,rule)).then(value => {
-                v2 = value;
-            }).then(() => {
-                if (rule.t == "else") {
-                    property = state.elseflag;
-                    state.elseflag = true;
-                }
-                if (operators[rule.t](property,v1,v2,rule.case,msg.parts)) {
-                    state.onward.push(msg);
-                    state.elseflag = false;
-                    if (node.checkall == "false") {
-                        return resolve(false);
-                    }
-                } else {
-                    state.onward.push(null);
-                }
-                resolve(state.currentRule < node.rules.length - 1);
-            });
-        })
-    }
-
-    function applyRules(node, msg, property,state) {
-        if (!state) {
-            state = {
-                currentRule: 0,
-                elseflag: true,
-                onward: [],
-                hasParts: msg.hasOwnProperty("parts") &&
-                                msg.parts.hasOwnProperty("id") &&
-                                msg.parts.hasOwnProperty("index")
-            }
-        }
-        return applyRule(node,msg,property,state).then(hasMore => {
-            if (hasMore) {
-                state.currentRule++;
-                return applyRules(node,msg,property,state);
-            } else {
-                node.previousValue = property;
-                return state.onward;
-            }
-        });
-    }
-
-
     function SwitchNode(n) {
         RED.nodes.createNode(this, n);
         this.rules = n.rules || [];
@@ -247,10 +94,10 @@ module.exports = function(RED) {
         var node = this;
         var valid = true;
         var repair = n.repair;
-        var needsCount = repair;
+        var needs_count = repair;
         for (var i=0; i<this.rules.length; i+=1) {
             var rule = this.rules[i];
-            needsCount = needsCount || ((rule.t === "tail") || (rule.t === "jsonata_exp"));
+            needs_count = needs_count || ((rule.t === "tail") || (rule.t === "jsonata_exp"));
             if (!rule.vt) {
                 if (!isNaN(Number(rule.v))) {
                     rule.vt = 'num';
@@ -295,26 +142,26 @@ module.exports = function(RED) {
             return;
         }
 
-        var pendingCount = 0;
-        var pendingId = 0;
-        var pendingIn = {};
-        var pendingOut = {};
+        var pending_count = 0;
+        var pending_id = 0;
+        var pending_in = {};
+        var pending_out = {};
         var received = {};
 
-        function addMessageToGroup(id, msg, parts) {
-            if (!(id in pendingIn)) {
-                pendingIn[id] = {
+        function add2group_in(id, msg, parts) {
+            if (!(id in pending_in)) {
+                pending_in[id] = {
                     count: undefined,
                     msgs: [],
-                    seq_no: pendingId++
+                    seq_no: pending_id++
                 };
             }
-            var group = pendingIn[id];
+            var group = pending_in[id];
             group.msgs.push(msg);
-            pendingCount++;
-            var max_msgs = getMaxKeptCount();
-            if ((max_msgs > 0) && (pendingCount > max_msgs)) {
-                clearPending();
+            pending_count++;
+            var max_msgs = max_kept_msgs_count(node);
+            if ((max_msgs > 0) && (pending_count > max_msgs)) {
+                clear_pending();
                 node.error(RED._("switch.errors.too-many"), msg);
             }
             if (parts.hasOwnProperty("count")) {
@@ -323,29 +170,32 @@ module.exports = function(RED) {
             return group;
         }
 
-
-        function addMessageToPending(msg) {
-            var parts = msg.parts;
-            // We've already checked the msg.parts has the require bits
-            var group = addMessageToGroup(parts.id, msg, parts);
-            var msgs = group.msgs;
-            var count = group.count;
-            if (count === msgs.length) {
-                // We have a complete group - send the individual parts
-                return msgs.reduce((promise, msg) => {
-                    return promise.then((result) => {
-                        msg.parts.count = count;
-                        return processMessage(msg, false);
-                    })
-                }, Promise.resolve()).then( () => {
-                    pendingCount -= group.msgs.length;
-                    delete pendingIn[parts.id];
-                });
-            }
-            return Promise.resolve();
+        function del_group_in(id, group) {
+            pending_count -= group.msgs.length;
+            delete pending_in[id];
         }
 
-        function sendGroup(onwards, port_count) {
+        function add2pending_in(msg) {
+            var parts = msg.parts;
+            if (parts.hasOwnProperty("id") &&
+                parts.hasOwnProperty("index")) {
+                var group = add2group_in(parts.id, msg, parts);
+                var msgs = group.msgs;
+                var count = group.count;
+                if (count === msgs.length) {
+                    for (var i = 0; i < msgs.length; i++) {
+                        var msg = msgs[i];
+                        msg.parts.count = count;
+                        process_msg(msg, false);
+                    }
+                    del_group_in(parts.id, group);
+                }
+                return true;
+            }
+            return false;
+        }
+
+        function send_group(onwards, port_count) {
             var counts = new Array(port_count).fill(0);
             for (var i = 0; i < onwards.length; i++) {
                 var onward = onwards[i];
@@ -380,104 +230,141 @@ module.exports = function(RED) {
             }
         }
 
-        function sendGroupMessages(onward, msg) {
+        function send2ports(onward, msg) {
             var parts = msg.parts;
             var gid = parts.id;
             received[gid] = ((gid in received) ? received[gid] : 0) +1;
             var send_ok = (received[gid] === parts.count);
 
-            if (!(gid in pendingOut)) {
-                pendingOut[gid] = {
+            if (!(gid in pending_out)) {
+                pending_out[gid] = {
                     onwards: []
                 };
             }
-            var group = pendingOut[gid];
+            var group = pending_out[gid];
             var onwards = group.onwards;
             onwards.push(onward);
-            pendingCount++;
+            pending_count++;
             if (send_ok) {
-                sendGroup(onwards, onward.length, msg);
-                pendingCount -= onward.length;
-                delete pendingOut[gid];
+                send_group(onwards, onward.length, msg);
+                pending_count -= onward.length;
+                delete pending_out[gid];
                 delete received[gid];
             }
-            var max_msgs = getMaxKeptCount();
-            if ((max_msgs > 0) && (pendingCount > max_msgs)) {
-                clearPending();
+            var max_msgs = max_kept_msgs_count(node);
+            if ((max_msgs > 0) && (pending_count > max_msgs)) {
+                clear_pending();
                 node.error(RED._("switch.errors.too-many"), msg);
             }
         }
 
-
-
-
-
-        function processMessage(msg, checkParts) {
-            var hasParts = msg.hasOwnProperty("parts") &&
-                            msg.parts.hasOwnProperty("id") &&
-                            msg.parts.hasOwnProperty("index");
-
-            if (needsCount && checkParts && hasParts) {
-                return addMessageToPending(msg);
+        function msg_has_parts(msg) {
+            if (msg.hasOwnProperty("parts")) {
+                var parts = msg.parts;
+                return (parts.hasOwnProperty("id") &&
+                        parts.hasOwnProperty("index"));
             }
-            return getProperty(node,msg)
-                    .then(property => applyRules(node,msg,property))
-                    .then(onward => {
-                        if (!repair || !hasParts) {
-                            node.send(onward);
-                        }
-                        else {
-                            sendGroupMessages(onward, msg);
-                        }
-                    }).catch(err => {
-                        node.warn(err);
-                    });
+            return false;
         }
 
-        function clearPending() {
-            pendingCount = 0;
-            pendingId = 0;
-            pendingIn = {};
-            pendingOut = {};
+        function process_msg(msg, check_parts) {
+            var has_parts = msg_has_parts(msg);
+            if (needs_count && check_parts && has_parts &&
+                add2pending_in(msg)) {
+                return;
+            }
+            var onward = [];
+            try {
+                var prop;
+                if (node.propertyType === 'jsonata') {
+                    prop = RED.util.evaluateJSONataExpression(node.property,msg);
+                } else {
+                    prop = RED.util.evaluateNodeProperty(node.property,node.propertyType,node,msg);
+                }
+                var elseflag = true;
+                for (var i=0; i<node.rules.length; i+=1) {
+                    var rule = node.rules[i];
+                    var test = prop;
+                    var v1,v2;
+                    if (rule.vt === 'prev') {
+                        v1 = node.previousValue;
+                    } else if (rule.vt === 'jsonata') {
+                        try {
+                            var exp = rule.v;
+                            if (rule.t === 'jsonata_exp') {
+                                if (has_parts) {
+                                    exp.assign("I", msg.parts.index);
+                                    exp.assign("N", msg.parts.count);
+                                }
+                            }
+                            v1 = RED.util.evaluateJSONataExpression(exp,msg);
+                        } catch(err) {
+                            node.error(RED._("switch.errors.invalid-expr",{error:err.message}));
+                            return;
+                        }
+                    } else if (rule.vt === 'json') {
+                        v1 = "json";
+                    } else if (rule.vt === 'null') {
+                        v1 = "null";
+                    } else {
+                        try {
+                            v1 = RED.util.evaluateNodeProperty(rule.v,rule.vt,node,msg);
+                        } catch(err) {
+                            v1 = undefined;
+                        }
+                    }
+                    v2 = rule.v2;
+                    if (rule.v2t === 'prev') {
+                        v2 = node.previousValue;
+                    } else if (rule.v2t === 'jsonata') {
+                        try {
+                            v2 = RED.util.evaluateJSONataExpression(rule.v2,msg);
+                        } catch(err) {
+                            node.error(RED._("switch.errors.invalid-expr",{error:err.message}));
+                            return;
+                        }
+                    } else if (typeof v2 !== 'undefined') {
+                        try {
+                            v2 = RED.util.evaluateNodeProperty(rule.v2,rule.v2t,node,msg);
+                        } catch(err) {
+                            v2 = undefined;
+                        }
+                    }
+                    if (rule.t == "else") { test = elseflag; elseflag = true; }
+                    if (operators[rule.t](test,v1,v2,rule.case,msg.parts)) {
+                        onward.push(msg);
+                        elseflag = false;
+                        if (node.checkall == "false") { break; }
+                    } else {
+                        onward.push(null);
+                    }
+                }
+                node.previousValue = prop;
+                if (!repair || !has_parts) {
+                    node.send(onward);
+                }
+                else {
+                    send2ports(onward, msg);
+                }
+            } catch(err) {
+                node.warn(err);
+            }
+        }
+
+        function clear_pending() {
+            pending_count = 0;
+            pending_id = 0;
+            pending_in = {};
+            pending_out = {};
             received = {};
         }
 
-        var pendingMessages = [];
-        var activeMessagePromise = null;
-        var processMessageQueue = function(msg) {
-            if (msg) {
-                // A new message has arrived - add it to the message queue
-                pendingMessages.push(msg);
-                if (activeMessagePromise !== null) {
-                    // The node is currently processing a message, so do nothing
-                    // more with this message
-                    return;
-                }
-            }
-            if (pendingMessages.length === 0) {
-                // There are no more messages to process, clear the active flag
-                // and return
-                activeMessagePromise = null;
-                return;
-            }
-
-            // There are more messages to process. Get the next message and
-            // start processing it. Recurse back in to check for any more
-            var nextMsg = pendingMessages.shift();
-            activeMessagePromise = processMessage(nextMsg,true)
-                .then(processMessageQueue)
-                .catch((err) => {
-                    node.error(err,nextMsg);
-                    return processMessageQueue();
-                });
-        }
-
         this.on('input', function(msg) {
-            processMessageQueue(msg);
+            process_msg(msg, true);
         });
 
         this.on('close', function() {
-            clearPending();
+            clear_pending();
         });
     }
 

nodes/core/logic/15-change.html

@@ -54,10 +54,6 @@
         outputs: 1,
         icon: "swap.png",
         label: function() {
-            function prop2name(type, key) {
-                var result = RED.utils.parseContextKey(key);
-                return type +"." +result.key;
-            }
             if (this.name) {
                 return this.name;
             }
@@ -74,13 +70,13 @@
             } else {
                 if (this.rules.length == 1) {
                     if (this.rules[0].t === "set") {
-                        return this._("change.label.set",{property:prop2name((this.rules[0].pt||"msg"), this.rules[0].p)});
+                        return this._("change.label.set",{property:(this.rules[0].pt||"msg")+"."+this.rules[0].p});
                     } else if (this.rules[0].t === "change") {
-                        return this._("change.label.change",{property:prop2name((this.rules[0].pt||"msg"), this.rules[0].p)});
+                        return this._("change.label.change",{property:(this.rules[0].pt||"msg")+"."+this.rules[0].p});
                     } else if (this.rules[0].t === "move") {
-                        return this._("change.label.move",{property:prop2name((this.rules[0].pt||"msg"), this.rules[0].p)});
+                        return this._("change.label.move",{property:(this.rules[0].pt||"msg")+"."+this.rules[0].p});
                     } else {
-                        return this._("change.label.delete",{property:prop2name((this.rules[0].pt||"msg"), this.rules[0].p)});
+                        return this._("change.label.delete",{property:(this.rules[0].pt||"msg")+"."+this.rules[0].p});
                     }
                 } else {
                     return this._("change.label.changeCount",{count:this.rules.length});

nodes/core/logic/15-change.js

@@ -98,61 +98,44 @@ module.exports = function(RED) {
             }
         }
 
-        function getToValue(msg,rule) {
-            var value = rule.to;
-            if (rule.tot === 'json') {
-                value = JSON.parse(rule.to);
-            } else if (rule.tot === 'bin') {
-                value = Buffer.from(JSON.parse(rule.to))
-            }
-            if (rule.tot === "msg") {
-                value = RED.util.getMessageProperty(msg,rule.to);
-            } else if ((rule.tot === 'flow') ||
-                       (rule.tot === 'global')) {
-                return new Promise((resolve,reject) => {
-                    RED.util.evaluateNodeProperty(rule.to, rule.tot, node, msg, (err,value) => {
-                        if (err) {
-                            resolve(undefined);
-                        } else {
-                            resolve(value);
-                        }
-                    });
-                });
-            } else if (rule.tot === 'date') {
-                value = Date.now();
-            } else if (rule.tot === 'jsonata') {
-                return new Promise((resolve,reject) => {
-                    RED.util.evaluateJSONataExpression(rule.to,msg, (err, value) => {
-                        if (err) {
-                            reject(RED._("change.errors.invalid-expr",{error:err.message}))
-                        } else {
-                            resolve(value);
-                        }
-                    });
-                });
-            }
-            return Promise.resolve(value);
-        }
-        function getFromValue(msg,rule) {
-            var fromValue;
-            var fromType;
-            var fromRE;
-            if (rule.t === 'change') {
-                if (rule.fromt === 'msg' || rule.fromt === 'flow' || rule.fromt === 'global') {
-                    return new Promise((resolve,reject) => {
+        function applyRule(msg,rule) {
+            try {
+                var property = rule.p;
+                var value = rule.to;
+                if (rule.tot === 'json') {
+                    value = JSON.parse(rule.to);
+                } else if (rule.tot === 'bin') {
+                    value = Buffer.from(JSON.parse(rule.to))
+                }
+                var current;
+                var fromValue;
+                var fromType;
+                var fromRE;
+                if (rule.tot === "msg") {
+                    value = RED.util.getMessageProperty(msg,rule.to);
+                } else if (rule.tot === 'flow') {
+                    value = node.context().flow.get(rule.to);
+                } else if (rule.tot === 'global') {
+                    value = node.context().global.get(rule.to);
+                } else if (rule.tot === 'date') {
+                    value = Date.now();
+                } else if (rule.tot === 'jsonata') {
+                    try{
+                        value = RED.util.evaluateJSONataExpression(rule.to,msg);
+                    } catch(err) {
+                        node.error(RED._("change.errors.invalid-expr",{error:err.message}));
+                        return;
+                    }
+                }
+                if (rule.t === 'change') {
+                    if (rule.fromt === 'msg' || rule.fromt === 'flow' || rule.fromt === 'global') {
                         if (rule.fromt === "msg") {
-                            resolve(RED.util.getMessageProperty(msg,rule.from));
-                        } else if (rule.fromt === 'flow' || rule.fromt === 'global') {
-                            var contextKey = RED.util.parseContextStore(rule.from);
-                            node.context()[rule.fromt].get(contextKey.key, contextKey.store, (err,fromValue) => {
-                                if (err) {
-                                    reject(err);
-                                } else {
-                                    resolve(fromValue);
-                                }
-                            });
+                            fromValue = RED.util.getMessageProperty(msg,rule.from);
+                        } else if (rule.fromt === 'flow') {
+                            fromValue = node.context().flow.get(rule.from);
+                        } else if (rule.fromt === 'global') {
+                            fromValue = node.context().global.get(rule.from);
                         }
-                    }).then(fromValue => {
                         if (typeof fromValue === 'number' || fromValue instanceof Number) {
                             fromType = 'num';
                         } else if (typeof fromValue === 'boolean') {
@@ -166,163 +149,108 @@ module.exports = function(RED) {
                             try {
                                 fromRE = new RegExp(fromRE, "g");
                             } catch (e) {
-                                return Promise.reject(new Error(RED._("change.errors.invalid-from",{error:e.message})));
+                                valid = false;
+                                node.error(RED._("change.errors.invalid-from",{error:e.message}));
+                                return;
                             }
                         } else {
-                            return Promise.reject(new Error(RED._("change.errors.invalid-from",{error:"unsupported type: "+(typeof fromValue)})));
+                            node.error(RED._("change.errors.invalid-from",{error:"unsupported type: "+(typeof fromValue)}));
+                            return
                         }
-                        return {
-                            fromType,
-                            fromValue,
-                            fromRE
-                        }
-                    });
-                } else {
-                    fromType = rule.fromt;
-                    fromValue = rule.from;
-                    fromRE = rule.fromRE;
-                }
-            }
-            return Promise.resolve({
-                fromType,
-                fromValue,
-                fromRE
-            });
-        }
-        function applyRule(msg,rule) {
-                var property = rule.p;
-                var current;
-                var fromValue;
-                var fromType;
-                var fromRE;
-                try {
-                return getToValue(msg,rule).then(value => {
-                    return getFromValue(msg,rule).then(fromParts => {
-                        fromValue = fromParts.fromValue;
-                        fromType = fromParts.fromType;
-                        fromRE = fromParts.fromRE;
-                        if (rule.pt === 'msg') {
-                            try {
-                                if (rule.t === 'delete') {
-                                    RED.util.setMessageProperty(msg,property,undefined);
-                                } else if (rule.t === 'set') {
-                                    RED.util.setMessageProperty(msg,property,value);
-                                } else if (rule.t === 'change') {
-                                    current = RED.util.getMessageProperty(msg,property);
-                                    if (typeof current === 'string') {
-                                        if ((fromType === 'num' || fromType === 'bool' || fromType === 'str') && current === fromValue) {
-                                            // str representation of exact from number/boolean
-                                            // only replace if they match exactly
-                                            RED.util.setMessageProperty(msg,property,value);
-                                        } else {
-                                            current = current.replace(fromRE,value);
-                                            RED.util.setMessageProperty(msg,property,current);
-                                        }
-                                    } else if ((typeof current === 'number' || current instanceof Number) && fromType === 'num') {
-                                        if (current == Number(fromValue)) {
-                                            RED.util.setMessageProperty(msg,property,value);
-                                        }
-                                    } else if (typeof current === 'boolean' && fromType === 'bool') {
-                                        if (current.toString() === fromValue) {
-                                            RED.util.setMessageProperty(msg,property,value);
-                                        }
-                                    }
-                                }
-                            } catch(err) {}
-                            return msg;
-                        } else if (rule.pt === 'flow' || rule.pt === 'global') {
-                            var contextKey = RED.util.parseContextStore(property);
-                            return new Promise((resolve,reject) => {
-                                var target = node.context()[rule.pt];
-                                var callback = err => {
-                                    if (err) {
-                                        reject(err);
-                                    } else {
-                                        resolve(msg);
-                                    }
-                                }
-                                if (rule.t === 'delete') {
-                                    target.set(contextKey.key,undefined,contextKey.store,callback);
-                                } else if (rule.t === 'set') {
-                                    target.set(contextKey.key,value,contextKey.store,callback);
-                                } else if (rule.t === 'change') {
-                                    target.get(contextKey.key,contextKey.store,(err,current) => {
-                                        if (err) {
-                                            reject(err);
-                                            return;
-                                        }
-                                        if (typeof current === 'string') {
-                                            if ((fromType === 'num' || fromType === 'bool' || fromType === 'str') && current === fromValue) {
-                                                // str representation of exact from number/boolean
-                                                // only replace if they match exactly
-                                                target.set(contextKey.key,value,contextKey.store,callback);
-                                            } else {
-                                                current = current.replace(fromRE,value);
-                                                target.set(contextKey.key,current,contextKey.store,callback);
-                                            }
-                                        } else if ((typeof current === 'number' || current instanceof Number) && fromType === 'num') {
-                                            if (current == Number(fromValue)) {
-                                                target.set(contextKey.key,value,contextKey.store,callback);
-                                            }
-                                        } else if (typeof current === 'boolean' && fromType === 'bool') {
-                                            if (current.toString() === fromValue) {
-                                                target.set(contextKey.key,value,contextKey.store,callback);
-                                            }
-                                        }
-                                    });
-                                }
-                            });
-                        }
-                    });
-                }).catch(err => {
-                    node.error(err, msg);
-                    return null;
-                });
-            } catch(err) {
-                return Promise.resolve(msg);
-            }
-        }
-        function applyRules(msg, currentRule) {
-            if (currentRule >= node.rules.length) {
-                return Promise.resolve(msg);
-            }
-            var r = node.rules[currentRule];
-            var rulePromise;
-            if (r.t === "move") {
-                if ((r.tot !== r.pt) || (r.p.indexOf(r.to) !== -1)) {
-                    rulePromise = applyRule(msg,{t:"set", p:r.to, pt:r.tot, to:r.p, tot:r.pt}).then(
-                        msg => applyRule(msg,{t:"delete", p:r.p, pt:r.pt})
-                    );
-                }
-                else { // 2 step move if we are moving from a child
-                    rulePromise = applyRule(msg,{t:"set", p:"_temp_move", pt:r.tot, to:r.p, tot:r.pt}).then(
-                        msg => applyRule(msg,{t:"delete", p:r.p, pt:r.pt})
-                    ).then(
-                        msg => applyRule(msg,{t:"set", p:r.to, pt:r.tot, to:"_temp_move", tot:r.pt})
-                    ).then(
-                        msg => applyRule(msg,{t:"delete", p:"_temp_move", pt:r.pt})
-                    )
-                }
-            } else {
-                rulePromise = applyRule(msg,r);
-            }
-            return rulePromise.then(
-                msg => {
-                    if (!msg) {
-                        return
-                    } else if (currentRule === node.rules.length - 1) {
-                        return msg;
                     } else {
-                        return applyRules(msg, currentRule+1);
+                        fromType = rule.fromt;
+                        fromValue = rule.from;
+                        fromRE = rule.fromRE;
                     }
                 }
-            );
+                if (rule.pt === 'msg') {
+                    if (rule.t === 'delete') {
+                        RED.util.setMessageProperty(msg,property,undefined);
+                    } else if (rule.t === 'set') {
+                        RED.util.setMessageProperty(msg,property,value);
+                    } else if (rule.t === 'change') {
+                        current = RED.util.getMessageProperty(msg,property);
+                        if (typeof current === 'string') {
+                            if ((fromType === 'num' || fromType === 'bool' || fromType === 'str') && current === fromValue) {
+                                // str representation of exact from number/boolean
+                                // only replace if they match exactly
+                                RED.util.setMessageProperty(msg,property,value);
+                            } else {
+                                current = current.replace(fromRE,value);
+                                RED.util.setMessageProperty(msg,property,current);
+                            }
+                        } else if ((typeof current === 'number' || current instanceof Number) && fromType === 'num') {
+                            if (current == Number(fromValue)) {
+                                RED.util.setMessageProperty(msg,property,value);
+                            }
+                        } else if (typeof current === 'boolean' && fromType === 'bool') {
+                            if (current.toString() === fromValue) {
+                                RED.util.setMessageProperty(msg,property,value);
+                            }
+                        }
+                    }
+                }
+                else {
+                    var target;
+                    if (rule.pt === 'flow') {
+                        target = node.context().flow;
+                    } else if (rule.pt === 'global') {
+                        target = node.context().global;
+                    }
+                    if (target) {
+                        if (rule.t === 'delete') {
+                            target.set(property,undefined);
+                        } else if (rule.t === 'set') {
+                            target.set(property,value);
+                        } else if (rule.t === 'change') {
+                            current = target.get(property);
+                            if (typeof current === 'string') {
+                                if ((fromType === 'num' || fromType === 'bool' || fromType === 'str') && current === fromValue) {
+                                    // str representation of exact from number/boolean
+                                    // only replace if they match exactly
+                                    target.set(property,value);
+                                } else {
+                                    current = current.replace(fromRE,value);
+                                    target.set(property,current);
+                                }
+                            } else if ((typeof current === 'number' || current instanceof Number) && fromType === 'num') {
+                                if (current == Number(fromValue)) {
+                                    target.set(property,value);
+                                }
+                            } else if (typeof current === 'boolean' && fromType === 'bool') {
+                                if (current.toString() === fromValue) {
+                                    target.set(property,value);
+                                }
+                            }
+                        }
+                    }
+                }
+            } catch(err) {/*console.log(err.stack)*/}
+            return msg;
         }
         if (valid) {
             this.on('input', function(msg) {
-                applyRules(msg, 0)
-                    .then( msg => { if (msg) { node.send(msg) }} )
-                    .catch( err => node.error(err, msg))
+                for (var i=0; i<this.rules.length; i++) {
+                    if (this.rules[i].t === "move") {
+                        var r = this.rules[i];
+                        if ((r.tot !== r.pt) || (r.p.indexOf(r.to) !== -1)) {
+                            msg = applyRule(msg,{t:"set", p:r.to, pt:r.tot, to:r.p, tot:r.pt});
+                            applyRule(msg,{t:"delete", p:r.p, pt:r.pt});
+                        }
+                        else { // 2 step move if we are moving from a child
+                            msg = applyRule(msg,{t:"set", p:"_temp_move", pt:r.tot, to:r.p, tot:r.pt});
+                            applyRule(msg,{t:"delete", p:r.p, pt:r.pt});
+                            msg = applyRule(msg,{t:"set", p:r.to, pt:r.tot, to:"_temp_move", tot:r.pt});
+                            applyRule(msg,{t:"delete", p:"_temp_move", pt:r.pt});
+                        }
+                    } else {
+                        msg = applyRule(msg,this.rules[i]);
+                    }
+                    if (msg === null) {
+                        return;
+                    }
+                }
+                node.send(msg);
             });
         }
     }

nodes/core/logic/17-split.html

@@ -415,7 +415,7 @@
                     $("#node-input-reduceExp").typedInput({types:[jsonata_or_empty]});
                     $("#node-input-reduceInit").typedInput({
                         default: 'num',
-                        types:['flow','global','str','num','bool','json','bin','date','jsonata','env'],
+                        types:['flow','global','str','num','bool','json','bin','date','jsonata'],
                         typeField: $("#node-input-reduceInitType")
                     });
                     $("#node-input-reduceFixup").typedInput({types:[jsonata_or_empty]});

nodes/core/logic/17-split.js

@@ -233,7 +233,7 @@ module.exports = function(RED) {
     RED.nodes.registerType("split",SplitNode);
 
 
-    var _max_kept_msgs_count;
+    var _max_kept_msgs_count = undefined;
 
     function max_kept_msgs_count(node) {
         if (_max_kept_msgs_count === undefined) {
@@ -252,29 +252,13 @@ module.exports = function(RED) {
         exp.assign("I", index);
         exp.assign("N", count);
         exp.assign("A", accum);
-        return new Promise((resolve,reject) => {
-            RED.util.evaluateJSONataExpression(exp, msg, (err, result) => {
-                if (err) {
-                    reject(err);
-                } else {
-                    resolve(result);
-                }
-            });
-        });
+        return RED.util.evaluateJSONataExpression(exp, msg);
     }
 
     function apply_f(exp, accum, count) {
         exp.assign("N", count);
         exp.assign("A", accum);
-        return new Promise((resolve,reject) => {
-            return RED.util.evaluateJSONataExpression(exp, {}, (err, result) => {
-                if (err) {
-                    reject(err);
-                } else {
-                    resolve(result);
-                }
-            });
-        });
+        return RED.util.evaluateJSONataExpression(exp, {});
     }
 
     function exp_or_undefined(exp) {
@@ -285,40 +269,32 @@ module.exports = function(RED) {
         return exp
     }
 
-    function reduceAndSendGroup(node, group) {
+    function reduce_and_send_group(node, group) {
         var is_right = node.reduce_right;
         var flag = is_right ? -1 : 1;
         var msgs = group.msgs;
-        return getInitialReduceValue(node, node.exp_init, node.exp_init_type).then(accum => {
-            var reduce_exp = node.reduce_exp;
-            var reduce_fixup = node.reduce_fixup;
-            var count = group.count;
-            msgs.sort(function(x,y) {
-                var ix = x.parts.index;
-                var iy = y.parts.index;
-                if (ix < iy) {return -flag;}
-                if (ix > iy) {return flag;}
-                return 0;
-            });
-
-            return msgs.reduce((promise, msg) => promise.then(accum => apply_r(reduce_exp, accum, msg, msg.parts.index, count)), Promise.resolve(accum))
-                .then(accum => {
-                    if(reduce_fixup !== undefined) {
-                        return apply_f(reduce_fixup, accum, count).then(accum => {
-                            node.send({payload: accum});
-                        });
-                    } else {
-                        node.send({payload: accum});
-                    }
-                });
-        }).catch(err => {
-            throw new Error(RED._("join.errors.invalid-expr",{error:err.message}));
+        var accum = eval_exp(node, node.exp_init, node.exp_init_type);
+        var reduce_exp = node.reduce_exp;
+        var reduce_fixup = node.reduce_fixup;
+        var count = group.count;
+        msgs.sort(function(x,y) {
+            var ix = x.parts.index;
+            var iy = y.parts.index;
+            if (ix < iy) return -flag;
+            if (ix > iy) return flag;
+            return 0;
         });
+        for(var msg of msgs) {
+            accum = apply_r(reduce_exp, accum, msg, msg.parts.index, count);
+        }
+        if(reduce_fixup !== undefined) {
+            accum = apply_f(reduce_fixup, accum, count);
+        }
+        node.send({payload: accum});
     }
 
     function reduce_msg(node, msg) {
-        var promise;
-        if (msg.hasOwnProperty('parts')) {
+        if(msg.hasOwnProperty('parts')) {
             var parts = msg.parts;
             var pending = node.pending;
             var pending_count = node.pending_count;
@@ -335,51 +311,66 @@ module.exports = function(RED) {
             }
             var group = pending[gid];
             var msgs = group.msgs;
-            if(parts.hasOwnProperty('count') && (group.count === undefined)) {
-                group.count = parts.count;
+            if(parts.hasOwnProperty('count') &&
+               (group.count === undefined)) {
+                group.count = count;
             }
             msgs.push(msg);
             pending_count++;
-            var completeProcess = function() {
-                node.pending_count = pending_count;
-                var max_msgs = max_kept_msgs_count(node);
-                if ((max_msgs > 0) && (pending_count > max_msgs)) {
-                    node.pending = {};
-                    node.pending_count = 0;
-                    var promise = Promise.reject(RED._("join.too-many"));
-                    promise.catch(()=>{});
-                    return promise;
-                }
-                return Promise.resolve();
-            }
             if(msgs.length === group.count) {
                 delete pending[gid];
-                pending_count -= msgs.length;
-                promise = reduceAndSendGroup(node, group).then(completeProcess);
-            } else {
-                promise = completeProcess();
+                try {
+                    pending_count -= msgs.length;
+                    reduce_and_send_group(node, group);
+                } catch(e) {
+                    node.error(RED._("join.errors.invalid-expr",{error:e.message}));            }
             }
-        } else {
+            node.pending_count = pending_count;
+            var max_msgs = max_kept_msgs_count(node);
+            if ((max_msgs > 0) && (pending_count > max_msgs)) {
+                node.pending = {};
+                node.pending_count = 0;
+                node.error(RED._("join.too-many"), msg);
+            }
+        }
+        else {
             node.send(msg);
         }
-        if (!promise) {
-            promise = Promise.resolve();
-        }
-        return promise;
     }
 
-    function getInitialReduceValue(node, exp, exp_type) {
-        return new Promise((resolve, reject) => {
-            RED.util.evaluateNodeProperty(exp, exp_type, node, {},
-                (err, result) => {
-                    if(err) {
-                        return reject(err);
-                    }
-                    else {
-                        return resolve(result);
-                    }
-                });
-            });
+    function eval_exp(node, exp, exp_type) {
+        if(exp_type === "flow") {
+            return node.context().flow.get(exp);
+        }
+        else if(exp_type === "global") {
+            return node.context().global.get(exp);
+        }
+        else if(exp_type === "str") {
+            return exp;
+        }
+        else if(exp_type === "num") {
+            return Number(exp);
+        }
+        else if(exp_type === "bool") {
+            if (exp === 'true') {
+                return true;
+            }
+            else if (exp === 'false') {
+                return false;
+            }
+        }
+        else if ((exp_type === "bin") ||
+                 (exp_type === "json")) {
+            return JSON.parse(exp);
+        }
+        else if(exp_type === "date") {
+            return Date.now();
+        }
+        else if(exp_type === "jsonata") {
+            var jexp = RED.util.prepareJSONataExpression(exp, node);
+            return RED.util.evaluateJSONataExpression(jexp, {});
+        }
+        throw new Error("unexpected initial value type");
     }
 
     function JoinNode(n) {
@@ -408,7 +399,6 @@ module.exports = function(RED) {
                 this.reduce_fixup = (exp_fixup !== undefined) ? RED.util.prepareJSONataExpression(exp_fixup, this) : undefined;
             } catch(e) {
                 this.error(RED._("join.errors.invalid-expr",{error:e.message}));
-                return;
             }
         }
 
@@ -447,8 +437,7 @@ module.exports = function(RED) {
                     newArray = newArray.concat(n);
                 })
                 group.payload = newArray;
-            }
-            else if (group.type === 'buffer') {
+            } else if (group.type === 'buffer') {
                 var buffers = [];
                 var bufferLen = 0;
                 if (group.joinChar !== undefined) {
@@ -461,8 +450,7 @@ module.exports = function(RED) {
                         buffers.push(group.payload[i]);
                         bufferLen += group.payload[i].length;
                     }
-                }
-                else {
+                } else {
                     bufferLen = group.bufferLen;
                     buffers = group.payload;
                 }
@@ -475,8 +463,7 @@ module.exports = function(RED) {
                     groupJoinChar = group.joinChar.toString();
                 }
                 RED.util.setMessageProperty(group.msg,node.property,group.payload.join(groupJoinChar));
-            }
-            else {
+            } else {
                 if (node.propertyType === 'full') {
                     group.msg = RED.util.cloneMessage(group.msg);
                 }
@@ -484,48 +471,13 @@ module.exports = function(RED) {
             }
             if (group.msg.hasOwnProperty('parts') && group.msg.parts.hasOwnProperty('parts')) {
                 group.msg.parts = group.msg.parts.parts;
-            }
-            else {
+            } else {
                 delete group.msg.parts;
             }
             delete group.msg.complete;
             node.send(group.msg);
         }
 
-        var pendingMessages = [];
-        var activeMessagePromise = null;
-        // In reduce mode, we must process messages fully in order otherwise
-        // groups may overlap and cause unexpected results. The use of JSONata
-        // means some async processing *might* occur if flow/global context is
-        // accessed.
-        var processReduceMessageQueue = function(msg) {
-            if (msg) {
-                // A new message has arrived - add it to the message queue
-                pendingMessages.push(msg);
-                if (activeMessagePromise !== null) {
-                    // The node is currently processing a message, so do nothing
-                    // more with this message
-                    return;
-                }
-            }
-            if (pendingMessages.length === 0) {
-                // There are no more messages to process, clear the active flag
-                // and return
-                activeMessagePromise = null;
-                return;
-            }
-
-            // There are more messages to process. Get the next message and
-            // start processing it. Recurse back in to check for any more
-            var nextMsg = pendingMessages.shift();
-            activeMessagePromise = reduce_msg(node, nextMsg)
-                .then(processReduceMessageQueue)
-                .catch((err) => {
-                    node.error(err,nextMsg);
-                    return processReduceMessageQueue();
-                });
-        }
-
         this.on("input", function(msg) {
             try {
                 var property;
@@ -564,7 +516,8 @@ module.exports = function(RED) {
                     propertyIndex = msg.parts.index;
                 }
                 else if (node.mode === 'reduce') {
-                    return processReduceMessageQueue(msg);
+                    reduce_msg(node, msg);
+                    return;
                 }
                 else {
                     // Use the node configuration to identify all of the group information
@@ -572,7 +525,7 @@ module.exports = function(RED) {
                     payloadType = node.build;
                     targetCount = node.count;
                     joinChar = node.joiner;
-                    if (n.count === "" && msg.hasOwnProperty('parts')) {
+                    if (targetCount === 0 && msg.hasOwnProperty('parts')) {
                         targetCount = msg.parts.count || 0;
                     }
                     if (node.build === 'object') {
@@ -601,7 +554,7 @@ module.exports = function(RED) {
                             payload:{},
                             targetCount:targetCount,
                             type:"object",
-                            msg:RED.util.cloneMessage(msg)
+                            msg:msg
                         };
                     }
                     else if (node.accumulate === true) {
@@ -611,7 +564,7 @@ module.exports = function(RED) {
                             payload:{},
                             targetCount:targetCount,
                             type:payloadType,
-                            msg:RED.util.cloneMessage(msg)
+                            msg:msg
                         }
                         if (payloadType === 'string' || payloadType === 'array' || payloadType === 'buffer') {
                             inflight[partId].payload = [];
@@ -623,7 +576,7 @@ module.exports = function(RED) {
                             payload:[],
                             targetCount:targetCount,
                             type:payloadType,
-                            msg:RED.util.cloneMessage(msg)
+                            msg:msg
                         };
                         if (payloadType === 'string') {
                             inflight[partId].joinChar = joinChar;
@@ -666,22 +619,19 @@ module.exports = function(RED) {
                 } else {
                     if (!isNaN(propertyIndex)) {
                         group.payload[propertyIndex] = property;
-                        group.currentCount++;
                     } else {
-                        if (property !== undefined) {
-                            group.payload.push(property);
-                            group.currentCount++;
-                        }
+                        group.payload.push(property);
                     }
+                    group.currentCount++;
                 }
-                group.msg = Object.assign(group.msg, msg);
+                // TODO: currently reuse the last received - add option to pick first received
+                group.msg = msg;
                 var tcnt = group.targetCount;
                 if (msg.hasOwnProperty("parts")) { tcnt = group.targetCount || msg.parts.count; }
                 if ((tcnt > 0 && group.currentCount >= tcnt) || msg.hasOwnProperty('complete')) {
                     completeSend(partId);
                 }
-            }
-            catch(err) {
+            } catch(err) {
                 console.log(err.stack);
             }
         });

nodes/core/logic/18-sort.js

@@ -17,7 +17,7 @@
 module.exports = function(RED) {
     "use strict";
 
-    var _max_kept_msgs_count;
+    var _max_kept_msgs_count = undefined;
 
     function max_kept_msgs_count(node) {
         if (_max_kept_msgs_count === undefined) {
@@ -32,20 +32,30 @@ module.exports = function(RED) {
         return _max_kept_msgs_count;
     }
 
-    // function get_context_val(node, name, dval) {
-    //     var context = node.context();
-    //     var val = context.get(name);
-    //     if (val === undefined) {
-    //         context.set(name, dval);
-    //         return dval;
-    //     }
-    //     return val;
-    // }
+    function eval_jsonata(node, code, val) {
+        try {
+            return RED.util.evaluateJSONataExpression(code, val);
+        }
+        catch (e) {
+            node.error(RED._("sort.invalid-exp"));
+            throw e;
+        }
+    }
+
+    function get_context_val(node, name, dval) {
+        var context = node.context();
+        var val = context.get(name);
+        if (val === undefined) {
+            context.set(name, dval);
+            return dval;
+        }
+        return val;
+    }
 
     function SortNode(n) {
         RED.nodes.createNode(this, n);
         var node = this;
-        var pending = {};//get_context_val(node, 'pending', {})
+        var pending = get_context_val(node, 'pending', {})
         var pending_count = 0;
         var pending_id = 0;
         var order = n.order || "ascending";
@@ -61,15 +71,16 @@ module.exports = function(RED) {
                 key_exp = RED.util.prepareJSONataExpression(key_exp, this);
             }
             catch (e) {
-                node.error(RED._("sort.invalid-exp",{message:e.toString()}));
+                node.error(RED._("sort.invalid-exp"));
                 return;
             }
         }
         var dir = (order === "ascending") ? 1 : -1;
-        var conv = as_num ? function(x) { return Number(x); }
-                          : function(x) { return x; };
+        var conv = as_num
+            ? function(x) { return Number(x); }
+            : function(x) { return x; };
 
-        function generateComparisonFunction(key) {
+        function gen_comp(key) {
             return function(x, y) {
                 var xp = conv(key(x));
                 var yp = conv(key(y));
@@ -79,105 +90,74 @@ module.exports = function(RED) {
             };
         }
 
-        function sortMessageGroup(group) {
-            var promise;
+        function send_group(group) {
+            var key = key_is_exp
+                ? function(msg) {
+                    return eval_jsonata(node, key_exp, msg);
+                }
+                : function(msg) {
+                    return RED.util.getMessageProperty(msg, key_prop);
+                };
+            var comp = gen_comp(key);
             var msgs = group.msgs;
-            if (key_is_exp) {
-                var evaluatedDataPromises = msgs.map(msg => {
-                    return new Promise((resolve,reject) => {
-                        RED.util.evaluateJSONataExpression(key_exp, msg, (err, result) => {
-                            if (err) {
-                                reject(RED._("sort.invalid-exp",{message:err.toString()}));
-                            } else {
-                                resolve({
-                                    item: msg,
-                                    sortValue: result
-                                })
-                            }
-                        });
-                    })
-                });
-                promise = Promise.all(evaluatedDataPromises).then(evaluatedElements => {
-                    // Once all of the sort keys are evaluated, sort by them
-                    var comp = generateComparisonFunction(elem=>elem.sortValue);
-                    return evaluatedElements.sort(comp).map(elem=>elem.item);
-                });
-            } else {
-                var key = function(msg) {
-                    return ;
-                }
-                var comp = generateComparisonFunction(msg => RED.util.getMessageProperty(msg, key_prop));
-                try {
-                    msgs.sort(comp);
-                }
-                catch (e) {
-                    return; // not send when error
-                }
-                promise = Promise.resolve(msgs);
+            try {
+                msgs.sort(comp);
+            }
+            catch (e) {
+                return; // not send when error
+            }
+            for (var i = 0; i < msgs.length; i++) {
+                var msg = msgs[i];
+                msg.parts.index = i;
+                node.send(msg);
             }
-            return promise.then(msgs => {
-                for (var i = 0; i < msgs.length; i++) {
-                    var msg = msgs[i];
-                    msg.parts.index = i;
-                    node.send(msg);
-                }
-            });
         }
 
-        function sortMessageProperty(msg) {
+        function sort_payload(msg) {
             var data = RED.util.getMessageProperty(msg, target_prop);
             if (Array.isArray(data)) {
-                if (key_is_exp) {
-                    // key is an expression. Evaluated the expression for each item
-                    // to get its sort value. As this could be async, need to do
-                    // it first.
-                    var evaluatedDataPromises = data.map(elem => {
-                        return new Promise((resolve,reject) => {
-                            RED.util.evaluateJSONataExpression(key_exp, elem, (err, result) => {
-                                if (err) {
-                                    reject(RED._("sort.invalid-exp",{message:err.toString()}));
-                                } else {
-                                    resolve({
-                                        item: elem,
-                                        sortValue: result
-                                    })
-                                }
-                            });
-                        })
-                    })
-                    return Promise.all(evaluatedDataPromises).then(evaluatedElements => {
-                        // Once all of the sort keys are evaluated, sort by them
-                        // and reconstruct the original message item with the newly
-                        // sorted values.
-                        var comp = generateComparisonFunction(elem=>elem.sortValue);
-                        data = evaluatedElements.sort(comp).map(elem=>elem.item);
-                        RED.util.setMessageProperty(msg, target_prop,data);
-                        return true;
-                    })
-                } else {
-                    var comp = generateComparisonFunction(elem=>elem);
-                    try {
-                        data.sort(comp);
-                    } catch (e) {
-                        return Promise.resolve(false);
+                var key = key_is_exp
+                    ? function(elem) {
+                        return eval_jsonata(node, key_exp, elem);
                     }
-                    return Promise.resolve(true);
+                    : function(elem) { return elem; };
+                var comp = gen_comp(key);
+                try {
+                    data.sort(comp);
                 }
+                catch (e) {
+                    return false;
+                }
+                return true;
             }
-            return Promise.resolve(false);
+            return false;
         }
 
-        function removeOldestPending() {
-            var oldest;
-            var oldest_key;
+        function check_parts(parts) {
+            if (parts.hasOwnProperty("id") &&
+                parts.hasOwnProperty("index")) {
+                return true;
+            }
+            return false;
+        }
+
+        function clear_pending() {
             for(var key in pending) {
-                if (pending.hasOwnProperty(key)) {
-                    var item = pending[key];
-                    if((oldest === undefined) ||
-                       (oldest.seq_no > item.seq_no)) {
-                        oldest = item;
-                        oldest_key = key;
-                    }
+                node.log(RED._("sort.clear"), pending[key].msgs[0]);
+                delete pending[key];
+            }
+            pending_count = 0;
+        }
+
+        function remove_oldest_pending() {
+            var oldest = undefined;
+            var oldest_key = undefined;
+            for(var key in pending) {
+                var item = pending[key];
+                if((oldest === undefined) ||
+                   (oldest.seq_no > item.seq_no)) {
+                    oldest = item;
+                    oldest_key = key;
                 }
             }
             if(oldest !== undefined) {
@@ -186,19 +166,16 @@ module.exports = function(RED) {
             }
             return 0;
         }
-
-        function processMessage(msg) {
+        
+        function process_msg(msg) {
             if (target_is_prop) {
-                sortMessageProperty(msg).then(send => {
-                    if (send) {
-                        node.send(msg);
-                    }
-                }).catch(err => {
-                    node.error(err,msg);
-                });
+                if (sort_payload(msg)) {
+                    node.send(msg);
+                }
+                return;
             }
             var parts = msg.parts;
-            if (!parts.hasOwnProperty("id") || !parts.hasOwnProperty("index")) {
+            if (!check_parts(parts)) {
                 return;
             }
             var gid = parts.id;
@@ -218,31 +195,23 @@ module.exports = function(RED) {
             pending_count++;
             if (group.count === msgs.length) {
                 delete pending[gid]
-                sortMessageGroup(group).catch(err => {
-                    node.error(err,msg);
-                });
+                send_group(group);
                 pending_count -= msgs.length;
-            } else {
-                var max_msgs = max_kept_msgs_count(node);
-                if ((max_msgs > 0) && (pending_count > max_msgs)) {
-                    pending_count -= removeOldestPending();
-                    node.error(RED._("sort.too-many"), msg);
-                }
+            }
+            var max_msgs = max_kept_msgs_count(node);
+            if ((max_msgs > 0) && (pending_count > max_msgs)) {
+                pending_count -= remove_oldest_pending();
+                node.error(RED._("sort.too-many"), msg);
             }
         }
-
+        
         this.on("input", function(msg) {
-            processMessage(msg);
+            process_msg(msg);
         });
 
         this.on("close", function() {
-            for(var key in pending) {
-                if (pending.hasOwnProperty(key)) {
-                    node.log(RED._("sort.clear"), pending[key].msgs[0]);
-                    delete pending[key];
-                }
-            }
-            pending_count = 0;        })
+            clear_pending();
+        })
     }
 
     RED.nodes.registerType("sort", SortNode);

nodes/core/parsers/70-JSON.html

@@ -31,8 +31,6 @@
     <dl class="message-properties">
         <dt>payload<span class="property-type">object | string</span></dt>
         <dd>A JavaScript object or JSON string.</dd>
-        <dt>schema<span class="property-type">object</span></dt>
-        <dd>An optional JSON Schema object to validate the payload against.</dd>
     </dl>
     <h3>Outputs</h3>
     <dl class="message-properties">
@@ -43,9 +41,6 @@
                 <li>If the input is a JavaScript object it creates a JSON string. The string can optionally be well-formatted.</li>
             </ul>
         </dd>
-        <dt>schemaError<span class="property-type">array</span></dt>
-        <dd>If JSON schema validation fails, the catch node will have a <code>schemaError</code> property
-            containing an array of errors.</dd>
     </dl>
     <h3>Details</h3>
     <p>By default, the node operates on <code>msg.payload</code>, but can be configured
@@ -58,8 +53,6 @@
        receives a String, no further checks will be made of the property. It will
        not check the String is valid JSON nor will it reformat it if the format option
        is selected.</p>
-    <p>For more details about JSON Schema you can consult the specification
-    <a href="http://json-schema.org/latest/json-schema-validation.html">here</a>.</p>
 </script>
 
 <script type="text/javascript">

nodes/core/parsers/70-JSON.js

@@ -16,52 +16,21 @@
 
 module.exports = function(RED) {
     "use strict";
-    const Ajv = require('ajv');
-    const ajv = new Ajv({allErrors: true, schemaId: 'auto'});
-    ajv.addMetaSchema(require('ajv/lib/refs/json-schema-draft-04.json'));
 
     function JSONNode(n) {
         RED.nodes.createNode(this,n);
         this.indent = n.pretty ? 4 : 0;
         this.action = n.action||"";
         this.property = n.property||"payload";
-        this.schema = null;
-        this.compiledSchema = null;
-
         var node = this;
         this.on("input", function(msg) {
-            var validate = false;
-            if (msg.schema) {
-                // If input schema is different, re-compile it
-                if (JSON.stringify(this.schema) != JSON.stringify(msg.schema)) {
-                    try {
-                        this.compiledSchema = ajv.compile(msg.schema);
-                        this.schema = msg.schema;
-                    } catch(e) {
-                        this.schema = null;
-                        this.compiledSchema = null;
-                        node.error(RED._("json.errors.schema-error-compile"), msg);
-                        return;
-                    }
-                }
-                validate = true;
-            }
             var value = RED.util.getMessageProperty(msg,node.property);
             if (value !== undefined) {
                 if (typeof value === "string") {
                     if (node.action === "" || node.action === "obj") {
                         try {
                             RED.util.setMessageProperty(msg,node.property,JSON.parse(value));
-                            if (validate) {
-                                if (this.compiledSchema(msg[node.property])) {
-                                    node.send(msg);
-                                } else {
-                                    msg.schemaError = this.compiledSchema.errors;
-                                    node.error(`${RED._("json.errors.schema-error")}: ${ajv.errorsText(this.compiledSchema.errors)}`, msg);
-                                }
-                            } else  {
-                                node.send(msg);
-                            }
+                            node.send(msg);
                         }
                         catch(e) { node.error(e.message,msg); }
                     } else {
@@ -72,19 +41,8 @@ module.exports = function(RED) {
                     if (node.action === "" || node.action === "str") {
                         if (!Buffer.isBuffer(value)) {
                             try {
-                                if (validate) {
-                                    if (this.compiledSchema(value)) {
-                                        RED.util.setMessageProperty(msg,node.property,JSON.stringify(value,null,node.indent));
-                                        node.send(msg);
-                                    } else {
-                                        msg.schemaError = this.compiledSchema.errors;
-                                        node.error(`${RED._("json.errors.schema-error")}: ${ajv.errorsText(this.compiledSchema.errors)}`, msg);
-                                    }
-                                } else {
-                                    RED.util.setMessageProperty(msg,node.property,JSON.stringify(value,null,node.indent));
-                                    node.send(msg);
-                                }
-
+                                RED.util.setMessageProperty(msg,node.property,JSON.stringify(value,null,node.indent));
+                                node.send(msg);
                             }
                             catch(e) { node.error(RED._("json.errors.dropped-error")); }
                         }

nodes/core/storage/50-file.html

@@ -37,8 +37,6 @@
         <dt class="optional">filename <span class="property-type">string</span></dt>
         <dd>If not configured in the node, this optional property sets the name of the file to be updated.</dd>
     </dl>
-    <h3>Output</h3>
-    <p>On completion of write, input message is sent to output port.</p>
     <h3>Details</h3>
     <p>Each message payload will be added to the end of the file, optionally appending
     a newline (\n) character between each one.</p>
@@ -125,8 +123,9 @@
         },
         color:"BurlyWood",
         inputs:1,
-        outputs:1,
-        icon: "file-out.png",
+        outputs:0,
+        icon: "file.png",
+        align: "right",
         label: function() {
             if (this.overwriteFile === "delete") {
                 return this.name||this._("file.label.deletelabel",{file:this.filename});
@@ -160,7 +159,7 @@
         outputLabels: function(i) {
             return (this.format === "utf8") ? "UTF8 string" : "binary buffer";
         },
-        icon: "file-in.png",
+        icon: "file.png",
         label: function() {
             return this.name||this.filename||this._("file.label.filelabel");
         },

nodes/core/storage/50-file.js

@@ -39,20 +39,14 @@ module.exports = function(RED) {
                     node.tout = null;
                 },333);
             }
-            if (filename === "") {
-                node.warn(RED._("file.errors.nofilename"));
-            } else if (node.overwriteFile === "delete") {
+            if (filename === "") { node.warn(RED._("file.errors.nofilename")); }
+            else if (node.overwriteFile === "delete") {
                 fs.unlink(filename, function (err) {
-                    if (err) {
-                        node.error(RED._("file.errors.deletefail",{error:err.toString()}),msg);
-                    } else {
-                        if (RED.settings.verbose) {
-                            node.log(RED._("file.status.deletedfile",{file:filename}));
-                        }
-                        node.send(msg);
-                    }
+                    if (err) { node.error(RED._("file.errors.deletefail",{error:err.toString()}),msg); }
+                    else if (RED.settings.verbose) { node.log(RED._("file.status.deletedfile",{file:filename})); }
                 });
-            } else if (msg.hasOwnProperty("payload") && (typeof msg.payload !== "undefined")) {
+            }
+            else if (msg.hasOwnProperty("payload") && (typeof msg.payload !== "undefined")) {
                 var dir = path.dirname(filename);
                 if (node.createDir) {
                     try {
@@ -70,21 +64,15 @@ module.exports = function(RED) {
                 if (typeof data === "boolean") { data = data.toString(); }
                 if (typeof data === "number") { data = data.toString(); }
                 if ((node.appendNewline) && (!Buffer.isBuffer(data))) { data += os.EOL; }
-                node.data.push({msg:msg,data:Buffer.from(data)});
+                node.data.push(Buffer.from(data));
 
                 while (node.data.length > 0) {
                     if (node.overwriteFile === "true") {
-                        (function(packet) {
-                            node.wstream = fs.createWriteStream(filename, { encoding:'binary', flags:'w', autoClose:true });
-                            node.wstream.on("error", function(err) {
-                                node.error(RED._("file.errors.writefail",{error:err.toString()}),msg);
-                            });
-                            node.wstream.on("open", function() {
-                                node.wstream.end(packet.data, function() {
-                                    node.send(packet.msg);
-                                });
-                            })
-                        })(node.data.shift());
+                        node.wstream = fs.createWriteStream(filename, { encoding:'binary', flags:'w', autoClose:true });
+                        node.wstream.on("error", function(err) {
+                            node.error(RED._("file.errors.writefail",{error:err.toString()}),msg);
+                        });
+                        node.wstream.end(node.data.shift());
                     }
                     else {
                         // Append mode
@@ -127,17 +115,10 @@ module.exports = function(RED) {
                         }
                         if (node.filename) {
                             // Static filename - write and reuse the stream next time
-                            var packet = node.data.shift()
-                            node.wstream.write(packet.data, function() {
-                                node.send(packet.msg);
-                            });
-
+                            node.wstream.write(node.data.shift());
                         } else {
                             // Dynamic filename - write and close the stream
-                            var packet = node.data.shift()
-                            node.wstream.end(packet.data, function() {
-                                node.send(packet.msg);
-                            });
+                            node.wstream.end(node.data.shift());
                             delete node.wstream;
                             delete node.wstreamIno;
                         }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red",
-  "version": "0.19.2",
+  "version": "0.18.7",
   "description": "A visual tool for wiring the Internet of Things",
   "homepage": "http://nodered.org",
   "license": "Apache-2.0",
@@ -33,36 +33,35 @@
     "flow"
   ],
   "dependencies": {
-    "ajv": "6.5.3",
     "basic-auth": "2.0.0",
     "bcryptjs": "2.4.3",
     "body-parser": "1.18.3",
     "cheerio": "0.22.0",
-    "clone": "2.1.2",
+    "clone": "2.1.1",
     "cookie": "0.3.1",
     "cookie-parser": "1.4.3",
     "cors": "2.8.4",
     "cron": "1.3.0",
-    "denque": "1.3.0",
     "express": "4.16.3",
     "express-session": "1.15.6",
     "fs-extra": "5.0.0",
     "fs.notify": "0.0.4",
     "hash-sum": "1.0.2",
-    "i18next": "11.6.0",
+    "i18next": "1.10.6",
     "is-utf8": "0.2.1",
-    "js-yaml": "3.12.0",
+    "js-yaml": "3.11.0",
     "json-stringify-safe": "5.0.1",
     "jsonata": "1.5.4",
     "media-typer": "0.3.0",
     "memorystore": "1.6.0",
-    "mqtt": "2.18.5",
-    "multer": "1.3.1",
-    "mustache": "2.3.1",
+    "mqtt": "2.18.0",
+    "multer": "1.3.0",
+    "mustache": "2.3.0",
     "node-red-node-email": "0.1.*",
-    "node-red-node-feedparser": "^0.1.12",
+    "node-red-node-feedparser": "0.1.*",
     "node-red-node-rbe": "0.2.*",
-    "node-red-node-twitter": "^1.1.0",
+    "node-red-node-sentiment": "^0.1.0",
+    "node-red-node-twitter": "*",
     "nopt": "4.0.1",
     "oauth2orize": "1.11.0",
     "on-headers": "1.0.1",
@@ -70,20 +69,19 @@
     "passport-http-bearer": "1.0.1",
     "passport-oauth2-client-password": "0.1.2",
     "raw-body": "2.3.3",
-    "request": "2.88.0",
-    "semver": "5.5.1",
-    "sentiment": "2.1.0",
-    "uglify-js": "3.4.8",
+    "request": "2.87.0",
+    "semver": "5.5.0",
+    "uglify-js": "3.3.25",
     "when": "3.7.8",
     "ws": "1.1.5",
     "xml2js": "0.4.19"
   },
   "optionalDependencies": {
-    "bcrypt": "~2.0.0"
+    "bcrypt": "~1.0.3"
   },
   "devDependencies": {
-    "chromedriver": "^2.41.0",
-    "grunt": "~1.0.3",
+    "chromedriver": "^2.33.2",
+    "grunt": "~1.0.1",
     "grunt-chmod": "~1.1.1",
     "grunt-cli": "~1.2.0",
     "grunt-concurrent": "~2.3.1",
@@ -92,8 +90,8 @@
     "grunt-contrib-concat": "~1.0.1",
     "grunt-contrib-copy": "~1.0.0",
     "grunt-contrib-jshint": "~1.1.0",
-    "grunt-contrib-uglify": "~3.4.0",
-    "grunt-contrib-watch": "~1.1.0",
+    "grunt-contrib-uglify": "~3.3.0",
+    "grunt-contrib-watch": "~1.0.0",
     "grunt-jsonlint": "~1.1.0",
     "grunt-mocha-istanbul": "5.0.2",
     "grunt-nodemon": "~0.4.2",
@@ -102,16 +100,16 @@
     "grunt-webdriver": "^2.0.3",
     "http-proxy": "^1.16.2",
     "istanbul": "0.4.5",
-    "mocha": "^5.2.0",
-    "node-red-node-test-helper": "0.1.7",
+    "mocha": "^5.1.1",
     "should": "^8.4.0",
     "sinon": "1.17.7",
     "stoppable": "^1.0.6",
-    "supertest": "3.1.0",
-    "wdio-chromedriver-service": "^0.1.3",
-    "wdio-mocha-framework": "^0.6.2",
-    "wdio-spec-reporter": "^0.1.5",
-    "webdriverio": "^4.13.1"
+    "supertest": "3.0.0",
+    "wdio-chromedriver-service": "^0.1.1",
+    "wdio-mocha-framework": "^0.5.11",
+    "wdio-spec-reporter": "^0.1.3",
+    "webdriverio": "^4.9.11",
+    "node-red-node-test-helper": "^0.1.7"
   },
   "engines": {
     "node": ">=4"

red.js

@@ -101,18 +101,8 @@ if (parsedArgs.settings) {
             var settingsStat = fs.statSync(defaultSettings);
             if (settingsStat.mtime.getTime() <= settingsStat.ctime.getTime()) {
                 // Default settings file has not been modified - safe to copy
-                try {
-                    fs.copySync(defaultSettings,userSettingsFile);
-                    settingsFile = userSettingsFile;
-                }
-                catch (err) {
-                    console.log("Failed to copy settings file to "+userSettingsFile);
-                    console.log("Error: "+err.toString());
-                    if (err.code == "EACCES") {
-                        console.log("You may need to set readOnly: true, in settings.js");
-                    }
-                    process.exit(1);
-                }
+                fs.copySync(defaultSettings,userSettingsFile);
+                settingsFile = userSettingsFile;
             } else {
                 // Use default settings.js as it has been modified
                 settingsFile = defaultSettings;

red/api/admin/context.js

@@ -1,133 +0,0 @@
-/**
- * Copyright JS Foundation and other contributors, http://js.foundation
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
-
-var log;
-var redNodes;
-var util;
-var settings;
-
-function exportContextStore(scope,ctx, store, result, callback) {
-    ctx.keys(store,function(err, keys) {
-        if (err) {
-            return callback(err);
-        }
-        result[store] = {};
-        var c = keys.length;
-        if (c === 0) {
-            callback(null);
-        } else {
-            keys.forEach(function(key) {
-                ctx.get(key,store,function(err, v) {
-                    if (err) {
-                        return callback(err);
-                    }
-                    if (scope !== 'global' ||
-                        store === redNodes.listContextStores().default ||
-                        !settings.hasOwnProperty("functionGlobalContext") ||
-                        !settings.functionGlobalContext.hasOwnProperty(key) ||
-                        settings.functionGlobalContext[key] !== v) {
-                            result[store][key] = util.encodeObject({msg:v});
-                    }
-                    c--;
-                    if (c === 0) {
-                        callback(null);
-                    }
-                });
-            });
-        }
-    });
-}
-
-module.exports = {
-    init: function(runtime) {
-        redNodes = runtime.nodes;
-        log = runtime.log;
-        util = runtime.util;
-        settings = runtime.settings;
-    },
-
-    get: function(req,res) {
-        var scope = req.params.scope;
-        var id = req.params.id;
-        var key = req.params[0];
-        var availableStores = redNodes.listContextStores();
-        //{ default: 'default', stores: [ 'default', 'file' ] }
-        var store = req.query['store'];
-        if (store && availableStores.stores.indexOf(store) === -1) {
-            return res.status(404).end();
-        }
-        var ctx;
-        if (scope === 'global') {
-            ctx = redNodes.getContext('global');
-        } else if (scope === 'flow') {
-            ctx = redNodes.getContext(id);
-        } else if (scope === 'node') {
-            var node = redNodes.getNode(id);
-            if (node) {
-                ctx = node.context();
-            }
-        }
-        if (ctx) {
-            if (key) {
-                store = store || availableStores.default;
-                ctx.get(key,store,function(err, v) {
-                    var encoded = util.encodeObject({msg:v});
-                    if (store !== availableStores.default) {
-                        encoded.store = store;
-                    }
-                    res.json(encoded);
-                });
-                return;
-            } else {
-                var stores;
-                if (!store) {
-                    stores = availableStores.stores;
-                } else {
-                    stores = [store];
-                }
-
-                var result = {};
-                var c = stores.length;
-                var errorReported = false;
-                stores.forEach(function(store) {
-                    exportContextStore(scope,ctx,store,result,function(err) {
-                        if (err) {
-                            // TODO: proper error reporting
-                            if (!errorReported) {
-                                errorReported = true;
-                                res.end(400);
-                            }
-                            return;
-                        }
-                        c--;
-                        if (c === 0) {
-                            if (!errorReported) {
-                                if (stores.length > 1 && scope === 'global') {
-                                }
-                                res.json(result);
-                            }
-                        }
-                    });
-                })
-
-
-
-            }
-        } else {
-            res.json({});
-        }
-    }
-}

red/api/admin/index.js

@@ -19,7 +19,6 @@ var express = require("express");
 var nodes = require("./nodes");
 var flows = require("./flows");
 var flow = require("./flow");
-var context = require("./context");
 var auth = require("../auth");
 
 var apiUtil = require("../util");
@@ -29,7 +28,6 @@ module.exports = {
         flows.init(runtime);
         flow.init(runtime);
         nodes.init(runtime);
-        context.init(runtime);
 
         var needsPermission = auth.needsPermission;
 
@@ -54,12 +52,6 @@ module.exports = {
         adminApp.get(/\/nodes\/((@[^\/]+\/)?[^\/]+)\/([^\/]+)$/,needsPermission("nodes.read"),nodes.getSet,apiUtil.errorHandler);
         adminApp.put(/\/nodes\/((@[^\/]+\/)?[^\/]+)\/([^\/]+)$/,needsPermission("nodes.write"),nodes.putSet,apiUtil.errorHandler);
 
-        // Context
-        adminApp.get("/context/:scope(global)",needsPermission("context.read"),context.get,apiUtil.errorHandler);
-        adminApp.get("/context/:scope(global)/*",needsPermission("context.read"),context.get,apiUtil.errorHandler);
-        adminApp.get("/context/:scope(node|flow)/:id",needsPermission("context.read"),context.get,apiUtil.errorHandler);
-        adminApp.get("/context/:scope(node|flow)/:id/*",needsPermission("context.read"),context.get,apiUtil.errorHandler);
-
         return adminApp;
     }
 }

red/api/editor/locales.js

@@ -29,13 +29,13 @@ module.exports = {
         var lngs = req.query.lng;
         namespace = namespace.replace(/\.json$/,"");
         var lang = req.query.lng; //apiUtil.determineLangFromHeaders(req.acceptsLanguages() || []);
-        var prevLang = i18n.i.language;
+        var prevLang = i18n.i.lng();
         // Trigger a load from disk of the language if it is not the default
-        i18n.i.changeLanguage(lang, function(){
-            var catalog = i18n.i.getResourceBundle(lang, namespace);
+        i18n.i.setLng(lang, function(){
+            var catalog = i18n.catalog(namespace,lang);
             res.json(catalog||{});
         });
-        i18n.i.changeLanguage(prevLang);
+        i18n.i.setLng(prevLang);
 
     },
     getAllNodes: function(req,res) {
@@ -44,7 +44,7 @@ module.exports = {
         var result = {};
         nodeList.forEach(function(n) {
             if (n.module !== "node-red") {
-                result[n.id] = i18n.i.getResourceBundle(lngs, n.id)||{};
+                result[n.id] = i18n.catalog(n.id,lngs)||{};
             }
         });
         res.json(result);

red/api/editor/locales/en-US/editor.json

@@ -265,8 +265,6 @@
         "settingIcon": "Icon",
         "noDefaultLabel": "none",
         "defaultLabel": "use default label",
-        "searchIcons": "Search icons",
-        "useDefault": "use default",
         "errors": {
             "scopeChange": "Changing the scope will make it unavailable to nodes in other flows that use it"
         }
@@ -308,11 +306,13 @@
         "savedNodes": "Saved nodes",
         "savedType": "Saved __type__",
         "saveFailed": "Save failed: __message__",
+
         "filename": "Filename",
         "folder": "Folder",
         "filenamePlaceholder": "file",
         "fullFilenamePlaceholder": "a/b/file",
         "folderPlaceholder": "a/b",
+
         "breadcrumb": "Library"
     },
     "palette": {
@@ -358,6 +358,7 @@
                 "monthsV_plural": "__count__ months ago",
                 "yearsV": "__count__ year ago",
                 "yearsV_plural": "__count__ years ago",
+
                 "yearMonthsV": "__y__ year, __count__ month ago",
                 "yearMonthsV_plural": "__y__ year, __count__ months ago",
                 "yearsMonthsV": "__y__ years, __count__ month ago",
@@ -458,16 +459,6 @@
             "filterAll":"all",
             "filtered": "__count__ hidden"
         },
-        "context": {
-            "name":"Context Data",
-            "label":"context",
-            "none": "none selected",
-            "refresh": "refresh to load",
-            "empty": "empty",
-            "node": "Node",
-            "flow": "Flow",
-            "global": "Global"
-        },
         "palette": {
             "name": "Palette management",
             "label": "palette"
@@ -488,14 +479,15 @@
                 "install": "install",
                 "removeFromProject": "remove from project",
                 "addToProject": "add to project",
+                "none": "None",
                 "files": "Files",
                 "flow": "Flow",
                 "credentials": "Credentials",
                 "invalidEncryptionKey": "Invalid encryption key",
                 "encryptionEnabled": "Encryption enabled",
                 "encryptionDisabled": "Encryption disabled",
-                "setTheEncryptionKey": "Set the encryption key:",
                 "resetTheEncryptionKey": "Reset the encryption key:",
+                "setTheEncryptionKey": "Set the encryption key:",
                 "changeTheEncryptionKey": "Change the encryption key:",
                 "currentKey": "Current key",
                 "newKey": "New key",
@@ -618,9 +610,7 @@
             "bool": "boolean",
             "json": "JSON",
             "bin": "buffer",
-            "date": "timestamp",
-            "jsonata": "expression",
-            "env": "env variable"
+            "date": "timestamp"
         }
     },
     "editableList": {
@@ -649,9 +639,6 @@
             "eval": "Error evaluating expression:\n  __message__"
         }
     },
-    "jsEditor": {
-        "title": "JavaScript editor"
-    },
     "jsonEditor": {
         "title": "JSON editor",
         "format": "format JSON"
@@ -714,7 +701,7 @@
             "ssh-key-add": "Add an ssh key",
             "credential-key": "Credentials encryption key",
             "cant-get-ssh-key": "Error! Can't get selected SSH key path.",
-            "already-exists2": "already exists",
+            "already-exists": "already exists",
             "git-error": "git error",
             "connection-failed": "Connection failed",
             "not-git-repo": "Not a git repository",
@@ -808,7 +795,6 @@
             "username": "Username",
             "password": "Password",
             "passphrase": "Passphrase",
-            "retry": "Retry",
             "update-failed": "Failed to update auth",
             "unhandled": "Unhandled error response"
         },

red/api/editor/locales/en-US/jsonata.json

@@ -189,11 +189,11 @@
         "desc":"Returns an aggregated value derived from applying the `function` parameter successively to each value in `array` in combination with the result of the previous application of the function.\n\nThe function must accept two arguments, and behaves like an infix operator between each value within the `array`.\n\nThe optional `init` parameter is used as the initial value in the aggregation."
     },
     "$flowContext": {
-        "args": "string[, string]",
+        "args": "string",
         "desc": "Retrieves a flow context property.\n\nThis is a Node-RED defined function."
     },
     "$globalContext": {
-        "args": "string[, string]",
+        "args": "string",
         "desc": "Retrieves a global context property.\n\nThis is a Node-RED defined function."
     },
     "$pad": {

red/api/editor/locales/ja/editor.json

@@ -98,13 +98,10 @@
             "nodeActionDisabled": "ノードのアクションは、サブフロー内で無効になっています",
             "missing-types": "不明なノードが存在するため、フローを停止しました。詳細はログを確認してください。",
             "restartRequired": "更新されたモジュールを有効化するため、Node-REDを再起動する必要があります",
-            "credentials_load_failed": "<p>認証情報を復号できないため、フローを停止しました</p><p>フローの認証情報ファイルは暗号化されています。しかし、プロジェクトの暗号鍵が存在しない、または不正です</p>",
-            "credentials_load_failed_reset": "<p>認証情報を復号できません</p><p>フローの認証情報ファイルは暗号化されています。しかし、プロジェクトの暗号鍵が存在しない、または不正です。</p><p>次回のデプロイでフローの認証情報ファイルがリセットされます。既存フローの認証情報は削除されます。</p>",
+            "credentials_load_failed": "<p>認証情報を復号できないため、フローを停止しました</p><p>フローの認証情報は暗号化されています。しかし、プロジェクトの暗号鍵が存在しない、または不正です</p>",
             "missing_flow_file": "<p>プロジェクトのフローファイルが存在しません</p><p>本プロジェクトにフローファイルが登録されていません</p>",
-            "missing_package_file": "<p>プロジェクトのパッケージファイルが存在しません</p><p>本プロジェクトにはpackage.jsonファイルがありません</p>",
             "project_empty": "<p>空のプロジェクトです</p><p>デフォルトのプロジェクトファイルを作成しますか？<br/>作成しない場合、エディタの外でファイルをプロジェクトへ手動で追加する必要があります</p>",
-            "project_not_found": "<p>プロジェクト '__project__' が存在しません</p>",
-            "git_merge_conflict": "<p>変更の自動マージが失敗しました</p><p>マージされていない競合を解決し、コミットしてください</p>"
+            "project_not_found": "<p>プロジェクト '__project__' が存在しません</p>"
         },
         "error": "<strong>エラー</strong>: __message__",
         "errors": {
@@ -239,7 +236,6 @@
         "output": "出力:",
         "deleteSubflow": "サブフローを削除",
         "info": "詳細",
-        "category": "カテゴリ",
         "format": "マークダウン形式",
         "errors": {
             "noNodesSelected": "<strong>サブフローを作成できません</strong>: ノードが選択されていません",
@@ -264,8 +260,6 @@
         "settingIcon": "アイコン",
         "noDefaultLabel": "なし",
         "defaultLabel": "既定の名前を使用",
-        "searchIcons": "アイコンを検索",
-        "useDefault":  "デフォルトを使用",
         "errors": {
             "scopeChange": "スコープの変更は、他のフローで使われているノードを無効にします"
         }
@@ -318,7 +312,6 @@
         "noInfo": "情報がありません",
         "filter": "ノードを検索",
         "search": "ノードを検索",
-        "addCategory": "新規追加...",
         "label": {
             "subflows": "サブフロー",
             "input": "入力",
@@ -456,16 +449,6 @@
             "filterAll": "全て",
             "filtered": "__count__ 個が無効"
         },
-        "context": {
-            "name": "コンテキストデータ",
-            "label": "コンテキストデータ",
-            "none": "選択されていません",
-            "refresh": "読み込みのため更新してください",
-            "empty": "データが存在しません",
-            "node": "Node",
-            "flow": "Flow",
-            "global": "Global"
-        },
         "palette": {
             "name": "パレットの管理",
             "label": "パレット"
@@ -585,6 +568,7 @@
                 "pullUnrelatedHistory": "<p>リモートに関連のないコミット履歴があります。</p><p>本当に変更をプルしてローカルリポジトリに反映しますか？</p>",
                 "pullChanges": "プル変更",
                 "history": "履歴",
+                "plural": "",
                 "daysAgo": "__count__ 日前",
                 "daysAgo_plural": "__count__ 日前",
                 "hoursAgo": "__count__ 時間前",
@@ -616,9 +600,7 @@
             "bool": "真偽",
             "json": "JSON",
             "bin": "バッファ",
-            "date": "日時",
-            "jsonata": "JSONata式",
-            "env": "環境変数"
+            "date": "日時"
         }
     },
     "editableList": {
@@ -647,9 +629,6 @@
             "eval": "表現評価エラー:\n  __message__"
         }
     },
-    "jsEditor": {
-        "title": "JavaScriptエディタ"
-    },
     "jsonEditor": {
         "title": "JSONエディタ",
         "format": "JSONフォーマット"
@@ -712,7 +691,7 @@
             "ssh-key-add": "SSHキーの追加",
             "credential-key": "認証情報の暗号化キー",
             "cant-get-ssh-key": "エラー! 選択したSSHキーのパスを取得できません。",
-            "already-exists2": "既に存在します",
+            "already-exists": "既に存在します",
             "git-error": "Gitエラー",
             "connection-failed": "接続に失敗しました",
             "not-git-repo": "Gitリポジトリではありません",
@@ -806,7 +785,6 @@
             "username": "ユーザ名",
             "password": "パスワード",
             "passphrase": "パスフレーズ",
-            "retry": "リトライ",
             "update-failed": "認証の更新に失敗しました",
             "unhandled": "エラー応答が処理されませんでした"
         },
@@ -820,7 +798,7 @@
             "no-empty": "デフォルトのファイル群を空でないプロジェクトに作成することはできません。",
             "git-error": "Gitエラー"
         },
-        "errors": {
+        "errors" : {
             "no-username-email": "Gitクライアントのユーザ名/emailが設定されていません。",
             "unexpected": "予期しないエラーが発生しました",
             "code": "コード"

red/api/editor/locales/ja/jsonata.json

@@ -214,9 +214,5 @@
     "$toMillis": {
         "args": "timestamp",
         "desc": "ISO 8601形式の文字列 `timestamp` を、Unixエポック(1 January, 1970 UTC)からの経過ミリ秒を表す数値へ変換します。 文字列が正しい形式でない場合、エラーとなります。"
-    },
-    "$env": {
-        "args": "arg",
-        "desc": "環境変数の値を返します。\n\n本関数はNode-REDの定義関数です。"
     }
 }

red/api/editor/settings.js

@@ -40,8 +40,6 @@ module.exports = {
             })
         }
 
-        safeSettings.context = runtime.nodes.listContextStores();
-
         var themeSettings = theme.settings();
         if (themeSettings) {
             safeSettings.editorTheme = themeSettings;

red/runtime/i18n.js

@@ -15,7 +15,6 @@
  **/
 
 var i18n = require("i18next");
-
 var when = require("when");
 var path = require("path");
 var fs = require("fs");
@@ -35,7 +34,7 @@ function registerMessageCatalogs(catalogs) {
 function registerMessageCatalog(namespace,dir,file) {
     return when.promise(function(resolve,reject) {
         resourceMap[namespace] = { basedir:dir, file:file};
-        i18n.loadNamespaces(namespace,function() {
+        i18n.loadNamespace(namespace,function() {
             resolve();
         });
     });
@@ -54,9 +53,7 @@ function mergeCatalog(fallback,catalog) {
 }
 
 var MessageFileLoader = {
-    type: "backend",
-    init: function(services, backendOptions, i18nextOptions) {},
-    read: function(lng, ns, callback) {
+    fetchOne: function(lng, ns, callback) {
         if (resourceMap[ns]) {
             var file = path.join(resourceMap[ns].basedir,lng,resourceMap[ns].file);
             //console.log(file);
@@ -97,18 +94,13 @@ function getCurrentLocale() {
 
 function init() {
     return when.promise(function(resolve,reject) {
-        i18n.use(MessageFileLoader);
+        i18n.backend(MessageFileLoader);
         var opt = {
-            // debug: true,
-            defaultNS: "runtime",
-            ns: [],
-            fallbackLng: defaultLang,
-            interpolation: {
-                unescapeSuffix: 'HTML',
-                escapeValue: false,
-                prefix: '__',
-                suffix: '__'
-            }
+            ns: {
+                namespaces: [],
+                defaultNs: "runtime"
+            },
+            fallbackLng: [defaultLang]
         };
         var lang = getCurrentLocale();
         if (lang) {
@@ -150,6 +142,5 @@ obj['_'] = function() {
     //    opts.defaultValue = def;
     //}
     //console.log(arguments);
-    var res = i18n.t.apply(i18n,arguments);
-    return res;
+    return i18n.t.apply(null,arguments);
 }

red/runtime/index.js

@@ -162,10 +162,10 @@ function start() {
                 if (settings.httpStatic) {
                     log.info(log._("runtime.paths.httpStatic",{path:path.resolve(settings.httpStatic)}));
                 }
-                return redNodes.loadContextsPlugin().then(function () {
-                    redNodes.loadFlows().then(redNodes.startFlows).catch(function(err) {});
-                    started = true;
-                });
+                redNodes.loadFlows().then(redNodes.startFlows).catch(function(err) {});
+                started = true;
+            }).catch(function(err) {
+                console.log(err);
             });
         });
 }
@@ -229,9 +229,7 @@ function stop() {
         clearTimeout(reinstallTimeout);
     }
     started = false;
-    return redNodes.stopFlows().then(function(){
-        return redNodes.closeContextsPlugin();
-    });
+    return redNodes.stopFlows();
 }
 
 var runtime = module.exports = {

red/runtime/locales/en-US/runtime.json

@@ -142,7 +142,6 @@
             "restore": "Restoring __type__ file backup : __path__",
             "restore-fail": "Restoring __type__ file backup failed : __message__",
             "fsync-fail": "Flushing file __path__ to disk failed : __message__",
-            "fwrite-fail": "Writing backup file __path__ to disk failed : __message__",
             "projects": {
                 "changing-project": "Setting active project : __project__",
                 "active-project": "Active project : __project__",
@@ -156,20 +155,5 @@
                 "readme": "### About\n\nThis is your project's README.md file. It helps users understand what your\nproject does, how to use it and anything else they may need to know."
             }
         }
-    },
-
-    "context": {
-        "log-store-init": "Context store  : '__name__' [__info__]",
-        "error-loading-module": "Error loading context store '__module__': __message__ ",
-        "error-module-not-defined": "Context store '__storage__' missing 'module' option",
-        "error-invalid-module-name": "Invalid context store name: '__name__'",
-        "error-invalid-default-module": "Default context store unknown: '__storage__'",
-        "unknown-store": "Unknown context store '__name__' specified. Using default store.",
-        "error-loading-module": "Error loading context store: __message__",
-        "localfilesystem": {
-            "error-circular": "Context __scope__ contains a circular reference that cannot be persisted",
-            "error-write": "Error writing context: __message__"
-        }
     }
-
 }

red/runtime/locales/ja/runtime.json

@@ -1,169 +1,10 @@
 {
-    "runtime": {
-        "welcome": "Welcome to Node-RED",
-        "version": "__component__ バージョン: __version__",
-        "unsupported_version": "__component__ は未サポートのバージョンです。必要: __requires__ 検知: __version__",
-        "paths": {
-            "settings": "設定ファイル: __path__",
-            "httpStatic": "HTTP Static    : __path__"
-        }
-    },
-
-    "server": {
-        "loading": "パレットノードのロード",
-        "palette-editor": {
-            "disabled": "パレットエディタを無効化 : ユーザ設定",
-            "npm-not-found": "バレットエディタを無効化 : npmコマンドが見つかりません"
-        },
-        "errors": "__count__ 個のノードの登録に失敗しました",
-        "errors_plural": "__count__ 個のノードの登録に失敗しました",
-        "errors-help": "詳細は -v を指定して実行してください",
-        "missing-modules": "不足しているノードモジュール:",
-        "node-version-mismatch": "ノードモジュールはこのバージョンではロードできません。必要なバージョン: __version__ ",
-        "type-already-registered": "'__type__' はモジュール __module__ で登録済みです",
-        "removing-modules": "設定からモジュールを削除します",
-        "added-types": "追加したノード:",
-        "removed-types": "削除したノード:",
-        "install": {
-            "invalid": "不正なモジュール名",
-            "installing": "モジュール__name__, バージョン: __version__をインスートールします",
-            "installed": "モジュール __name__ をインストールしました",
-            "install-failed": "インストールに失敗しました",
-            "install-failed-long": "モジュール __name__ のインストールに失敗しました:",
-            "install-failed-not-found": "$t(install-failed-long) モジュールが見つかりません",
-            "upgrading": "モジュール __name__ をバージョン __version__ に更新します",
-            "upgraded": "モジュール __name__ を更新しました。新しいバージョンを使うには、Node-REDを再起動してください。",
-            "upgrade-failed-not-found": "$t(server.install.install-failed-long) バージョンが見つかりません",
-            "install-failed-not-found": "$t(server.install.install-failed-long) モジュールが見つかりません",
-            "uninstalling": "モジュールをアンインストールします: __name__",
-            "uninstall-failed": "アンインストールに失敗しました",
-            "uninstall-failed-long": "モジュール __name__ のアンインストールに失敗しました:",
-            "uninstalled": "モジュール __name__ をアンインストールしました"
-        },
-        "unable-to-listen": "__listenpath__ に対してlistenできません",
-        "port-in-use": "エラー: ポートが使用中です",
-        "uncaught-exception": "未補足の例外:",
-        "admin-ui-disabled": "管理UIを無効化しました",
-        "now-running": "サーバは __listenpath__ で実行中です",
-        "failed-to-start": "サーバの起動に失敗しました:",
-        "headless-mode": "ヘッドレスモードで実行中です",
-        "httpadminauth-deprecated": "httpAdminAuthは非推奨です。代わりに adminAuth を使用してください"
-    },
-
-    "api": {
-        "flows": {
-            "error-save": "フローの保存エラー: __message__",
-            "error-reload": "フローの読み込みエラー: __message__"
-        },
-        "library": {
-            "error-load-entry": "ライブラリエントリ '__path__' の読み込みエラー: __message__",
-            "error-save-entry": "ライブラリエントリ  '__path__' の保存エラー: __message__",
-            "error-load-flow": "フロー '__path__' の読み込みエラー: __message__",
-            "error-save-flow": "フロー '__path__' の保存エラー: __message__"
-        },
-        "nodes": {
-            "enabled": "ノードを有効化しました:",
-            "disabled": "ノードを無効化しました:",
-            "error-enable": "ノードの有効化に失敗しました:"
-        }
-    },
-
-    "comms": {
-        "error": "通信チャネルエラー: __message__",
-        "error-server": "サーバエラー: __message__",
-        "error-send": "送信エラー: __message__"
-    },
-
-    "settings": {
-        "user-not-available": "ユーザ設定を保存できません: __message__",
-        "not-available": "設定が利用できません",
-        "property-read-only": "プロパティ '__prop__' は読み出し専用です"
-    },
-
-    "nodes": {
-        "credentials": {
-            "error":"クレデンシャルの読み込みエラー: __message__",
-            "error-saving":"クレデンシャルの保存エラー: __message__",
-            "not-registered": "クレデンシャル '__type__' は登録されていません",
-            "system-key-warning": "\n\n---------------------------------------------------------------------\nフローのクレデンシャルファイルはシステム生成キーで暗号化されています。\n\nシステム生成キーを何らかの理由で失った場合、クレデンシャルファイルを\n復元することはできません。その場合、ファイルを削除してクレデンシャルを\n再入力しなければなりません。\n\n設定ファイル内で 'credentialSecret' オプションを使って独自キーを設定\nします。変更を次にデプロイする際、Node-REDは選択したキーを用いてクレ\nデンシャルを再暗号化します。 \n\n---------------------------------------------------------------------\n"
-        },
-        "flows": {
-            "registered-missing": "欠落しているノードを登録します: __type__",
-            "error": "フローの読み込みエラー: __message__",
-            "starting-modified-nodes": "更新されたノードを開始します",
-            "starting-modified-flows": "更新されたフローを開始します",
-            "starting-flows": "フローを開始します",
-            "started-modified-nodes": "更新されたノードを開始しました",
-            "started-modified-flows": "更新されたフローを開始しました",
-            "started-flows": "フローを開始しました",
-            "stopping-modified-nodes": "更新されたノードを停止します",
-            "stopping-modified-flows": "更新されたフローを停止します",
-            "stopping-flows": "フローを停止します",
-            "stopped-modified-nodes": "更新されたノードを停止しました",
-            "stopped-modified-flows": "更新されたフローを停止しました",
-            "stopped-flows": "フローを停止しました",
-            "stopped": "停止しました",
-            "stopping-error": "ノードの停止に失敗しました: __message__",
-            "added-flow": "フローを追加します: __label__",
-            "updated-flow": "フローを更新しました: __label__",
-            "removed-flow": "フローを削除しました: __label__",
-            "missing-types": "欠落しているノードが登録されるのを待っています:",
-            "missing-type-provided": " - __type__ (npmモジュール __module__ からインストールされました)",
-            "missing-type-install-1": "欠落しているモジュールをインストールするには次のコマンドを実行してください:",
-            "missing-type-install-2": "コマンドの実行は次のディレクトリで行います:"
-        },
-        "flow": {
-            "unknown-type": "不明なノード: __type__",
-            "missing-types": "欠落したノード",
-            "error-loop": "メッセージの例外補足回数が最大値を超えました"
-        },
-        "index": {
-            "unrecognised-id": "不明なID: __id__",
-            "type-in-use": "ノードは使用中です: __msg__",
-            "unrecognised-module": "不明なモジュール: __module__"
-        },
-        "registry": {
-            "localfilesystem": {
-                "module-not-found": "モジュール '__module__' が見つかりません"
-            }
-        }
-    },
-    
     "storage": {
-        "index": {
-            "forbidden-flow-name": "不正なフロー名"
-        },
         "localfilesystem": {
-            "user-dir": "ユーザディレクトリ : __path__",
-            "flows-file": "フローファイル     : __path__",
-            "create": "__type__ ファイルを作成します",
-            "empty": "既存の __type__ ファイルが空です",
-            "invalid": "既存の __type__ ファイルはJSON形式ではありません",
-            "restore": " __type__ ファイルをバックアップ __path__ から復元します",
-            "restore-fail": "__type__ ファイルをバックアップから復元するのに失敗しました : __message__",
-            "fsync-fail": "ファイル __path__ のディスクへの書き出しに失敗しました : __message__",
             "projects": {
-                "changing-project": "プロジェクトを設定します : __project__",
-                "active-project": "選択中のプロジェクト : __project__",
-                "project-not-found": "プロジェクトが見つかりません : __project__",
-                "no-active-project": "プロジェクトが選択されていません : デフォルトのフローファイルを使用します",
-                "disabled": "プロジェクトは無効化されています : editorTheme.projects.enabled=false",
-                "disabledNoFlag": "プロジェクトは無効化されています : 有効にするには editorTheme.projects.enabled=true を設定してください",
-                "git-not-found": "プロジェクトは無効化されています : gitコマンドが見つかりません",
-                "git-version-old": "プロジェクトは無効化されています : git __version__ はサポートされていません。2.xが必要です。",
                 "summary": "Node-REDプロジェクト",
                 "readme": "### 説明\nこれはプロジェクトのREADME.mdファイルです。このファイルには、\nプロジェクトの説明、利用方法、その他の情報を記載します。"
             }
         }
-    },
-
-    "context": {
-        "log-store-init": "コンテクストストア : '__name__' [__info__]",
-        "error-loading-module": "コンテクストストア '__module__' のロードでエラーが発生しました: __message__ ",
-        "error-module-not-defined": "コンテクストストア '__storage__' に 'module' オプションが指定されていません",
-        "error-invalid-module-name": "不正なコンテクストストア名: '__name__'",
-        "error-invalid-default-module": "デフォルトコンテクストストアが不明: '__storage__'",
-        "unknown-store": "不明なコンテクストストア '__name__' が指定されました。デフォルトストアを使用します。"        
-      }
-
+    }
 }

red/runtime/nodes/Node.js

@@ -105,12 +105,12 @@ Node.prototype.close = function(removed) {
     if (promises.length > 0) {
         return when.settle(promises).then(function() {
             if (this._context) {
-               return context.delete(this._alias||this.id,this.z);
+                 context.delete(this._alias||this.id,this.z);
             }
         });
     } else {
         if (this._context) {
-            return context.delete(this._alias||this.id,this.z);
+             context.delete(this._alias||this.id,this.z);
         }
         return;
     }

red/runtime/nodes/context.js

@@ -0,0 +1,91 @@
+/**
+ * Copyright JS Foundation and other contributors, http://js.foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ **/
+
+var clone = require("clone");
+var when = require("when");
+var util = require("../util");
+
+function createContext(id,seed) {
+    var data = seed || {};
+    var obj = seed || {};
+    obj.get = function get(key) {
+        return util.getMessageProperty(data,key);
+    };
+    obj.set = function set(key, value) {
+        util.setMessageProperty(data,key,value);
+    }
+    obj.keys = function() {
+        var keysData = Object.keys(data);
+        if (seed == null) {
+            return keysData;
+        } else {
+            return keysData.filter(function (key) {
+                return key !== "set" && key !== "get" && key !== "keys";
+            });
+        }
+    }
+    return obj;
+}
+
+var contexts = {};
+var globalContext = null;
+
+function getContext(localId,flowId) {
+    var contextId = localId;
+    if (flowId) {
+        contextId = localId+":"+flowId;
+    }
+    if (contexts.hasOwnProperty(contextId)) {
+        return contexts[contextId];
+    }
+    var newContext = createContext(contextId);
+    if (flowId) {
+        newContext.flow = getContext(flowId);
+    }
+    if (globalContext) {
+        newContext.global = globalContext;
+    }
+    contexts[contextId] = newContext;
+    return newContext;
+}
+function deleteContext(id,flowId) {
+    var contextId = id;
+    if (flowId) {
+        contextId = id+":"+flowId;
+    }
+    delete contexts[contextId];
+}
+function clean(flowConfig) {
+    var activeIds = {};
+    var contextId;
+    var node;
+    for (var id in contexts) {
+        if (contexts.hasOwnProperty(id)) {
+            var idParts = id.split(":");
+            if (!flowConfig.allNodes.hasOwnProperty(idParts[0])) {
+                delete contexts[id];
+            }
+        }
+    }
+}
+module.exports = {
+    init: function(settings) {
+        globalContext = createContext("global",settings.functionGlobalContext || {});
+    },
+    get: getContext,
+    delete: deleteContext,
+    clean:clean
+};

red/runtime/nodes/context/index.js

@@ -1,384 +0,0 @@
-/**
- * Copyright JS Foundation and other contributors, http://js.foundation
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
-
-var clone = require("clone");
-var log = require("../../log");
-var memory = require("./memory");
-
-var settings;
-
-// A map of scope id to context instance
-var contexts = {};
-
-// A map of store name to instance
-var stores = {};
-var storeList = [];
-var defaultStore;
-
-// Whether there context storage has been configured or left as default
-var hasConfiguredStore = false;
-
-// Unknown Stores
-var unknownStores = {};
-
-function logUnknownStore(name) {
-    if (name) {
-        var count = unknownStores[name] || 0;
-        if (count == 0) {
-            log.warn(log._("context.unknown-store", {name: name}));
-            count++;
-            unknownStores[name] = count;
-        }
-    }
-}
-
-function init(_settings) {
-    settings = _settings;
-    contexts = {};
-    stores = {};
-    storeList = [];
-    hasConfiguredStore = false;
-    var seed = settings.functionGlobalContext || {};
-    contexts['global'] = createContext("global",seed);
-    // create a default memory store - used by the unit tests that skip the full
-    // `load()` initialisation sequence.
-    // If the user has any stores configured, this will be disgarded
-    stores["_"] = new memory();
-    defaultStore = "memory";
-}
-
-function load() {
-    return new Promise(function(resolve,reject) {
-        // load & init plugins in settings.contextStorage
-        var plugins = settings.contextStorage || {};
-        var defaultIsAlias = false;
-        var promises = [];
-        if (plugins && Object.keys(plugins).length > 0) {
-            var hasDefault = plugins.hasOwnProperty('default');
-            var defaultName;
-            for (var pluginName in plugins) {
-                if (plugins.hasOwnProperty(pluginName)) {
-                    // "_" is a reserved name - do not allow it to be overridden
-                    if (pluginName === "_") {
-                        continue;
-                    }
-                    if (!/^[a-zA-Z0-9_]+$/.test(pluginName)) {
-                        return reject(new Error(log._("context.error-invalid-module-name", {name:pluginName})));
-                    }
-
-                    // Check if this is setting the 'default' context to be a named plugin
-                    if (pluginName === "default" && typeof plugins[pluginName] === "string") {
-                        // Check the 'default' alias exists before initialising anything
-                        if (!plugins.hasOwnProperty(plugins[pluginName])) {
-                            return reject(new Error(log._("context.error-invalid-default-module", {storage:plugins["default"]})));
-                        }
-                        defaultIsAlias = true;
-                        continue;
-                    }
-                    if (!hasDefault && !defaultName) {
-                        defaultName = pluginName;
-                    }
-                    var plugin;
-                    if (plugins[pluginName].hasOwnProperty("module")) {
-                        // Get the provided config and copy in the 'approved' top-level settings (eg userDir)
-                        var config = plugins[pluginName].config || {};
-                        copySettings(config, settings);
-
-                        if (typeof plugins[pluginName].module === "string") {
-                            // This config identifies the module by name - assume it is a built-in one
-                            // TODO: check it exists locally, if not, try to require it as-is
-                            try {
-                                plugin = require("./"+plugins[pluginName].module);
-                            } catch(err) {
-                                return reject(new Error(log._("context.error-loading-module", {module:plugins[pluginName].module,message:err.toString()})));
-                            }
-                        } else {
-                            // Assume `module` is an already-required module we can use
-                            plugin = plugins[pluginName].module;
-                        }
-                        try {
-                            // Create a new instance of the plugin by calling its module function
-                            stores[pluginName] = plugin(config);
-                            var moduleInfo = plugins[pluginName].module;
-                            if (typeof moduleInfo !== 'string') {
-                                if (moduleInfo.hasOwnProperty("toString")) {
-                                    moduleInfo = moduleInfo.toString();
-                                } else {
-                                    moduleInfo = "custom";
-                                }
-                            }
-                            log.info(log._("context.log-store-init", {name:pluginName, info:"module="+moduleInfo}));
-                        } catch(err) {
-                            return reject(new Error(log._("context.error-loading-module",{module:pluginName,message:err.toString()})));
-                        }
-                    } else {
-                        // Plugin does not specify a 'module'
-                        return reject(new Error(log._("context.error-module-not-defined", {storage:pluginName})));
-                    }
-                }
-            }
-
-            // Open all of the configured contexts
-            for (var plugin in stores) {
-                if (stores.hasOwnProperty(plugin)) {
-                    promises.push(stores[plugin].open());
-                }
-            }
-            // There is a 'default' listed in the configuration
-            if (hasDefault) {
-                // If 'default' is an alias, point it at the right module - we have already
-                // checked that it exists. If it isn't an alias, then it will
-                // already be set to a configured store
-                if (defaultIsAlias) {
-                    stores["_"] =  stores[plugins["default"]];
-                    defaultStore = plugins["default"];
-                } else {
-                    stores["_"] = stores["default"];
-                    defaultStore = "default";
-                }
-            } else if (defaultName) {
-                // No 'default' listed, so pick first in list as the default
-                stores["_"] = stores[defaultName];
-                defaultStore = defaultName;
-                defaultIsAlias = true;
-            } else {
-                // else there were no stores list the config object - fall through
-                // to below where we default to a memory store
-                storeList = ["memory"];
-                defaultStore = "memory";
-            }
-            hasConfiguredStore = true;
-            storeList = Object.keys(stores).filter(n=>!(defaultIsAlias && n==="default") && n!== "_");
-        } else {
-            // No configured plugins
-            log.info(log._("context.log-store-init", {name:"default", info:"module=memory"}));
-            promises.push(stores["_"].open())
-            storeList = ["memory"];
-            defaultStore = "memory";
-        }
-        return resolve(Promise.all(promises));
-    }).catch(function(err) {
-        throw new Error(log._("context.error-loading-module",{message:err.toString()}));
-    });
-}
-
-function copySettings(config, settings){
-    var copy = ["userDir"]
-    config.settings = {};
-    copy.forEach(function(setting){
-        config.settings[setting] = clone(settings[setting]);
-    });
-}
-
-function getContextStorage(storage) {
-    if (stores.hasOwnProperty(storage)) {
-        // A known context
-        return stores[storage];
-    } else if (stores.hasOwnProperty("_")) {
-        // Not known, but we have a default to fall back to
-        if (storage !== defaultStore) {
-            // It isn't the default store either, so log it
-            logUnknownStore(storage);
-        }
-        return stores["_"];
-    }
-}
-
-
-function createContext(id,seed) {
-    // Seed is only set for global context - sourced from functionGlobalContext
-    var scope = id;
-    var obj = seed || {};
-    var seedKeys;
-    var insertSeedValues;
-    if (seed) {
-        seedKeys = Object.keys(seed);
-        insertSeedValues = function(keys,values) {
-            if (!Array.isArray(keys)) {
-                if (values[0] === undefined) {
-                    values[0] = seed[keys];
-                }
-            } else {
-                for (var i=0;i<keys.length;i++) {
-                    if (values[i] === undefined) {
-                        values[i] = seed[keys[i]];
-                    }
-                }
-            }
-        }
-    }
-
-    obj.get = function(key, storage, callback) {
-        var context;
-        if (!storage && !callback) {
-            context = stores["_"];
-        } else {
-            if (typeof storage === 'function') {
-                callback = storage;
-                storage = "_";
-            }
-            if (callback && typeof callback !== 'function'){
-                throw new Error("Callback must be a function");
-            }
-            context = getContextStorage(storage);
-        }
-        if (callback) {
-            if (!seed) {
-                context.get(scope,key,callback);
-            } else {
-                context.get(scope,key,function() {
-                    if (arguments[0]) {
-                        callback(arguments[0]);
-                        return;
-                    }
-                    var results = Array.prototype.slice.call(arguments,[1]);
-                    insertSeedValues(key,results);
-                    // Put the err arg back
-                    results.unshift(undefined);
-                    callback.apply(null,results);
-                });
-            }
-        } else {
-            // No callback, attempt to do this synchronously
-            var results = context.get(scope,key);
-            if (seed) {
-                if (Array.isArray(key)) {
-                    insertSeedValues(key,results);
-                } else if (results === undefined){
-                    results = seed[key];
-                }
-            }
-            return results;
-        }
-    };
-    obj.set = function(key, value, storage, callback) {
-        var context;
-        if (!storage && !callback) {
-            context = stores["_"];
-        } else {
-            if (typeof storage === 'function') {
-                callback = storage;
-                storage = "_";
-            }
-            if (callback && typeof callback !== 'function') {
-                throw new Error("Callback must be a function");
-            }
-            context = getContextStorage(storage);
-        }
-        context.set(scope, key, value, callback);
-    };
-    obj.keys = function(storage, callback) {
-        var context;
-        if (!storage && !callback) {
-            context = stores["_"];
-        } else {
-            if (typeof storage === 'function') {
-                callback = storage;
-                storage = "_";
-            }
-            if (callback && typeof callback !== 'function') {
-                throw new Error("Callback must be a function");
-            }
-            context = getContextStorage(storage);
-        }
-        if (seed) {
-            if (callback) {
-                context.keys(scope, function(err,keys) {
-                    callback(err,Array.from(new Set(seedKeys.concat(keys)).keys()));
-                });
-            } else {
-                var keys = context.keys(scope);
-                return Array.from(new Set(seedKeys.concat(keys)).keys())
-            }
-        } else {
-            return context.keys(scope, callback);
-        }
-    };
-    return obj;
-}
-
-function getContext(localId,flowId) {
-    var contextId = localId;
-    if (flowId) {
-        contextId = localId+":"+flowId;
-    }
-    if (contexts.hasOwnProperty(contextId)) {
-        return contexts[contextId];
-    }
-    var newContext = createContext(contextId);
-    if (flowId) {
-        newContext.flow = getContext(flowId);
-    }
-    newContext.global = contexts['global'];
-    contexts[contextId] = newContext;
-    return newContext;
-}
-
-function deleteContext(id,flowId) {
-    if(!hasConfiguredStore){
-        // only delete context if there's no configured storage.
-        var contextId = id;
-        if (flowId) {
-            contextId = id+":"+flowId;
-        }
-        delete contexts[contextId];
-        return stores["_"].delete(contextId);
-    }else{
-        return Promise.resolve();
-    }
-}
-
-function clean(flowConfig) {
-    var promises = [];
-    for(var plugin in stores){
-        if(stores.hasOwnProperty(plugin)){
-            promises.push(stores[plugin].clean(Object.keys(flowConfig.allNodes)));
-        }
-    }
-    for (var id in contexts) {
-        if (contexts.hasOwnProperty(id) && id !== "global") {
-            var idParts = id.split(":");
-            if (!flowConfig.allNodes.hasOwnProperty(idParts[0])) {
-                delete contexts[id];
-            }
-        }
-    }
-    return Promise.all(promises);
-}
-
-function close() {
-    var promises = [];
-    for(var plugin in stores){
-        if(stores.hasOwnProperty(plugin)){
-            promises.push(stores[plugin].close());
-        }
-    }
-    return Promise.all(promises);
-}
-
-function listStores() {
-    return {default:defaultStore,stores:storeList};
-}
-
-module.exports = {
-    init: init,
-    load: load,
-    listStores: listStores,
-    get: getContext,
-    delete: deleteContext,
-    clean: clean,
-    close: close
-};

red/runtime/nodes/context/localfilesystem.js

@@ -1,377 +0,0 @@
-/**
- * Copyright JS Foundation and other contributors, http://js.foundation
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
-
-/**
- * Local file-system based context storage
- *
- * Configuration options:
- * {
- *    base: "context",         // the base directory to use
- *                             // default: "context"
- *    dir: "/path/to/storage", // the directory to create the base directory in
- *                             // default: settings.userDir
- *    cache: true,             // whether to cache contents in memory
- *                             // default: true
- *    flushInterval: 30        // if cache is enabled, the minimum interval
- *                             // between writes to storage, in seconds. This
- *                                can be used to reduce wear on underlying storage.
- *                                default: 30 seconds
- *  }
- *
- *
- *  $HOME/.node-red/contexts
- *  ├── global
- *  │     └── global_context.json
- *  ├── <id of Flow 1>
- *  │     ├── flow_context.json
- *  │     ├── <id of Node a>.json
- *  │     └── <id of Node b>.json
- *  └── <id of Flow 2>
- *         ├── flow_context.json
- *         ├── <id of Node x>.json
- *         └── <id of Node y>.json
- */
-
-var fs = require('fs-extra');
-var path = require("path");
-var util = require("../../util");
-var log = require("../../log");
-
-var safeJSONStringify = require("json-stringify-safe");
-var MemoryStore = require("./memory");
-
-
-function getStoragePath(storageBaseDir, scope) {
-    if(scope.indexOf(":") === -1){
-        if(scope === "global"){
-            return path.join(storageBaseDir,"global",scope);
-        }else{ // scope:flow
-            return path.join(storageBaseDir,scope,"flow");
-        }
-    }else{ // scope:local
-        var ids = scope.split(":")
-        return path.join(storageBaseDir,ids[1],ids[0]);
-    }
-}
-
-function getBasePath(config) {
-    var base = config.base || "context";
-    var storageBaseDir;
-    if (!config.dir) {
-        if(config.settings && config.settings.userDir){
-            storageBaseDir = path.join(config.settings.userDir, base);
-        }else{
-            try {
-                fs.statSync(path.join(process.env.NODE_RED_HOME,".config.json"));
-                storageBaseDir = path.join(process.env.NODE_RED_HOME, base);
-            } catch(err) {
-                try {
-                    // Consider compatibility for older versions
-                    if (process.env.HOMEPATH) {
-                        fs.statSync(path.join(process.env.HOMEPATH,".node-red",".config.json"));
-                        storageBaseDir = path.join(process.env.HOMEPATH, ".node-red", base);
-                    }
-                } catch(err) {
-                }
-                if (!storageBaseDir) {
-                    storageBaseDir = path.join(process.env.HOME || process.env.USERPROFILE || process.env.HOMEPATH || process.env.NODE_RED_HOME,".node-red", base);
-                }
-            }
-        }
-    }else{
-        storageBaseDir = path.join(config.dir, base);
-    }
-    return storageBaseDir;
-}
-
-function loadFile(storagePath){
-    return fs.pathExists(storagePath).then(function(exists){
-        if(exists === true){
-            return fs.readFile(storagePath, "utf8");
-        }else{
-            return Promise.resolve(undefined);
-        }
-    });
-}
-
-function listFiles(storagePath) {
-    var promises = [];
-    return fs.readdir(storagePath).then(function(files) {
-        files.forEach(function(file) {
-            if (!/^\./.test(file)) {
-                var fullPath = path.join(storagePath,file);
-                var stats = fs.statSync(fullPath);
-                if (stats.isDirectory()) {
-                    promises.push(fs.readdir(fullPath).then(function(subdirFiles) {
-                        var result = [];
-                        subdirFiles.forEach(subfile => {
-                            if (/\.json$/.test(subfile)) {
-                                result.push(path.join(file,subfile))
-                            }
-                        });
-                        return result;
-                    }))
-                }
-            }
-        });
-        return Promise.all(promises);
-    }).then(dirs => dirs.reduce((acc, val) => acc.concat(val), []));
-}
-
-function stringify(value) {
-    var hasCircular;
-    var result = safeJSONStringify(value,null,4,function(k,v){hasCircular = true})
-    return { json: result, circular: hasCircular };
-}
-
-function LocalFileSystem(config){
-    this.config = config;
-    this.storageBaseDir = getBasePath(this.config);
-    if (config.hasOwnProperty('cache')?config.cache:true) {
-        this.cache = MemoryStore({});
-    }
-    this.pendingWrites = {};
-    this.knownCircularRefs = {};
-
-    if (config.hasOwnProperty('flushInterval')) {
-        this.flushInterval = Math.max(0,config.flushInterval) * 1000;
-    } else {
-        this.flushInterval = 30000;
-    }
-}
-
-LocalFileSystem.prototype.open = function(){
-    var self = this;
-    if (this.cache) {
-        var scopes = [];
-        var promises = [];
-        return listFiles(self.storageBaseDir).then(function(files) {
-            files.forEach(function(file) {
-                var parts = file.split(path.sep);
-                if (parts[0] === 'global') {
-                    scopes.push("global");
-                } else if (parts[1] === 'flow.json') {
-                    scopes.push(parts[0])
-                } else {
-                    scopes.push(parts[1].substring(0,parts[1].length-5)+":"+parts[0]);
-                }
-                promises.push(loadFile(path.join(self.storageBaseDir,file)));
-            })
-            return Promise.all(promises);
-        }).then(function(res) {
-            scopes.forEach(function(scope,i) {
-                var data = res[i]?JSON.parse(res[i]):{};
-                Object.keys(data).forEach(function(key) {
-                    self.cache.set(scope,key,data[key]);
-                })
-            });
-        }).catch(function(err){
-            if(err.code == 'ENOENT') {
-                return fs.ensureDir(self.storageBaseDir);
-            }else{
-                throw err;
-            }
-        }).then(function() {
-            self._flushPendingWrites = function() {
-                var scopes = Object.keys(self.pendingWrites);
-                self.pendingWrites = {};
-                var promises = [];
-                var newContext = self.cache._export();
-                scopes.forEach(function(scope) {
-                    var storagePath = getStoragePath(self.storageBaseDir,scope);
-                    var context = newContext[scope];
-                    var stringifiedContext = stringify(context);
-                    if (stringifiedContext.circular && !self.knownCircularRefs[scope]) {
-                        log.warn(log._("error-circular",{scope:scope}));
-                        self.knownCircularRefs[scope] = true;
-                    } else {
-                        delete self.knownCircularRefs[scope];
-                    }
-                    log.debug("Flushing localfilesystem context scope "+scope);
-                    promises.push(fs.outputFile(storagePath + ".json", stringifiedContext.json, "utf8"));
-                });
-                delete self._pendingWriteTimeout;
-                return Promise.all(promises);
-            }
-        });
-    } else {
-        return fs.ensureDir(self.storageBaseDir);
-    }
-}
-
-LocalFileSystem.prototype.close = function(){
-    if (this.cache && this._flushPendingWrites) {
-        clearTimeout(this._pendingWriteTimeout);
-        delete this._pendingWriteTimeout;
-        return this._flushPendingWrites();
-    }
-    return Promise.resolve();
-}
-
-LocalFileSystem.prototype.get = function(scope, key, callback) {
-    if (this.cache) {
-        return this.cache.get(scope,key,callback);
-    }
-    if(typeof callback !== "function"){
-        throw new Error("Callback must be a function");
-    }
-    var storagePath = getStoragePath(this.storageBaseDir ,scope);
-    loadFile(storagePath + ".json").then(function(data){
-        if(data){
-            data = JSON.parse(data);
-            if (!Array.isArray(key)) {
-                callback(null, util.getObjectProperty(data,key));
-            } else {
-                var results = [undefined];
-                for (var i=0;i<key.length;i++) {
-                    results.push(util.getObjectProperty(data,key[i]))
-                }
-                callback.apply(null,results);
-            }
-        }else{
-            callback(null, undefined);
-        }
-    }).catch(function(err){
-        callback(err);
-    });
-};
-
-LocalFileSystem.prototype.set = function(scope, key, value, callback) {
-    var self = this;
-    var storagePath = getStoragePath(this.storageBaseDir ,scope);
-    if (this.cache) {
-        this.cache.set(scope,key,value,callback);
-        this.pendingWrites[scope] = true;
-        if (this._pendingWriteTimeout) {
-            // there's a pending write which will handle this
-            return;
-        } else {
-            this._pendingWriteTimeout = setTimeout(function() {
-                self._flushPendingWrites.call(self).catch(function(err) {
-                    log.error(log._("context.localfilesystem.error-write",{message:err.toString()}))
-                });
-            }, this.flushInterval);
-        }
-    } else if (callback && typeof callback !== 'function') {
-        throw new Error("Callback must be a function");
-    } else {
-        loadFile(storagePath + ".json").then(function(data){
-            var obj = data ? JSON.parse(data) : {}
-            if (!Array.isArray(key)) {
-                key = [key];
-                value = [value];
-            } else if (!Array.isArray(value)) {
-                // key is an array, but value is not - wrap it as an array
-                value = [value];
-            }
-            for (var i=0;i<key.length;i++) {
-                var v = null;
-                if (i<value.length) {
-                    v = value[i];
-                }
-                util.setObjectProperty(obj,key[i],v);
-            }
-            var stringifiedContext = stringify(obj);
-            if (stringifiedContext.circular && !self.knownCircularRefs[scope]) {
-                log.warn(log._("error-circular",{scope:scope}));
-                self.knownCircularRefs[scope] = true;
-            } else {
-                delete self.knownCircularRefs[scope];
-            }
-            return fs.outputFile(storagePath + ".json", stringifiedContext.json, "utf8");
-        }).then(function(){
-            if(typeof callback === "function"){
-                callback(null);
-            }
-        }).catch(function(err){
-            if(typeof callback === "function"){
-                callback(err);
-            }
-        });
-    }
-};
-
-LocalFileSystem.prototype.keys = function(scope, callback){
-    if (this.cache) {
-        return this.cache.keys(scope,callback);
-    }
-    if(typeof callback !== "function"){
-        throw new Error("Callback must be a function");
-    }
-    var storagePath = getStoragePath(this.storageBaseDir ,scope);
-    loadFile(storagePath + ".json").then(function(data){
-        if(data){
-            callback(null, Object.keys(JSON.parse(data)));
-        }else{
-            callback(null, []);
-        }
-    }).catch(function(err){
-        callback(err);
-    });
-};
-
-LocalFileSystem.prototype.delete = function(scope){
-    var cachePromise;
-    if (this.cache) {
-        cachePromise = this.cache.delete(scope);
-    } else {
-        cachePromise = Promise.resolve();
-    }
-    var that = this;
-    delete this.pendingWrites[scope];
-    return cachePromise.then(function() {
-        var storagePath = getStoragePath(that.storageBaseDir,scope);
-        return fs.remove(storagePath + ".json");
-    });
-}
-
-LocalFileSystem.prototype.clean = function(_activeNodes) {
-    var activeNodes = {};
-    _activeNodes.forEach(function(node) { activeNodes[node] = true });
-    var self = this;
-    var cachePromise;
-    if (this.cache) {
-        cachePromise = this.cache.clean(_activeNodes);
-    } else {
-        cachePromise = Promise.resolve();
-    }
-    this.knownCircularRefs = {};
-    return cachePromise.then(() => listFiles(self.storageBaseDir)).then(function(files) {
-        var promises = [];
-        files.forEach(function(file) {
-            var parts = file.split(path.sep);
-            var removePromise;
-            if (parts[0] === 'global') {
-                // never clean global
-                return;
-            } else if (!activeNodes[parts[0]]) {
-                // Flow removed - remove the whole dir
-                removePromise = fs.remove(path.join(self.storageBaseDir,parts[0]));
-            } else if (parts[1] !== 'flow.json' && !activeNodes[parts[1].substring(0,parts[1].length-5)]) {
-                // Node removed - remove the context file
-                removePromise = fs.remove(path.join(self.storageBaseDir,file));
-            }
-            if (removePromise) {
-                promises.push(removePromise);
-            }
-        });
-        return Promise.all(promises)
-    })
-}
-
-module.exports = function(config){
-    return new LocalFileSystem(config);
-};

red/runtime/nodes/context/memory.js

@@ -1,166 +0,0 @@
-/**
- * Copyright JS Foundation and other contributors, http://js.foundation
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
-
-var util = require("../../util");
-
-function Memory(config){
-    this.data = {};
-}
-
-Memory.prototype.open = function(){
-    return Promise.resolve();
-};
-
-Memory.prototype.close = function(){
-    return Promise.resolve();
-};
-
-Memory.prototype._getOne = function(scope, key) {
-    var value;
-    var error;
-    if(this.data[scope]){
-        value = util.getObjectProperty(this.data[scope], key);
-    }
-    return value;
-}
-
-Memory.prototype.get = function(scope, key, callback) {
-    var value;
-    var error;
-    if (!Array.isArray(key)) {
-        try {
-            value = this._getOne(scope,key);
-        } catch(err) {
-            if (!callback) {
-                throw err;
-            }
-            error = err;
-        }
-        if (callback) {
-            callback(error,value);
-            return;
-        } else {
-            return value;
-        }
-    }
-
-    value = [];
-    for (var i=0; i<key.length; i++) {
-        try {
-            value.push(this._getOne(scope,key[i]));
-        } catch(err) {
-            if (!callback) {
-                throw err;
-            } else {
-                callback(err);
-                return;
-            }
-        }
-    }
-    if (callback) {
-        callback.apply(null, [undefined].concat(value));
-    } else {
-        return value;
-    }
-};
-
-Memory.prototype.set = function(scope, key, value, callback) {
-    if(!this.data[scope]){
-        this.data[scope] = {};
-    }
-    var error;
-    if (!Array.isArray(key)) {
-        key = [key];
-        value = [value];
-    } else if (!Array.isArray(value)) {
-        // key is an array, but value is not - wrap it as an array
-        value = [value];
-    }
-    try {
-        for (var i=0; i<key.length; i++) {
-            var v = null;
-            if (i < value.length) {
-                v = value[i];
-            }
-            util.setObjectProperty(this.data[scope],key[i],v);
-        }
-    } catch(err) {
-        if (callback) {
-            error = err;
-        } else {
-            throw err;
-        }
-    }
-    if(callback){
-        callback(error);
-    }
-};
-
-Memory.prototype.keys = function(scope, callback){
-    var values = [];
-    var error;
-    try{
-        if(this.data[scope]){
-            if (scope !== "global") {
-                values = Object.keys(this.data[scope]);
-            } else {
-                values = Object.keys(this.data[scope]).filter(function (key) {
-                    return key !== "set" && key !== "get" && key !== "keys";
-                });
-            }
-        }
-    }catch(err){
-        if(callback){
-            error = err;
-        }else{
-            throw err;
-        }
-    }
-    if(callback){
-        if(error){
-            callback(error);
-        } else {
-            callback(null, values);
-        }
-    } else {
-        return values;
-    }
-};
-
-Memory.prototype.delete = function(scope){
-    delete this.data[scope];
-    return Promise.resolve();
-};
-
-Memory.prototype.clean = function(activeNodes){
-    for(var id in this.data){
-        if(this.data.hasOwnProperty(id) && id !== "global"){
-            var idParts = id.split(":");
-            if(activeNodes.indexOf(idParts[0]) === -1){
-                delete this.data[id];
-            }
-        }
-    }
-    return Promise.resolve();
-}
-
-Memory.prototype._export = function() {
-    return this.data;
-}
-
-module.exports = function(config){
-    return new Memory(config);
-};

red/runtime/nodes/flows/index.js

@@ -160,12 +160,11 @@ function setFlows(_config,type,muteLog,forceStart) {
             activeFlowConfig = newFlowConfig;
             if (forceStart || started) {
                 return stop(type,diff,muteLog).then(function() {
-                    return context.clean(activeFlowConfig).then(function() {
-                        start(type,diff,muteLog).then(function() {
-                            events.emit("runtime-event",{id:"runtime-deploy",payload:{revision:flowRevision},retain: true});
-                        });
-                        return flowRevision;
+                    context.clean(activeFlowConfig);
+                    start(type,diff,muteLog).then(function() {
+                        events.emit("runtime-event",{id:"runtime-deploy",payload:{revision:flowRevision},retain: true});
                     });
+                    return flowRevision;
                 }).catch(function(err) {
                 })
             } else {

red/runtime/nodes/index.js

@@ -167,8 +167,6 @@ module.exports = {
     createNode: createNode,
     getNode: flows.get,
     eachNode: flows.eachNode,
-    getContext: context.get,
-
 
     paletteEditorEnabled: registry.paletteEditorEnabled,
     installModule: installModule,
@@ -218,10 +216,5 @@ module.exports = {
     setCredentialSecret: credentials.setKey,
     clearCredentials: credentials.clear,
     exportCredentials: credentials.export,
-    getCredentialKeyType: credentials.getKeyType,
-
-    // Contexts
-    loadContextsPlugin: context.load,
-    closeContextsPlugin: context.close,
-    listContextStores: context.listStores
+    getCredentialKeyType: credentials.getKeyType
 };

red/runtime/nodes/registry/installer.js

@@ -15,6 +15,7 @@
  **/
 
 
+var when = require("when");
 var path = require("path");
 var fs = require("fs");
 
@@ -35,8 +36,6 @@ function init(_settings) {
     settings = _settings;
 }
 
-var activePromise = Promise.resolve();
-
 function checkModulePath(folder) {
     var moduleName;
     var err;
@@ -72,86 +71,79 @@ function checkExistingModule(module,version) {
     return false;
 }
 function installModule(module,version) {
-    activePromise = activePromise.then(() => {
-        //TODO: ensure module is 'safe'
-        return new Promise((resolve,reject) => {
-            var installName = module;
-            var isUpgrade = false;
-            try {
-                if (moduleRe.test(module)) {
-                    // Simple module name - assume it can be npm installed
-                    if (version) {
-                        installName += "@"+version;
-                    }
-                } else if (slashRe.test(module)) {
-                    // A path - check if there's a valid package.json
-                    installName = module;
-                    module = checkModulePath(module);
+    //TODO: ensure module is 'safe'
+    return when.promise(function(resolve,reject) {
+        var installName = module;
+        var isUpgrade = false;
+        try {
+            if (moduleRe.test(module)) {
+                // Simple module name - assume it can be npm installed
+                if (version) {
+                    installName += "@"+version;
                 }
-                isUpgrade = checkExistingModule(module,version);
-            } catch(err) {
-                return reject(err);
-            }
-            if (!isUpgrade) {
-                log.info(log._("server.install.installing",{name: module,version: version||"latest"}));
-            } else {
-                log.info(log._("server.install.upgrading",{name: module,version: version||"latest"}));
+            } else if (slashRe.test(module)) {
+                // A path - check if there's a valid package.json
+                installName = module;
+                module = checkModulePath(module);
             }
+            isUpgrade = checkExistingModule(module,version);
+        } catch(err) {
+            return reject(err);
+        }
+        if (!isUpgrade) {
+            log.info(log._("server.install.installing",{name: module,version: version||"latest"}));
+        } else {
+            log.info(log._("server.install.upgrading",{name: module,version: version||"latest"}));
+        }
 
-            var installDir = settings.userDir || process.env.NODE_RED_HOME || ".";
-            var args = ['install','--save','--save-prefix="~"','--production',installName];
-            log.trace(npmCommand + JSON.stringify(args));
-            var child = child_process.spawn(npmCommand,args,{
-                cwd: installDir,
-                shell: true
-            });
-            var output = "";
-            child.stdout.on('data', (data) => {
-                output += data;
-            });
-            child.stderr.on('data', (data) => {
-                output += data;
-            });
-            child.on('close', (code) => {
-                if (code !== 0) {
-                    var e;
-                    var lookFor404 = new RegExp(" 404 .*"+module,"m");
-                    var lookForVersionNotFound = new RegExp("version not found: "+module+"@"+version,"m");
-                    if (lookFor404.test(output)) {
-                        log.warn(log._("server.install.install-failed-not-found",{name:module}));
-                        e = new Error("Module not found");
-                        e.code = 404;
-                        reject(e);
-                    } else if (isUpgrade && lookForVersionNotFound.test(output)) {
-                        log.warn(log._("server.install.upgrade-failed-not-found",{name:module}));
-                        e = new Error("Module not found");
-                        e.code = 404;
-                        reject(e);
-                    } else {
-                        log.warn(log._("server.install.install-failed-long",{name:module}));
-                        log.warn("------------------------------------------");
-                        log.warn(output);
-                        log.warn("------------------------------------------");
-                        reject(new Error(log._("server.install.install-failed")));
-                    }
-                } else {
-                    if (!isUpgrade) {
-                        log.info(log._("server.install.installed",{name:module}));
-                        resolve(require("./index").addModule(module).then(reportAddedModules));
-                    } else {
-                        log.info(log._("server.install.upgraded",{name:module, version:version}));
-                        events.emit("runtime-event",{id:"restart-required",payload:{type:"warning",text:"notification.warnings.restartRequired"},retain:true});
-                        resolve(require("./registry").setModulePendingUpdated(module,version));
-                    }
-                }
-            });
+        var installDir = settings.userDir || process.env.NODE_RED_HOME || ".";
+        var args = ['install','--save','--save-prefix="~"','--production',installName];
+        log.trace(npmCommand + JSON.stringify(args));
+        var child = child_process.spawn(npmCommand,args,{
+            cwd: installDir,
+            shell: true
+        });
+        var output = "";
+        child.stdout.on('data', (data) => {
+            output += data;
+        });
+        child.stderr.on('data', (data) => {
+            output += data;
+        });
+        child.on('close', (code) => {
+            if (code !== 0) {
+                var e;
+                var lookFor404 = new RegExp(" 404 .*"+module,"m");
+                var lookForVersionNotFound = new RegExp("version not found: "+module+"@"+version,"m");
+                if (lookFor404.test(output)) {
+                    log.warn(log._("server.install.install-failed-not-found",{name:module}));
+                    e = new Error("Module not found");
+                    e.code = 404;
+                    reject(e);
+                } else if (isUpgrade && lookForVersionNotFound.test(output)) {
+                    log.warn(log._("server.install.upgrade-failed-not-found",{name:module}));
+                    e = new Error("Module not found");
+                    e.code = 404;
+                    reject(e);
+                } else {
+                    log.warn(log._("server.install.install-failed-long",{name:module}));
+                    log.warn("------------------------------------------");
+                    log.warn(output);
+                    log.warn("------------------------------------------");
+                    reject(new Error(log._("server.install.install-failed")));
+                }
+            } else {
+                if (!isUpgrade) {
+                    log.info(log._("server.install.installed",{name:module}));
+                    resolve(require("./index").addModule(module).then(reportAddedModules));
+                } else {
+                    log.info(log._("server.install.upgraded",{name:module, version:version}));
+                    events.emit("runtime-event",{id:"restart-required",payload:{type:"warning",text:"notification.warnings.restartRequired"},retain:true});
+                    resolve(require("./registry").setModulePendingUpdated(module,version));
+                }
+            }
         });
-    }).catch(err => {
-        // In case of error, reset activePromise to be resolvable
-        activePromise = Promise.resolve();
-        throw err;
     });
-    return activePromise;
 }
 
 
@@ -184,54 +176,47 @@ function reportRemovedModules(removedNodes) {
 }
 
 function uninstallModule(module) {
-    activePromise = activePromise.then(() => {
-        return new Promise((resolve,reject) => {
-            if (/[\s;]/.test(module)) {
-                reject(new Error(log._("server.install.invalid")));
-                return;
-            }
-            var installDir = settings.userDir || process.env.NODE_RED_HOME || ".";
-            var moduleDir = path.join(installDir,"node_modules",module);
+    return when.promise(function(resolve,reject) {
+        if (/[\s;]/.test(module)) {
+            reject(new Error(log._("server.install.invalid")));
+            return;
+        }
+        var installDir = settings.userDir || process.env.NODE_RED_HOME || ".";
+        var moduleDir = path.join(installDir,"node_modules",module);
 
-            try {
-                fs.statSync(moduleDir);
-            } catch(err) {
-                return reject(new Error(log._("server.install.uninstall-failed",{name:module})));
-            }
+        try {
+            fs.statSync(moduleDir);
+        } catch(err) {
+            return reject(new Error(log._("server.install.uninstall-failed",{name:module})));
+        }
 
-            var list = registry.removeModule(module);
-            log.info(log._("server.install.uninstalling",{name:module}));
+        var list = registry.removeModule(module);
+        log.info(log._("server.install.uninstalling",{name:module}));
 
-            var args = ['remove','--save',module];
-            log.trace(npmCommand + JSON.stringify(args));
+        var args = ['remove','--save',module];
+        log.trace(npmCommand + JSON.stringify(args));
 
-            var child = child_process.execFile(npmCommand,args,
-                {
-                    cwd: installDir
-                },
-                function(err, stdin, stdout) {
-                    if (err) {
-                        log.warn(log._("server.install.uninstall-failed-long",{name:module}));
-                        log.warn("------------------------------------------");
-                        log.warn(err.toString());
-                        log.warn("------------------------------------------");
-                        reject(new Error(log._("server.install.uninstall-failed",{name:module})));
-                    } else {
-                        log.info(log._("server.install.uninstalled",{name:module}));
-                        reportRemovedModules(list);
-                        // TODO: tidy up internal event names
-                        events.emit("node-module-uninstalled",module)
-                        resolve(list);
-                    }
+        var child = child_process.execFile(npmCommand,args,
+            {
+                cwd: installDir
+            },
+            function(err, stdin, stdout) {
+                if (err) {
+                    log.warn(log._("server.install.uninstall-failed-long",{name:module}));
+                    log.warn("------------------------------------------");
+                    log.warn(err.toString());
+                    log.warn("------------------------------------------");
+                    reject(new Error(log._("server.install.uninstall-failed",{name:module})));
+                } else {
+                    log.info(log._("server.install.uninstalled",{name:module}));
+                    reportRemovedModules(list);
+                    // TODO: tidy up internal event names
+                    events.emit("node-module-uninstalled",module)
+                    resolve(list);
                 }
-            );
-        });
-    }).catch(err => {
-        // In case of error, reset activePromise to be resolvable
-        activePromise = Promise.resolve();
-        throw err;
+            }
+        );
     });
-    return activePromise;
 }
 
 function checkPrereq() {
@@ -242,9 +227,9 @@ function checkPrereq() {
     ) {
         log.info(log._("server.palette-editor.disabled"));
         paletteEditorEnabled = false;
-        return Promise.resolve();
+        return when.resolve();
     } else {
-        return new Promise(resolve => {
+        return when.promise(function(resolve) {
             child_process.execFile(npmCommand,['-v'],function(err) {
                 if (err) {
                     log.info(log._("server.palette-editor.npm-not-found"));