Use url.UserPassword() so passwords are escaped (#101)

* add Dockerfile

* dockerfile: switch to multi-stage build to lighten up the final image

* dockerfile: update to latest images, and update the 2nd stage image on build

* Use url.UserPassword() so passwords are escaped

Dockerfile

@@ -0,0 +1,18 @@
+FROM golang:1.12-alpine3.10 as builder
+
+WORKDIR /go/src/vsphere-influxdb-go
+COPY . .
+RUN apk --update add --virtual build-deps git 
+RUN go get -d -v ./...
+RUN CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo
+
+FROM alpine:3.10
+RUN apk update \
+ && apk upgrade \
+ && apk add ca-certificates \
+ && addgroup -S spock && adduser -S spock -G spock
+COPY --from=0 /go/src/vsphere-influxdb-go/vsphere-influxdb-go /vsphere-influxdb-go
+
+USER spock
+
+CMD ["/vsphere-influxdb-go"]

vsphere-influxdb.go

@@ -110,7 +110,8 @@ func (vcenter *VCenter) Connect() error {
 	defer cancel()
 
 	stdlog.Println("Connecting to vcenter:", vcenter.Hostname)
-	u, err := url.Parse("https://" + vcenter.Username + ":" + vcenter.Password + "@" + vcenter.Hostname + "/sdk")
+	u, err := url.Parse("https://" + vcenter.Hostname + "/sdk")
+	u.User = url.UserPassword(vcenter.Username, vcenter.Password)
 	if err != nil {
 		errlog.Println("Could not parse vcenter url:", vcenter.Hostname)
 		errlog.Println("Error:", err)

vsphere-influxdb.json.sample

@@ -1,5 +1,6 @@
 {
   "Domain": ".lab",
+  "RemoveHostDomainName": false,
   "Interval": 60,
   "VCenters": [
     { "Username": "monitoring", "Password": "monixx", "Hostname": "vcenter-01.dc-01.lab" },