Background

The goal of this guide is to capture some Do and Don'ts of Go code for the InfluxDB database. When it comes to Go, writing good code is often achieved with the help of tools like go fmt and go vet. However there are still some practices not enforceable by any tools. This guide lists some specific practices to follow when writing code for the database.

Like everything, one needs to use good judgment. There will always be times when it doesn't make sense to follow a guideline outlined in this document. If that case arises, be ready to justify your choices.

The Guidelines

Try not to use third-party libraries

A third-party package is defined as one that is not part of the standard Go distribution. Generally speaking we prefer to minimize our use of third-party packages, and avoid them unless absolutely necessarily. We'll often write a little bit of code rather than pull in a third-party package. Of course, we do use some third-party packages -- most importantly we use BoltDB in some storage engines. So to maximise the chance your change will be accepted by us, use only the standard libraries, or the third-party packages we have decided to use.

For rationale, check out the post The Case Against Third Party Libraries.

Always include a default case in a 'switch' statement

The lack of a default case in a switch statement can be a significant source of bugs. This is particularly true in the case of a type-assertions switch. So always include a default statement unless you have an explicit reason not to.

When -- and when not -- set a channel to 'nil'

Use defer with anonymous functions to handle complex locking

Consider a block of code like the following.

    mu.Lock()
    if foo == "quit" {
        mu.Unlock()
        return
    } else if foo == "continue" {
        if bar == "quit" {
            mu.Unlock()
            return
        }
        bar = "still going"
    } else {
        qux = "here at last"
        mu.Unlock()
        return
    }
    foo = "more to do"
    bar = "still more to do"
    mu.Unlock()

    qux = "finished now"
    return

While this is obviously contrived, complex lock control like this is sometimes required, and doesn't lend itself to defer. But as the code evolves, it's easy to introduce new cases, and forget to release locks. One way to address this is to use an anonymous function like so:

    more := func() bool {
        mu.Lock()
        defer mu.Unlock()
        if foo == "quit" {
            return false
        } else if foo == "continue" {
            if bar == "quit" {
                return false
            }
            bar = "still going"
        } else {
            qux = "here at last"
            return false
        }
        foo = "more to do"
        bar = "still more to do"
        return true
    }()

    if more {
        qux = "finished"
    }
    return

This allows us to use defer but ensures that if any new cases are added to the logic within the anonymous function, the lock will always be released. Another advantage of this approach is that defer will still run even in the event of a panic, ensuring the locks will be released even in that case.

When to call 'panic()'

Useful links

Useful techniques in Go
Go in production
Principles of designing Go APIs with channels
Common mistakes in Golang. Especially this section Loops, Closures, and Local Variables

3.7 KiB Raw Blame History