frodovdr/node-red
1
0
Fork 0
mirror of https://github.com/node-red/node-red.git synced 2025-12-27 15:34:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

Handle deprecated calls to child_process with args

Browse Source
This commit is contained in:
Nick O'Leary
2025-07-04 14:59:58 +01:00
parent aadbbc96ee
commit b364f8f9b6
4 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/node_modules/@node-red/nodes/core/function/90-exec.js vendored
View File

@@ -91,7 +91,13 @@ module.exports = function(RED) {
const opts = isWindows ? { ...node.spawnOpt, shell: true } : node.spawnOpt
/* istanbul ignore else */
node.debug(cmd+" ["+arg+"]");
child = spawn(cmd,arg,opts);
if (opts.shell) {
// When called with shell: true, passing in separate args is deprecated in Node 24
// so we need to join the command and args into a single string.
child = spawn([cmd].concat(arg).join(" "), opts);
} else {
child = spawn(cmd,arg,opts);
}
node.status({fill:"blue",shape:"dot",text:"pid:"+child.pid});
var unknownCommand = (child.pid === undefined);
if (node.timer !== 0) {

5
packages/node_modules/@node-red/registry/lib/installer.js vendored
View File

@@ -367,9 +367,10 @@ async function getModuleVersionFromNPM(module, version) {
if (version) {
installName += "@" + version;
}
return new Promise((resolve, reject) => {
child_process.execFile(npmCommand,['info','--json',installName],{ shell: true },function(err,stdout,stderr) {
child_process.execFile(`${npmCommand} info --json ${installName}`, { shell: true },function(err,stdout,stderr) {
try {
if (!stdout) {
log.warn(log._("server.install.install-failed-not-found",{name:module}));
@@ -595,7 +596,7 @@ async function checkPrereq() {
installerEnabled = false;
} else {
return new Promise(resolve => {
child_process.execFile(npmCommand,['-v'],{ shell: true },function(err,stdout) {
child_process.execFile(`${npmCommand} -v`,{ shell: true },function(err,stdout) {
if (err) {
log.info(log._("server.palette-editor.npm-not-found"));
installerEnabled = false;

1
packages/node_modules/@node-red/runtime/lib/storage/localfilesystem/projects/git/index.js vendored
View File

@@ -417,6 +417,7 @@ module.exports = {
log.trace("git init: "+JSON.stringify(result));
resolve(result);
}).catch(function(err) {
console.log(err)
log.trace("git init: git not found");
resolve(null);
});

10
packages/node_modules/@node-red/util/lib/exec.js vendored
View File

@@ -57,7 +57,15 @@ module.exports = {
return new Promise((resolve, reject) => {
let stdout = "";
let stderr = "";
const child = child_process.spawn(command,args,options);
let child
if (args && options.shell) {
// If we are using a shell, we need to join the args into a single string
// as passing a separate array of args is deprecated in Node 24
command = [command].concat(args).join(" ");
child = child_process.spawn(command, options)
} else {
child = child_process.spawn(command, args, options);
}
child.stdout.on('data', (data) => {
const str = ""+data;
stdout += str;